src

Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Add ignored test to be used for debugging input XM files

Related to Issue [MWDAM-1617]

    • -0
    • +535
    ./Deltares.DamEngine.IntegrationTests/TestFiles/InputForDebugging.xml
    • -0
    • +4
    ./Deltares.DamEngine.IntegrationTests/Deltares.DamEngine.IntegrationTests.csproj
    • -0
    • +55
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/DebuggingTest.cs
Fixed some more failing tests by adapting data.

Related to Issue [MWDAM-1345]

    • -3
    • +3
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/WtiPipingSellmeijerRevisedTests.cs
    • -44
    • +3
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityOutwardsTests.cs
Fixed some more failing tests by adapting data.

Related to Issue [MWDAM-1345]

Fixed failing test by adapting data.

Related to Issue [MWDAM-1345]

Fixed problem 1 as stated by PO in issue, just throw error when water level (high/low) at riverside is below dike toe. Added tests for this.

Related to Issue [MWDAM-1345]

    • too large
    ./Deltares.DamEngine.Calculators.Tests/PlLinesCreator/PlLinesCreatorTest.cs
    • -8
    • +16
    ./Deltares.DamEngine.Data/Geotechnics/SurfaceLine2Extensions.cs
    • too large
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
    • -2
    • +2
    ./Deltares.DamEngine.Calculators/PlLinesCreator/SensorPlLine1Creator.cs
    • -0
    • +65
    ./Deltares.DamEngine.Calculators.Tests/Sensors/SensorPLLineCreatorTest.cs
I improved some code (code was correct, but prevent SonarQube message and improved exception testing in the tests)

Related to Issue [MWDAM-1445]

    • -3
    • +3
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalGrebbedijkTests.cs
  1. … 1 more file in changeset.
Added code (with tests) to improve handling of "wrong" segments. To be able to test this properly, added PipingModelType.Wti2017 to supported models so we can actually define an improper test project. Adding this also helps for MWDAM-1393 and thus MWDAM-1145, Piping part.

Related to Issue [MWDAM-1445]

    • -0
    • +66
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalGrebbedijkTests.cs
    • -18
    • +53
    ./Deltares.DamEngine.Calculators/DikesOperational/OperationalCalculator.cs
Set version dam engine to 19.1.0 (19.1.1 has not been released yet)

Removed obsolete file

Related to Issue [MWDAM-1513]

    • -2
    • +2
    ./Deltares.DamEngine.Version/GlobalAssembly.cs.svn
Ensured deleting of created test data folders at end of tests.

Related to Issue [MWDAM-1554]

    • -0
    • +28
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
Fix bug reported by SonarQube

Related to Issue [MWDAM-1513]

    • -13
    • +1
    ./Deltares.DamEngine.Calculators/DikesOperational/OperationalCalculator.cs
Fix bug reported by SonarQube

Related to Issue [MWDAM-1514]

Fix bug reported by SonarQube

Related to Issue [MWDAM-1514]

Replaced two test files by one, rewrote tests to use common code.

Related to Issue [MWDAM-1554]

    • -331
    • +0
    ./Deltares.DamEngine.IntegrationTests/TestFiles/DesignInputFileWithRiverLevelAboveDikeTopButBelowDTHWithNoAdaption.xml
    • -0
    • +331
    ./Deltares.DamEngine.IntegrationTests/TestFiles/DesignInputFileWithRiverLevelAboveDikeTopButBelowDTH.xml
    • -103
    • +92
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
    • -331
    • +0
    ./Deltares.DamEngine.IntegrationTests/TestFiles/DesignInputFileWithRiverLevelAboveDikeTopButBelowDTHWithAdaption.xml
    • -4
    • +1
    ./Deltares.DamEngine.IntegrationTests/Deltares.DamEngine.IntegrationTests.csproj
Typos fixed and improved formatting

Related to Issue [MWDAM-1554]

    • -12
    • +11
    ./Deltares.DamEngine.Calculators/DikesDesign/DesignCalculator.cs
Re-instated deep copy and reset of surface line in PerformDesignCalculation to ensure that correct surface line is used for each individual design step in case of Piping as well as in Stability.

Related to Issue [MWDAM-1554]

    • -21
    • +34
    ./Deltares.DamEngine.Calculators/DikesDesign/DesignCalculator.cs
Fixed the issue by taking the adaption of the surface line forward to before kernel Prepare statement. Added tests for it.

Related to Issue [MWDAM-1554]

    • -0
    • +331
    ./Deltares.DamEngine.IntegrationTests/TestFiles/DesignInputFileWithRiverLevelAboveDikeTopButBelowDTHWithNoAdaption.xml
    • -78
    • +88
    ./Deltares.DamEngine.Calculators/DikesDesign/DesignCalculator.cs
    • -0
    • +70
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
    • -0
    • +331
    ./Deltares.DamEngine.IntegrationTests/TestFiles/DesignInputFileWithRiverLevelAboveDikeTopButBelowDTHWithAdaption.xml
    • -0
    • +6
    ./Deltares.DamEngine.IntegrationTests/Deltares.DamEngine.IntegrationTests.csproj
Improved naming of functions for PL3 and PL4

Related to Issue [MWDAM-1555]

    • too large
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
Whilst investigating this option, came across typo and 2 thing that could easily be fixed when looking at the sonarqube results. So did this whilst waiting for Irene to return her verdict about this issue.

Related to Issue [MWDAM-1554]

    • too large
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
Made RequiredSafetyFactorStabilityInnerSlope, RequiredSafetyFactorStabilityOuterSlope, RequiredSafetyFactorPiping, UpliftCriterionStability and UpliftCriterionPiping required in xsd/DamLocation.xsd

Related to Issue [MWDAM-1537]

    • -7
    • +7
    ./Deltares.DamEngine.Data/Design/DesignScenario.cs
    • -10
    • +5
    ./Deltares.DamEngine.Interface/FillXmlInputFromDam.cs
    • -3
    • +0
    ./Deltares.DamEngine.Calculators/Properties/Resources.nl-NL.resx
    • -18
    • +0
    ./Deltares.DamEngine.Calculators/Properties/Resources.Designer.cs
    • -5
    • +5
    ./Deltares.DamEngine.Interface/FillDamFromXmlInput.cs
    • -20
    • +5
    ./Deltares.DamEngine.Calculators/DikesDesign/DesignCalculator.cs
  1. … 5 more files in changeset.
Made PlLineOffsetBelowDikeToeAtPolder, PlLineOffsetBelowDikeTopAtPolder, PlLineOffsetBelowDikeTopAtRiver and PlLineOffsetBelowShoulderBaseInside required in xsd/DamLocation.xsd

Related to Issue [MWDAM-1537]

    • -12
    • +12
    ./Deltares.DamEngine.Data/Design/DesignScenario.cs
    • -4
    • +4
    ./Deltares.DamEngine.Interface/FillDamFromXmlInput.cs
    • too large
    ./Deltares.DamEngine.Io/DamInput.cs
    • -16
    • +4
    ./Deltares.DamEngine.Calculators/DikesDesign/DesignCalculator.cs
    • -8
    • +4
    ./Deltares.DamEngine.Interface/FillXmlInputFromDam.cs
  1. … 2 more files in changeset.
Corrected setting DampingFactorPl3 and DampingFactorPl4.

Related to Issue [MWDAM-1533]

    • -2
    • +2
    ./Deltares.DamEngine.Interface/FillXmlInputFromDam.cs
    • -2
    • +2
    ./Deltares.DamEngine.Interface/FillDamFromXmlInput.cs
Set Run_UsingTestFiles_HasExpectedResultsInOutputFile in OperationalIntegrationTests to Categories.WorkInProgress due to:

Removed ModelFactors from Location in xsd.

Related to Issue [MWDAM-1519]

    • -0
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalIntegrationTests.cs
Fixed IO tests, due to Removed ModelFactors.

Related to Issue [MWDAM-1519]

    • -10
    • +0
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForDamProjectData.cs
Removed ModelFactors from Location in xsd.

Related to Issue [MWDAM-1519]

    • -12
    • +0
    ./Deltares.DamEngine.Interface/FillDamFromXmlInput.cs
    • -16
    • +0
    ./Deltares.DamEngine.Interface/FillXmlInputFromDam.cs
    • too large
    ./Deltares.DamEngine.Io/DamInput.cs
  1. … 1 more file in changeset.
Set Run_UsingTestFiles_HasExpectedResultsInOutputFile in OperationalPulauTekongTests and Run_UsingTestFiles_HasExpectedResultsInOutputFile in OperationalGrebbedijkTests to Categories.WorkInProgress due to: Removed HeadPl3, HeadPl4, Pl1BelowCrestRiverside, Pl1BelowCrestPolderside, Pl1BelowShoulderCrestPolderside, Pl1BelowToeDikePolderside, Pl1BelowCrestMiddle, Pl1FactorBelowShoulderCrest from WaternetOptions.

Related to Issue [MWDAM-1519]

Tests must be solved in MWDAM-1535

    • -0
    • +2
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalGrebbedijkTests.cs
    • -0
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalPulauTekongTests.cs
Removed HeadPl3, HeadPl4, Pl1BelowCrestRiverside, Pl1BelowCrestPolderside, Pl1BelowShoulderCrestPolderside, Pl1BelowToeDikePolderside, Pl1BelowCrestMiddle, Pl1FactorBelowShoulderCrest from WaternetOptions.

Related to Issue [MWDAM-1519]

    • -9
    • +0
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForDamProjectData.cs
    • too large
    ./Deltares.DamEngine.Io/DamInput.cs
    • -9
    • +0
    ./Deltares.DamEngine.Interface/FillDamFromXmlInput.cs
    • -12
    • +0
    ./Deltares.DamEngine.Interface/FillXmlInputFromDam.cs
  1. … 1 more file in changeset.
Removed obsolete parameters from test file to solve test error.

Related to Issue [MWDAM-1527]

Removed SoilType as it is never really used.

Related to Issue [MWDAM-1527]

    • -2
    • +1
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForDamProjectData.cs
    • too large
    ./Deltares.DamEngine.Io/DamInput.cs
    • -42
    • +0
    ./Deltares.DamEngine.Interface/ConversionHelper.cs
    • -68
    • +21
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForSoilProfiles.cs
    • -1
    • +0
    ./Deltares.DamEngine.Interface/FillDamFromXmlInput.cs
    • -6
    • +3
    ./Deltares.DamEngine.Calculators.Tests/Uplift/SoilVolumeMassCalculatorEffectiveStressTest.cs
    • -22
    • +0
    ./Deltares.DamEngine.Interface.Tests/ConversionHelperTests.cs
    • -1
    • +0
    ./Deltares.DamEngine.Data/Deltares.DamEngine.Data.csproj
    • -2
    • +0
    ./Deltares.DamEngine.Interface/FillXmlInputFromDam.cs
  1. … 1 more file in changeset.
Removed all probabilistic parameters named under "Added on 9-7-2019" except for SlopeDampingPiezometricHeightPolderSide (used in PlLinesCreator) and SlopeDampingPiezometricHeightPolderSide (used by Delphi D-GeoStability) as these are used in the engine.

Related to Issue [MWDAM-1527]

    • -7
    • +0
    ./Deltares.DamEngine.Data/General/MStabParameters.cs
    • -6
    • +2
    ./Deltares.DamEngine.Data/General/ModelParameters.cs
    • too large
    ./Deltares.DamEngine.Io/DamInput.cs
  1. … 1 more file in changeset.
Removed obsolete parameters from the Engine. Increased version number from 19.1 to 19.2.

Related to Issue [MWDAM-1527]

    • -54
    • +12
    ./Deltares.DamEngine.Data/Design/DesignScenario.cs
    • -2
    • +2
    ./Deltares.DamEngine.Version/GlobalAssembly.cs.svn
    • -6
    • +0
    ./Deltares.DamEngine.Data/General/FailureMechanismParametersMStab.cs
    • -3
    • +1
    ./Deltares.DamEngine.Data/General/PlLineEnumerations.cs