DAM / DamEngine / trunk

src

Checkout Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 7
Last Commit: 17 Dec
Commits this week: 0
Total Lines of Code (LoC): 147,819
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 01 Apr 2020
11:46 am

John Bokma

Adapted the calculation grid. Cleaned code a bit.

Related to Issue [MWDAM-1627]

Options
    • -4
    • +0
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperOutputFromEngine.cs
    • -2
    • +26
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
    • -104
    • +67
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapperTests.cs
    • -64
    • +39
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -62
    • +19
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/MacroStabilityIoTests.cs
    • -25
    • +32
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • too large
    ./Deltares.DamEngine.Calculators.Tests/PlLinesCreator/PlLinesCreatorTest.cs
    • -8
    • +4
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperOutput.cs
Tuesday 31 Mar 2020
6:30 pm

John Bokma

Replaced First() by SingleOrDefault(). Reverted new grid testing as this depends on other changes too which can not yet be committed as these have nothing to do with this issue.

Related to Issue [MWDAM-1632]

Options
    • -22
    • +14
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/MacroStabilityIoTests.cs
6:14 pm

John Bokma

Replaced First() by SingleOrDefault(). Als tried new test for grid parameters. If this works, temp code can be removed.

Related to Issue [MWDAM-1632]

Options
    • -15
    • +23
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/MacroStabilityIoTests.cs
5:02 pm

John Bokma

Added scenarios for testing with different dilatancy types.

Related to Issue [MWDAM-1632]

Options
    • -5
    • +27
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/ConversionHelperTests.cs
4:13 pm

John Bokma

Removed double using.

Related to Issue [MWDAM-1632]

Options
    • -16
    • +15
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/ConversionHelper.cs
Friday 21 Feb 2020
10:47 am

tang_ds

Added XMLdoc to visualize the testcases for the intermediate aquifer layers

Related to Issue [MWDAM-1398]

Options
    • -2
    • +84
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverterTests.cs
10:31 am

tang_ds

Cleanup the 1D profile implementation:

- No need for separate CreateHeadLine method, as the generic method will already create one.

Related to Issue [MWDAM-1398]

Options
    • -52
    • +26
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverter.cs
    • -20
    • +1
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverterTests.cs
10:20 am

tang_ds

Added NULL checks to the converter routine:

- Generalised log message

Related to Issue [MWDAM-1398]

Options
    • -7
    • +10
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverter.cs
    • -2
    • +2
    ./Deltares.DamEngine.Calculators/Properties/Resources.resx
    • -2
    • +2
    ./Deltares.DamEngine.Calculators/Properties/Resources.nl-NL.resx
    • -4
    • +13
    ./Deltares.DamEngine.Calculators/Properties/Resources.Designer.cs
    • -2
    • +22
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverterTests.cs
10:12 am

tang_ds

Added assertion for the geometry based on Point2D coordinates for flexibility

Related to Issue [MWDAM-1398]

Options
    • -40
    • +44
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverterTests.cs
9:24 am

tang_ds

Completed testcases for the 2D waternet lines from PLLines and 2D SoilProfile

Related to Issue [MWDAM-1398]

Options
    • -0
    • +287
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverterTests.cs
9:10 am

tang_ds

Added extra functional testcases for the intermediate aquifer layers

Related to Issue [MWDAM-1398]

Options
    • -11
    • +382
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverterTests.cs
Thursday 20 Feb 2020
4:50 pm

tang_ds

Added testcase which represents the edgecase when multiple aquifer layers for the inebtween aquifer layer does not envelope the whole X coordinate range

Related to Issue [MWDAM-1398]

Options
    • -20
    • +224
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverterTests.cs
    • -10
    • +27
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverter.cs
3:10 pm

tang_ds

Added testcase which represents the edgecase when multiple aquifer layers for the bottom do not envelope the whole X coordinate range

Related to Issue [MWDAM-1398]

Options
    • -0
    • +76
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverterTests.cs
3:03 pm

tang_ds

Added first implementation of PLLine conversion to waternet input for 2D profiles

Related to Issue [MWDAM-1398]

Options
    • -1
    • +335
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverterTests.cs
    • -1
    • +146
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverter.cs
2:56 pm

John Bokma

Implemented the required (minimum) output with tests and conversion helper. Removed some obsolete code and tests.

Related to Issue [MWDAM-1627]

Options
    • -19
    • +19
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/ConversionHelperTests.cs
    • -1
    • +35
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperOutputFromEngine.cs
    • -39
    • +0
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapperTests.cs
    • -4
    • +38
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperOutput.cs
    • -14
    • +0
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -6
    • +11
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/ConversionHelper.cs
    • -4
    • +76
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/MacroStabilityIoTests.cs
11:49 am

John Bokma

Finished the issue now soil parameters are all decoded upon and implemented.

Related to Issue [MWDAM-1632]

Options
    • -7
    • +3
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/ConversionHelperTests.cs
    • -10
    • +8
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/ConversionHelper.cs
10:50 am

John Bokma

Re-implemented r=the tangent lines now these are part of the wrapper again.

Related to Issue [MWDAM-1627]

Options
    • -4
    • +3
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/MacroStabilityIoTests.cs
    • -6
    • +5
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -5
    • +4
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
10:47 am

John Bokma

Set failing tests to WIP.

Related to Issue [MWDAM-1627]

Options
    • -0
    • +2
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapperTests.cs
Wednesday 19 Feb 2020
6:50 pm

John Bokma

Adapted failing tests due to new C#wrapper, Started with correct implementation of MacroStabilityInwardsKernelWrapper based on the C#wrapper, added conversion methods with tests for that to support some result items.

Related to Issue [MWDAM-1627]

Options
    • -4
    • +33
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/ConversionHelperTests.cs
    • -0
    • +31
    ./Deltares.DamEngine.Data/General/ModelParametersForPlLines.cs
    • -3
    • +4
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/MacroStabilityIoTests.cs
    • -14
    • +47
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapperTests.cs
    • -1
    • +1
    ./Deltares.DamEngine.Data/Deltares.DamEngine.Data.csproj
    • -2
    • +38
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/ConversionHelper.cs
    • -52
    • +35
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -71
    • +0
    ./Deltares.DamEngine.Data/General/ModelParameters.cs
3:54 pm

tang_ds

Added testcase for the PLLines to Waternet converter when PLLines lie below the profile

Related to Issue [MWDAM-1398]

Options
    • -1
    • +45
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverterTests.cs
    • -9
    • +25
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverter.cs
2:35 pm

tang_ds

Updated definitions for PL3 and PL4:

- Waternetline for PL3 is associated with the toplevel of the bottom most aquifer layer

- Waternetline for PL4 is associated with the toplevel of the in between aquifer layer

Related to Issue [MWDAM-1398]

Options
    • -6
    • +10
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverterTests.cs
    • -4
    • +4
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverter.cs
12:56 pm

John Bokma

Quick fix for compilation errors due to new release of C#wrapper.

Related to Issue [MWDAM-1627]

Options
    • -59
    • +29
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -9
    • +11
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -3
    • +3
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/ConversionHelper.cs
    • -15
    • +2
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityInwards/MacroStabilityKernelDataInput.cs
    • -9
    • +10
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/ConversionHelperTests.cs
    • -9
    • +11
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
    • -0
    • +7
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperOutput.cs
10:53 am

John Bokma

Activated the IO test for the input part. This now has to be successful.

Related to Issue [MWDAM-1627]

Options
    • -1
    • +0
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/MacroStabilityIoTests.cs
Tuesday 18 Feb 2020
4:12 pm

Tom The

Implement parameter RatioCuPc in data model and XSD

Related to Issue [MWDAM-1625]

Options
    • -0
    • +2
    ./Deltares.DamEngine.Interface/FillXmlInputFromDam.cs
    • -6
    • +6
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForDamProjectData.cs
    • -0
    • +1
    ./Deltares.DamEngine.Interface/FillDamFromXmlInput.cs
    • too large
    ./Deltares.DamEngine.Io/DamInput.cs
  5. … 1 more file in changeset.
3:19 pm

Tom The

Implement parameters RRatio and StrengthIncreaseExponent in data model and XSD

Related to Issue [MWDAM-1625]

Options
    • -1
    • +2
    ./Deltares.DamEngine.Interface.Tests/FillDamFromXmlInputTests.cs
    • -35
    • +36
    ./Deltares.DamEngine.Interface/FillXmlInputFromDam.cs
    • too large
    ./Deltares.DamEngine.Io/DamInput.cs
    • -6
    • +6
    ./Deltares.DamEngine.Data/Geotechnics/Soil.cs
    • -0
    • +2
    ./Deltares.DamEngine.Interface/FillDamFromXmlInput.cs
    • -1
    • +3
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForDamProjectData.cs
  7. … 1 more file in changeset.
3:17 pm

tang_ds

Implemented conversions for the waternet from the DamEngine to the calculation kernel:

- Expanded tests by also incorporating the geometry into account

Related to Issue [MWDAM-1398]

Options
    • -16
    • +37
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/MacroStabilityIoTests.cs
1:50 pm

tang_ds

Implemented conversions for the waternet from the DamEngine to the calculation kernel.

Related to Issue [MWDAM-1398]

Options
    • -54
    • +54
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
    • -52
    • +52
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -36
    • +73
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/MacroStabilityIoTests.cs
11:45 am

John Bokma

Adapted to review comments bar the renaming of the Fill.. classes themselves. Solved some SonarQube code smells. Complaints by SonarQube about uncovered lines are BUILLSHIT!!!!!!!!!!!!!! All the added lines are covered by the IO tests which is easily verifiable by setting some breakpoints and debugging the IO tests. You see the code is covered.

Related to Issue [MWDAM-1623]

Options
    • -9
    • +17
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
    • -7
    • +5
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/ConversionHelper.cs
    • -12
    • +12
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
10:26 am

John Bokma

Implemented trafficload with test.

Related to Issue [MWDAM-1638]

Options
    • -0
    • +11
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -13
    • +14
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/MacroStabilityIoTests.cs
9:55 am

tang_ds

Implemented conversions for the UpliftVanCalculationGrid from the DamEngine to the calculation kernel.

Related to Issue [MWDAM-1399]

Options
    • -18
    • +23
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -34
    • +44
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/MacroStabilityIoTests.cs
    • -18
    • +45
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs