DAM / DamEngine / trunk

src

Checkout Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 7
Last Commit: 17 Dec
Commits this week: 0
Total Lines of Code (LoC): 147,819
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 29 Jul 2020
2:35 pm

tang_ds

Fixed edge case:

- Updated XMLDocs and function argument types to prevent modification to collections

-- Changed a ToList to an ToArray call to prevent modifications

Related to Issue [MWDAM-1683]

Options
    • -1
    • +1
    ./Deltares.DamEngine.Data/Geotechnics/SoilSurfaceProfile.cs
2:32 pm

tang_ds

Fixed edge case:

- Updated XMLDocs and function argument types to prevent modification to collections

- Added a filter on the layerdata --> the layer data sometimes generates a surface consisting of two curves (which simply cannot represent a surface, because at least 3 curves are necessary). This behavior becomes relevant when running TestRunMacroStabilityWithErrorUpliftVan

Related to Issue [MWDAM-1683]

Options
    • -10
    • +20
    ./Deltares.DamEngine.Data/Geotechnics/SoilSurfaceProfile.cs
2:03 pm

tang_ds

Fixed edge case:

- Refactored solution: pass a local surface line geometry to prevent rounding off errors from properly recognising the surfaces

Related to Issue [MWDAM-1683]

Options
    • -42
    • +47
    ./Deltares.DamEngine.Data/Geotechnics/SoilSurfaceProfile.cs
12:10 pm

tang_ds

Fixed edge case:

- Fixed test

Related to Issue [MWDAM-1683]

Options
    • -1
    • +1
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapperTests.cs
11:58 am

tang_ds

Fixed edge case:

- Added case to deal with horizontal intersections or when the ZCoordinate has rounding errors at intersections

Related to Issue [MWDAM-1683]

Options
    • -0
    • +85
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilSurfaceProfileTests.cs
    • -11
    • +35
    ./Deltares.DamEngine.Data/Geotechnics/SoilSurfaceProfile.cs
Tuesday 28 Jul 2020
2:09 pm

Walter Austmann

Rename function to reflect its functionality

Merged from 19.2 branch

Related to Issue [MWDAM-1579]

Options
    • -3
    • +3
    ./Deltares.DamEngine.Calculators/DikesOperational/OperationalCalculator.cs
12:35 pm

tang_ds

Cleanup:

- Updated XMLDocs and function calls

Related to Issue [MWDAM-1683]

Options
    • -9
    • +25
    ./Deltares.DamEngine.Data/Geotechnics/SoilSurfaceProfile.cs
12:22 pm

tang_ds

Cleanup:

- Refactored: extracted a function to generate closed outer loop based on coordinates

Related to Issue [MWDAM-1683]

Options
    • -15
    • +13
    ./Deltares.DamEngine.Data/Geotechnics/SoilSurfaceProfile.cs
12:16 pm

tang_ds

Cleanup:

- Reordered functions for clarity

Related to Issue [MWDAM-1683]

Options
    • -124
    • +123
    ./Deltares.DamEngine.Data/Geotechnics/SoilSurfaceProfile.cs
12:08 pm

tang_ds

Cleanup:

- Removed obsolete code

Related to Issue [MWDAM-1683]

Options
    • -220
    • +0
    ./Deltares.DamEngine.Data/Geotechnics/SoilSurfaceProfile.cs
12:06 pm

tang_ds

Improved algorithm for the generation of surfaces:

- Added test to verify that the soil properties are correctly set after generating

Related to Issue [MWDAM-1683]

Options
    • -2
    • +14
    ./Deltares.DamEngine.Data/Geotechnics/SoilSurfaceProfile.cs
    • -21
    • +62
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilSurfaceProfileTests.cs
11:35 am

tang_ds

Improved algorithm for the generation of surfaces:

- Added test with a horizontal intersection with the bottom level of a layer

Related to Issue [MWDAM-1683]

Options
    • -0
    • +96
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilSurfaceProfileTests.cs
11:15 am

tang_ds

Removed WIP categories from unit tests

Related to Issue [MWDAM-1683]

Options
    • -3
    • +1
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilSurfaceProfileTests.cs
11:14 am

tang_ds

Improved algorithm for the generation of surfaces:

- Adjustments made when the intersection inflects at the bottom level of a layer

Related to Issue [MWDAM-1683]

Options
    • -0
    • +191
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilSurfaceProfileTests.cs
    • -7
    • +29
    ./Deltares.DamEngine.Data/Geotechnics/SoilSurfaceProfile.cs
Monday 27 Jul 2020
5:12 pm

John Bokma

Adapted to fix tests.

Related to Issue [MWDAM-1579]

Options
    • -8
    • +21
    ./Deltares.DamEngine.Calculators/DikesOperational/OperationalCalculator.cs
3:50 pm

Walter Austmann

Synchronize Location data with Design Scenario data

Merge from 19.2 branch

Related to Issue [MWDAM-1579]

Options
    • -15
    • +37
    ./Deltares.DamEngine.Calculators/DikesOperational/OperationalCalculator.cs
    • -0
    • +9
    ./Deltares.DamEngine.Calculators/DikesOperational/OperationalCalculatorTask.cs
3:11 pm

tang_ds

Fixed failing unit test:

- Corrected algorithm, because apparently it is possible to get an enclosed area without coordinates ---> corrected filtering

- Adjusted resulting safety factor.

Related to Issue [MWDAM-1683]

Options
    • -1
    • +1
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapperTests.cs
    • -5
    • +6
    ./Deltares.DamEngine.Data/Geotechnics/SoilSurfaceProfile.cs
2:51 pm

tang_ds

Improved algorithm for the generation of surfaces:

- Added testcase where a layer is fully above the surface line (no intersections)

Related to Issue [MWDAM-1683]

Options
    • -3
    • +70
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilSurfaceProfileTests.cs
    • -3
    • +7
    ./Deltares.DamEngine.Data/Geotechnics/SoilSurfaceProfile.cs
2:24 pm

tang_ds

Improved algorithm for the generation of surfaces:

- Decoupled old algorithm

-- Used 3 testcases to prove the algorithm:

--- Soil layers fully below surface line

--- Soil layers enveloping the surface line

--- Soil layers partially enveloping the surface line such that the enveloped area results in one single area

Related to Issue [MWDAM-1683]

Options
    • -6
    • +372
    ./Deltares.DamEngine.Data/Geotechnics/SoilSurfaceProfile.cs
    • -103
    • +84
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilSurfaceProfileTests.cs
Friday 24 Jul 2020
7:00 pm

John Bokma

Added WiP for locally successful test. So I guess C#wrapper or Failmech has been changed although this should not effect this test at all. So DSL change????

Related to Issue [MWDAM-1627]

Options
    • -1
    • +2
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilSurfaceProfileTests.cs
6:47 pm

John Bokma

Removed WiP for successful test.

Related to Issue [MWDAM-1627]

Options
    • -1
    • +0
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilSurfaceProfileTests.cs
6:26 pm

John Bokma

Corrected TangentLinesDefinition.

Related to Issue [MWDAM-1627]

Options
    • -2
    • +2
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
6:07 pm

John Bokma

Commented out correction for 1d profile layers above surface level as this causes numerous unexplained errors.

Related to Issue [MWDAM-1627]

Options
    • -13
    • +15
    ./Deltares.DamEngine.Data/Geotechnics/SoilProfileHelper.cs
5:32 pm

John Bokma

Added setting aquifer status.

Related to Issue [MWDAM-1627]

Options
    • -0
    • +1
    ./Deltares.DamEngine.Data/Geotechnics/SoilProfileHelper.cs
4:49 pm

John Bokma

Corrected stability test by setting intended tangent line type. Corrected other tests by correcting DetermineForSurfaceLineCorrected1DProfileAtX.

Related to Issue [MWDAM-1627]

Options
    • -3
    • +23
    ./Deltares.DamEngine.Data/Geotechnics/SoilProfileHelper.cs
    • -1
    • +1
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapperTests.cs
3:08 pm

John Bokma

Corrected handling for grid and tangent lines as well as all water net data. Now the failing tests work so removed the WiP status for these tests.

Related to Issue [MWDAM-1627]

Options
    • -44
    • +42
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapperTests.cs
    • -5
    • +10
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -1
    • +7
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
    • -2
    • +4
    ./Deltares.DamEngine.Data/General/SoilGeometryProbability.cs
    • -0
    • +4
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverter.cs
    • -13
    • +3
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityInwards/UpliftVanGridCreator.cs
    • -0
    • +1
    ./Deltares.DamEngine.Data/Deltares.DamEngine.Data.csproj
    • -0
    • +43
    ./Deltares.DamEngine.Data/Geotechnics/SoilProfileHelper.cs
    • too large
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
    • -10
    • +31
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/TestHelpers/DamEngineDataTestFactory.cs
    • -1
    • +2
    ./Deltares.DamEngine.Calculators/Uplift/UpliftLocationDeterminator.cs
Thursday 23 Jul 2020
4:16 pm

tang_ds

Added unit test to prove the SoilSurfaceProfile.ConvertTo2DProfile:

- Temporarily added WIP category for the tests to make build server green again

Related to Issue [MWDAM-1683]

Options
    • -1
    • +73
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilSurfaceProfileTests.cs
8:45 am

tang_ds

Added unit test to prove the SoilSurfaceProfile.ConvertTo2DProfile:

- Refactored test in case the order of curves differs during subsequent runs

-- Adjusted test --> set bottom level at the end of the routine to set the soil layers height?

Related to Issue [MWDAM-1683]

Options
    • -4
    • +2
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilSurfaceProfileTests.cs
Wednesday 22 Jul 2020
4:21 pm

tang_ds

Copied SynchronizeLoops call to be executed at the end of the routine to prevent KeyNotFoundException in the wrapper

Related to Issue [MWDAM-1650]

Options
    • -0
    • +2
    ./Deltares.DamEngine.Data/Geometry/GeometryData.cs
4:02 pm

tang_ds

Added unit test to prove the SoilSurfaceProfile.ConvertTo2DProfile:

- Refactored test in case the order of curves differs during subsequent runs

-- Added log message for more information

Related to Issue [MWDAM-1683]

Options
    • -1
    • +4
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilSurfaceProfileTests.cs