DAM / DamEngine / trunk

src

Checkout Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 7
Last Commit: 17 Dec
Commits this week: 0
Total Lines of Code (LoC): 147,819
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 09 Dec 2022
11:03 am

Walter Austmann

Replace System.NullReferenceException by ArgumentNullException

Related to Issue [MWDAM-1856]

Options
    • -7
    • +7
    ./Deltares.DamEngine.Interface/FillDamFromXmlInput.cs
    • -9
    • +9
    ./Deltares.DamEngine.Interface/FillXmlInputFromDam.cs
10:25 am

Walter Austmann

Remove useless assignment

Related to Issue [MWDAM-1856]

Options
    • -2
    • +1
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
10:12 am

Walter Austmann

Remove number of parameters

Related to Issue [MWDAM-1856]

Options
    • -2
    • +2
    ./Deltares.DamEngine.Data/Geometry/GeometryData.cs
    • -83
    • +49
    ./Deltares.DamEngine.Data/Geometry/Routines2D.cs
    • -2
    • +2
    ./Deltares.DamEngine.Data/Geometry/LineHelper.cs
    • -1
    • +1
    ./Deltares.DamEngine.Data/Geometry/GeometryCurve.cs
    • -5
    • +5
    ./Deltares.DamEngine.Data/Geotechnics/LayerDetector.cs
9:11 am

Walter Austmann

Use count property

Related to Issue [MWDAM-1856]

Options
    • -2
    • +2
    ./Deltares.DamEngine.Calculators/PlLinesCreator/SensorPlLineCreatorBase.cs
8:59 am

Walter Austmann

Remove unnecessary cast

Related to Issue [MWDAM-1856]

Options
    • -35
    • +29
    ./Deltares.DamEngine.Calculators/KernelWrappers/Assemblers/DtoPropertyAttributeMap.cs
8:58 am

Walter Austmann

Rename parameters to match base class or interface declaration

Related to Issue [MWDAM-1856]

Options
    • -7
    • +7
    ./Deltares.DamEngine.Calculators/KernelWrappers/Assemblers/Geometry2DSectionAssembler.cs
    • -32
    • +32
    ./Deltares.DamEngine.Calculators/KernelWrappers/Assemblers/DtoDocumentAssembler.cs
    • -8
    • +8
    ./Deltares.DamEngine.Calculators/KernelWrappers/Assemblers/IDtoAssembler.cs
8:56 am

Walter Austmann

Remove redundant jump

Related to Issue [MWDAM-1856]

Options
    • -3
    • +2
    ./Deltares.DamEngine.Calculators/General/Parallel.cs
8:35 am

Walter Austmann

Remove unused setter

Related to Issue [MWDAM-1856]

Options
    • -20
    • +6
    ./Deltares.DamEngine.Data/Geotechnics/SoilLayer2D.cs
Thursday 08 Dec 2022
5:20 pm

Walter Austmann

Remove unused private method in release mode

Related to Issue [MWDAM-1856]

Options
    • -0
    • +2
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityCommonHelper.cs
4:52 pm

Walter Austmann

Remove unused private methods

Related to Issue [MWDAM-1856]

Options
    • -5
    • +0
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForSoilProfiles.cs
    • -19
    • +0
    ./Deltares.DamEngine.Calculators/PlLinesCreator/SensorPlLine1Creator.cs
4:45 pm

Walter Austmann

Remove the unnecessary Boolean literal(s)

Related to Issue [MWDAM-1856]

Options
    • -1
    • +1
    ./Deltares.DamEngine.Calculators/Uplift/UpliftLocationDeterminator.cs
    • -3
    • +3
    ./Deltares.DamEngine.Data/Geometry/Routines2D.cs
    • -1
    • +1
    ./Deltares.DamEngine.Data/Standard/ObjectCopier.cs
    • -2
    • +2
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
    • -6
    • +6
    ./Deltares.DamEngine.Data/Geometry/GeometryGenerator.cs
    • -1
    • +1
    ./Deltares.DamEngine.Data/Geometry/GeometryData.cs
    • -7
    • +7
    ./Deltares.DamEngine.Data/Geotechnics/LayerDetector.cs
    • -1
    • +1
    ./Deltares.DamEngine.Data/Geometry/GeometrySurface.cs
4:30 pm

Walter Austmann

Short-circuit logic should be used in boolean contexts

Related to Issue [MWDAM-1856]

Options
    • -1
    • +1
    ./Deltares.DamEngine.Data/Standard/ObjectCopier.cs
    • -1
    • +1
    ./Deltares.DamEngine.Data/Geometry/GeometryPointString.cs
4:27 pm

Walter Austmann

Remove unused directives

Related to Issue [MWDAM-1856]

Options
    • -1
    • +0
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/TestHelpers/DamEngineDataTestFactory.cs
    • -5
    • +0
    ./Deltares.DamEngine.Calculators/KernelWrappers/DamPipingSellmeijerVnk/DamPipingSellmeijerVnkOutput.cs
    • -3
    • +0
    ./Deltares.DamEngine.Data/Standard/ThrowHelper.cs
    • -1
    • +0
    ./Deltares.DamEngine.TestHelpers/XmlAdapter.cs
    • -5
    • +0
    ./Deltares.DamEngine.Data/General/Sensors/SensorFactory.cs
    • -1
    • +0
    ./Deltares.DamEngine.Calculators/KernelWrappers/Interfaces/IKernelWrapper.cs
    • -1
    • +0
    ./Deltares.DamEngine.Io/IdValidator.cs
    • too large
    ./Deltares.DamEngine.Io/DamInput.cs
    • -1
    • +0
    ./Deltares.DamEngine.Calculators/DikesDesign/SurfaceLineHeightAdapter.cs
    • -6
    • +0
    ./Deltares.DamEngine.Data/General/Physics.cs
    • -1
    • +0
    ./Deltares.DamEngine.Calculators/Uplift/UpliftLocationDeterminator.cs
    • -1
    • +0
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamPipingBligh/DamPipingBlighKernelWrapperTests.cs
    • -1
    • +0
    ./Deltares.DamEngine.Data/Geotechnics/SoilProfile1DAquiferLayerCombiner.cs
    • -1
    • +0
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/Common/DamPipingHelperTests.cs
    • -1
    • +0
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilProfile1DAquiferLayerCombinerTests.cs
  16. … 8 more files in changeset.
4:16 pm

Walter Austmann

Create UpliftSituation for output parameter

Related to Issue [MWDAM-1856]

Options
    • -14
    • +21
    ./Deltares.DamEngine.Calculators/KernelWrappers/Common/PlLinesHelper.cs
4:14 pm

Walter Austmann

Use getters and setters for properties

Related to Issue [MWDAM-1856]

Options
    • -2
    • +2
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityInwards/MacroStabilityOutputItem.cs
    • -3
    • +3
    ./Deltares.DamEngine.Calculators/KernelWrappers/Common/DamKernelInput.cs
    • -7
    • +7
    ./Deltares.DamEngine.Data/General/UpliftSituation.cs
    • -2
    • +2
    ./Deltares.DamEngine.Data/Geometry/Point2D.cs
    • -7
    • +7
    ./Deltares.DamEngine.Calculators/DikesDesign/SurfaceLineAdapter.cs
    • -3
    • +3
    ./Deltares.DamEngine.Data/Geometry/Routines2D.cs
    • -1
    • +1
    ./Deltares.DamEngine.Data/General/Sensors/SensorPlLineCreatorSettings.cs
    • -3
    • +3
    ./Deltares.DamEngine.Data/Geotechnics/SoilProfile1DAquiferLayerCombiner.cs
2:45 pm

John Bokma

Solved the bugs in SonarQube. Note that 2 (of the 10) reported bugs were actually false negatives as assessed by me and reviewed by Tom who closed these two bugs.

Related to Issue [MWDAM-1852]

Options
    • -20
    • +8
    ./Deltares.DamEngine.Data/Standard/ListExtension.cs
    • -0
    • +1754
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
    • -8
    • +7
    ./Deltares.DamEngine.Data/Geotechnics/SoilSurfaceProfile.cs
    • -2
    • +1
    ./Deltares.DamEngine.Data/Geometry/GeometryLoop.cs
    • -1
    • +0
    ./Deltares.DamEngine.Data/Geotechnics/LayerDetector.cs
Monday 05 Dec 2022
12:04 pm

John Bokma

Update the code for the new library of the Macrostability C#-wrapper.

Related to Issue [MWDAM-1848]

Options
    • -3
    • +3
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -3
    • +4
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
Friday 07 Oct 2022
3:27 pm

John Bokma

Adapted to review comments.

Related to Issue [MWDAM-1792]

Options
    • -2
    • +148
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityCommonHelper.cs
    • -145
    • +37
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -114
    • +8
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityOutwards/MacroStabilityOutwardsKernelWrapper.cs
Wednesday 05 Oct 2022
3:26 pm

John Bokma

Adaapted to review comments.

Related to Issue [MWDAM-1842]

Options
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
    • -3
    • +3
    ./Deltares.DamEngine.Data/Geotechnics/SoilProfile2D.cs
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/DebuggingTest.cs
1:44 pm

John Bokma

Updated to the latest successful build of the C# wrapper. Adapted for missing WaterNetDefinition in construction stage.

Related to Issue [MWDAM-1792]

Options
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MultiCoreMacroStabilityTests.cs
    • -0
    • +1
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
  3. … 15 more files in changeset.
Tuesday 04 Oct 2022
10:46 am

John Bokma

Re-added handling of UpliftVan/BishopUpliftVan in Postprocessing Stability Inwards.

Related to Issue [MWDAM-1792]

Options
    • -0
    • +8
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityCommonHelper.cs
Monday 03 Oct 2022
6:34 pm

John Bokma

(Re-)Added the stability outward calculation for Bishop, NoAdaption.

Related to Issue [MWDAM-1792]

Options
    • -0
    • +353
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityOutwards/MacroStabilityOutwardsKernelWrapper.cs
    • -31
    • +12
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityOutwardsTests.cs
  3. ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityOutwards
    • -1
    • +2
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/DesignCalculatorTests.cs
    • -0
    • +13
    ./Deltares.DamEngine.Calculators/KernelWrappers/Common/KernelWrapperHelper.cs
    • -0
    • +2
    ./Deltares.DamEngine.Calculators/Deltares.DamEngine.Calculators.csproj
    • -0
    • +6
    ./Deltares.DamEngine.IntegrationTests/Deltares.DamEngine.IntegrationTests.csproj
    • -0
    • +338
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityCommonHelper.cs
    • -0
    • +68
    ./Deltares.DamEngine.IntegrationTests/TestFiles/InputFileForStabOutsideBishopSpecifiedGrid.xml
    • -280
    • +38
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -0
    • +68
    ./Deltares.DamEngine.IntegrationTests/TestFiles/InputFileForStabOutsideBishopAutomaticGrid.xml
    • -4
    • +14
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityInwards/BishopGridCreator.cs
Wednesday 28 Sep 2022
6:25 pm

John Bokma

Re-Adapted the failing test as setting the culture seems not to be really working on TC as it does locally.

Related to Issue [MWDAM-1842]

Options
    • -2
    • +2
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/DesignCalculatorTests.cs
6:13 pm

John Bokma

Adapted the failing tests due to re-implementation of Adapt option.

Related to Issue [MWDAM-1842]

Options
    • -2
    • +2
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/DesignCalculatorTests.cs
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/DebuggingTest.cs
    • -12
    • +9
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
5:22 pm

John Bokma

Re-implemented Adapt Geometry option for OptimizedSlopeAndShoulderAdaption, model Bishop.

Related to Issue [MWDAM-1842]

Options
    • -0
    • +30
    ./Deltares.DamEngine.Data/Geotechnics/LayerDetector.cs
    • -2
    • +0
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -1
    • +39
    ./Deltares.DamEngine.Data/Geotechnics/SoilProfile2D.cs
    • -1
    • +1
    ./Deltares.DamEngine.Calculators/DikesDesign/DesignCalculatorShoulderPerPoint.cs
    • -9
    • +45
    ./Deltares.DamEngine.Calculators/DikesDesign/DesignCalculatorCombinedSlopeAndShoulderAdaption.cs
    • -7
    • +7
    ./Deltares.DamEngine.Calculators/DikesDesign/DesignCalculatorFirstSlopeAdaptionThenShoulderAdaption.cs
    • -1
    • +1
    ./Deltares.DamEngine.Calculators/DikesDesign/DesignCalculator.cs
    • -26
    • +26
    ./Deltares.DamEngine.Data/Design/DesignScenario.cs
Tuesday 27 Sep 2022
1:37 pm

Walter Austmann

Fix typo's

Related to Issue [MWDAM-1809]

Options
    • too large
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
    • -5
    • +5
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
Monday 26 Sep 2022
5:49 pm

Walter Austmann

Add test (and fixed bug) for the case that no uplift occurs

Related to Issue [MWDAM-1809]

Options
    • -5
    • +93
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
    • -1
    • +1
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -10
    • +6
    ./Deltares.DamEngine.Calculators/KernelWrappers/Common/UpliftHelper.cs
2:26 pm

Walter Austmann

Add reviewer suggestions

Related to Issue [MWDAM-1809]

Options
    • -15
    • +16
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
Friday 23 Sep 2022
10:54 am

Walter Austmann

Improve unit test

Related to Issue [MWDAM-1809]

Options
    • -46
    • +68
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapperTests.cs
Thursday 22 Sep 2022
4:45 pm

Walter Austmann

Add Bishop UpliftVan in PostProcess

Related to Issue [MWDAM-1809]

Options
    • -16
    • +68
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -13
    • +64
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapperTests.cs