DAM / DamEngine / trunk

src

Checkout Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 7
Last Commit: 17 Dec
Commits this week: 0
Total Lines of Code (LoC): 147,819
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 21 Nov 2024
10:25 am

Virginie Trompille

The waternet creator based on 2D geometry is used instead of the one based on 1D.

Related to Issue [MWDAM-2251]

Options
    • -7
    • +3
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityOutwards/MacroStabilityOutwardsKernelWrapper.cs
    • -7
    • +3
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
Wednesday 20 Nov 2024
3:01 pm

Virginie Trompille

Unit test added for CombineSurfaceLineWithSoilProfile2D using complex 2D profile (with 6 surfaces in 2 layers) and a zigzag surface line.

Unused methods in FactoryForSurfaceLines removed.

Related to Issue [MWDAM-2257]

Options
    • -1
    • +266
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilProfile2DSurfaceLineHelperTests.cs
    • -1
    • +170
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForSoilProfiles.cs
    • -219
    • +10
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForSurfaceLines.cs
Tuesday 19 Nov 2024
12:15 pm

Virginie Trompille

Expected results updated with the new calculated results (due to improvement of the waternet line for PL1)

Related to Issue [MWDAM-2252]

Options
    • too large
    ./Deltares.DamEngine.IntegrationTests/TestFiles/LargeInsideBishopNoAdaptionGridResults_Cores_1.xml
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MultiCoreMacroStabilityTests.cs
12:04 pm

John Bokma

Removed obsolete code.

Related to Issue [MWDAM-2216]

Options
    • -30
    • +2
    ./Deltares.DamEngine.Data/Geometry/GeometryHelper.cs
11:20 am

Virginie Trompille

Case where phreatic line passes through all layers of 2D profile is better handled.

Also added that the waternet line for PL1 can't be situated in the bottom aquifer.

Related to Issue [MWDAM-2252]

Options
    • -0
    • +20
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverter.cs
    • -4
    • +4
    ./Deltares.DamEngine.Data/Standard/ComputeDoubles.cs
    • -62
    • +39
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverterTests.cs
9:30 am

Virginie Trompille

Tolerance when comparing doubles improved

Related to Issue [MWDAM-2246]

Options
    • -1
    • +1
    ./Deltares.DamEngine.Data/Standard/ComputeDoubles.cs
Monday 18 Nov 2024
4:57 pm

Virginie Trompille

Nuget of StixFileWriter updated with last build of trunk #92-84c32f2

Related to Issue [MWDAM-2245]

Options
    • -1
    • +1
    ./Deltares.DamEngine.Calculators/Deltares.DamEngine.Calculators.csproj
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/Deltares.DamEngine.IntegrationTests.csproj
    • -1
    • +1
    ./Deltares.DamEngine.Calculators.Tests/Deltares.DamEngine.Calculators.Tests.csproj
Friday 15 Nov 2024
5:54 pm

John Bokma

Cleaned code some more.

Related to Issue [MWDAM-2216]

Options
    • -4
    • +4
    ./Deltares.DamEngine.Data/Geometry/GeometryData.cs
    • -8
    • +8
    ./Deltares.DamEngine.Data/Geometry/Routines2D.cs
4:49 pm

John Bokma

Cleaned code somewhat.

Related to Issue [MWDAM-2216]

Options
    • -105
    • +131
    ./Deltares.DamEngine.Data/Geometry/GeometryData.cs
    • -2
    • +2
    ./Deltares.DamEngine.Data/Geometry/GeometryLoop.cs
    • -1
    • +0
    ./Deltares.DamEngine.Data/Geometry/GeometryHelper.cs
    • -34
    • +38
    ./Deltares.DamEngine.Data/Geometry/GeometryGenerator.cs
    • -12
    • +12
    ./Deltares.DamEngine.Data.Tests/Geotechnics/GeometryHelperTests.cs
1:54 pm

Virginie Trompille

Adapted to review: exception is raised when problem with in-between aquifer

Related to Issue [MWDAM-2225]

Options
    • -0
    • +4
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverter.cs
    • -0
    • +9
    ./Deltares.DamEngine.Calculators/Properties/Resources.Designer.cs
    • -0
    • +3
    ./Deltares.DamEngine.Calculators/Properties/Resources.resx
    • -0
    • +3
    ./Deltares.DamEngine.Calculators/Properties/Resources.nl-NL.resx
10:37 am

Virginie Trompille

Expected results updated with new calculated results due to position of waternet line of PL1 (moved 1 mm upwards when coinciding with other waternet line)

Related to Issue [MWDAM-2242]

Options
    • too large
    ./Deltares.DamEngine.IntegrationTests/TestFiles/LargeInsideBishopNoAdaptionGridResults_Cores_1.xml
10:02 am

Virginie Trompille

Expected results updated with new calculated results due to position of waternet line of PL1 (moved 1 mm upwards when coinciding with other waternet line)

Related to Issue [MWDAM-2242]

Options
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MultiCoreMacroStabilityTests.cs
Thursday 14 Nov 2024
4:32 pm

Virginie Trompille

Expected results updated with new calculated results due to position of waternet line of PL1 (moved 1 mm upwards when coinciding with other waternet line)

Related to Issue [MWDAM-2242]

Options
    • -7
    • +7
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/CheckLargeResultsSets.cs
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MultiCoreMacroStabilityTests.cs
4:11 pm

John Bokma

Interim commit with code and fixed test.

Related to Issue [MWDAM-2216]

Options
    • -0
    • +12
    ./Deltares.DamEngine.Data/Geometry/GeometryCurve.cs
    • -2
    • +2
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MultiCoreMacroStabilityTests.cs
    • -8
    • +8
    ./Deltares.DamEngine.Data/Geometry/GeometryLoop.cs
    • -2
    • +30
    ./Deltares.DamEngine.Data/Geometry/Point2D.cs
    • -6
    • +338
    ./Deltares.DamEngine.Data/Geometry/GeometryGenerator.cs
    • -1
    • +5
    ./Deltares.DamEngine.Data/Geotechnics/SoilLayer1D.cs
    • -14
    • +25
    ./Deltares.DamEngine.Data.Tests/Geotechnics/GeometryHelperTests.cs
    • -15
    • +221
    ./Deltares.DamEngine.Data/Geometry/GeometryData.cs
    • -1
    • +67
    ./Deltares.DamEngine.Data/Geometry/Routines2D.cs
    • -12
    • +3
    ./Deltares.DamEngine.Data/Geometry/GeometryHelper.cs
4:02 pm

Virginie Trompille

Unused methods removed

Related to Issue [MWDAM-2242]

Options
    • -42
    • +0
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverter.cs
4:01 pm

Virginie Trompille

Expected results updated with new calculated results due to position of waternet line of PL1 (moved 1 mm upwards when coinciding with other waternet line)

Related to Issue [MWDAM-2242]

Options
    • too large
    ./Deltares.DamEngine.IntegrationTests/TestFiles/DesignBishopAdaptionWithScenariosForHeadPl3_Results.xml
3:31 pm

Virginie Trompille

Issues in sonar cloud solved

Related to Issue [MWDAM-2225]

Options
    • -2
    • +2
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverter.cs
3:08 pm

John Bokma

Removed the double adding of curve 5.

Related to Issue [MWDAM-2216]

Options
    • -1
    • +0
    ./Deltares.DamEngine.Data.Tests/General/GeometryDataTests.cs
3:07 pm

Virginie Trompille

Expected results updated with new calculated results due to position of waternet line of PL1 (moved 1 mm upwards when coinciding with other waternet line)

Related to Issue [MWDAM-2242]

Options
    • -5
    • +5
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/CheckLargeResultsSets.cs
    • -3
    • +3
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MultiCoreMacroStabilityTests.cs
    • -3
    • +3
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
1:40 pm

Virginie Trompille

Expected results updated with new calculated results due to position of waternet line of PL1 (moved 1 mm upwards when coinciding with other waternet line)

Related to Issue [MWDAM-2242]

Options
    • -2
    • +2
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityOutwardsTests.cs
1:33 pm

Virginie Trompille

Waternet line for in-between aquifer changed into 2 lines instead of a close boundary to be correctly displayed in STIX file.

Related to Issue [MWDAM-2242]

Options
    • -15
    • +30
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverter.cs
    • -54
    • +67
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverterTests.cs
1:14 pm

Tom The

Added check on surfaceline being strict ascending

Related to Issue [MWDAM-2132]

Options
    • -2
    • +15
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityCommonHelper.cs
    • -0
    • +37
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SurfaceLine2ValidatorTests.cs
    • -1
    • +1
    ./Deltares.DamEngine.Data/Geotechnics/SurfaceLine2Validator.cs
    • -1
    • +28
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForSurfaceLines.cs
    • -0
    • +10
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/MacroStabilityCommonHelperTests.cs
12:54 pm

Virginie Trompille

Comparison of X coordinates improved using tolerance to avoid unwanted extension of 2D geometry

Related to Issue [MWDAM-2246]

Options
    • -3
    • +3
    ./Deltares.DamEngine.Data/Standard/ComputeDoubles.cs
    • -6
    • +8
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityCommonHelper.cs
10:16 am

Virginie Trompille

Commit 5016 reverted due to unexpected failing unit tests

Related to Issue [MWDAM-2251]

Options
    • -1
    • +6
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -1
    • +6
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityOutwards/MacroStabilityOutwardsKernelWrapper.cs
Wednesday 13 Nov 2024
6:01 pm

Virginie Trompille

The waternet creator based on 2D geometry is used instead of the one based on 1D.

Related to Issue [MWDAM-2251]

Options
    • -6
    • +1
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityOutwards/MacroStabilityOutwardsKernelWrapper.cs
    • -6
    • +1
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
5:05 pm

Virginie Trompille

Adapted to review: exception is raised when no bottom aquifer present

Related to Issue [MWDAM-2225]

Options
    • -32
    • +22
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverterTests.cs
    • -21
    • +33
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverter.cs
3:02 pm

Virginie Trompille

Obsolete code removed and unit tests updated

Related to Issue [MWDAM-2246]

Options
    • -1
    • +13
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverterTests.cs
    • -1
    • +1
    ./Deltares.DamEngine.Interface/FillDamFromXmlInput.cs
    • -36
    • +0
    ./Deltares.DamEngine.Data/Geotechnics/SoilProfile2D.cs
2:09 pm

Virginie Trompille

Fix unit tests

Related to Issue [MWDAM-2250]

Options
    • -3
    • +3
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/Common/PlLinesHelperTests.cs
1:44 pm

Virginie Trompille

When reading the input xml file from DAM UI, the last curve of the loop (between first and last point) is added

Related to Issue [MWDAM-2246]

Options
    • -8
    • +26
    ./Deltares.DamEngine.Interface/FillDamFromXmlInput.cs
1:28 pm

Tom The

Added test if surfaceline is fully above bottom of soilprofile2D before combining them

Related to Issue [MWDAM-2132]

Options
    • -2
    • +22
    ./Deltares.DamEngine.Data/Geotechnics/SoilProfile2DSurfaceLineHelper.cs
    • -50
    • +19
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForSurfaceLines.cs
    • -0
    • +12
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilProfile2DSurfaceLineHelperTests.cs
    • -0
    • +11
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/MacroStabilityCommonHelperTests.cs
    • -1
    • +5
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityCommonHelper.cs