DAM / DamEngine / trunk

src

Checkout Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 7
Last Commit: 17 Dec
Commits this week: 0
Total Lines of Code (LoC): 147,819
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 17 Jan
6:19 pm

Esther van Zantvoort

sonar cloud improvement

Related to Issue [MWDAM-2158]

Options
    • -33
    • +44
    ./Deltares.DamEngine.Data/General/Dike.cs
5:13 pm

Virginie Trompille

Add a validation on the presence of isolated in-between aquifers

Related to Issue [MWDAM-2581]

Options
    • -60
    • +106
    ./Deltares.DamEngine.Calculators.Tests/PlLinesCreator/SoilProfileValidatorTests.cs
    • -0
    • +6
    ./Deltares.DamEngine.Calculators/Properties/Resources.Designer.cs
    • -6
    • +5
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForSurfaceLines.cs
    • -0
    • +3
    ./Deltares.DamEngine.Calculators/Properties/Resources.resx
    • -0
    • +20
    ./Deltares.DamEngine.Calculators/PlLinesCreator/SoilProfileValidator.cs
    • -8
    • +8
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForSoilProfiles.cs
    • -0
    • +3
    ./Deltares.DamEngine.Calculators/Properties/Resources.nl-NL.resx
    • -19
    • +72
    ./Deltares.DamEngine.Calculators/KernelWrappers/Common/SoilProfile2DHelper.cs
4:57 pm

Esther van Zantvoort

Added validation message when piping is combined with 2D-geometry.

Related to Issue [MWDAM-2158]

Options
    • -1
    • +19
    ./Deltares.DamEngine.Data/General/Dike.cs
    • -1
    • +3
    ./Deltares.DamEngine.Interface/EngineInterface.cs
    • -0
    • +38
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/PipingBlighTests.cs
    • -5
    • +65
    ./Deltares.DamEngine.TestHelpers/XmlAdapter.cs
    • -31
    • +9
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
12:08 pm

Esther van Zantvoort

Use InputTutorialStability2D.xml in IssuesTests

Related to Issue [MWDAM-2578]

Options
    • -606
    • +0
    ./Deltares.DamEngine.IntegrationTests/TestFiles/InputFileDWP8.xml
    • -4
    • +6
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/IssuesTests.cs
    • -482
    • +0
    ./Deltares.DamEngine.IntegrationTests/TestFiles/InputFileDWP2.xml
    • -6
    • +0
    ./Deltares.DamEngine.IntegrationTests/Deltares.DamEngine.IntegrationTests.csproj
12:04 pm

John Bokma

Renamed the local parameter as requested.

Related to Issue [MWDAM-2446]

Options
    • -3
    • +3
    ./Deltares.DamEngine.Data.Tests/Geotechnics/GeometryExporterTests.cs
10:25 am

Virginie Trompille

Dike embankment material is added in unit tests with 1D profile

Related to Issue [MWDAM-2164]

Options
    • -3
    • +4
    ./Deltares.DamEngine.Calculators.Tests/PlLinesCreator/SoilProfileValidatorTests.cs
10:14 am

Virginie Trompille

Dike embankment material is added in unit tests with 1D profile

Related to Issue [MWDAM-2164]

Options
    • -16
    • +35
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamPipingBligh/DamPipingBlighKernelWrapperTests.cs
    • -63
    • +88
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/Common/PlLinesHelperTests.cs
    • too large
    ./Deltares.DamEngine.Calculators.Tests/PlLinesCreator/PlLinesCreatorTest.cs
    • -17
    • +23
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/WtiPipingSellmeijerRevised/WtiPipingSellmeijerRevisedKernelWrapperTests.cs
    • -45
    • +38
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForSoilProfiles.cs
    • -16
    • +23
    ./Deltares.DamEngine.Calculators.Tests/Uplift/UpliftLocationDeterminatorTest.cs
9:30 am

Virginie Trompille

Validation of the Dike embankment material is incorrect (material needed only for 1D profile, not 2D)

Related to Issue [MWDAM-2164]

Options
    • -3
    • +3
    ./Deltares.DamEngine.Calculators/PlLinesCreator/SoilProfileValidator.cs
    • -0
    • +17
    ./Deltares.DamEngine.Calculators.Tests/PlLinesCreator/SoilProfileValidatorTests.cs
Thursday 16 Jan
5:51 pm

Esther van Zantvoort

Use InputTutorialStability2D.xml where possible in MacroStabilityInwardsTests

Related to Issue [MWDAM-2578]

Options
    • -10
    • +24
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
    • too large
    ./Deltares.DamEngine.IntegrationTests/TestFiles/MacroStabilityTutorialDesignInputFileMultipleLocations.xml
    • -513
    • +0
    ./Deltares.DamEngine.IntegrationTests/TestFiles/MacroStabilityTutorialDesignInputFile.xml
    • -433
    • +0
    ./Deltares.DamEngine.IntegrationTests/TestFiles/MacroStabilityTutorialDesignInputFile22.xml
    • -976
    • +0
    ./Deltares.DamEngine.IntegrationTests/TestFiles/MacroStabilityTutorialDesignInputFile13.xml
    • -506
    • +0
    ./Deltares.DamEngine.IntegrationTests/TestFiles/MacroStabilityTutorialDesignInputFile18.xml
    • -15
    • +0
    ./Deltares.DamEngine.IntegrationTests/Deltares.DamEngine.IntegrationTests.csproj
4:58 pm

Virginie Trompille

Check on the presence of aquifers/aquitards for 1D profile is done at cross section DikeTopAtPolder (instead of DikeToeAtPolder) to include the layers in the dike body.

Related to Issue [MWDAM-2164]

Options
    • -1
    • +1
    ./Deltares.DamEngine.Calculators/PlLinesCreator/SoilProfileValidator.cs
4:55 pm

Virginie Trompille

Unit tests for the new validator added.

Related to Issue [MWDAM-2164]

Options
    • -0
    • +355
    ./Deltares.DamEngine.Calculators.Tests/PlLinesCreator/SoilProfileValidatorTests.cs
3:39 pm

Esther van Zantvoort

Removed redundant comment line

Related to Issue [MWDAM-2367]

Options
    • -1
    • +0
    ./Deltares.DamEngine.Data/Geotechnics/SoilProfile2DSurfaceLineHelper.cs
3:36 pm

Esther van Zantvoort

Added Assert.Multiple

Related to Issue [MWDAM-2367]

Options
    • -2
    • +3
    ./Deltares.DamEngine.Data.Tests/Geometry/GeometryCurveTests.cs
3:33 pm

Esther van Zantvoort

Reverted on request of reviewer revision(s) 5223 from DamEngine/trunk/src/Deltares.DamEngine.Data/General/Dike.cs:

Fix SonarCloud issues

Related to Issue [MWDAM-2367]

........

Options
    • -3
    • +2
    ./Deltares.DamEngine.Data/General/Dike.cs
11:52 am

Virginie Trompille

Validations of the soil profile performed in class PlLinesCreator.cs and PlLinesToWaternetConverter.cs are moved to a new class SoilProfileValidator and called only by the PlLinesCreator.

Related to Issue [MWDAM-2164]

Options
    • -3
    • +94
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForSoilProfiles.cs
    • -296
    • +4
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverterTests.cs
    • -8
    • +3
    ./Deltares.DamEngine.Calculators/KernelWrappers/Common/DamPipingHelper.cs
    • -0
    • +3
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForSurfaceLines.cs
    • -1
    • +0
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/Common/UpliftHelperTests.cs
    • -1
    • +1
    ./Deltares.DamEngine.Calculators/KernelWrappers/Interfaces/IKernelDataOutput.cs
    • -13
    • +25
    ./Deltares.DamEngine.Calculators/Properties/Resources.resx
    • -5
    • +23
    ./Deltares.DamEngine.Calculators/Properties/Resources.nl-NL.resx
    • -48
    • +22
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
    • -1
    • +1
    ./Deltares.DamEngine.Calculators/KernelWrappers/Common/PlLinesHelper.cs
    • -1
    • +1
    ./Deltares.DamEngine.Calculators/KernelWrappers/Common/UpliftHelper.cs
    • -58
    • +9
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/TestHelpers/DamEngineDataTestFactory.cs
    • -0
    • +186
    ./Deltares.DamEngine.Calculators/PlLinesCreator/SoilProfileValidator.cs
    • -41
    • +7
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverter.cs
    • -28
    • +46
    ./Deltares.DamEngine.Calculators/Properties/Resources.Designer.cs
Wednesday 15 Jan
12:01 pm

John Bokma

Added test file for dwp_8 to create an issue test.

Related to Issue [MWDAM-2400]

Options
    • -0
    • +606
    ./Deltares.DamEngine.IntegrationTests/TestFiles/InputFileDWP8.xml
    • -1
    • +4
    ./Deltares.DamEngine.IntegrationTests/Deltares.DamEngine.IntegrationTests.csproj
10:09 am

Virginie Trompille

Problem solved by using a smaller accuracy when comparing z coordinates

Related to Issue [MWDAM-2569]

Options
    • -3
    • +4
    ./Deltares.DamEngine.Data/Geotechnics/SoilSurfaceProfile.cs
10:00 am

Virginie Trompille

Unit test reproducing the problem added.

Related to Issue [MWDAM-2569]

Options
    • -0
    • +63
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilSurfaceProfileTests.cs
12:09 am

Esther van Zantvoort

Select locations in xml

Related to Issue [MWDAM-2578]

Options
    • -3
    • +3
    ./Deltares.DamEngine.IntegrationTests/Deltares.DamEngine.IntegrationTests.csproj
    • -3
    • +5
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
    • too large
    ./Deltares.DamEngine.IntegrationTests/TestFiles/InputTutorialStability2D.xml
    • -513
    • +0
    ./Deltares.DamEngine.IntegrationTests/TestFiles/DesignInputFileWithRiverLevelAboveDikeTopButBelowDTH.xml
    • -0
    • +18
    ./Deltares.DamEngine.TestHelpers/XmlAdapter.cs
Tuesday 14 Jan
6:05 pm

Esther van Zantvoort

Adapted to review

Related to Issue [MWDAM-2488]

Options
    • -9
    • +13
    ./Deltares.DamEngine.Data.Tests/Design/DesignScenarioTests.cs
11:57 am

John Bokma

Fixed some issues in the exporter tests.

Related to Issue [MWDAM-2446]

Options
    • -5
    • +4
    ./Deltares.DamEngine.Data.Tests/Geotechnics/GeometryExporterTests.cs
9:33 am

Virginie Trompille

If statement removed because always true

Related to Issue [MWDAM-2517]

Options
    • -9
    • +6
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverter.cs
9:04 am

Virginie Trompille

Reference line of the waternet containing upwards vertical part is corrected (by shifting the highest point by 1cm) in order to be correctly displayed in D-Stability

Related to Issue [MWDAM-2517]

Options
    • -0
    • +34
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverterTests.cs
    • -0
    • +26
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverter.cs
Monday 13 Jan
5:55 pm

Esther van Zantvoort

Set Invariant Culture

Related to Issue [MWDAM-2488]

Options
    • -0
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
5:31 pm

Esther van Zantvoort

Update tests RiverLevelAboveDikeTopButBelowDikeTableHeight for AdaptGeometry and NoAdaption

Related to Issue [MWDAM-2488]

Options
  1. ./Deltares.DamEngine.Data.Tests/Design
    • -17
    • +23
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
    • -3
    • +8
    ./Deltares.DamEngine.Data/Design/DesignScenario.cs
    • -982
    • +511
    ./Deltares.DamEngine.IntegrationTests/TestFiles/DesignInputFileWithRiverLevelAboveDikeTopButBelowDTH.xml
    • -0
    • +68
    ./Deltares.DamEngine.Data.Tests/Design/DesignScenarioTests.cs
5:21 pm

John Bokma

Updated the exporter and its helper.

Related to Issue [MWDAM-2446]

Options
    • -18
    • +7
    ./Deltares.DamEngine.Data/GeometryExport/GeometryExporter.cs
    • -0
    • +4
    ./Deltares.DamEngine.Data/GeometryExport/GeometryExporterHelper.cs
5:09 pm

John Bokma

Added (rudimentary) tests for the geometry exporter.

Related to Issue [MWDAM-2446]

Options
    • -35
    • +7
    ./Deltares.DamEngine.Data.Tests/Geotechnics/GeometryHelperTests.cs
    • -34
    • +0
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilProfile2DSurfaceLineHelperTests.cs
    • -0
    • +10
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
    • -16
    • +2
    ./Deltares.DamEngine.Data/Geometry/GeometryConstants.cs
    • -0
    • +53
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForSoilProfiles.cs
    • -0
    • +110
    ./Deltares.DamEngine.Data.Tests/Geotechnics/GeometryExporterTests.cs
    • -28
    • +9
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/MacroStabilityCommonHelperTests.cs
    • -6
    • +0
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilSurfaceProfileTests.cs
10:05 am

Virginie Trompille

The determination of 2D aquifer layers in PlLinesToWaternetConverter is extracted to a new class SoilProfile2DHelper in order to be used by the waternet creator validator

Related to Issue [MWDAM-2525]

Options
    • -0
    • +1002
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/Common/SoilProfile2DHelperTests.cs
    • -0
    • +1198
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverterTests.cs
    • -207
    • +8
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverter.cs
    • -0
    • +232
    ./Deltares.DamEngine.Calculators/KernelWrappers/Common/SoilProfile2DHelper.cs
Friday 10 Jan
2:40 pm

Virginie Trompille

Refactoring: comments improved + unused method DetermineStabilityUplift removed

Related to Issue [MWDAM-2226]

Options
    • -3
    • +3
    ./Deltares.DamEngine.Data/General/Sensors/Sensor.cs
    • -1
    • +0
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
    • -5
    • +3
    ./Deltares.DamEngine.Calculators/KernelWrappers/Common/PlLinesHelper.cs
    • -14
    • +2
    ./Deltares.DamEngine.Calculators/KernelWrappers/Common/UpliftHelper.cs
    • -1
    • +0
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -4
    • +4
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/Common/UpliftHelperTests.cs
Wednesday 08 Jan
4:02 pm

John Bokma

Removed Wip-status and Slow status for test as it succeeds and runs very fast.

Related to Issue [MWDAM-1979]

Options
    • -2
    • +0
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs