DAM / DamEngine / trunk

src

Checkout Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 7
Last Commit: 15 Dec
Commits this week: 0
Total Lines of Code (LoC): 147,819
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 13 Feb
5:55 pm

Esther van Zantvoort

Adapted to review

Related to Issue [MWDAM-2643]

Options
    • -1
    • +1
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
    • -6
    • +7
    ./Deltares.DamEngine.Calculators/DikesDesign/SurfaceLineAdapter.cs
    • -2
    • +3
    ./Deltares.DamEngine.Calculators/Uplift/UpliftLocationDeterminator.cs
1:14 pm

Esther van Zantvoort

Fix sonarcloud: Remove TextFixture

Related to Issue [MWDAM-2674]

Options
    • -7
    • +0
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MultiCoreMacroStabilityTests.cs
    • -3
    • +0
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalMultiCoreTests.cs
12:51 pm

Esther van Zantvoort

Reverted revision(s) 5774 from :

Fix sonarcloud Reliability issue: Use a comparison to 'default(TDomainObject)' instead or add a constraint to 'TDomainObject' so that it can't be a value type.

Related to Issue [MWDAM-2643]

........

Options
    • -2
    • +1
    ./Deltares.DamEngine.Calculators/KernelWrappers/Assemblers/DtoAssembler.cs
12:50 pm

John Bokma

I corrected the input file so it now contains an inner loop with IsAquifer = true whilst its outer loops are aquitards.

Related to Issue [MWDAM-2462]

Options
    • -1
    • +1
    ./Deltares.DamEngine.Calculators.Tests/PlLinesCreator/TestFiles/InputFileDWP1WithInnerLoop.xml
10:39 am

John Bokma

Corrected result for change in accuracy of coordinates.

Related to Issue [MWDAM-2400]

Options
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
Wednesday 12 Feb
4:57 pm

Esther van Zantvoort

Fix sonarcloud Reliability issue: Use a comparison to 'default(TDomainObject)' instead or add a constraint to 'TDomainObject' so that it can't be a value type.

Related to Issue [MWDAM-2643]

Options
    • -1
    • +2
    ./Deltares.DamEngine.Calculators/KernelWrappers/Assemblers/DtoAssembler.cs
4:45 pm

Esther van Zantvoort

Fix sonarcloud Reliability issues: Do not check floating point equality with exact values, use a range instead

Related to Issue [MWDAM-2643]

Options
    • -1
    • +3
    ./Deltares.DamEngine.Calculators/Uplift/UpliftLocationDeterminator.cs
    • -2
    • +3
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
    • -3
    • +4
    ./Deltares.DamEngine.Calculators/DikesDesign/SurfaceLineAdapter.cs
4:35 pm

John Bokma

Adapted to review comment by Tom. Also contains the fix for review comment on Issue [MWDAM-2400] by Virginie.

Related to Issue [MWDAM-2258]

Options
    • -36
    • +31
    ./Deltares.DamEngine.Data/Geotechnics/SoilProfile2DSurfaceLineHelper.cs
3:34 pm

Virginie Trompille

Adapted to review: obsolete parameter IsTangentLinesAutomatic for Bishop removed

Related to Issue [MWDAM-2665]

Options
    • -12
    • +3
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityInwards/BishopGridCreator.cs
    • -4
    • +0
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/BishopCalculationGrid.cs
    • -2
    • +4
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
    • -1
    • +0
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityInwards/BishopGridCreatorTests.cs
3:10 pm

Virginie Trompille

Failing tests for shift geometry solved (when calling ReconstructSurfaces the surface line of the original soil profile had no points)

Related to Issue [MWDAM-2677]

Options
    • -2
    • +1
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilProfile2DSurfaceLineHelperTests.cs
    • -0
    • +23
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/IssuesTests.cs
    • -8
    • +9
    ./Deltares.DamEngine.Data/Geotechnics/SoilProfile2DSurfaceLineHelper.cs
    • -27
    • +28
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
1:28 pm

Tom The

Removed properties from Location that are duplicated in DesignScenario

Related to Issue [MWDAM-2649]

Options
    • -1
    • +0
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
    • -3
    • +4
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalStabilityProfile1DTests.cs
    • -4
    • +4
    ./Deltares.DamEngine.Data/Design/DesignScenario.cs
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/IssuesTests.cs
    • -4
    • +4
    ./Deltares.DamEngine.Calculators.Tests/Sensors/SensorLocationTests.cs
    • -2
    • +2
    ./Deltares.DamEngine.Calculators/KernelWrappers/Common/PlLinesHelper.cs
    • -24
    • +0
    ./Deltares.DamEngine.Calculators/DikesDesign/DesignCalculator.cs
    • -0
    • +1
    ./Deltares.DamEngine.Calculators.Tests/Sensors/SensorPLLineCreatorTest.cs
    • binary
    ./Deltares.DamEngine.IntegrationTests/TestFiles/Operational/Profile1DTests/CalculateStabilityInsideBishopGrid1_UseLocationDataOutputFile.xml
    • -6
    • +6
    ./Deltares.DamEngine.TestHelpers/GeneralHelper.cs
    • -64
    • +0
    ./Deltares.DamEngine.Data/General/Location.cs
    • -8
    • +8
    ./Deltares.DamEngine.Data/General/Sensors/SensorLocation.cs
1:23 pm

Esther van Zantvoort

Add tests for multicore that do not run with 1 core first, only check on errors and expected number of results.

Related to Issue [MWDAM-2674]

Options
    • -22
    • +71
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MultiCoreMacroStabilityTests.cs
    • -12
    • +51
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalMultiCoreTests.cs
1:16 pm

Virginie Trompille

Failing tests temporary moved to WIP

Related to Issue [MWDAM-2677]

Options
    • -1
    • +2
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilProfile2DSurfaceLineHelperTests.cs
1:06 pm

Virginie Trompille

Shift temporary set to 0 because implementation is not correct

Related to Issue [MWDAM-2677]

Options
    • -0
    • +4
    ./Deltares.DamEngine.Data/Geotechnics/SoilProfile2DSurfaceLineHelper.cs
12:18 pm

Virginie Trompille

Commit 5760 partly reverted: Z coord. of point should be modified

Related to Issue [MWDAM-2677]

Options
    • -1
    • +2
    ./Deltares.DamEngine.Data/Geotechnics/SoilProfile2D.cs
10:28 am

Virginie Trompille

Input of test updated to not use the shift of the geometry

Related to Issue [MWDAM-2677]

Options
    • -0
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/IssuesTests.cs
10:10 am

Tom The

Adapted to review

Related to Issue [MWDAM-2627]

Options
    • -3
    • +24
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalStabilityProfile1DTests.cs
9:31 am

Virginie Trompille

Unit tests including shift of the geometry are extended to highlight new bug

Related to Issue [MWDAM-2677]

Options
    • -9
    • +9
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForSoilProfiles.cs
    • -4
    • +3
    ./Deltares.DamEngine.Data/Geotechnics/SoilProfile2D.cs
    • -43
    • +37
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilProfile2DSurfaceLineHelperTests.cs
Tuesday 11 Feb
9:55 pm

Esther van Zantvoort

TC agents have 8 cores

Related to Issue [MWDAM-2668]

Options
    • -4
    • +4
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MultiCoreMacroStabilityTests.cs
9:48 pm

Esther van Zantvoort

Mention maxCores and processorCount in assertion.

Related to Issue [MWDAM-2668]

Options
    • -1
    • +1
    ./Deltares.DamEngine.TestHelpers/GeneralHelper.cs
5:50 pm

Esther van Zantvoort

Ignore the test when maxCores is larger than processorCount.

Related to Issue [MWDAM-2668]

Options
    • -0
    • +5
    ./Deltares.DamEngine.TestHelpers/GeneralHelper.cs
5:41 pm

Esther van Zantvoort

Limit cores in tests to relevant combinations.

Run all with 4 cores and at least another with less than 12 cores.

Related to Issue [MWDAM-2668]

Options
    • -9
    • +9
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MultiCoreMacroStabilityTests.cs
    • -3
    • +4
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalMultiCoreTests.cs
5:30 pm

Virginie Trompille

The shift of the geometry compared to the surface line is implemented and tested.

Related to Issue [MWDAM-2677]

Options
    • -13
    • +1
    ./Deltares.DamEngine.Data/Geotechnics/SoilProfile2D.cs
    • -1
    • +1
    ./Deltares.DamEngine.Calculators/DikesDesign/DesignCalculatorCombinedSlopeAndShoulderAdaption.cs
    • -4
    • +39
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilProfile2DSurfaceLineHelperTests.cs
    • -6
    • +8
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityCommonHelper.cs
    • -13
    • +13
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/MacroStabilityCommonHelperTests.cs
    • -1
    • +1
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityOutwards/MacroStabilityOutwardsKernelWrapper.cs
    • -9
    • +9
    ./Deltares.DamEngine.Data/Geotechnics/SoilProfile2DSurfaceLineHelper.cs
    • -1
    • +1
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
2:46 pm

Esther van Zantvoort

Reverted revision(s) 5750 from DamEngine:

Keep unused method on request of reviewer

Related to Issue [MWDAM-2646]

........

Options
    • -24
    • +2
    ./Deltares.DamEngine.TestHelpers/GeneralHelper.cs
2:36 pm

Esther van Zantvoort

Keep unused method on request of reviewer

Related to Issue [MWDAM-2646]

Options
    • -2
    • +24
    ./Deltares.DamEngine.TestHelpers/GeneralHelper.cs
12:07 pm

Esther van Zantvoort

Fixed sonarcloud: removed TextFixture from class

Related to Issue [MWDAM-2496]

Options
    • -2
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MultiCoreMacroStabilityTests.cs
    • -2
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalMultiCoreTests.cs
11:59 am

Esther van Zantvoort

Moved code to GeneralHelper RunMultiCoreWithXmlInputFile

Related to Issue [MWDAM-2496]

Options
    • -0
    • +33
    ./Deltares.DamEngine.TestHelpers/GeneralHelper.cs
    • -20
    • +2
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalMultiCoreTests.cs
    • -26
    • +3
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MultiCoreMacroStabilityTests.cs
11:36 am

Esther van Zantvoort

Correction of outcommented lines

Related to Issue [MWDAM-2496]

Options
    • -3
    • +3
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalMultiCoreTests.cs
11:32 am

Esther van Zantvoort

Modified message in ThrowWhenLevelAboveDike

Related to Issue [MWDAM-2647]

Options
    • -1
    • +1
    ./Deltares.DamEngine.Data/Geotechnics/SurfaceLine2Extensions.cs
    • -2
    • +2
    ./Deltares.DamEngine.Calculators.Tests/Sensors/SensorPLLineCreatorTest.cs
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
9:06 am

Virginie Trompille

Test name improved

Related to Issue [MWDAM-2462]

Options
    • -2
    • +2
    ./Deltares.DamEngine.Calculators.Tests/PlLinesCreator/SoilProfileValidatorTests.cs