src

Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Code improved according to sonarcloud issue

Related to Issue [MWDAM-2691]

Waternet line associated to an empty PL line (no points) is not created

Related to Issue [MWDAM-2733]

Integration tests for piping updated with the new results.

Related to Issue [MWDAM-2691]

    • -2
    • +2
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/WtiPipingSellmeijerRevisedTests.cs
Code for the PL3/PL4 reduction re-implemented and improved (1D soil profile is not converted to 2D soil profile to spare calculation time).

Integration tests for piping updated with the new results.

Related to Issue [MWDAM-2691]

    • -5
    • +4
    ./Deltares.DamEngine.Data/Geometry/GeometryPointString.cs
    • -28
    • +32
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/PipingBlighTests.cs
    • -58
    • +76
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
    • too large
    ./Deltares.DamEngine.Calculators.Tests/PlLinesCreator/PlLinesCreatorTest.cs
Updated the xml file after adding shift to UI.

Related to Issue [MWDAM-2701]

    • too large
    ./Deltares.DamEngine.IntegrationTests/TestFiles/InputTutorialStability2D.xml
Added tests for PL3 and PL4

Related to Issue [MWDAM-2548]

    • -9
    • +110
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalStabilityProfile1DTests.cs
code temporary reverted due to execution timeout

Related to Issue [MWDAM-2691]

Reduction of PL3/PL4 temporary reverted to better investigate the piping failing tests (execution time out)

Related to Issue [MWDAM-2691]

    • too large
    ./Deltares.DamEngine.Calculators.Tests/PlLinesCreator/PlLinesCreatorTest.cs
Improve unit tests

Related to Issue [MWDAM-2548]

    • -4
    • +6
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalStabilityProfile1DTests.cs
Test is corrected and WIP is removed

Related to Issue [MWDAM-2462]

    • -1
    • +2
    ./Deltares.DamEngine.Calculators.Tests/PlLinesCreator/SoilProfileValidatorTests.cs
Adapted to review: method starting with Get renamed into Determine

Related to Issue [MWDAM-2724]

    • -2
    • +2
    ./Deltares.DamEngine.Calculators/DikesDesign/SurfaceLineShoulderAdapter.cs
    • -3
    • +3
    ./Deltares.DamEngine.Calculators/DikesDesign/SurfaceLineHeightAdapter.cs
    • -1
    • +1
    ./Deltares.DamEngine.Data/Geotechnics/SurfaceLine2Extensions.cs
Reduction of PL3/PL4 implemented when the aquifer intersects the surface line (i.e. the ditch)

Related to Issue [MWDAM-2691]

    • -5
    • +4
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForSurfaceLines.cs
    • -13
    • +103
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
    • too large
    ./Deltares.DamEngine.Calculators.Tests/PlLinesCreator/PlLinesCreatorTest.cs
Fix SonarCloud issues

Related to Issue [MWDAM-2548]

    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalStabilityProfile1DTests.cs
Cleanup and Reformat

Related to Issue [MWDAM-2548]

    • -81
    • +88
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalStabilityProfile1DTests.cs
    • -2
    • +1
    ./Deltares.DamEngine.Calculators.Tests/Sensors/SensorPLLineCreatorTest.cs
    • -1
    • +1
    ./Deltares.DamEngine.Calculators.Tests/Sensors/SensorLocationTests.cs
Fix unit tests

Related to Issue [MWDAM-2548]

    • -1
    • +1
    ./Deltares.DamEngine.Calculators.Tests/Sensors/SensorLocationTests.cs
    • -5
    • +3
    ./Deltares.DamEngine.Calculators.Tests/Sensors/SensorPLLineCreatorTest.cs
Added test for PL-line using only sensordata

Related to Issue [MWDAM-2548]

    • -19
    • +82
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalStabilityProfile1DTests.cs
Improve test and move out of WorkInProgress

Related to Issue [MWDAM-2548]

    • -26
    • +39
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalStabilityProfile1DTests.cs
STIX file added

Related to Issue [MWDAM-2462]

    • binary
    ./Deltares.DamEngine.Calculators.Tests/PlLinesCreator/TestFiles/DWP_1InnerLoopAquifer.stix
Cognitive complexity is reduced

Related to Issue [MWDAM-2716]

Removed Geometry2DSectionAssembler.cs

Related to Issue [MWDAM-2160]

    • -80
    • +0
    ./Deltares.DamEngine.Calculators/General/Geometry2DSectionParameters.cs
    • -119
    • +0
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/Assemblers/Geometry2DSectionAssemblerTest.cs
Remove code for reading sti files.

Related to Issue [MWDAM-2160]

    • -598
    • +413
    ./Deltares.DamEngine.IntegrationTests/TestFiles/InputForDebugging.xml
Remove code for reading sti files.

Related to Issue [MWDAM-2160]

    • -16
    • +0
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/DesignCalculatorTests.cs
Remove code for reading sti files.

Related to Issue [MWDAM-2160]

Remove code for reading sti files.

Related to Issue [MWDAM-2160]

    • -5
    • +0
    ./Deltares.DamEngine.Interface/FillXmlInputFromDam.cs
    • -11
    • +5
    ./Deltares.DamEngine.Data.Tests/General/SoilGeometryProbabilityTest.cs
    • -4
    • +0
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForDamProjectData.cs
    • -3
    • +1
    ./Deltares.DamEngine.Calculators/Uplift/UpliftLocationDeterminator.cs
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
    • -5
    • +0
    ./Deltares.DamEngine.Interface/FillDamFromXmlInput.cs
    • -30
    • +12
    ./Deltares.DamEngine.Data/General/SoilGeometryProbability.cs
    • -890
    • +0
    ./Deltares.DamEngine.IntegrationTests/TestFiles/InputFileForDGeoStability.xml
    • -2
    • +0
    ./Deltares.DamEngine.Interface.Tests/ConversionHelperTests.cs
    • -3
    • +0
    ./Deltares.DamEngine.IntegrationTests/Deltares.DamEngine.IntegrationTests.csproj
  1. … 13 more files in changeset.
Case without in between aquifers improved

Related to Issue [MWDAM-2716]

Added comments

Related to Issue [MWDAM-2272]

    • -1
    • +4
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalCombinationTests.cs
Added test for PLline creation with sensors for SoilProfile1D

Related to Issue [MWDAM-2548]

    • -0
    • +3
    ./Deltares.DamEngine.IntegrationTests/Deltares.DamEngine.IntegrationTests.csproj
    • -0
    • +142
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalStabilityProfile1DTests.cs
In-between aquifers situated at the left side of DikeToeAtPolder are not taken into account.

Unit tets added.

Related to Issue [MWDAM-2720]

    • -35
    • +16
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForSoilProfiles.cs
Sonarcloud issues fixed

Related to Issue [MWDAM-2716]

Moved Run_UsingTestFiles_WithPipingModelFailsBecauseNoRelevantSegments to OperationalCombinationTests

Related to Issue [MWDAM-2272]

    • -37
    • +0
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalStabilityProfile1DTests.cs
    • -0
    • +65
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalCombinationTests.cs