Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 05 Dec 2018
2:41 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated DuneBoundaryCalculator calls. WTI-1923

Options
    • -3
    • +3
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Service/DuneLocationCalculationService.cs
    • -1
    • +4
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/GuiServices/DuneLocationCalculationGuiServiceTest.cs
    • -9
    • +20
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Views/DuneLocationCalculationsViewTest.cs
    • -1
    • +5
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/TreeNodeInfos/DuneErosionFailureMechanismContextTreeNodeInfoTest.cs
    • -7
    • +16
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/TreeNodeInfos/DuneLocationCalculationsContextTreeNodeInfoTest.cs
    • -1
    • +5
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/TreeNodeInfos/DuneLocationCalculationsGroupContextTreeNodeInfoTest.cs
    • -1
    • +6
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Service.Test/DuneLocationCalculationActivityFactoryTest.cs
    • -5
    • +21
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Service.Test/DuneLocationCalculationActivityTest.cs
    • -7
    • +22
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Service.Test/DuneLocationCalculationServiceTest.cs
    • -3
    • +3
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Calculator/Factory/HydraRingCalculatorFactory.cs
    • -7
    • +6
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Calculator/Factory/IHydraRingCalculatorFactory.cs
    • -2
    • +5
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/TreeNodeInfos/AssessmentSectionTreeNodeInfoTest.cs
    • -1
    • +4
    /Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/AssessmentSectionCalculationActivityFactoryTest.cs
2:41 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added update handler to importer. WTI-1486

Options
    • -2
    • +15
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
    • -2
    • +18
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicBoundaryDatabaseImporterTest.cs
2:36 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Updated constructor parameter order. WTI-1486

Options
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicBoundaryDatabaseImporterTest.cs
2:35 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Introduced an update handler for the hydraulic boundary database. WTI-1486

Options
    • -0
    • +60
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Handlers/IHydraulicBoundaryDatabaseUpdateHandler.cs
    • -0
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Ringtoets.Integration.IO.csproj
1:33 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed constructor arguments from derived classes: WTI-1923

- Removed directory constructor from the base class. Calculation directories should be passed through the HydraRingCalculationSettings object.

-- Adjusted derived classes

Options
    • -7
    • +7
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Calculator/DesignWaterLevelCalculator.cs
    • -7
    • +7
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Calculator/DunesBoundaryConditionsCalculator.cs
    • -34
    • +3
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Calculator/HydraRingCalculatorBase.cs
    • -7
    • +7
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Calculator/HydraulicLoadsCalculator.cs
    • -7
    • +7
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Calculator/OvertoppingCalculator.cs
    • -7
    • +6
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Calculator/StructuresCalculator.cs
    • -7
    • +7
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Calculator/WaveConditionsCosineCalculator.cs
    • -7
    • +7
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Calculator/WaveHeightCalculator.cs
    • -1
    • +2
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Calculator/DesignWaterLevelCalculatorTest.cs
    • -1
    • +2
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Calculator/DunesBoundaryConditionsCalculatorTest.cs
    • -1
    • +2
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Calculator/HydraulicLoadsCalculatorTest.cs
    • -1
    • +2
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Calculator/OvertoppingCalculatorTest.cs
    • -1
    • +5
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Calculator/StructuresCalculatorTest.cs
    • -1
    • +2
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Calculator/WaveConditionsCosineCalculatorTest.cs
    • -1
    • +2
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Calculator/WaveHeightCalculatorTest.cs
1:06 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduced test factory to create instances of HydraRingCalculationSettings. WTI-1923

- Replaced local definitions

Options
    • -12
    • +10
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Calculator/HydraRingCalculatorBaseTest.cs
    • -0
    • +20
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.TestUtil.Test/HydraRingCalculationSettingsTestFactoryTest.cs
    • -0
    • +1
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.TestUtil.Test/Ringtoets.HydraRing.Calculation.TestUtil.Test.csproj
    • -0
    • +21
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.TestUtil/HydraRingCalculationSettingsTestFactory.cs
    • -0
    • +1
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.TestUtil/Ringtoets.HydraRing.Calculation.TestUtil.csproj
12:00 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added documentation. WTI-1486

Options
    • -0
    • +11
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
11:54 am

Robert Tangerman <robert.tangerman@deltares.nl>

Derived importer from FileImporterBase. WTI-1486

Options
    • -1
    • +16
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
    • -1
    • +15
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicBoundaryDatabaseImporterTest.cs
11:53 am

Dennis Tang <dennis.tang@deltares.nl>

Changed wiring in the HydraRingInitializationService: WTI-1923

- Removed directory constructor parameters, as they are grouped into a ConfigurationSettings object.

-- Adjusted the calculator base and cleaned up its tests which still use the directories as argument

Options
    • -5
    • +4
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Calculator/HydraRingCalculatorBase.cs
    • -10
    • +0
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/HydraRingFileConstants.cs
    • -7
    • +13
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Services/HydraRingInitializationService.cs
    • -30
    • +8
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Calculator/HydraRingCalculatorBaseTest.cs
    • -7
    • +27
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Services/HydraRingInitializationServiceTest.cs
11:48 am

Dennis Tang <dennis.tang@deltares.nl>

Removed unused reference. WTI-1923

Options
    • -1
    • +0
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Data/Input/HydraRingCalculationSettings.cs
11:47 am

Robert Tangerman <robert.tangerman@deltares.nl>

Introduced new hydraulic boundary database importer. WTI-1486

Options
    • -0
    • +27
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
    • -0
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Ringtoets.Integration.IO.csproj
    • -0
    • +31
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicBoundaryDatabaseImporterTest.cs
    • -0
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Ringtoets.Integration.IO.Test.csproj
11:27 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3403: WTI-1887

- Introduced additional constructor for the typed object

- Cleaned up XMLDoc and code

Options
    • -2
    • +2
    /Core/Components/src/Core.Components.DotSpatial/Converter/FeatureBasedMapDataConverter.cs
    • -1
    • +1
    /Core/Components/src/Core.Components.DotSpatial/Converter/MapPolygonDataConverter.cs
    • -0
    • +8
    /Core/Components/src/Core.Components.Gis/Data/FeatureBasedMapData.cs
    • -1
    • +3
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/FeatureBasedMapDataConverterTest.cs
    • -1
    • +18
    /Core/Components/test/Core.Components.Gis.Test/Data/FeatureBasedMapDataTest.cs
11:12 am

Dennis Tang <dennis.tang@deltares.nl>

Added constructor in the HydraRing CalculatorBase: WTI-1923

- Started replacing the constructor with the calculation settings overload.

Options
    • -1
    • +1
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Calculator/HydraRingCalculatorBase.cs
    • -7
    • +15
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Calculator/HydraRingCalculatorBaseTest.cs
11:08 am

Dennis Tang <dennis.tang@deltares.nl>

Simplified CalculationSettings object: WTI-1923

- Removed unused property

-- Renamed property

- Removed filepath checks

-- Checks are already performed on the calling side, so there's no need to check again.

Options
    • -21
    • +10
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Data/Input/HydraRingCalculationSettings.cs
    • -44
    • +11
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Data/Input/HydraRingCalculationSettingsTest.cs
10:40 am

Dennis Tang <dennis.tang@deltares.nl>

Added constructor in the HydraRing CalculatorBase: WTI-1923

- Added constructor which accepts the a hydraring calculation configuration object.

Options
    • -0
    • +22
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Calculator/HydraRingCalculatorBase.cs
    • -0
    • +13
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Calculator/HydraRingCalculatorBaseTest.cs
10:29 am

Dennis Tang <dennis.tang@deltares.nl>

Added HydraRing configuration class: WTI-1923

- Introduced to hold all general configuration information in order to perform a hydraring calculation.

Options
    • -0
    • +56
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Data/Input/HydraRingCalculationSettings.cs
    • -0
    • +1
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Ringtoets.HydraRing.Calculation.csproj
    • -0
    • +83
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Data/Input/HydraRingCalculationSettingsTest.cs
    • -0
    • +1
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Ringtoets.HydraRing.Calculation.Test.csproj
Tuesday 04 Dec 2018
4:07 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3401: WTI-1906

- Cleaned up src and test code

- Added background color for the warning panel as desired

Options
    • -4
    • +7
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssemblyResultPerSectionMapView.Designer.cs
    • -16
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssemblyResultPerSectionMapView.cs
    • -5
    • +9
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/AssemblyResultPerSectionMapViewTest.cs
1:36 pm

Dennis Tang <dennis.tang@deltares.nl>

Merge branch 'feature/1887'

Options
1:35 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3395: WTI-1887

- Updated test names to a more descriptive one

-- Corrected typos

Options
    • -1
    • +1
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/MapLineDataConverterTest.cs
    • -2
    • +2
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/MapPointDataConverterTest.cs
    • -2
    • +2
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/MapPolygonDataConverterTest.cs
10:43 am

Robert Tangerman <robert.tangerman@deltares.nl>

Updated reference line color. WTI-1892

Options
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Factories/RingtoetsMapDataFactory.cs
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Factories/RingtoetsMapDataFactoryTest.cs
10:38 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3395: WTI-1887

- Fixed compilation errors in the converter test of the FeatureBasedMapData.

Options
    • -70
    • +189
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/FeatureBasedMapDataConverterTest.cs
Monday 03 Dec 2018
9:08 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3395: WTI-1887

- Fixed compilation errors in the converter tests of the derived map data classes

Options
    • -11
    • +8
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/MapLineDataConverterTest.cs
    • -10
    • +7
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/MapPointDataConverterTest.cs
    • -11
    • +10
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/MapPolygonDataConverterTest.cs
Friday 30 Nov 2018
12:01 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3395: WTI-1887

- Renamed test names

- Improved XMLDoc

Options
    • -1
    • +1
    /Core/Components/src/Core.Components.Gis/Theme/LineCategoryTheme.cs
    • -1
    • +1
    /Core/Components/src/Core.Components.Gis/Theme/MapTheme.cs
    • -1
    • +1
    /Core/Components/src/Core.Components.Gis/Theme/PointCategoryTheme.cs
    • -1
    • +1
    /Core/Components/src/Core.Components.Gis/Theme/PolygonCategoryTheme.cs
    • -1
    • +1
    /Core/Components/test/Core.Components.Gis.Test/Theme/CategoryThemeTest.cs
11:54 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3395: WTI-1887

- Fixed compilation errors in the converters after changes in the datamodel for the derived classes of the FeatureBasedMapData

-- Moved all generic functions to the base class

-- Moved general operation definitions to the base class

Options
    • -47
    • +64
    /Core/Components/src/Core.Components.DotSpatial/Converter/FeatureBasedMapDataConverter.cs
    • -26
    • +7
    /Core/Components/src/Core.Components.DotSpatial/Converter/MapLineDataConverter.cs
    • -24
    • +5
    /Core/Components/src/Core.Components.DotSpatial/Converter/MapPointDataConverter.cs
    • -32
    • +16
    /Core/Components/src/Core.Components.DotSpatial/Converter/MapPolygonDataConverter.cs
9:09 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3395: WTI-1887

- Fixed compilation errors as a consequence of changes in the derived classes of FeatureBasedMapData

-- Fixed for the demo thematical map

Options
    • -68
    • +56
    /Demo/Ringtoets/src/Demo.Ringtoets/Commands/OpenThematicalMapViewCommand.cs
Thursday 29 Nov 2018
5:09 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3395: WTI-1887

- Fixed compilation errors as a consequence of changes in the derived classes of FeatureBasedMapData

-- Fixed for the property classes

Options
    • -26
    • +21
    /Core/Plugins/test/Core.Plugins.Map.Test/PropertyClasses/MapLineDataPropertiesTest.cs
    • -26
    • +21
    /Core/Plugins/test/Core.Plugins.Map.Test/PropertyClasses/MapPointDataPropertiesTest.cs
    • -26
    • +21
    /Core/Plugins/test/Core.Plugins.Map.Test/PropertyClasses/MapPolygonDataPropertiesTest.cs
5:02 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3395: WTI-1887

- Fixed compilation errors due to changes in the derived classes from the FeatureBasedMapData

-- Fixed for the MapDataFactories

Options
    • -6
    • +6
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Factories/AssemblyMapDataFactory.cs
    • -3
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Factories/CombinedSectionAssemblyMapDataFactory.cs
4:54 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3395: WTI-1887

- Fixed compilation errors of the derived classes from the FeatureBasedMapData as a consequence of the data model change.

Options
    • -7
    • +15
    /Core/Components/src/Core.Components.Gis/Data/MapLineData.cs
    • -7
    • +16
    /Core/Components/src/Core.Components.Gis/Data/MapPointData.cs
    • -7
    • +15
    /Core/Components/src/Core.Components.Gis/Data/MapPolygonData.cs
    • -4
    • +50
    /Core/Components/test/Core.Components.Gis.Test/Data/MapLineDataTest.cs
    • -3
    • +52
    /Core/Components/test/Core.Components.Gis.Test/Data/MapPointDataTest.cs
    • -2
    • +49
    /Core/Components/test/Core.Components.Gis.Test/Data/MapPolygonDataTest.cs
4:28 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3395: WTI-1887

- Added typed derivative of the FeatureBasedMapData in order to prevent duplication of specific converters

Options
    • -1
    • +29
    /Core/Components/src/Core.Components.Gis/Data/FeatureBasedMapData.cs
    • -1
    • +33
    /Core/Components/test/Core.Components.Gis.Test/Data/FeatureBasedMapDataTest.cs
4:02 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3395: WTI-1887

- Swapped constructor arguments for the CategoryThemeProperties

- Refactored property return value

- Further cleanup

Options
    • -18
    • +18
    /Core/Plugins/src/Core.Plugins.Map/PropertyClasses/CategoryThemeProperties.cs
    • -3
    • +3
    /Core/Plugins/src/Core.Plugins.Map/PropertyClasses/LineCategoryThemeProperties.cs
    • -1
    • +1
    /Core/Plugins/src/Core.Plugins.Map/PropertyClasses/MapLineDataProperties.cs
    • -1
    • +1
    /Core/Plugins/src/Core.Plugins.Map/PropertyClasses/MapPointDataProperties.cs
    • -1
    • +1
    /Core/Plugins/src/Core.Plugins.Map/PropertyClasses/MapPolygonDataProperties.cs
    • -3
    • +3
    /Core/Plugins/src/Core.Plugins.Map/PropertyClasses/PointCategoryThemeProperties.cs
    • -3
    • +3
    /Core/Plugins/src/Core.Plugins.Map/PropertyClasses/PolygonCategoryThemeProperties.cs
    • -1
    • +1
    /Core/Plugins/test/Core.Plugins.Map.Test/PropertyClasses/CategoryThemePropertiesTest.cs
    • -4
    • +4
    /Core/Plugins/test/Core.Plugins.Map.Test/PropertyClasses/LineCategoryThemePropertiesTest.cs
    • -4
    • +4
    /Core/Plugins/test/Core.Plugins.Map.Test/PropertyClasses/PointCategoryThemePropertiesTest.cs
    • -4
    • +4
    /Core/Plugins/test/Core.Plugins.Map.Test/PropertyClasses/PolygonCategoryThemePropertiesTest.cs