Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 10 Sep 2018
10:53 am

Dennis Tang <dennis.tang@deltares.nl>

Updated migration script:

- Do not migrate ModelFactorSuperCriticalFlow for stability point structures.

WTI-1800

Options
    • -2
    • +0
    /Ringtoets/Migration/src/Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • -1
    • +0
    /Ringtoets/Migration/test/Ringtoets.Migration.Integration.Test/MigrationTo181IntegrationTest.cs
10:42 am

Dennis Tang <dennis.tang@deltares.nl>

Fixed compilation errors:

- Removed obsolete ModelFactorSuperCriticalFlow for stability point structures.

WTI-1800

Options
    • -1
    • +0
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/DbContext/IStructuresCalculationEntity.cs
    • -1
    • +0
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/StructuresCalculationCreateExtensionsTest.cs
10:41 am

Dennis Tang <dennis.tang@deltares.nl>

Updated database design:

- Regenerated entities based on the new file format.

WTI-1800

Options
    • -1
    • +1
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/DbContext/ClosingStructuresCalculationEntity.cs
    • -1
    • +1
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/DbContext/HeightStructuresCalculationEntity.cs
    • -3
    • +0
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/DbContext/RingtoetsEntities.edmx
    • -88
    • +88
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/DbContext/RingtoetsEntities.edmx.diagram
    • -1
    • +0
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/DbContext/StabilityPointStructuresCalculationEntity.cs
10:25 am

Dennis Tang <dennis.tang@deltares.nl>

Updated database design:

- Updated SQL scripts and .rtd base file

WTI-1800

Options
    • -2
    • +1
    /Ringtoets/Migration/src/Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure18.1.sql
    • binary
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/Ringtoets.rtd
    • -2
    • +1
    /build/DatabaseStructure.sql
10:18 am

Dennis Tang <dennis.tang@deltares.nl>

Updated database design:

- Removed ModelFactorSuperCriticalFlow (Mean) from stability point structures

WTI-1800

Options
    • binary
    /design/DatabaseDesign.eap
9:49 am

Dennis Tang <dennis.tang@deltares.nl>

Merge branch 'master' into 18_1_New_HydraRing

Options
Friday 07 Sep 2018
5:02 pm

Elmar Kleijn

Moved ModelFactorSuperCriticalFlow from StructuresInputBase to ClosingStructuresInput and HeightStructuresInput. WTI-1800

Options
    • -2
    • +2
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.TestUtil/RingtoetsProjectTestHelper.cs
4:56 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup:

Fixed failing test

WTI-1803

Options
    • -1
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.TestUtil.Test/InvalidIdTestHelperTest.cs
4:47 pm

Elmar Kleijn

Moved ModelFactorSuperCriticalFlow from StructuresInputBase to ClosingStructuresInput and HeightStructuresInput. WTI-1800

Options
    • -3
    • +0
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.IO.Test/test-data/StabilityPointStructuresCalculationConfigurationExporter/completeConfiguration.xml
    • -3
    • +0
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.IO.Test/test-data/StabilityPointStructuresCalculationConfigurationExporter/configurationWithForeshoreProfile.xml
    • -3
    • +0
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.IO.Test/test-data/StabilityPointStructuresCalculationConfigurationExporter/configurationWithStructure.xml
    • -3
    • +0
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.IO.Test/test-data/StabilityPointStructuresCalculationConfigurationExporter/configurationWithStructureAndLoadSchematizationTypeLinear.xml
    • -3
    • +0
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.IO.Test/test-data/StabilityPointStructuresCalculationConfigurationExporter/configurationWithStructureAndLoadSchematizationTypeQadratic.xml
    • -3
    • +0
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.IO.Test/test-data/StabilityPointStructuresCalculationConfigurationExporter/configurationWithUseBreakWater.xml
    • -6
    • +0
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.IO.Test/test-data/StabilityPointStructuresCalculationConfigurationExporter/folderWithSubfolderAndCalculation.xml
    • -3
    • +0
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.IO.Test/test-data/StabilityPointStructuresCalculationConfigurationExporter/sparseConfiguration.xml
    • -4
    • +0
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.IO.Test/test-data/StabilityPointStructuresCalculationConfigurationWriter/completeConfiguration.xml
    • -4
    • +0
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.IO.Test/test-data/StabilityPointStructuresCalculationConfigurationWriter/folderWithSubfolderAndCalculation.xml
4:44 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3213 / 3217:

- Uniformed XMLDoc across the creators for the idGenerator parameter.

WTI-1803

Options
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/AggregatedSerializableCombinedFailureMechanismSectionAssembliesCreator.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/AggregatedSerializableCombinedFailureMechanismSectionAssemblyCreator.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/AggregatedSerializableFailureMechanismCreator.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/AggregatedSerializableFailureMechanismSectionAssemblyCreator.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableFailureMechanismSectionCreator.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableTotalAssemblyResultCreator.cs
4:42 pm

Elmar Kleijn

Moved ModelFactorSuperCriticalFlow from StructuresInputBase to ClosingStructuresInput and HeightStructuresInput. WTI-1800

Options
    • -1
    • +1
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Service.Test/StabilityPointStructuresCalculationServiceTest.cs
    • -14
    • +13
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Service.Test/StabilityPointStructuresValidationRulesRegistryTest.cs
4:38 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3213 / 3217:

- Renamed the ID generator accordingly

WTI-1803

Options
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/AggregatedSerializableCombinedFailureMechanismSectionAssembliesCreator.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/AggregatedSerializableCombinedFailureMechanismSectionAssemblyCreator.cs
    • -3
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/AggregatedSerializableFailureMechanismCreator.cs
    • -3
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/AggregatedSerializableFailureMechanismSectionAssemblyCreator.cs
    • -3
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableAssemblyCreator.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableAssessmentProcessCreator.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableAssessmentSectionCreator.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableFailureMechanismCreator.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableFailureMechanismSectionCreator.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableTotalAssemblyResultCreator.cs
    • -0
    • +84
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Helpers/IdentifierGenerator.cs
    • -84
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Helpers/UniqueIdentifierGenerator.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Ringtoets.Integration.IO.csproj
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/AggregatedSerializableCombinedFailureMechanismSectionAssembliesCreatorTest.cs
    • -4
    • +4
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/AggregatedSerializableCombinedFailureMechanismSectionAssemblyCreatorTest.cs
  16. … 9 more files in changeset.
4:35 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3213 / 3217:

- Moved ID generation for an exportable assessment section to the ID generator

WTI-1803

Options
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableAssessmentSectionCreator.cs
    • -0
    • +19
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Helpers/UniqueIdentifierGenerator.cs
    • -0
    • +44
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Helpers/UniqueIdentifierGeneratorTest.cs
4:34 pm

Elmar Kleijn

Moved ModelFactorSuperCriticalFlow from StructuresInputBase to ClosingStructuresInput and HeightStructuresInput. WTI-1800

Options
    • -8
    • +6
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Integration/HydraRingConfigurationServiceIntegrationTest.cs
4:29 pm

Elmar Kleijn

Moved ModelFactorSuperCriticalFlow from StructuresInputBase to ClosingStructuresInput and HeightStructuresInput. WTI-1800

Options
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/PropertyClasses/StructuresInputBasePropertiesTest.cs
    • -4
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/StructureCalculationConfigurationWriter/structureCalculationWithAllParametersSet.xml
    • -1
    • +0
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Forms/PropertyClasses/HeightStructuresInputContextProperties.cs
    • -1
    • +1
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.IO.Test/Configurations/HeightStructuresCalculationStochastAssignerTest.cs
    • -3
    • +3
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.IO.Test/test-data/HeightStructuresCalculationConfigurationExporter/completeConfiguration.xml
    • -3
    • +3
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.IO.Test/test-data/HeightStructuresCalculationConfigurationExporter/configurationWithForeshoreProfile.xml
    • -3
    • +3
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.IO.Test/test-data/HeightStructuresCalculationConfigurationExporter/configurationWithStructure.xml
    • -3
    • +3
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.IO.Test/test-data/HeightStructuresCalculationConfigurationExporter/configurationWithUseBreakWater.xml
    • -6
    • +6
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.IO.Test/test-data/HeightStructuresCalculationConfigurationExporter/folderWithSubfolderAndCalculation.xml
    • -3
    • +3
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.IO.Test/test-data/HeightStructuresCalculationConfigurationExporter/sparseConfiguration.xml
    • -4
    • +4
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.IO.Test/test-data/HeightStructuresCalculationConfigurationWriter/completeConfiguration.xml
    • -4
    • +4
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.IO.Test/test-data/HeightStructuresCalculationConfigurationWriter/folderWithSubfolderAndCalculation.xml
4:12 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3213 / 3217:

- Generate unique IDs per unique prefix

WTI-1803

Options
    • -3
    • +10
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Helpers/UniqueIdentifierGenerator.cs
    • -12
    • +10
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/AggregatedSerializableCombinedFailureMechanismSectionAssembliesCreatorTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/AggregatedSerializableCombinedFailureMechanismSectionAssemblyCreatorTest.cs
    • -10
    • +8
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/AggregatedSerializableFailureMechanismCreatorTest.cs
    • -6
    • +6
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/AggregatedSerializableFailureMechanismSectionAssemblyCreatorTest.cs
    • -30
    • +31
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/SerializableAssemblyCreatorTest.cs
    • -1
    • +21
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Helpers/UniqueIdentifierGeneratorTest.cs
    • -109
    • +109
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/test-data/AssemblyExporter/ExpectedGml.gml
3:24 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3227:

- Formatting

WTI-1803

Options
    • -2
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/SerializableFailureMechanismSectionAssemblyResultCreatorTest.cs
3:21 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3226:

- Formatting

- Fixed XMLDocs

WTI-1803

Options
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/AggregatedSerializable/AggregatedSerializableFailureMechanism.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/AggregatedSerializable/AggregatedSerializableFailureMechanismSectionAssembly.cs
    • -2
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/AggregatedSerializable/AggregatedSerializableCombinedFailureMechanismSectionAssemblyTest.cs
    • -6
    • +6
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/AggregatedSerializable/AggregatedSerializableFailureMechanismSectionAssemblyTest.cs
3:14 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3223:

- Introduced random extensions to select a subset of enums

- Applied to affected tests

-- Applied to AssessmentSectionAssemblyResult as none and notapplicable are invalid results and will cause a NotSupportedException when generated.

WTI-1803

Options
    • -1
    • +86
    /Core/Common/test/Core.Common.TestUtil.Test/RandomExtensionsTest.cs
    • -0
    • +37
    /Core/Common/test/Core.Common.TestUtil/RandomExtensions.cs
    • -7
    • +11
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/AggregatedSerializableCombinedFailureMechanismSectionAssembliesCreatorTest.cs
    • -7
    • +11
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/AggregatedSerializableCombinedFailureMechanismSectionAssemblyCreatorTest.cs
    • -14
    • +22
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/AggregatedSerializableFailureMechanismCreatorTest.cs
    • -14
    • +22
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/AggregatedSerializableFailureMechanismSectionAssemblyCreatorTest.cs
    • -7
    • +11
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/SerializableAssemblyCreatorTest.cs
    • -1
    • +8
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/SerializableAssessmentSectionAssemblyResultCreatorTest.cs
    • -7
    • +11
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/SerializableCombinedFailureMechanismSectionAssemblyResultCreatorTest.cs
2:36 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. Paired with tang_ds. WTI-1806

Options
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/PresentationObjects/AssemblyResultsContext.cs
    • -2
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Exporters/AssemblyExporterTest.cs
    • -2
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/TreeNodeInfos/AssemblyResultsContextTreeNodeInfoTest.cs
1:32 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3223:

- Fixed XMLDocs

WTI-1803

Options
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/AggregatedSerializable/AggregatedSerializableCombinedFailureMechanismSectionAssemblies.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/AggregatedSerializable/AggregatedSerializableCombinedFailureMechanismSectionAssembly.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/AggregatedSerializableCombinedFailureMechanismSectionAssemblyCreator.cs
    • -6
    • +6
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.TestUtil/SerializableFailureMechanismSectionAssemblyResultTestHelper.cs
1:23 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Updated xsd documentation. WTI-1715

Options
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/Resources/ConfiguratieSchema.xsd
    • -3
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.IO/Resources/HbLocatieSchema.xsd
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/Resources/StochastSchema.xsd
    • -1
    • +1
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.IO/Resources/GEBUConfiguratieSchema.xsd
    • -7
    • +7
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.IO/Resources/MacroStabiliteitBinnenwaartsConfiguratieSchema.xsd
    • -7
    • +7
    /Ringtoets/Piping/src/Ringtoets.Piping.IO/Resources/PipingConfiguratieSchema.xsd
    • -1
    • +1
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/Resources/BekledingenConfiguratieSchema.xsd
1:20 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3220:

- Improved test name

WTI-1803

Options
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/AggregatedSerializable/AggregatedSerializableFailureMechanismSectionAssemblyTest.cs
1:16 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3219:

- Uniformed XMLDoc across all aggregated objects.

WTI-1803

Options
    • -3
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/AggregatedSerializable/AggregatedSerializableCombinedFailureMechanismSectionAssemblies.cs
    • -3
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/AggregatedSerializable/AggregatedSerializableCombinedFailureMechanismSectionAssembly.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/AggregatedSerializable/AggregatedSerializableFailureMechanism.cs
    • -3
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/AggregatedSerializable/AggregatedSerializableFailureMechanismSectionAssembly.cs
1:09 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3217:

- Fixed test name

WTI-1803

Options
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Assembly/ExportableAssessmentSectionTest.cs
1:05 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated review comments 3216:

- Uniformed XMLDoc for Creator functions

- Fixed typos

WTI-1803

Options
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/AggregatedSerializableCombinedFailureMechanismSectionAssemblyCreator.cs
    • -7
    • +7
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/AggregatedSerializableFailureMechanismCreator.cs
    • -6
    • +6
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/AggregatedSerializableFailureMechanismSectionAssemblyCreator.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableAssessmentSectionAssemblyResultCreator.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableAssessmentSectionCategoryGroupCreator.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableAssessmentSectionCreator.cs
    • -1
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableCombinedFailureMechanismSectionAssemblyResultCreator.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableFailureMechanismCategoryGroupCreator.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableFailureMechanismCreator.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableFailureMechanismGroupCreator.cs
    • -4
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableFailureMechanismResultCreator.cs
    • -4
    • +6
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableFailureMechanismSectionAssemblyResultCreator.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableFailureMechanismSectionCategoryGroupCreator.cs
    • -3
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableFailureMechanismSectionCreator.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableFailureMechanismTypeCreator.cs
11:32 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3216:

- Uniformed XMLDocs of creator classes

WTI-1803

Options
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/AggregatedSerializableFailureMechanismSectionAssemblyCreator.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableAssemblyCreator.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableFailureMechanismSectionCreator.cs
10:51 am

Elmar Kleijn

Moved ModelFactorSuperCriticalFlow from StructuresInputBase to ClosingStructuresInput and HeightStructuresInput. WTI-1800

Options
    • -1
    • +1
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/Configurations/ClosingStructuresCalculationStochastAssignerTest.cs
    • -3
    • +3
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/test-data/ClosingStructuresCalculationConfigurationExporter/completeConfiguration.xml
    • -3
    • +3
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/test-data/ClosingStructuresCalculationConfigurationExporter/configurationWithForeshoreProfile.xml
    • -3
    • +3
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/test-data/ClosingStructuresCalculationConfigurationExporter/configurationWithStructure.xml
    • -3
    • +3
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/test-data/ClosingStructuresCalculationConfigurationExporter/configurationWithUseBreakWater.xml
    • -6
    • +6
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/test-data/ClosingStructuresCalculationConfigurationExporter/folderWithSubfolderAndCalculation.xml
    • -3
    • +3
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/test-data/ClosingStructuresCalculationConfigurationExporter/sparseConfiguration.xml
    • -4
    • +4
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/test-data/ClosingStructuresCalculationConfigurationWriter/completeConfiguration.xml
    • -4
    • +4
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/test-data/ClosingStructuresCalculationConfigurationWriter/folderWithSubfolderAndCalculation.xml
10:43 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3216:

- Removed parameter name check for the InvalidEnumArgumentException tests, as the parameter name is already present in the exception message.

WTI-1803

Options
    • -2
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/SerializableAssemblyMethodCreatorTest.cs
    • -2
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/SerializableAssessmentSectionCategoryGroupCreatorTest.cs
    • -2
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/SerializableFailureMechanismCategoryGroupCreatorTest.cs
    • -2
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/SerializableFailureMechanismGroupCreatorTest.cs
    • -2
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/SerializableFailureMechanismSectionCategoryGroupCreatorTest.cs
    • -2
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/SerializableFailureMechanismTypeCreatorTest.cs
10:34 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3215:

- Removed ArgumentNullException tests that are part of an internal call.

WTI-1803

Options
    • -12
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/SerializableAssessmentProcessCreatorTest.cs
    • -60
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/SerializableTotalAssemblyResultCreatorTest.cs