Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 16 Jan 2018
1:41 pm

Dennis Tang <dennis.tang@deltares.nl>

- Extended FeatureBasedMapDataProperties with category properties - Improved tests

WTI-1551

Options
    • -1
    • +10
    /Core/Plugins/src/Core.Plugins.Map/Properties/Resources.Designer.cs
    • -0
    • +3
    /Core/Plugins/src/Core.Plugins.Map/Properties/Resources.resx
    • -15
    • +35
    /Core/Plugins/src/Core.Plugins.Map/PropertyClasses/FeatureBasedMapDataProperties.cs
    • -18
    • +56
    /Core/Plugins/test/Core.Plugins.Map.Test/PropertyClasses/FeatureBasedMapDataPropertiesTest.cs
1:33 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Changed DotSettings to apply 'var' style.

Options
    • -0
    • +1
    /Ringtoets.sln.DotSettings
1:21 pm

Elmar Kleijn

Eliminated usage of "pass through" properties. WTI-1562

Options
    • -10
    • +27
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil.Test/TestHydraulicBoundaryLocationTest.cs
    • -5
    • +6
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil/TestHydraulicBoundaryLocation.cs
12:50 pm

Elmar Kleijn

Eliminated usage of "pass through" properties. WTI-1562

Options
    • -1
    • +1
    /Demo/Ringtoets/test/Demo.Ringtoets.Test/Commands/AddNewDemoAssessmentSectionCommandTest.cs
    • -2
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Factories/RingtoetsMapDataFeaturesFactory.cs
    • -3
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/Hydraulics/HydraulicBoundaryLocationTest.cs
    • -7
    • +16
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil.Test/TestHydraulicBoundaryLocationTest.cs
12:41 pm

Elmar Kleijn

Eliminated usage of "pass through" properties. WTI-1562

Options
    • -163
    • +155
    /Demo/Ringtoets/test/Demo.Ringtoets.Test/Commands/AddNewDemoAssessmentSectionCommandTest.cs
10:57 am

Dennis Tang <dennis.tang@deltares.nl>

Added tests to validate behaviour of the DynamicReadOnly and DynamicValidation implementations on the FeatureBasedMapDataProperties

WTI-1551

Options
    • -2
    • +147
    /Core/Plugins/test/Core.Plugins.Map.Test/PropertyClasses/FeatureBasedMapDataPropertiesTest.cs
10:40 am

Dennis Tang <dennis.tang@deltares.nl>

Changed base class implementation for the FeatureBasedMapData properties: - Added properties related to MapThemes - Changed implementations of the DynamicReadOnly and DynamicVisible functions

WTI-1551

Options
    • -0
    • +54
    /Core/Plugins/src/Core.Plugins.Map/Properties/Resources.Designer.cs
    • -0
    • +18
    /Core/Plugins/src/Core.Plugins.Map/Properties/Resources.resx
    • -2
    • +52
    /Core/Plugins/src/Core.Plugins.Map/PropertyClasses/FeatureBasedMapDataProperties.cs
    • -4
    • +74
    /Core/Plugins/test/Core.Plugins.Map.Test/PropertyClasses/FeatureBasedMapDataPropertiesTest.cs
    • -4
    • +4
    /Core/Plugins/test/Core.Plugins.Map.Test/PropertyClasses/MapLineDataPropertiesTest.cs
    • -6
    • +6
    /Core/Plugins/test/Core.Plugins.Map.Test/PropertyClasses/MapPointDataPropertiesTest.cs
    • -4
    • +4
    /Core/Plugins/test/Core.Plugins.Map.Test/PropertyClasses/MapPolygonDataPropertiesTest.cs
10:35 am

Carlos Lubbers

Implemented review comments from review 2425 WTI-450: * Updated xmldoc * Added rounding to property class value with annotation in string resources * Removed unneeded length calculation routines from more places

Options
    • -0
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Data/AssessmentSection/ReferenceLine.cs
    • -1
    • +10
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Factories/RingtoetsMapDataFeaturesFactory.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Properties/Resources.Designer.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Properties/Resources.resx
    • -2
    • +2
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Factories/RingtoetsMapDataFeaturesFactoryTest.cs
    • -3
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/AssessmentSection.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Properties/Resources.Designer.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Properties/Resources.resx
    • -2
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/PropertyClasses/ReferenceLineProperties.cs
    • -3
    • +5
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/PropertyClasses/ReferenceLinePropertiesTest.cs
10:35 am

Elmar Kleijn

Eliminated usage of "pass through" properties. WTI-1562

Options
    • -10
    • +4
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/GrassCoverErosionOutwards/GrassCoverErosionOutwardsHydraulicLocationEntityReadExtensionsTest.cs
10:34 am

Elmar Kleijn

Eliminated usage of "pass through" properties. WTI-1562

Options
    • -6
    • +3
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/GrassCoverErosionOutwards/GrassCoverErosionOutwardsHydraulicLocationEntityReadExtensionsTest.cs
    • -20
    • +11
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/HydraulicLocationEntityReadExtensionsTest.cs
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/Piping/PipingCalculationEntityReadExtensionsTest.cs
10:21 am

Elmar Kleijn

Improved HydraulicBoundaryLocationTest. WTI-1562

Options
    • -12
    • +20
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/Hydraulics/HydraulicBoundaryLocationTest.cs
10:05 am

Elmar Kleijn

Extended HydraulicBoundaryLocation. WTI-1562

Options
    • -2
    • +38
    /Ringtoets/Common/src/Ringtoets.Common.Data/Hydraulics/HydraulicBoundaryLocation.cs
8:28 am

Elmar Kleijn

Performed small cleanup. WTI-1562

Options
    • -3
    • +0
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Data.Test/DuneLocationTest.cs
8:25 am

Elmar Kleijn

Eliminated usage of "pass through" properties. WTI-1562

Options
    • -12
    • +0
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Data/DuneLocation.cs
    • -19
    • +0
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Data.Test/DuneLocationTest.cs
7:53 am

Elmar Kleijn

Improved test coverage. WTI-1559

Options
    • -0
    • +15
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Forms.Test/PropertyClasses/GrassCoverErosionOutwardsDesignWaterLevelLocationsPropertiesTest.cs
    • -0
    • +15
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Forms.Test/PropertyClasses/GrassCoverErosionOutwardsWaveHeightLocationsPropertiesTest.cs
Monday 15 Jan 2018
4:22 pm

Dennis Tang <dennis.tang@deltares.nl>

Added initial property class for the category themes.

WTI-1551

Options
    • -0
    • +1
    /Core/Plugins/src/Core.Plugins.Map/Core.Plugins.Map.csproj
    • -0
    • +47
    /Core/Plugins/src/Core.Plugins.Map/Properties/Resources.Designer.cs
    • -0
    • +15
    /Core/Plugins/src/Core.Plugins.Map/Properties/Resources.resx
    • -0
    • +108
    /Core/Plugins/src/Core.Plugins.Map/PropertyClasses/CategoryThemeProperties.cs
    • -0
    • +5
    /Core/Plugins/test/Core.Plugins.Map.Test/Core.Plugins.Map.Test.csproj
    • -0
    • +148
    /Core/Plugins/test/Core.Plugins.Map.Test/PropertyClasses/CategoryThemePropertiesTest.cs
4:10 pm

Elmar Kleijn

Fixed failing tests. WTI-1559

Options
    • -1
    • +1
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Forms.Test/Views/GrassCoverErosionOutwardsDesignWaterLevelLocationsViewTest.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Forms.Test/Views/GrassCoverErosionOutwardsWaveHeightLocationsViewTest.cs
4:01 pm

Elmar Kleijn

Fixed compilation errors. WTI-1559

Options
    • -0
    • +1
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Integration.Test/GrassCoverErosionOutwardsDesignWaterLevelLocationsViewIntegrationTest.cs
    • -0
    • +1
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Integration.Test/GrassCoverErosionOutwardsWaveHeightLocationsViewIntegrationTest.cs
    • -5
    • +21
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Plugin.Test/ViewInfos/GrassCoverErosionOutwardsDesignWaterLevelLocationsViewInfoTest.cs
    • -5
    • +21
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Plugin.Test/ViewInfos/GrassCoverErosionOutwardsWaveHeightLocationsViewInfoTest.cs
3:58 pm

Elmar Kleijn

Fixed compilation errors. WTI-1559

Options
    • -2
    • +10
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Forms.Test/Views/GrassCoverErosionOutwardsDesignWaterLevelLocationsViewTest.cs
    • -2
    • +10
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Forms.Test/Views/GrassCoverErosionOutwardsWaveHeightLocationsViewTest.cs
3:56 pm

Elmar Kleijn

Fixed compilation errors. WTI-1559

Options
    • -0
    • +2
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Plugin/GrassCoverErosionOutwardsPlugin.cs
3:56 pm

Dennis Tang <dennis.tang@deltares.nl>

Reduced number of generated elements as demo data.

WTI-1551

Options
    • -2
    • +2
    /Demo/Ringtoets/src/Demo.Ringtoets/Commands/OpenThematicalMapViewCommand.cs
3:56 pm

Elmar Kleijn

Adapted GrassCoverErosionOutwardsDesignWaterLevelLocationsView and GrassCoverErosionOutwardsWaveHeightLocationsView. WTI-1559

Options
    • -3
    • +6
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Forms/Views/GrassCoverErosionOutwardsDesignWaterLevelLocationsView.cs
    • -3
    • +6
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Forms/Views/GrassCoverErosionOutwardsWaveHeightLocationsView.cs
3:55 pm

Elmar Kleijn

Adapted DesignWaterLevelLocationsView and WaveHeightLocationsView. WTI-1559

Options
    • -7
    • +7
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Views/HydraulicBoundaryLocationsView.cs
    • -8
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/DesignWaterLevelLocationsView.cs
    • -8
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/WaveHeightLocationsView.cs
    • -18
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/DesignWaterLevelLocationsViewTest.cs
    • -18
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/WaveHeightLocationsViewTest.cs
3:52 pm

Elmar Kleijn

Adapted HydraulicBoundaryLocationsView. WTI-1559

Options
    • -3
    • +13
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Views/HydraulicBoundaryLocationsView.cs
    • -3
    • +23
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Views/HydraulicBoundaryLocationsViewTest.cs
2:00 pm

Elmar Kleijn

Adapted grass outwards property classes. WTI-1559

Options
    • -4
    • +17
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Forms/PropertyClasses/GrassCoverErosionOutwardsDesignWaterLevelLocationsProperties.cs
    • -4
    • +17
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Forms/PropertyClasses/GrassCoverErosionOutwardsWaveHeightLocationsProperties.cs
    • -4
    • +8
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Plugin/GrassCoverErosionOutwardsPlugin.cs
    • -7
    • +8
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Forms.Test/PropertyClasses/GrassCoverErosionOutwardsDesignWaterLevelLocationsPropertiesTest.cs
    • -7
    • +8
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Forms.Test/PropertyClasses/GrassCoverErosionOutwardsWaveHeightLocationsPropertiesTest.cs
1:49 pm

Elmar Kleijn

Adapted grass outwards property classes. WTI-1559

Options
    • -19
    • +26
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Forms/PropertyClasses/GrassCoverErosionOutwardsDesignWaterLevelLocationProperties.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Forms/PropertyClasses/GrassCoverErosionOutwardsDesignWaterLevelLocationsProperties.cs
    • -19
    • +26
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Forms/PropertyClasses/GrassCoverErosionOutwardsWaveHeightLocationProperties.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Forms/PropertyClasses/GrassCoverErosionOutwardsWaveHeightLocationsProperties.cs
    • -43
    • +41
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Plugin/GrassCoverErosionOutwardsPlugin.cs
    • -17
    • +27
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Forms.Test/PropertyClasses/GrassCoverErosionOutwardsDesignWaterLevelLocationPropertiesTest.cs
    • -17
    • +27
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Forms.Test/PropertyClasses/GrassCoverErosionOutwardsWaveHeightLocationPropertiesTest.cs
1:16 pm

Elmar Kleijn

Cleaned up HydraulicBoundaryLocationProperties. WTI-1559

Options
    • -2
    • +11
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/PropertyClasses/DesignWaterLevelLocationProperties.cs
    • -10
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/PropertyClasses/HydraulicBoundaryLocationProperties.cs
    • -2
    • +11
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/PropertyClasses/WaveHeightLocationProperties.cs
    • -0
    • +11
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/PropertyClasses/DesignWaterLevelLocationPropertiesTest.cs
    • -32
    • +6
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/PropertyClasses/HydraulicBoundaryLocationPropertiesTest.cs
    • -0
    • +11
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/PropertyClasses/WaveHeightLocationPropertiesTest.cs
1:02 pm

Dennis Tang <dennis.tang@deltares.nl>

Renamed Criteria -> Criterion as it is a singular item to be applied.

WTI-1551

Options
    • -11
    • +11
    /Core/Components/src/Core.Components.DotSpatial/Converter/FeatureBasedMapDataConverter.cs
    • -2
    • +2
    /Core/Components/src/Core.Components.Gis/Core.Components.Gis.csproj
    • -8
    • +8
    /Core/Components/src/Core.Components.Gis/Theme/CategoryTheme.cs
    • -62
    • +0
    /Core/Components/src/Core.Components.Gis/Theme/ValueCriteria.cs
    • -39
    • +0
    /Core/Components/src/Core.Components.Gis/Theme/ValueCriteriaOperator.cs
    • -0
    • +62
    /Core/Components/src/Core.Components.Gis/Theme/ValueCriterion.cs
    • -0
    • +39
    /Core/Components/src/Core.Components.Gis/Theme/ValueCriterionOperator.cs
    • -8
    • +8
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/FeatureBasedMapDataConverterTest.cs
    • -7
    • +7
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/MapLineDataConverterTest.cs
    • -8
    • +8
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/MapPointDataConverterTest.cs
    • -7
    • +7
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/MapPolygonDataConverterTest.cs
    • -1
    • +1
    /Core/Components/test/Core.Components.Gis.Test/Core.Components.Gis.Test.csproj
    • -7
    • +6
    /Core/Components/test/Core.Components.Gis.Test/Theme/CategoryThemeTest.cs
    • -65
    • +0
    /Core/Components/test/Core.Components.Gis.Test/Theme/ValueCriteriaTest.cs
    • -0
    • +65
    /Core/Components/test/Core.Components.Gis.Test/Theme/ValueCriterionTest.cs
  16. … 3 more files in changeset.
11:59 am

Dennis Tang <dennis.tang@deltares.nl>

Removed 'Theme' folder in test util: - There's only one criteria implementation remaining, making the folder obsolete

WTI-1551

Options
    • -1
    • +0
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/FeatureBasedMapDataConverterTest.cs
    • -1
    • +1
    /Core/Components/test/Core.Components.Gis.Test/Theme/MapThemeTest.cs
    • -0
    • +41
    /Core/Components/test/Core.Components.Gis.TestUtil.Test/CategoryThemeTestFactoryTest.cs
    • -1
    • +1
    /Core/Components/test/Core.Components.Gis.TestUtil.Test/Core.Components.Gis.TestUtil.Test.csproj
    • -42
    • +0
    /Core/Components/test/Core.Components.Gis.TestUtil.Test/Theme/CategoryThemeTestFactoryTest.cs
    • -0
    • +46
    /Core/Components/test/Core.Components.Gis.TestUtil/CategoryThemeTestFactory.cs
    • -1
    • +1
    /Core/Components/test/Core.Components.Gis.TestUtil/Core.Components.Gis.TestUtil.csproj
    • -46
    • +0
    /Core/Components/test/Core.Components.Gis.TestUtil/Theme/CategoryThemeTestFactory.cs
11:57 am

Dennis Tang <dennis.tang@deltares.nl>

- Removed ICriteria: -- There's only one concrete implementation present, hence no need to define an interface to be able to use multiple types of criteria -- Removed concrete test implementation, there's no need to to have an empty test object anymore

WTI-1551

Options
    • -25
    • +5
    /Core/Components/src/Core.Components.DotSpatial/Converter/FeatureBasedMapDataConverter.cs
    • -1
    • +0
    /Core/Components/src/Core.Components.Gis/Core.Components.Gis.csproj
    • -2
    • +2
    /Core/Components/src/Core.Components.Gis/Theme/CategoryTheme.cs
    • -28
    • +0
    /Core/Components/src/Core.Components.Gis/Theme/ICriteria.cs
    • -1
    • +1
    /Core/Components/src/Core.Components.Gis/Theme/ValueCriteria.cs
    • -53
    • +0
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/FeatureBasedMapDataConverterTest.cs
    • -5
    • +3
    /Core/Components/test/Core.Components.Gis.Test/Theme/CategoryThemeTest.cs
    • -1
    • +0
    /Core/Components/test/Core.Components.Gis.Test/Theme/ValueCriteriaTest.cs
    • -1
    • +0
    /Core/Components/test/Core.Components.Gis.TestUtil.Test/Core.Components.Gis.TestUtil.Test.csproj
    • -41
    • +0
    /Core/Components/test/Core.Components.Gis.TestUtil.Test/Theme/TestCriteriaTest.cs
    • -1
    • +4
    /Core/Components/test/Core.Components.Gis.TestUtil/Core.Components.Gis.TestUtil.csproj
    • -1
    • +6
    /Core/Components/test/Core.Components.Gis.TestUtil/Theme/CategoryThemeTestFactory.cs
    • -30
    • +0
    /Core/Components/test/Core.Components.Gis.TestUtil/Theme/TestCriteria.cs