Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 12 Sep 24
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 05 Sep 2018
3:06 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3211:

- Fixed issues with the IdValidator:

-- Do not throw exceptions, return boolean in all cases. Fixed tests on the consuming sides

-- Updated XMLDocs

-- Expanded general testcase generator with additional cases for the consumers

WTI-1789

Options
    • -7
    • +5
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/Helpers/IdValidator.cs
    • -12
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/Helpers/IdValidatorTest.cs
    • -25
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableAssemblyTest.cs
    • -13
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableAssessmentProcessTest.cs
    • -14
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableAssessmentSectionTest.cs
    • -16
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableCombinedFailureMechanismSectionAssemblyTest.cs
    • -16
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableFailureMechanismSectionAssemblyTest.cs
    • -26
    • +2
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableFailureMechanismSectionCollectionTest.cs
    • -20
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableFailureMechanismSectionTest.cs
    • -19
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableFailureMechanismTest.cs
    • -16
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableTotalAssemblyResultTest.cs
    • -12
    • +8
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.TestUtil.Test/InvalidIdTestHelperTest.cs
    • -0
    • +2
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.TestUtil/InvalidIdTestHelper.cs
2:52 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3211:

- Updated XMLDoc

- Separated tests for ShouldSerialize tests

WTI-1789

Options
    • -1
    • +1
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/DataTypes/SerializableFailureMechanismAssemblyResult.cs
    • -1
    • +1
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/DataTypes/SerializableFailureMechanismSectionAssemblyResult.cs
    • -5
    • +20
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/DataTypes/SerializableFailureMechanismAssemblyResultTest.cs
    • -5
    • +21
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/DataTypes/SerializableFailureMechanismSectionAssemblyResultTest.cs
2:16 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduced support to write failure mechanism assembly section results:

- Only write results that have a category result != NONE to the serializable model. None is a not supported option and throws an exception.

WTI-1803

Options
    • -14
    • +56
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/AggregatedSerializableFailureMechanismSectionAssemblyCreator.cs
    • -3
    • +233
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/AggregatedSerializableFailureMechanismSectionAssemblyCreatorTest.cs
9:42 am

Dennis Tang <dennis.tang@deltares.nl>

Reverted commit 1f5d1d319b9a4bf62f6271d02e2b556f1ad6843c:

- Support for NULLABLE failure mechanism category was removed from the assembly result creator.

WTI-1803

Options
    • -13
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableFailureMechanismSectionAssemblyResultCreator.cs
    • -2
    • +14
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/AggregatedSerializableFailureMechanismCreatorTest.cs
    • -2
    • +14
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/AggregatedSerializableFailureMechanismSectionAssemblyCreatorTest.cs
    • -1
    • +7
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/SerializableAssemblyCreatorTest.cs
    • -55
    • +7
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/SerializableFailureMechanismSectionAssemblyResultCreatorTest.cs
    • -23
    • +5
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.TestUtil/SerializableFailureMechanismSectionAssemblyResultTestHelper.cs
9:40 am

Dennis Tang <dennis.tang@deltares.nl>

Reverted commit 4b1149de407862f37e58b78bcf8409602ec3031f:

- Reverted because section assembly result should NOT be exported in case there's no result --> no reason anymore to make the category group NULLABLE.

WTI-1789

Options
    • -11
    • +2
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/DataTypes/SerializableFailureMechanismSectionAssemblyResult.cs
    • -23
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/DataTypes/SerializableFailureMechanismSectionAssemblyResultTest.cs
8:59 am

Elmar Kleijn

Moved ModelFactorSuperCriticalFlow from StructuresInputBase to ClosingStructuresInput and HeightStructuresInput. WTI-1800

Options
    • -0
    • +8
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresInputTest.cs
    • -7
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/Structures/StructuresInputBaseTest.cs
    • -0
    • +8
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Data.Test/HeightStructuresInputTest.cs
8:58 am

Dennis Tang <dennis.tang@deltares.nl>

Moved string values to resources for the exporter. WTI-1806

Options
    • -4
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Exporters/AssemblyExporter.cs
    • -0
    • +19
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Properties/Resources.Designer.cs
    • -0
    • +6
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Properties/Resources.resx
8:55 am

Elmar Kleijn

Moved ModelFactorSuperCriticalFlow from StructuresInputBase to ClosingStructuresInput and HeightStructuresInput. WTI-1800

Options
    • -0
    • +1
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Data/ClosingStructuresInput.cs
    • -1
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Data/Structures/StructuresInputBase.cs
    • -0
    • +1
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Data/HeightStructuresInput.cs
8:53 am

Elmar Kleijn

Moved ModelFactorSuperCriticalFlow from StructuresInputBase to ClosingStructuresInput and HeightStructuresInput. WTI-1800

Options
    • -0
    • +23
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Data/ClosingStructuresInput.cs
    • -27
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Data/Structures/StructuresInputBase.cs
    • -2
    • +30
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Data/HeightStructuresInput.cs
8:47 am

Dennis Tang <dennis.tang@deltares.nl>

Updated exporter descriptions and moved string values to resources:

- Also moved forms resource to the plugin resource.

WTI-1806

Options
    • -9
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Properties/Resources.Designer.cs
    • -3
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Properties/Resources.resx
    • -1
    • +37
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Properties/Resources.Designer.cs
    • -0
    • +12
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Properties/Resources.resx
    • -4
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/RingtoetsPlugin.cs
    • -2
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/ExportInfos/AssemblyResultsContextExportInfoTest.cs
8:38 am

Elmar Kleijn

Changed default value for standard deviation of ModelFactorSuperCriticalFlow. WTI-1800

Options
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Data/Structures/StructuresInputBase.cs
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/Structures/StructuresInputBaseTest.cs
8:13 am

Elmar Kleijn

Removed ModelFactorSubCriticalFlow from stability point structures input. WTI-1800

Options
    • -11
    • +2
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresFailureMechanismPropertiesTest.cs
    • -12
    • +3
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Forms.Test/PropertyClasses/StabilityPointStructuresFailureMechanismPropertiesTest.cs
7:48 am

Elmar Kleijn

Removed ModelFactorSubCriticalFlow from stability point structures input. WTI-1800

Options
    • -11
    • +0
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Data/GeneralStabilityPointStructuresInput.cs
    • -18
    • +2
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Forms/PropertyClasses/StabilityPointStructuresFailureMechanismProperties.cs
    • -7
    • +0
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Data.Test/GeneralStabilityPointStructuresInputTest.cs
    • -3
    • +0
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Forms.Test/PropertyClasses/StabilityPointStructuresFailureMechanismPropertiesTest.cs
7:45 am

Elmar Kleijn

Removed ModelFactorSubCriticalFlow from closing structures input. WTI-1800

Options
    • -11
    • +0
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Data/GeneralClosingStructuresInput.cs
    • -17
    • +1
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresFailureMechanismProperties.cs
    • -7
    • +0
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Data.Test/GeneralClosingStructuresInputTest.cs
    • -3
    • +0
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresFailureMechanismPropertiesTest.cs
    • -18
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Properties/Resources.Designer.cs
    • -6
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Properties/Resources.resx
Tuesday 04 Sep 2018
4:11 pm

Dennis Tang <dennis.tang@deltares.nl>

Added logic to the exporter:

- Refactored logic to create an exportable assessment section.

- Inlined statements and simplified boolean checks

WTI-1806

Options
    • -16
    • +18
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Exporters/AssemblyExporter.cs
4:04 pm

Dennis Tang <dennis.tang@deltares.nl>

Added logic to the exporter:

- Added all logic to export the assembly results of an assessment section

-- Added tests and a reference test file which the written file should match.

WTI-1806

Options
    • -3
    • +53
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Exporters/AssemblyExporter.cs
    • -0
    • +156
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Exporters/AssemblyExporterTest.cs
    • -0
    • +4
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Ringtoets.Integration.IO.Test.csproj
    • -0
    • +1515
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/test-data/AssemblyExporter/ExpectedGml.gml
2:40 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup:

- Fixed alignment

WTI-1806

Options
    • -1
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableAssessmentSectionFactoryTest.cs
12:53 pm

Dennis Tang <dennis.tang@deltares.nl>

Wired exporter to the plugin:

- Added reference line check to enable or disable the context menu item

WTI-1806

Options
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/RingtoetsPlugin.cs
    • -2
    • +29
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/ExportInfos/AssemblyResultsContextExportInfoTest.cs
11:17 am

Dennis Tang <dennis.tang@deltares.nl>

Wired exporter to the plugin:

- Introduced export info to enable exporting functionality

WTI-1806

Options
    • -1
    • +10
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/RingtoetsPlugin.cs
    • -0
    • +118
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/ExportInfos/AssemblyResultsContextExportInfoTest.cs
    • -1
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Ringtoets.Integration.Plugin.Test.csproj
    • -1
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/RingtoetsPluginTest.cs
10:51 am

Dennis Tang <dennis.tang@deltares.nl>

Introduced new context to represent all the assembly results:

- Wired it in the RingtoetsPlugin

- Introduced new treenode info test

- Renamed resource parameter

WTI-1806

Options
    • -10
    • +10
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Properties/Resources.Designer.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Properties/Resources.resx
    • -7
    • +29
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/RingtoetsPlugin.cs
    • -1
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Ringtoets.Integration.Plugin.Test.csproj
    • -1
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/RingtoetsPluginTest.cs
    • -0
    • +177
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/TreeNodeInfos/AssemblyResultsContextTreeNodeInfoTest.cs
    • -10
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/TreeNodeInfos/AssessmentSectionTreeNodeInfoTest.cs
10:21 am

Dennis Tang <dennis.tang@deltares.nl>

Merge branch 'master' into AssemblyExport

Options
10:16 am

Robert Tangerman <robert.tangerman@deltares.nl>

Edited dotSettings for correct object initializer alignment. WTI-1787

Options
    • -0
    • +1
    /Ringtoets.sln.DotSettings
9:51 am

Dennis Tang <dennis.tang@deltares.nl>

Introduced new context to represent all the assembly results. WTI-1806

Options
    • -0
    • +40
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/PresentationObjects/AssemblyResultsContext.cs
    • -0
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Ringtoets.Integration.Forms.csproj
    • -0
    • +50
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/PresentationObjects/AssemblyResultsContextTest.cs
    • -0
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Ringtoets.Integration.Forms.Test.csproj
9:43 am

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. Paired with tang_ds. WTI-1790

Options
    • -7
    • +6
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/AggregatedSerializableCombinedFailureMechanismSectionAssembliesCreator.cs
    • -6
    • +5
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableClosingStructuresFailureMechanismFactory.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableCombinedSectionAssemblyFactory.cs
    • -6
    • +5
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableDuneErosionFailureMechanismFactory.cs
    • -6
    • +5
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableGrassCoverErosionInwardsFailureMechanismFactory.cs
    • -6
    • +5
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableGrassCoverErosionOutwardsFailureMechanismFactory.cs
    • -6
    • +5
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableGrassCoverSlipOffInwardsFailureMechanismFactory.cs
    • -6
    • +5
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableGrassCoverSlipOffOutwardsFailureMechanismFactory.cs
    • -6
    • +5
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableHeightStructuresFailureMechanismFactory.cs
    • -6
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableMacroStabilityInwardsFailureMechanismFactory.cs
    • -8
    • +6
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableMacroStabilityOutwardsFailureMechanismFactory.cs
    • -7
    • +6
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableMicrostabilityFailureMechanismFactory.cs
    • -6
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportablePipingFailureMechanismFactory.cs
    • -6
    • +5
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportablePipingStructureFailureMechanismFactory.cs
    • -6
    • +5
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableStabilityPointStructuresFailureMechanismFactory.cs
  16. … 6 more files in changeset.
9:12 am

Dennis Tang <dennis.tang@deltares.nl>

Initial commit assembly exporter. WTI-1806

Options
    • -0
    • +62
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Exporters/AssemblyExporter.cs
    • -0
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Ringtoets.Integration.IO.csproj
    • -0
    • +80
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Exporters/AssemblyExporterTest.cs
    • -0
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Ringtoets.Integration.IO.Test.csproj
8:50 am

Elmar Kleijn

Removed variable 64 from Hydra-Ring structures input. WTI-1800

Options
    • -2
    • +2
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
    • -4
    • +3
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Data/Input/Structures/StructuresClosureLowSillCalculationInputTest.cs
    • -1
    • +1
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Data/Input/Structures/StructuresStabilityPointFloodedCulvertLinearCalculationInputTest.cs
    • -1
    • +0
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Data/Input/Structures/StructuresStabilityPointFloodedCulvertQuadraticCalculationInputTest.cs
8:10 am

Elmar Kleijn

Removed variable 64 from Hydra-Ring structures input. WTI-1800

Options
    • -31
    • +30
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Integration/HydraRingConfigurationServiceIntegrationTest.cs
8:05 am

Elmar Kleijn

Removed variable 64 from Hydra-Ring structures input. WTI-1800

Options
    • -31
    • +30
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Integration/HydraRingConfigurationServiceIntegrationTest.cs
7:55 am

Elmar Kleijn

Removed variable 64 from Hydra-Ring structures input. WTI-1800

Options
    • -79
    • +72
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Integration/HydraRingConfigurationServiceIntegrationTest.cs
7:31 am

Elmar Kleijn

Removed variable 64 from Hydra-Ring structures input. WTI-1800

Options
    • -87
    • +83
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Data/Input/Structures/StructuresStabilityPointLowSillQuadraticCalculationInputTest.cs