Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 21 Mar 2017
10:12 am

Robert Tangerman <robert.tangerman@deltares.nl>

- Refactored WaveConditionsCalculationConfigurationImporter so it doesn't throw an internal exception anymore. - Refactored CalculationConfigurationImporter so it doesn't catch internal exceptions. Related to Issue [WTI-1160]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8879 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 68a0bfe3063d231cb82f1fecd634897f872eed61

Former-commit-id: df8a1eed3b3f0d43e0ac4b5173fbc23fb86a7753

Options
    • -35
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/CalculationConfigurationImporter.cs
    • -53
    • +135
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/Importers/WaveConditionsCalculationConfigurationImporter.cs
    • -1
    • +1
    /Ringtoets/Revetment/test/Ringtoets.Revetment.IO.Test/Importers/WaveConditionsCalculationConfigurationImporterTest.cs
10:05 am

Marten Janssen <marten.janssen@deltares.nl>

Fixed 'double' runs on build server paired with tang_ds

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8878 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f3716f986f845f28d3888f82bade4327cb628456

Former-commit-id: 8423bf3e698a1a74cdad404f35254ecd33750483

Options
    • -6
    • +6
    /Ringtoets/Common/test/Ringtoets.Common.Forms.TestUtil.Test/DistributionPropertiesTestHelperTest.cs
    • -41
    • +41
    /Ringtoets/Common/test/Ringtoets.Common.Forms.TestUtil.Test/MapDataTestHelperTest.cs
    • -4
    • +4
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Plugin.Test/ExportInfos/GrassCoverErosionOutwardsWaveConditionsCalculationGroupContextWaveConditionsExportInfoTest.cs
    • -4
    • +7
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/PropertyInfos/BackgroundDataPropertyInfoTest .cs
    • -2
    • +2
    /Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.Plugin.Test/ExportInfos/StabilityStoneCoverWaveConditionsCalculationGroupContextWaveConditionsExportInfoTest.cs
    • -4
    • +4
    /Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Plugin.Test/ExportInfos/WaveImpactAsphaltCoverWaveConditionsCalculationGroupContextWaveConditionsExportInfoTest.cs
9:17 am

Marten Janssen <marten.janssen@deltares.nl>

review related changes paired with tang_ds Related to Issue [WTI-1158]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8877 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 506ee3a41e57d3b609db573f9bb32813181af9a6

Former-commit-id: 58fc8224734ba07c55eb6f17469e5e3c8170f836

Options
    • -2
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.Forms/ImportInfos/RingtoetsImportInfoFactory.cs
    • -33
    • +2
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/ImportInfos/RingtoetsImportInfoFactoryTest.cs
9:04 am

Robert Tangerman <robert.tangerman@deltares.nl>

Refactored PipingCalculationConfigurationImporter so it doesn't throw an internal exception anymore. Related to Issue [WTI-1160]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8876 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f55e5c9b3e68f3d46fe73167804462e04127b1a2

Former-commit-id: 9347de9f10defc5f39adc604e660eb755a43ecf9

Options
    • -69
    • +170
    /Ringtoets/Piping/src/Ringtoets.Piping.IO/Importers/PipingCalculationConfigurationImporter.cs
    • -1
    • +1
    /Ringtoets/Piping/test/Ringtoets.Piping.IO.Test/Importers/PipingCalculationConfigurationImporterTest.cs
9:04 am

Marten Janssen <marten.janssen@deltares.nl>

Cleanup Made export of DikeHeightCalculationType not depend on DikeProfile Related to Issue [WTI-1153]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8875 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c8b540bdc56bf4b18fe1b322dfe2b3d3695d37ba

Former-commit-id: 636c4ab78430d09b20838fb289e12bb1e1ee07d0

Options
    • -6
    • +18
    /Ringtoets/Common/test/Ringtoets.Common.IO.TestUtil/CustomCalculationConfigurationWriterDesignGuidelinesTestFixture.cs
    • -24
    • +51
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.IO/Writers/GrassCoverErosionInwardsCalculationConfigurationWriter.cs
    • -0
    • +2
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.IO.Test/test-data/GrassCoverErosionInwardsCalculationConfigurationExporter/folderWithSubfolderAndCalculation.xml
    • -0
    • +1
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.IO.Test/test-data/GrassCoverErosionInwardsCalculationConfigurationWriter/folderWithSubfolderAndCalculation.xml
    • -0
    • +1
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.IO.Test/test-data/GrassCoverErosionInwardsCalculationConfigurationWriter/sparseConfiguration.xml
8:13 am

Marten Janssen <marten.janssen@deltares.nl>

Deltares cleanup after review Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8874 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 41fe916cc0126c725715b7404e4abefd02f9ecb0

Former-commit-id: 1d88184ea779739d656adbab0f391092dd395d33

Options
    • -4
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Exceptions/CannotDetermineFingerprintExceptionTest.cs
Monday 20 Mar 2017
4:45 pm

Joël van den Berg

implemented GrassCoverErosionInwardsCalculationConfigurationImporter. Related to Issue [WTI-1155]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8873 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d470c59432f78d95ec2d26fe06e0be1bd53a4c44

Former-commit-id: eca37e7a03a266d6fe0ef1c6822f98620ea01206

Options
    • -0
    • +5
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/CalculationConfigurationImporter.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Data/GrassCoverErosionInwardsInput.cs
    • -0
    • +302
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.IO/Importers/GrassCoverErosionInwardsCalculationConfigurationImporter.cs
    • -1
    • +72
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.IO/Properties/Resources.Designer.cs
    • -0
    • +15
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.IO/Properties/Resources.resx
    • -0
    • +1
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.IO/Ringtoets.GrassCoverErosionInwards.IO.csproj
    • -0
    • +324
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.IO.Test/Importers/GrassCoverErosionInwardsCalculationConfigurationImporterTest.cs
    • -0
    • +1
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.IO.Test/Ringtoets.GrassCoverErosionInwards.IO.Test.csproj
    • -0
    • +6
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.IO.Test/test-data/GrassCoverErosionInwardsCalculationConfigurationImporter/validConfigurationCalculationDikeHeightWithoutDikeProfile.xml
    • -0
    • +6
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.IO.Test/test-data/GrassCoverErosionInwardsCalculationConfigurationImporter/validConfigurationCalculationUnknownDikeProfile.xml
    • -0
    • +6
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.IO.Test/test-data/GrassCoverErosionInwardsCalculationConfigurationImporter/validConfigurationCalculationUnknownHydraulicBoundaryLocation.xml
    • -0
    • +9
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.IO.Test/test-data/GrassCoverErosionInwardsCalculationConfigurationImporter/validConfigurationCalculationUseForeshoreWithoutGeometry.xml
    • -0
    • +11
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.IO.Test/test-data/GrassCoverErosionInwardsCalculationConfigurationImporter/validConfigurationCalculationWaveReductionWithoutDikeProfile.xml
    • -0
    • +16
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.IO.Test/test-data/GrassCoverErosionInwardsCalculationConfigurationImporter/validConfigurationFullCalculation.xml
    • -0
    • +6
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.IO.Test/test-data/GrassCoverErosionInwardsCalculationConfigurationImporter/validConfigurationInvalidOrientation.xml
    • -9
    • +9
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.IO.Test/test-data/GrassCoverErosionInwardsCalculationConfigurationReader/validConfigurationFullCalculation.xml
    • -1
    • +1
    /Ringtoets/Revetment/test/Ringtoets.Revetment.IO.Test/Readers/ReadWaveConditionsCalculationTest.cs
4:26 pm

Marten Janssen <marten.janssen@deltares.nl>

Created base class for Calculation configuration exporters and applied it where possible Related to Issue [WTI-1153]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8872 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 39729f36f6239588e9b28075085c9b4fb908796b

Former-commit-id: e81d4f9db3d72306969c08684aaab11aaaf8ce34

Options
    • -115
    • +24
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/Writers/CalculationConfigurationWriterTest.cs
    • -0
    • +179
    /Ringtoets/Common/test/Ringtoets.Common.IO.TestUtil/CustomCalculationConfigurationWriterDesignGuidelinesTestFixture.cs
    • -4
    • +5
    /Ringtoets/Common/test/Ringtoets.Common.IO.TestUtil/Ringtoets.Common.IO.TestUtil.csproj
    • -1
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.IO.TestUtil/packages.config
    • -96
    • +4
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.IO.Test/Writers/GrassCoverErosionInwardsCalculationConfigurationWriterTest.cs
    • -10
    • +9
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.IO.Test/Writers/GrassCoverErosionOutwardsCalculationConfigurationWriterTest.cs
    • -96
    • +4
    /Ringtoets/Piping/test/Ringtoets.Piping.IO.Test/Exporters/PipingCalculationConfigurationWriterTest.cs
    • -0
    • +4
    /Ringtoets/Revetment/test/Ringtoets.Revetment.IO.Test/Ringtoets.Revetment.IO.Test.csproj
    • -11
    • +4
    /Ringtoets/Revetment/test/Ringtoets.Revetment.IO.Test/Writers/WaveConditionsCalculationConfigurationWriterTest.cs
    • -10
    • +9
    /Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.IO.Test/Writers/StabilityStoneCoverCalculationConfigurationWriterTest.cs
    • -10
    • +9
    /Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.IO.Test/Writers/WaveImpactAsphaltCoverCalculationConfigurationWriterTest.cs
4:08 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments tester: - Readded the collection to be notified when elements are updated -- This is necessary in case the collection comes from a migrated rtd file (FilePath: "Onbekend") and is updated with a file that contains EXACTLY the same items as the collection. This will notify the Collection property info pane and display the new FilePath location -- Added test to verify behaviour

Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8871 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 308e4949f23dd0363b891e91eb6a30e158da41c6

Former-commit-id: 2bc99ad86759a204617b92f7890811a7032db637

Options
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Data/UpdateDataStrategies/UpdateDataStrategyBase.cs
    • -2
    • +53
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/UpdateDataStrategies/UpdateDataStrategyBaseTest.cs
    • -1
    • +9
    /Ringtoets/Piping/test/Ringtoets.Piping.Plugin.Test/FileImporter/RingtoetsPipingSurfaceLineUpdateDataStrategyTest.cs
    • -1
    • +4
    /Ringtoets/Piping/test/Ringtoets.Piping.Plugin.Test/FileImporter/StochasticSoilModelUpdateDataStrategyTest.cs
3:59 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Implemented method for logging error for calculation configuration importers. Related to Issue [WTI-1160]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8870 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d3f9c80a2ffa8bc7e538e95abceae2506a02bef0

Former-commit-id: bee23133c8fcd60de0ecd6e14521b1e4650d1cd3

Options
    • -4
    • +6
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/CalculationConfigurationImporter.cs
3:34 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Reverted adding new exception. Related to Issue [WTI-1160]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8869 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 433f0c8049710fe2e2d177c10049fc9eaa937d25

Former-commit-id: 69658bcdcae4f6db38e05ff4d2c1f77b68bbac26

Options
    • -58
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.IO/Exceptions/CalculationParseException.cs
    • -1
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.IO/Ringtoets.Common.IO.csproj
    • -32
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/Exceptions/CalculationParseExceptionTest.cs
    • -1
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/Ringtoets.Common.IO.Test.csproj
3:30 pm

Marten Janssen <marten.janssen@deltares.nl>

Modified GrassCoverErosionInwardsCalculationConfigurationWriter such that the following is (also) exported when a Dike Profile is set: - Dike height - Calculation type Related to Issue [WTI-1153]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8868 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d37e02ba57be34e46a8c9d7c9dcf7cf6892c036d

Former-commit-id: 95d006a04312679712fb2c951f451c45d825fd81

Options
    • -0
    • +13
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.IO/Writers/GrassCoverErosionInwardsCalculationConfigurationWriter.cs
    • -0
    • +2
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.IO.Test/test-data/GrassCoverErosionInwardsCalculationConfigurationWriter/completeConfiguration.xml
    • -0
    • +2
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.IO.Test/test-data/GrassCoverErosionInwardsCalculationConfigurationWriter/folderWithSubfolderAndCalculation.xml
3:20 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1553: - Introduced RingtoetsImportInfoFactory to generalise the creation of ImportInfo objects for the CalculationGroups. -- Incorporated the RingtoetsImportInfoFactory for the already existing ImportInfo implementations

Related to Issue [WTI-1158]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8867 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 71bb51231f8e4e797afd4e6fb831f0ffa83e13fe

Former-commit-id: 0873eceb0a11007139e7ff439f8af9eb2ad74df2

Options
    • -22
    • +9
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Plugin/GrassCoverErosionOutwardsPlugin.cs
    • -12
    • +9
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/PipingPlugin.cs
    • -22
    • +9
    /Ringtoets/StabilityStoneCover/src/Ringtoets.StabilityStoneCover.Plugin/StabilityStoneCoverPlugin.cs
    • -22
    • +9
    /Ringtoets/WaveImpactAsphaltCover/src/Ringtoets.WaveImpactAsphaltCover.Plugin/WaveImpactAsphaltCoverPlugin.cs
3:14 pm

bouvrie <bouvrie@example.com>

* Refactored FingerprintHelper such that it no longer uses a MemoryStream (which can overload it's internal buffer when too much data is put into it), and now uses a FileStream to a temp file instead. ** Introduced CannotDetermineFingerprintException in order to wrap potential IO-related exceptions that can not occur when working with FingerprintHelper. Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8866 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 271043e9b9cfbd2269aa098ad4957d40a7c13a27

Former-commit-id: fd2ea0920c45048fdf75ffa1ced25af2923d6820

Options
    • -0
    • +1
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Application.Ringtoets.Storage.csproj
    • -0
    • +58
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Exceptions/CannotDetermineFingerprintException.cs
    • -4
    • +39
    /Application/Ringtoets/src/Application.Ringtoets.Storage/FingerprintHelper.cs
    • -1
    • +10
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Properties/Resources.Designer.cs
    • -0
    • +3
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Properties/Resources.resx
    • -3
    • +7
    /Application/Ringtoets/src/Application.Ringtoets.Storage/StorageSqLite.cs
    • -0
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Application.Ringtoets.Storage.Test.csproj
    • -0
    • +35
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Exceptions/CannotDetermineFingerprintExceptionTest.cs
3:13 pm

Marten Janssen <marten.janssen@deltares.nl>

Modified GrassCoverErosionInwardsCalculationConfigurationWriter such that no dike profile properties are exported when DikeProfile is null Related to Issue [WTI-1153]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8865 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8fcdeb26cdc4ec7fb8d9cac95fdd15963f2d20c9

Former-commit-id: 7cc636f72c7af6f87dabdfe93a2b1b2861c483a8

Options
    • -0
    • +5
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.IO/Writers/GrassCoverErosionInwardsCalculationConfigurationWriter.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.IO.Test/Writers/GrassCoverErosionInwardsCalculationConfigurationWriterTest.cs
    • -12
    • +0
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.IO.Test/test-data/GrassCoverErosionInwardsCalculationConfigurationExporter/folderWithSubfolderAndCalculation.xml
    • -6
    • +0
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.IO.Test/test-data/GrassCoverErosionInwardsCalculationConfigurationWriter/folderWithSubfolderAndCalculation.xml
    • -6
    • +0
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.IO.Test/test-data/GrassCoverErosionInwardsCalculationConfigurationWriter/sparseConfiguration.xml
2:21 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added new exception to use in CalculationConfigurationImporters. Related to Issue [WTI-1160]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8864 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f3e646e8d76ff349aeb6e7059f9be7799dc0a654

Former-commit-id: 6b11488fb077172d40ebf04151e52c2fca941cdf

Options
    • -0
    • +58
    /Ringtoets/Common/src/Ringtoets.Common.IO/Exceptions/CalculationParseException.cs
    • -0
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/Ringtoets.Common.IO.csproj
    • -0
    • +32
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/Exceptions/CalculationParseExceptionTest.cs
    • -0
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/Ringtoets.Common.IO.Test.csproj
2:12 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1553: - Introduced RingtoetsImportInfoFactory to generalise the creation of ImportInfo objects for the CalculationGroups. Related to Issue [WTI-1158]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8863 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2e49fb2a22dab555dac0df8689dcaf8633198641

Former-commit-id: 7c24afadc3badbf95a0f4b53f5b43d2003de5cbb

Options
    • -0
    • +64
    /Ringtoets/Common/src/Ringtoets.Common.Forms/ImportInfos/RingtoetsImportInfoFactory.cs
    • -0
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Ringtoets.Common.Forms.csproj
    • -2
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Forms/TreeNodeInfos/RingtoetsTreeNodeInfoFactory.cs
    • -0
    • +110
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/ImportInfos/RingtoetsImportInfoFactoryTest.cs
    • -0
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Ringtoets.Common.Forms.Test.csproj
    • -1
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/TreeNodeInfos/RingtoetsTreeNodeInfoFactoryTest.cs
2:03 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Implemented FilteredKeyDictionary which prevents items being added for keys that are not allowed. Related to Issue [WTI-1141]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8862 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3aa870ab8b10f9152eb4be2acc713774055b4451

Former-commit-id: 209dd477f22b1329fb8ec9d44c2dbca8cd67c6f6

Options
    • -13
    • +1
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/BackgroundDataEntityReadExtensions.cs
    • -60
    • +0
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/BackgroundDataEntityReadExtensionsTest.cs
    • -0
    • +1
    /Core/Common/src/Core.Common.Base/Core.Common.Base.csproj
    • -0
    • +197
    /Core/Common/src/Core.Common.Base/FilteredKeyDictionary.cs
    • -0
    • +1
    /Core/Common/test/Core.Common.Base.Test/Core.Common.Base.Test.csproj
    • -0
    • +553
    /Core/Common/test/Core.Common.Base.Test/FilteredKeyDictionaryTest.cs
    • -3
    • +9
    /Ringtoets/Common/src/Ringtoets.Common.Data/AssessmentSection/BackgroundData.cs
    • -0
    • +62
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/AssessmentSection/BackgroundDataTest.cs
1:56 pm

bouvrie <bouvrie@example.com>

* Cleanup and renaming parameters. * Replaced '\r\n' sequences with Environment.NewLine, due to the sequence being system dependent. * Updated/refreshed project references, as they weren't resolving. Related to Issue [WTI-1156]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8861 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d2754a29febccc97bced9915542f44820e442647

Former-commit-id: 5051dec4baaddf2b6720c77279b69393525e9284

Options
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/ReferenceLines/ReferenceLineExporterTest.cs
    • -6
    • +6
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.IO.Test/DuneLocationsExporterTest.cs
    • -6
    • +6
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.IO.Test/DuneLocationsWriterTest.cs
    • -12
    • +16
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.IO.Test/Exporters/GrassCoverErosionOutwardsWaveConditionsExporterTest.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.IO.Test/Ringtoets.GrassCoverErosionOutwards.IO.Test.csproj
    • -2
    • +2
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Service.Test/MessageProviders/GrassCoverErosionOutwardsDesignWaterLevelCalculationMessageProviderTest.cs
    • -2
    • +2
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Service.Test/MessageProviders/GrassCoverErosionOutwardsWaveHeightCalculationMessageProviderTest.cs
    • -2
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/MessageProviders/DesignWaterLevelCalculationMessageProviderTest.cs
    • -2
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/MessageProviders/WaveHeightCalculationMessageProviderTest.cs
    • -3
    • +3
    /Ringtoets/Piping/test/Ringtoets.Piping.IO.Test/Importers/StochasticSoilModelImporterTest.cs
    • -4
    • +4
    /Ringtoets/Revetment/test/Ringtoets.Revetment.IO.Test/Exporters/WaveConditionsExporterBaseTest.cs
    • -4
    • +4
    /Ringtoets/Revetment/test/Ringtoets.Revetment.IO.Test/Writers/WaveConditionsWriterTest.cs
    • -13
    • +17
    /Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.IO.Test/Exporters/StabilityStoneCoverWaveConditionsExporterTest.cs
    • -1
    • +1
    /Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.IO.Test/Ringtoets.StabilityStoneCover.IO.Test.csproj
    • -12
    • +16
    /Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.IO.Test/Exporters/WaveImpactAsphaltCoverWaveConditionsExporterTest.cs
    • -1
    • +1
    /Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.IO.Test/Ringtoets.WaveImpactAsphaltCover.IO.Test.csproj
1:31 pm

Marten Janssen <marten.janssen@deltares.nl>

Previous review comments processed Related to Issue [WTI-1159]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8860 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: abe308fe8337a2dd67a32318eb0cbf08d18d741f

Former-commit-id: 3c06b033106557840d1881e63f86523a2d4f9bc6

Options
    • -0
    • +7
    /Ringtoets/Common/src/Ringtoets.Common.IO/Writers/CalculationConfigurationWriter.cs
1:20 pm

Marten Janssen <marten.janssen@deltares.nl>

Modified CalculationConfigurationExporterTest to use CustomCalculationConfigurationExporterDesignGuidelinesTestFixture. Updated XMLdoc

Related to Issue [WTI-1157]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8859 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bcace9c3cc9a6473a6c2f324fa270068f729a689

Former-commit-id: cc4da4c48fb49c8570780abf3b67db8aa4d9915c

Options
    • -0
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.IO/Exporters/CalculationConfigurationExporter.cs
    • -93
    • +17
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/Exporters/CalculationConfigurationExporterTest.cs
    • -0
    • +4
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/Ringtoets.Common.IO.Test.csproj
1:10 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1553: - Added missing test - Extracted variables to a class variable

Related to Issue [WTI-1158]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8858 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b66cb97395885c629741a5981662a04e150f33bb

Former-commit-id: 361d104c68d897caf59f23788b98a5b2b4248d46

Options
    • -6
    • +31
    /Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Plugin.Test/ImportInfos/WaveImpactAsphaltCoverWaveConditionsCalculationGroupContextImportInfoTest.cs
    • -5
    • +10
    /Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Plugin.Test/TreeNodeInfos/WaveImpactAsphaltCoverWaveConditionsCalculationGroupContextTreeNodeInfoTest.cs
1:06 pm

Marten Janssen <marten.janssen@deltares.nl>

Cleanup Improved dictionary extender Related to Issue [WTI-1157]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8857 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1ebd36d02b7284ce69817cb02a49ea30639f9f7b

Former-commit-id: f393401327f19af3823e5a0c5373eafafabfff3b

Options
    • -14
    • +0
    /Ringtoets.sln
    • -7
    • +4
    /Ringtoets/Common/src/Ringtoets.Common.IO/Readers/CalculationConfigurationReader.cs
    • -27
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.IO.TestUtil.Test/Properties/AssemblyInfo.cs
    • -59
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.IO.TestUtil.Test/Ringtoets.Common.IO.TestUtil.Test.csproj
11:55 am

bouvrie <bouvrie@example.com>

* Moved default values from dialogs to *Info objects to improved testability ** Unable to properly test images on the dialogs themselves, due to background color in dialog. Related to Issue [WTI-1159]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8856 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 9134e97086c6967f193b7a698ed75d7623df7e92

Former-commit-id: 9cdcdaa9d82d067e5bd0c0e621ff3e32b662d655

Options
    • -5
    • +3
    /Core/Common/src/Core.Common.Gui/Commands/GuiExportHandler.cs
    • -6
    • +1
    /Core/Common/src/Core.Common.Gui/Commands/GuiImportHandler.cs
    • -6
    • +1
    /Core/Common/src/Core.Common.Gui/Commands/GuiUpdateHandler.cs
    • -4
    • +9
    /Core/Common/src/Core.Common.Gui/Plugin/ExportInfo.cs
    • -4
    • +9
    /Core/Common/src/Core.Common.Gui/Plugin/ImportInfo.cs
    • -4
    • +9
    /Core/Common/src/Core.Common.Gui/Plugin/UpdateInfo.cs
    • -27
    • +27
    /Core/Common/src/Core.Common.Gui/Properties/Resources.Designer.cs
    • -3
    • +3
    /Core/Common/src/Core.Common.Gui/Properties/Resources.resx
    • -6
    • +8
    /Core/Common/test/Core.Common.Gui.Test/Plugin/ExportInfoTest.cs
    • -6
    • +8
    /Core/Common/test/Core.Common.Gui.Test/Plugin/ImportInfoTest.cs
    • -6
    • +8
    /Core/Common/test/Core.Common.Gui.Test/Plugin/UpdateInfoTest.cs
    • -2
    • +4
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/ExportInfos/DuneLocationsContextExportInfoTest.cs
    • -2
    • +4
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Plugin.Test/ExportInfos/GrassCoverErosionInwardsCalculationContextExportInfoTest.cs
    • -2
    • +4
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Plugin.Test/ExportInfos/GrassCoverErosionInwardsCalculationGroupContextExportInfoTest.cs
    • -2
    • +4
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Plugin.Test/ExportInfos/GrassCoverErosionOutwardsWaveConditionsCalculationContextConfigurationExportInfoTest.cs
  16. … 16 more files in changeset.
11:54 am

Marten Janssen <marten.janssen@deltares.nl>

Created CustomCalculationConfigurationExporterDesignGuidelinesTestFixture for all test classes that are calculation configuration exporters Related to Issue [WTI-1157]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8855 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 9d3a0ff4e37b31c2f211f672dc2697c2f9b1a5e7

Former-commit-id: 24c51abffb0a0e2b1c7889e618b862f638f04289

Options
    • -0
    • +196
    /Ringtoets/Common/test/Ringtoets.Common.IO.TestUtil/CustomCalculationConfigurationExporterDesignGuidelinesTestFixture.cs
    • -0
    • +28
    /Ringtoets/Common/test/Ringtoets.Common.IO.TestUtil/Ringtoets.Common.IO.TestUtil.csproj
    • -0
    • +27
    /Ringtoets/Common/test/Ringtoets.Common.IO.TestUtil/packages.config
    • -74
    • +14
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.IO.Test/Exporters/GrassCoverErosionInwardsCalculationConfigurationExporterTest.cs
    • -0
    • +4
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.IO.Test/Ringtoets.GrassCoverErosionInwards.IO.Test.csproj
    • -41
    • +12
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.IO.Test/Exporters/GrassCoverErosionOutwardsCalculationConfigurationExporterTest.cs
    • -0
    • +4
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.IO.Test/Ringtoets.GrassCoverErosionOutwards.IO.Test.csproj
    • -64
    • +14
    /Ringtoets/Piping/test/Ringtoets.Piping.IO.Test/Exporters/PipingCalculationConfigurationExporterTest.cs
    • -0
    • +4
    /Ringtoets/Piping/test/Ringtoets.Piping.IO.Test/Ringtoets.Piping.IO.Test.csproj
    • -0
    • +3
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/Writers/WaveConditionsCalculationConfigurationWriter.cs
    • -41
    • +12
    /Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.IO.Test/Exporters/StabilityStoneCoverCalculationConfigurationExporterTest.cs
    • -0
    • +4
    /Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.IO.Test/Ringtoets.StabilityStoneCover.IO.Test.csproj
    • -41
    • +13
    /Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.IO.Test/Exporters/WaveImpactAsphaltCoverCalculationConfigurationExporterTest.cs
    • -0
    • +4
    /Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.IO.Test/Ringtoets.WaveImpactAsphaltCover.IO.Test.csproj
11:14 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated review 1554: - Replaced tabs in Migration_5_17.1.sql with whitespaces (only on modified lines in rev 8839 - Added additional asserts to verify that only the minimum amount of observers are notified Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8854 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bff84b19179a5ab3e5b5323f019323c5e73592c9

Former-commit-id: 796835de13543ac8005625148c7ee7789933fc0d

Options
    • -2
    • +2
    /Application/Ringtoets/src/Application.Ringtoets.Migration.Core/Resources/Migration_5_17.1.sql
    • -23
    • +163
    /Ringtoets/Piping/test/Ringtoets.Piping.Forms.Test/Views/PipingFailureMechanismViewTest.cs
10:23 am

Joël van den Berg

Changed wave conditions writer so that break water properties are not exported when no foreshore profile is selected. Related to Issue [WTI-1156]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8853 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8e4ddac2b07afa3cb0fc62a2d6eca1d44b191575

Former-commit-id: a0e27d46607db71d54ca66b86afb173607839a28

Options
    • -6
    • +0
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.IO.Test/test-data/GrassCoverErosionOutwardsCalculationConfigurationExporter/fullValidConfiguration.xml
    • -9
    • +12
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/Writers/WaveConditionsCalculationConfigurationWriter.cs
    • -6
    • +0
    /Ringtoets/Revetment/test/Ringtoets.Revetment.IO.Test/test-data/WaveConditionsCalculationConfigurationWriter/sparseConfiguration.xml
    • -6
    • +0
    /Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.IO.Test/test-data/StabilityStoneCoverCalculationConfigurationExporter/fullValidConfiguration.xml
    • -6
    • +0
    /Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.IO.Test/test-data/WaveImpactAsphaltCoverCalculationConfigurationExporter/fullValidConfiguration.xml
10:20 am

Marten Janssen <marten.janssen@deltares.nl>

Added Ringtoets.Common.IO.TestUtil and Ringtoets.Common.IO.TestUtil.Test projects Related to Issue [WTI-1157]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8852 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3559e559a6322423b997f802542cd3299cb4bf98

Former-commit-id: 7c64ffe1385beec6bffccc1d2b042d459bf01ea7

Options
    • -0
    • +28
    /Ringtoets.sln
    • -0
    • +27
    /Ringtoets/Common/test/Ringtoets.Common.IO.TestUtil.Test/Properties/AssemblyInfo.cs
    • -0
    • +59
    /Ringtoets/Common/test/Ringtoets.Common.IO.TestUtil.Test/Ringtoets.Common.IO.TestUtil.Test.csproj
    • -0
    • +27
    /Ringtoets/Common/test/Ringtoets.Common.IO.TestUtil/Properties/AssemblyInfo.cs
    • -0
    • +59
    /Ringtoets/Common/test/Ringtoets.Common.IO.TestUtil/Ringtoets.Common.IO.TestUtil.csproj
9:17 am

Joël van den Berg

Extended Wave condition exporter tests to test for created output files. Related to Issue [WTI-1156]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8851 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0e0a12b68da169e3cc23f92e36af73080f7fc51f

Former-commit-id: d8969b4fa73bf584e31ee717bdcf0f42f1501e52

Options
    • -0
    • +114
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.IO.Test/Exporters/GrassCoverErosionOutwardsWaveConditionsExporterTest.cs
    • -0
    • +4
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.IO.Test/Ringtoets.GrassCoverErosionOutwards.IO.Test.csproj
    • -2
    • +3
    /Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.IO.Test/Exporters/StabilityStoneCoverWaveConditionsExporterTest.cs
    • -0
    • +114
    /Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.IO.Test/Exporters/WaveImpactAsphaltCoverWaveConditionsExporterTest.cs
    • -0
    • +4
    /Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.IO.Test/Ringtoets.WaveImpactAsphaltCover.IO.Test.csproj
9:16 am

Joël van den Berg

Made WaveImpactAsphaltCoverWaveConditionsExporterTest test wave condition export info instead of configuration export info. Related to Issue [WTI-1157]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8850 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e9391db97cf8f79eca2ef6a26574d87c1cfc44bb

Former-commit-id: 805cf0a0c9e082c04042b020d8421c8019dfc70b

Options
    • -7
    • +35
    /Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Plugin.Test/ExportInfos/WaveImpactAsphaltCoverWaveConditionsCalculationContextWaveConditionsExportInfoTest.cs