Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 01 Jun 2018
10:43 am

Elmar Kleijn

Adapted DuneErosionFailureMechanismPropertyChangeHandler. WTI-1655

Options
    • -1
    • +0
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/DuneErosionFailureMechanismPropertyChangeHandler.cs
    • -145
    • +4
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/DuneErosionFailureMechanismPropertyChangeHandlerTest.cs
10:35 am

Carlos Lubbers

Implement review comments, update tests, xmldoc and cleanup WTI-1654

Options
    • -2
    • +2
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCalculationCollectionCreateExtensionsTest.cs
    • -7
    • +7
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCalculationOutputCreateExtensionsTest.cs
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCreateExtensionsTest.cs
    • -31
    • +31
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
    • -2
    • +2
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationCalculationCollectionEntityReadExtensionsTest.cs
    • -3
    • +3
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationCalculationEntityReadExtensionsTest.cs
    • -2
    • +2
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationCalculationOutputEntityReadExtensionsTest.cs
10:29 am

Elmar Kleijn

Adapted DuneLocationsTestHelper. WTI-1655

Options
    • -13
    • +6
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Data.TestUtil.Test/DuneLocationsTestHelperTest.cs
    • -14
    • +8
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Data.TestUtil/DuneLocationsTestHelper.cs
9:11 am

Robert Tangerman <robert.tangerman@deltares.nl>

Introduced specific reader for assessment section category wave conditions calculation configurations. WTI-1705

Options
    • -0
    • +50
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/Configurations/AssessmentSectionCategoryWaveConditionsCalculationConfigurationReader.cs
    • -0
    • +1
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/Ringtoets.Revetment.IO.csproj
    • -0
    • +48
    /Ringtoets/Revetment/test/Ringtoets.Revetment.IO.Test/Configurations/AssessmentSectionCategoryWaveConditionsCalculationConfigurationReaderTest.cs
    • -0
    • +1
    /Ringtoets/Revetment/test/Ringtoets.Revetment.IO.Test/Ringtoets.Revetment.IO.Test.csproj
7:58 am

Robert Tangerman <robert.tangerman@deltares.nl>

Renamed Helpers folder to Converters. WTI-1705

Options
    • -1
    • +1
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/Configurations/AssessmentSectionCategoryWaveConditionsCalculationConfigurationExporter.cs
    • -1
    • +1
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/Configurations/AssessmentSectionCategoryWaveConditionsCalculationConfigurationWriter.cs
    • -0
    • +156
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/Configurations/Converters/ConfigurationAssessmentSectionCategoryTypeConverter.cs
    • -0
    • +167
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/Configurations/Converters/ConfigurationFailureMechanismCategoryTypeConverter.cs
    • -0
    • +145
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/Configurations/Converters/ConfigurationWaveConditionsInputStepSizeConverter.cs
    • -1
    • +1
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/Configurations/FailureMechanismCategoryWaveConditionsCalculationConfigurationExporter.cs
    • -156
    • +0
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/Configurations/Helpers/ConfigurationAssessmentSectionCategoryTypeConverter.cs
    • -167
    • +0
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/Configurations/Helpers/ConfigurationFailureMechanismCategoryTypeConverter.cs
    • -145
    • +0
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/Configurations/Helpers/ConfigurationWaveConditionsInputStepSizeConverter.cs
    • -1
    • +1
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/Configurations/WaveConditionsCalculationConfigurationExporter.cs
    • -1
    • +1
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/Configurations/WaveConditionsCalculationConfigurationReader.cs
    • -1
    • +1
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/Configurations/WaveConditionsCalculationConfigurationWriter.cs
    • -1
    • +1
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/Configurations/failureMechanismCategoryWaveConditionsCalculationConfigurationWriter.cs
    • -3
    • +3
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/Ringtoets.Revetment.IO.csproj
    • -0
    • +254
    /Ringtoets/Revetment/test/Ringtoets.Revetment.IO.Test/Configurations/Converters/ConfigurationAssessmentSectionCategoryTypeConverterTest.cs
  16. … 6 more files in changeset.
Thursday 31 May 2018
5:00 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup - Fixed validation for calculations that are created for locations: - Editiorial, removed redundant whitespaces

WTI-1654

Options
    • -18
    • +18
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
4:58 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup - Fixed validation for calculations that are created for locations: - Emulated outer join for the hydraulic boundary locations on grass cover erosion outwards failure mechanism

WTI-1654

Options
    • -9
    • +25
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
4:52 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup - Fixed validation for calculations that are created for locations: - Emulated outer join for the hydraulic boundary locations on assessment section level

WTI-1654

Options
    • -6
    • +22
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
4:28 pm

Elmar Kleijn

Removed Calculation property from DuneLocation. WTI-1655

Options
    • -7
    • +0
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Data/DuneLocation.cs
    • -2
    • +0
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Data.Test/DuneLocationTest.cs
4:24 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup - Fixed validation for calculations that are created for locations: - Emulated outer join for the dune locations

WTI-1654

Options
    • -175
    • +191
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
3:13 pm

Elmar Kleijn

Review related changes (WTI REVIEW 2881). WTI-1575

Options
    • -0
    • +4
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Plugin/DuneErosionPlugin.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/DuneErosionPluginTest.cs
    • -1
    • +48
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/TreeNodeInfos/DuneLocationCalculationsGroupContextTreeNodeInfoTest.cs
2:54 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2901: - Updated XMLDoc - Changed prefix for the resources of the AssemblyErrorMessageCreator

Paired with ~carloslubbers

WTI-1671

Options
    • -26
    • +26
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/AssemblyErrorMessageCreator.cs
    • -48
    • +48
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Properties/Resources.Designer.cs
    • -24
    • +24
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Properties/Resources.resx
2:42 pm

Elmar Kleijn

Review related changes (WTI REVIEW 2886 and 2889). WTI-1575

Options
    • -0
    • +1
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Service/DuneLocationCalculationActivity.cs
    • -2
    • +1
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Service/DuneLocationCalculationService.cs
    • -0
    • +1
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Service.Test/DuneLocationCalculationActivityTest.cs
2:37 pm

Elmar Kleijn

Review related changes (WTI REVIEW 2880 and 2882). WTI-1575

Options
    • -1
    • +1
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/PresentationObjects/DuneLocationCalculationsGroupContext.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/Views/DuneLocationCalculationsViewBase.Designer.cs
    • -2
    • +3
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Data.Test/DuneErosionFailureMechanismExtensionsTest.cs
    • -16
    • +16
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Views/DuneLocationCalculationsViewBaseTest.cs
    • -2
    • +3
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/TreeNodeInfos/DuneLocationCalculationsGroupContextTreeNodeInfoTest.cs
2:29 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup - Rename DuneLocationOutputEntity to DuneLocationCalculationOutputEntity: - Fixed migration script and verification tests

WTI-1654

Options
    • -2
    • +2
    /Application/Ringtoets/src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • binary
    /Application/Ringtoets/test/Application.Ringtoets.Migration.Core.Test/test-data/MigrationTestProject181.rtd
    • -4
    • +3
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
2:03 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup - Rename DuneLocationOutputEntity to DuneLocationCalculationOutputEntity: - Fixed compiling errors - Renamed read extension and corresponding test

WTI-1654

Options
    • -1
    • +1
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Application.Ringtoets.Storage.csproj
    • -1
    • +1
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Create/DuneErosion/DuneLocationCalculationCreateExtensions.cs
    • -5
    • +7
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Create/DuneErosion/DuneLocationCalculationOutputCreateExtensions.cs
    • -2
    • +1
    /Application/Ringtoets/src/Application.Ringtoets.Storage/DbContext/PartialRingtoetsEntities.cs
    • -1
    • +1
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/DuneErosion/DuneLocationCalculationEntityReadExtensions.cs
    • -0
    • +60
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/DuneErosion/DuneLocationCalculationOutputEntityReadExtensions.cs
    • -60
    • +0
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/DuneErosion/DuneLocationOutputEntityReadExtensions.cs
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Application.Ringtoets.Storage.Test.csproj
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneErosionFailureMechanismCreateExtensionsTest.cs
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCalculationCollectionCreateExtensionsTest.cs
    • -2
    • +2
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCalculationCreateExtensionsTest.cs
    • -4
    • +4
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCalculationOutputCreateExtensionsTest.cs
    • -2
    • +2
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationCalculationCollectionEntityReadExtensionsTest.cs
    • -2
    • +2
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationCalculationEntityReadExtensionsTest.cs
    • -0
    • +117
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationCalculationOutputEntityReadExtensionsTest.cs
    • -117
    • +0
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationOutputEntityReadExtensionsTest.cs
    • -2
    • +2
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/FailureMechanismEntityReadExtensionsTest.cs
1:55 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup - Rename DuneLocationOutputEntity to DuneLocationCalculationOutputEntity: - Regenerated entities

WTI-1654

Options
    • -2
    • +2
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Application.Ringtoets.Storage.csproj
    • -2
    • +2
    /Application/Ringtoets/src/Application.Ringtoets.Storage/DbContext/DuneLocationCalculationEntity.cs
    • -0
    • +48
    /Application/Ringtoets/src/Application.Ringtoets.Storage/DbContext/DuneLocationCalculationOutputEntity.cs
    • -48
    • +0
    /Application/Ringtoets/src/Application.Ringtoets.Storage/DbContext/DuneLocationOutputEntity.cs
    • -1
    • +1
    /Application/Ringtoets/src/Application.Ringtoets.Storage/DbContext/RingtoetsEntities.Context.cs
    • -71
    • +71
    /Application/Ringtoets/src/Application.Ringtoets.Storage/DbContext/RingtoetsEntities.edmx
    • -89
    • +89
    /Application/Ringtoets/src/Application.Ringtoets.Storage/DbContext/RingtoetsEntities.edmx.diagram
1:42 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup - Rename DuneLocationOutputEntity to DuneLocationCalculationOutputEntity: - Generated the new .SQL and RT file

WTI-1654

Options
    • -7
    • +7
    /Application/Ringtoets/src/Application.Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure18.1.sql
    • binary
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Ringtoets.rtd
    • -7
    • +7
    /build/DatabaseStructure.sql
1:40 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup - Rename DuneLocationOutputEntity to DuneLocationCalculationOutputEntity: - Adjused DatabaseDesign.eap

WTI-1654

Options
    • binary
    /design/DatabaseDesign.eap
1:38 pm

Dennis Tang <dennis.tang@deltares.nl>

Adapted migration script: - Migrated DuneLocationOutput such that they are mapped onto the correct dune location calculation collections -- Adjusted validation tests

WTI-1654

Options
    • -2
    • +37
    /Application/Ringtoets/src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • -7
    • +96
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
11:46 am

Dennis Tang <dennis.tang@deltares.nl>

Adapted migration script: - Create new (mandatory) rows for the CalculationCollectionEntity and the CalculationEntity for DuneErosion -- Adjusted reference 173 file to include dune locations with output calculated based on either the signaling or the lower limit norm -- Adjusted validation tests

WTI-1654

Options
    • -1
    • +144
    /Application/Ringtoets/src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • binary
    /Application/Ringtoets/test/Application.Ringtoets.Migration.Core.Test/test-data/MigrationTestProject173.rtd
    • -2
    • +131
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
11:20 am

Carlos Lubbers

Implement review comments for dune map view WTI-1577

Options
    • -0
    • +3
    /Ringtoets.sln
    • -2
    • +3
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/Factories/DuneErosionMapDataFeaturesFactory.cs
    • -7
    • +8
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Data.TestUtil/DuneLocationsTestHelper.cs
    • -23
    • +23
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Factories/AggregatedDuneLocationFactoryTest.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Factories/DuneErosionMapDataFeaturesFactoryTest.cs
    • -4
    • +0
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Ringtoets.DuneErosion.Forms.Test.csproj
    • -1
    • +0
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Views/AggregatedDuneLocationTest.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Views/DuneErosionFailureMechanismViewTest.cs
    • -3
    • +5
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.TestUtil/DuneErosionMapFeaturesTestHelper.cs
11:19 am

Elmar Kleijn

Review related changes (WTI REVIEW 2878). WTI-1575

Options
    • -3
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Util/FailureMechanismNormHelper.cs
    • -8
    • +8
    /Ringtoets/Common/test/Ringtoets.Common.Util.Test/FailureMechanismNormHelperTest.cs
    • -7
    • +0
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Data/GrassCoverErosionOutwardsFailureMechanismExtensions.cs
11:10 am

Elmar Kleijn

Review related changes (WTI REVIEW 2873). WTI-1575

Options
    • -1
    • +1
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/Views/DuneLocationCalculationRow.cs
    • -20
    • +13
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/Views/DuneLocationCalculationsView.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/Views/DuneLocationCalculationsViewBase.cs
    • -2
    • +2
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Plugin/DuneErosionPlugin.cs
    • -2
    • +2
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Views/DuneLocationCalculationRowTest.cs
    • -13
    • +13
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Views/DuneLocationCalculationsViewTest.cs
    • -2
    • +1
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/ViewInfos/DuneLocationCalculationsViewInfoTest.cs
10:41 am

Carlos Lubbers

Cleanup resources WTI-1584

Options
    • -9
    • +0
    /Core/Common/src/Core.Common.Gui/Properties/Resources.Designer.cs
    • -3
    • +0
    /Core/Common/src/Core.Common.Gui/Properties/Resources.resx
    • -54
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Data/Properties/Resources.Designer.cs
    • -18
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Data/Properties/Resources.resx
    • -18
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.Designer.cs
    • -6
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.resx
    • -10
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Service/Properties/Resources.Designer.cs
    • -3
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Service/Properties/Resources.resx
    • -9
    • +0
    /Ringtoets/Piping/src/Ringtoets.Piping.Forms/Properties/Resources.Designer.cs
    • -3
    • +0
    /Ringtoets/Piping/src/Ringtoets.Piping.Forms/Properties/Resources.resx
    • -10
    • +0
    /Ringtoets/Piping/src/Ringtoets.Piping.Service/Properties/Resources.Designer.cs
    • -3
    • +0
    /Ringtoets/Piping/src/Ringtoets.Piping.Service/Properties/Resources.resx
9:06 am

Carlos Lubbers

Cleanup unused resources in grass cover erosion outwards service WTI-1584

Options
    • -40
    • +0
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Service/Properties/Resources.Designer.cs
    • -12
    • +0
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Service/Properties/Resources.resx
Wednesday 30 May 2018
3:54 pm

Dennis Tang <dennis.tang@deltares.nl>

Fixed failing test: - Stored new (empty) 181 project with the new database structure

WTI-1654

Options
    • binary
    /Application/Ringtoets/test/Application.Ringtoets.Migration.Core.Test/test-data/MigrationTestProject181.rtd
3:51 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted StorageSQLIntegrationTest to verify the round trip saving and opening RT projects: - Fixed failiing test: -- CollectionEntities should always be set for the dune failure mechanism meta entity to prevent ArgumentNullExceptions

WTI-1654

Options
    • -2
    • +12
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/AssessmentSectionEntityReadExtensionsTest.cs
3:40 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted StorageSQLIntegrationTest to verify the round trip saving and opening RT projects: - Included the new entities to be loaded - Switched order in the CreateExtensions: locations should be created first to prevent InvalidOperationExceptions because no matching DuneLocationEntity is found

WTI-1654

Options
    • -1
    • +1
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Create/DuneErosion/DuneErosionFailureMechanismCreateExtensions.cs
    • -0
    • +3
    /Application/Ringtoets/src/Application.Ringtoets.Storage/DbContext/PartialRingtoetsEntities.cs
    • -1
    • +34
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
3:29 pm

Carlos Lubbers

Implement review comments. Update asserts, rename AssemblyErrorMessageTranslator, update test names and update method names WTI-1671

Options
    • -8
    • +8
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/Assembly/AssessmentSectionAssemblyCalculator.cs
    • -4
    • +4
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/Assembly/FailureMechanismAssemblyCalculator.cs
    • -26
    • +26
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/Assembly/FailureMechanismSectionAssemblyCalculator.cs
    • -0
    • +136
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/AssemblyErrorMessageCreator.cs
    • -120
    • +0
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/AssemblyErrorMessageTranslator.cs
    • -8
    • +8
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/Categories/AssemblyCategoriesCalculator.cs
    • -1
    • +1
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Ringtoets.AssemblyTool.KernelWrapper.csproj
    • -0
    • +132
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/AssemblyErrorMessageCreatorTest.cs
    • -109
    • +0
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/AssemblyErrorMessageTranslatorTest.cs
    • -20
    • +20
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Calculators/Assembly/AssessmentSectionAssemblyCalculatorTest.cs
    • -10
    • +10
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Calculators/Assembly/FailureMechanismAssemblyCalculatorTest.cs
    • -73
    • +73
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Calculators/Assembly/FailureMechanismSectionAssemblyCalculatorTest.cs
    • -12
    • +12
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Calculators/Categories/AssemblyCategoriesCalculatorTest.cs
    • -1
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Ringtoets.AssemblyTool.KernelWrapper.Test.csproj
    • -2
    • +2
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil.Test/Kernels/Assembly/CombinedFailureMechanismSectionAssemblyKernelStubTest.cs
  16. … 5 more files in changeset.