Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 12 Sep 24
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 26 Jul 2017
10:24 am

Marten Janssen <marten.janssen@deltares.nl>

Completed validation method for StochasticSoilModelReader Related to Issue [WTI-1291]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10869 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 00bda34bc090bfbf7beac1b84a56a30694d29774

Former-commit-id: 231fdc462044e167121a93b062bcfe3a21510b52

Options
    • -0
    • +9
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.Designer.cs
    • -0
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.resx
    • -0
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.IO/Ringtoets.Common.IO.csproj
    • -0
    • +56
    /Ringtoets/Common/src/Ringtoets.Common.IO/SoilProfile/Schema/MechanismTableDefinitions.cs
    • -0
    • +49
    /Ringtoets/Common/src/Ringtoets.Common.IO/SoilProfile/Schema/SegmentPointsTableDefinitions.cs
    • -0
    • +39
    /Ringtoets/Common/src/Ringtoets.Common.IO/SoilProfile/Schema/SegmentTableDefinitions.cs
    • -0
    • +5
    /Ringtoets/Common/src/Ringtoets.Common.IO/SoilProfile/Schema/StochasticSoilModelTableDefinitions.cs
    • -0
    • +30
    /Ringtoets/Common/src/Ringtoets.Common.IO/SoilProfile/SoilDatabaseQueryBuilder.cs
    • -5
    • +65
    /Ringtoets/Common/src/Ringtoets.Common.IO/SoilProfile/StochasticSoilModelReader.cs
    • -0
    • +16
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/SoilProfile/SoilDatabaseQueryBuilderTest.cs
    • -8
    • +26
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/SoilProfile/StochasticSoilModelReaderTest.cs
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/StochasticSoilModelReader/complete.soil
8:48 am

Joël van den Berg

Proper hashing of some data types (equal objects should return equal hashes!) Reused SequenceEquals instead of implementing this ourselves for collections in data types, e.g. layers in a profile. Implemented TestHelper.AssertCollectionAreEqual to test whether elements in a collection are equal using a IEqualityComparer<T>. Related to Issue [WTI-1342]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10868 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 9f56c861e647986e5c2bfdc79bfdfed5a293a492

Former-commit-id: 5076ae29a1be1edbe3a2049746757157933ad786

Options
    • -0
    • +217
    /Core/Common/test/Core.Common.TestUtil.Test/TestHelperTest.cs
    • -1
    • +35
    /Core/Common/test/Core.Common.TestUtil/TestHelper.cs
    • -376
    • +19
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Primitives/MacroStabilityInwardsSoilLayer2D.cs
    • -1
    • +5
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Primitives/MacroStabilityInwardsSoilProfile1D.cs
    • -21
    • +7
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Primitives/MacroStabilityInwardsSoilProfile2D.cs
    • -0
    • +104
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Primitives/Ring.cs
    • -0
    • +1
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Primitives/Ringtoets.MacroStabilityInwards.Primitives.csproj
    • -0
    • +16
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Primitives.Test/MacroStabilityInwardsSoilLayer1DTest.cs
    • -24
    • +42
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Primitives.Test/MacroStabilityInwardsSoilLayer2DTest.cs
    • -0
    • +16
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Primitives.Test/MacroStabilityInwardsSoilProfile1DTest.cs
    • -136
    • +82
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Primitives.Test/MacroStabilityInwardsSoilProfile2DTest.cs
    • -65
    • +0
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Primitives.Test/Ring.cs
    • -0
    • +143
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Primitives.Test/RingTest.cs
    • -1
    • +0
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Primitives.Test/Ringtoets.MacroStabilityInwards.Primitives.Test.csproj
    • -28
    • +44
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Primitives.Test/SoilLayerPropertiesTest.cs
    • -20
    • +6
    /Ringtoets/Piping/src/Ringtoets.Piping.Primitives/PipingSoilProfile.cs
    • -0
    • +16
    /Ringtoets/Piping/test/Ringtoets.Piping.Primitives.Test/PipingSoilProfileTest.cs
Tuesday 25 Jul 2017
4:37 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Implement review comments 1970: - Refactor HasIllustrationPoints and SetIllustrationPoints to HasGeneralResult and SetGeneralResult - ProbabilityAssessmentOutput in GrassCoverErosionInwardsOvertoppingOutput cannot be null - Improve tests for services and output objects - Move Resources to Common - Correct implementation of IllustrationPointsParserErrorMessage - Made ConvertIllustrationPointsResult private Related to Issue [WTI-1318]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10867 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 26b18ecde3707516f72159c322b00f31c74271a9

Former-commit-id: 693f5a23203efef71b2a492062c80e2d8e3202e3

Options
    • -1
    • +1
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Create/StructuresCalculationCreateExtensions.cs
    • -1
    • +1
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/ClosingStructures/ClosingStructuresCalculationEntityReadExtensions.cs
    • -1
    • +1
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/GrassCoverErosionOutwards/GrassCoverErosionOutwardsHydraulicLocationEntityReadExtensions.cs
    • -1
    • +1
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/HeightStructures/HeightStructuresCalculationEntityReadExtensions.cs
    • -1
    • +1
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/HydraulicLocationEntityReadExtensions.cs
    • -1
    • +1
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/StabilityPointStructures/StabilityPointStructuresCalculationEntityReadExtensions.cs
    • -6
    • +6
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/HydraulicBoundaryLocationCreateExtensionsTest.cs
    • -8
    • +8
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/StructuresCalculationCreateExtensionsTest.cs
    • -3
    • +3
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/ClosingStructures/ClosingStructuresCalculationEntityReadExtensionsTest.cs
    • -3
    • +3
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/HeightStructures/HeightStructuresCalculationEntityReadExtensionsTest.cs
    • -3
    • +3
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/StabilityPointStructures/StabilityPointStructuresCalculationEntityReadExtensionsTest.cs
    • -3
    • +3
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
    • -3
    • +3
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Data/Hydraulics/DesignWaterLevelCalculation.cs
    • -3
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Data/Hydraulics/HydraulicBoundaryLocationOutput.cs
  16. … 42 more files in changeset.
3:15 pm

Elmar Kleijn

Review related changes Related to Issue [WTI-1289]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10866 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8f315e588f3e741604a2c8d13c5352d7dc018fb6

Former-commit-id: 05448f3a211c055246e8d551732936274e271357

Options
    • -1
    • +22
    /Core/Common/src/Core.Common.Base/Properties/Resources.Designer.cs
    • -3
    • +2
    /Ringtoets/Piping/src/Ringtoets.Piping.KernelWrapper/PipingSurfaceLineCreator.cs
    • -2
    • +3
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/PipingPlugin.cs
3:08 pm

Marten Janssen <marten.janssen@deltares.nl>

Connected SoilDatabaseConstraintsReader to StochasticSoilModelReader Related to Issue [WTI-1291]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10865 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e7ba279287bce2e222acdc999eb55304c01c1ecc

Former-commit-id: 22ef3b217f964050dad4b691e1daee393eab206b

Options
    • -1
    • +20
    /Ringtoets/Common/src/Ringtoets.Common.IO/SoilProfile/StochasticSoilModelReader.cs
    • -1
    • +46
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/SoilProfile/StochasticSoilModelReaderTest.cs
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/StochasticSoilModelReader/incorrectVersion.soil
3:04 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1976: - Formatted file - Updated XMLDocs

Reviewed by ~janssen

Related to Issue [WTI-1290]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10864 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 96d7dd34071979c54f8e3f856e5cf592c544763f

Former-commit-id: 0a8aadc910a8ce4ce048f64401d4a413010db4a8

Options
    • -4
    • +5
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Factories/MacroStabilityInwardsChartDataFactory.cs
    • -3
    • +2
    /Ringtoets/Piping/src/Ringtoets.Piping.Forms/Factories/PipingChartDataFactory.cs
2:31 pm

Joël van den Berg

Introduced concept of difference in 1D and 2D profiles for Macro Stability Inwards. Related to Issue [WTI-1342]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10863 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8e881f55e61effd0c2f3016539e1c9fa374fa850

Former-commit-id: 16bf302601598b552700cb9c7eded5e589ff576f

Options
    • -2
    • +2
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/SoilProfileUnderSurfaceLineFactory.cs
    • -4
    • +4
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/StochasticSoilModel.cs
    • -2
    • +2
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/StochasticSoilProfile.cs
    • -7
    • +7
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Factories/MacroStabilityInwardsChartDataFactory.cs
    • -13
    • +13
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Factories/MacroStabilityInwardsChartDataPointsFactory.cs
    • -2
    • +2
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/PropertyClasses/StochasticSoilProfileProperties.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/UITypeEditors/MacroStabilityInwardsInputContextStochasticSoilProfileSelectionEditor.cs
    • -6
    • +6
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsInputView.cs
    • -8
    • +8
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsSoilLayerTable.cs
    • -4
    • +4
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.IO/Builders/SoilLayer1D.cs
    • -6
    • +6
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.IO/Builders/SoilLayer2D.cs
    • -10
    • +10
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.IO/Builders/SoilProfileBuilder1D.cs
    • -10
    • +10
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.IO/Builders/SoilProfileBuilder2D.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.IO/Exceptions/MacroStabilityInwardsSoilProfileReadException.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.IO/Exceptions/SoilLayerConversionException.cs
  16. … 59 more files in changeset.
2:27 pm

Elmar Kleijn

Fixed build Related to Issue [WTI-1289]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10862 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d293ad616d0b94209ad2fd6394422e3213db560c

Former-commit-id: 9c9f5537124e9a366daedb445f802a55a093d4dc

Options
    • -0
    • +390
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.IO.Test/Importers/MacrostabilityInwardsSurfaceLineTransformerTest.cs
2:15 pm

Elmar Kleijn

Review related changes Related to Issue [WTI-1289]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10861 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0e544de5b4d2f98864ae088cf1a24e42f64a52e6

Former-commit-id: 6c9241e428b95facb23d9815de3678d038508702

Options
    • -0
    • +9
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Properties/Resources.Designer.cs
    • -0
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Properties/Resources.resx
    • -2
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.IO/SurfaceLines/CharacteristicPoints.cs
    • -8
    • +9
    /Ringtoets/Common/src/Ringtoets.Common.IO/SurfaceLines/SurfaceLine.cs
    • -4
    • +4
    /Ringtoets/Common/src/Ringtoets.Common.IO/SurfaceLines/SurfaceLinesCsvImporterConfiguration.cs
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/SurfaceLines/CharacteristicPointsTest.cs
    • -2
    • +2
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/SurfaceLines/SurfaceLineTest.cs
    • -45
    • +0
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Properties/Resources.Designer.cs
    • -15
    • +0
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Properties/Resources.resx
    • -2
    • +2
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/PropertyClasses/MacroStabilityInwardsInputContextProperties.cs
    • -84
    • +1
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.IO/Properties/Resources.Designer.cs
    • -28
    • +1
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.IO/Properties/Resources.resx
    • -0
    • +1
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Primitives/Ringtoets.MacroStabilityInwards.Primitives.csproj
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Primitives/RingtoetsMacroStabilityInwardsSurfaceLine.cs
    • -390
    • +0
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.IO.Test/Importers/MacrostabilityInwardsSurfaceLineTransformerTest.cs
  16. … 23 more files in changeset.
1:24 pm

Joël van den Berg

Fixed name of resource. Related to Issue [WTI-1354]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10860 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4d5e9bb3897e217ee0c473c718faa8bf044ee657

Former-commit-id: 89922d8b9b082ea69140dbf183d3168ec8d5eb79

Options
    • -4
    • +4
    /Ringtoets/Common/src/Ringtoets.Common.Service/Properties/Resources.Designer.cs
    • -2
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.Service/Properties/Resources.resx
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Service/MessageProviders/DesignWaterLevelCalculationMessageProvider.cs
12:48 pm

Marten Janssen <marten.janssen@deltares.nl>

Fixed failing test Related to Issue [WTI-1291]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10859 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 54e01fd4b7f54e5c1d3ef4adb855e74d3c4cf2f7

Former-commit-id: 403902a42348e6ade7e46528ffebbe72889e70db

Options
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/SoilProfile/SoilDatabaseQueryBuilderTest.cs
12:11 pm

Marten Janssen <marten.janssen@deltares.nl>

Final implementation of new SoilDatabaseConstraintsReader

Related to Issue [WTI-1291]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10858 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ef835d82589076b084088a577f86ca1bbb5e9fc1

Former-commit-id: 77e4e9c7a5aaacc2b9b3b215ba46be0f6ffa025e

Options
    • -0
    • +60
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.Designer.cs
    • -0
    • +18
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.resx
    • -0
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.IO/Ringtoets.Common.IO.csproj
    • -0
    • +44
    /Ringtoets/Common/src/Ringtoets.Common.IO/SoilProfile/Schema/StochasticSoilModelTableDefinitions.cs
    • -0
    • +60
    /Ringtoets/Common/src/Ringtoets.Common.IO/SoilProfile/Schema/StochasticSoilProfileTableDefinitions.cs
    • -2
    • +115
    /Ringtoets/Common/src/Ringtoets.Common.IO/SoilProfile/SoilDatabaseConstraintsReader.cs
    • -0
    • +32
    /Ringtoets/Common/src/Ringtoets.Common.IO/SoilProfile/SoilDatabaseQueryBuilder.cs
    • -0
    • +89
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/SoilProfile/SoilDatabaseConstraintsReaderTest.cs
    • -0
    • +27
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/SoilProfile/SoilDatabaseQueryBuilderTest.cs
    • -4
    • +5
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/SoilProfile/StochasticSoilModelReaderTest.cs
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/SoilDatabaseConstraintsReader/missingStochasticSoilModelTable.soil
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/SoilDatabaseConstraintsReader/missingStochasticSoilProfileProbability.soil
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/SoilDatabaseConstraintsReader/missingStochasticSoilProfileTable.soil
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/SoilDatabaseConstraintsReader/nonUniqueSoilModelNames.soil
11:51 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1971: - Ran DeltaresClean on the illustrationpoint converters related files. Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10857 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d80588bb60247e23fce99490581d19ea9b11b5ab

Former-commit-id: 4a17a22944679368e84bce71b629c2b1faefd4c0

Options
    • -2
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.Service/IllustrationPoints/CombinationTypeConverter.cs
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/IllustrationPoints/CombinationTypeConverterTest.cs
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/IllustrationPoints/GeneralResultConverterTest.cs
11:43 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1971: - Reverted to old implementation for the CombinationTypeConverter: -- InvalidEnumArgumentException thrown when an enum is fed which is undefined -- NotSupportedException thrown when an enum is defined, but could not be converted - Adjusted implementation of the IllustrationPointNodeConverter: -- Instead of returning NULL for an unknown IIllustrationPoint, throw a NotSupportedException. Data should not be set on the nodes when there's an invalid element present. Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10856 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2cbfb8c965710004156f587b1d1d143aa01f2d15

Former-commit-id: 3c4c94634b5e02d5e0fe07ca0dd1d0c6d8e6c2d6

Options
    • -5
    • +13
    /Ringtoets/Common/src/Ringtoets.Common.Service/IllustrationPoints/CombinationTypeConverter.cs
    • -7
    • +20
    /Ringtoets/Common/src/Ringtoets.Common.Service/IllustrationPoints/FaultTreeIllustrationPointConverter.cs
    • -10
    • +32
    /Ringtoets/Common/src/Ringtoets.Common.Service/IllustrationPoints/IllustrationPointNodeConverter.cs
    • -6
    • +6
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/IllustrationPoints/CombinationTypeConverterTest.cs
    • -1
    • +2
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/IllustrationPoints/FaultTreeIllustrationPointConverterTest.cs
    • -6
    • +12
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/IllustrationPoints/IllustrationPointNodeConverterTest.cs
10:59 am

Marten Janssen <marten.janssen@deltares.nl>

First implementation of new SoilDatabaseConstraintsReader Related to Issue [WTI-1291]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10855 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2b34326c1477954c3bf2e87bb28e0146bd58b739

Former-commit-id: bf0188145a460552208da2583b6468eb71a99005

Options
    • -0
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/Ringtoets.Common.IO.csproj
    • -0
    • +43
    /Ringtoets/Common/src/Ringtoets.Common.IO/SoilProfile/SoilDatabaseConstraintsReader.cs
    • -2
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.IO/SoilProfile/StochasticSoilModelReader.cs
    • -0
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/Ringtoets.Common.IO.Test.csproj
    • -0
    • +86
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/SoilProfile/SoilDatabaseConstraintsReaderTest.cs
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/SoilDatabaseConstraintsReader/emptySchema.soil
10:38 am

Marten Janssen <marten.janssen@deltares.nl>

Updated SqLiteDatabaseReaderBase (and derived classes) with a proper implementation of Dispose Updated XMLDoc Modified StochasticSoilModelReader such that it properly closes the connection (by extracting the execution of queries from the constructor to a separate method) Related to Issue [WTI-1291]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10854 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 721294a1ef92c2c79c1b058f30bb4eaea3182b7c

Former-commit-id: 582c188c3ae3c02b89058895579732fda4cf5f4a

Options
    • -1
    • +18
    /Core/Common/src/Core.Common.IO/Readers/SqLiteDatabaseReaderBase.cs
    • -6
    • +32
    /Ringtoets/Common/src/Ringtoets.Common.IO/SoilProfile/StochasticSoilModelReader.cs
    • -2
    • +49
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/SoilProfile/StochasticSoilModelReaderTest.cs
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/StochasticSoilModelReader/incorrectVersion.soil
    • -0
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/StochasticSoilModelReader/text.txt
    • -2
    • +2
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.IO/HydraulicBoundaryDatabaseContext/HydraulicBoundarySqLiteDatabaseReader.cs
    • -2
    • +2
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.IO/SoilProfile/MacroStabilityInwardsSoilProfileReader.cs
    • -2
    • +2
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.IO/SoilProfile/StochasticSoilModelReader.cs
    • -2
    • +2
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.IO/SoilProfile/StochasticSoilProfileReader.cs
    • -2
    • +2
    /Ringtoets/Piping/src/Ringtoets.Piping.IO/SoilProfile/PipingSoilProfileReader.cs
    • -2
    • +2
    /Ringtoets/Piping/src/Ringtoets.Piping.IO/SoilProfile/StochasticSoilModelReader.cs
    • -2
    • +2
    /Ringtoets/Piping/src/Ringtoets.Piping.IO/SoilProfile/StochasticSoilProfileReader.cs
9:12 am

Joël van den Berg

Added soil layer property equality members Related to Issue [WTI-1342]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10853 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d07f23bcf3d8bf432f896f81816105ffd6325088

Former-commit-id: bb6594dec00dc19b475fdda1d4d7d89d2d912b70

Options
    • -0
    • +68
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Primitives/SoilLayerProperties.cs
    • -3
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Primitives.Test/MacroStabilityInwardsSoilLayerTest.cs
    • -0
    • +135
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Primitives.Test/SoilLayerPropertiesTest.cs
9:05 am

Marten Janssen <marten.janssen@deltares.nl>

Full implementation of new SoilDatabaseVersionReader Updated XMLdoc Related to Issue [WTI-1291]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10852 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a720c70b7399012d7949d0c54612f04aae785282

Former-commit-id: 3286e25080d955f999c98f197c0b68b127648236

Options
    • -1
    • +1
    /Core/Common/src/Core.Common.IO/Readers/SqLiteDatabaseReaderBase.cs
    • -0
    • +18
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.Designer.cs
    • -0
    • +6
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.resx
    • -0
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.IO/Ringtoets.Common.IO.csproj
    • -0
    • +44
    /Ringtoets/Common/src/Ringtoets.Common.IO/SoilProfile/Schema/MetaTableDefinitions.cs
    • -0
    • +45
    /Ringtoets/Common/src/Ringtoets.Common.IO/SoilProfile/SoilDatabaseQueryBuilder.cs
    • -3
    • +63
    /Ringtoets/Common/src/Ringtoets.Common.IO/SoilProfile/SoilDatabaseVersionReader.cs
    • -0
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/Ringtoets.Common.IO.Test.csproj
    • -0
    • +44
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/SoilProfile/SoilDatabaseQueryBuilderTest.cs
    • -2
    • +63
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/SoilProfile/SoilDatabaseVersionReaderTest.cs
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/SoilDatabaseVersionReader/correctVersion.soil
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/SoilDatabaseVersionReader/empty.soil
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/SoilDatabaseVersionReader/incorrectSchema.soil
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/SoilDatabaseVersionReader/incorrectVersion.soil
8:57 am

Elmar Kleijn

Implemented CloseViewForData for GeneralResultFaultTreeIllustrationPointView Related to Issue [WTI-1311]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10851 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3c3195b68dbffd5c8898ad557c12224bc5ad2187

Former-commit-id: 91a45518c99c087eb2e6808b7f48108e4e55b75b

Options
    • -29
    • +17
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/RingtoetsPlugin.cs
    • -0
    • +567
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/ViewInfos/GeneralResultFaultTreeIllustrationPointViewInfoTest.cs
8:09 am

Marten Janssen <marten.janssen@deltares.nl>

Updated error message Related to Issue [WTI-1328]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10850 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d84ca84683a08039ccb1768ef3b19825cbc63235

Former-commit-id: 3d6c10f3a65acf80d96c10b9f49af87af3699a51

Options
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.Designer.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.resx
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/Configurations/Import/CalculationConfigurationImporterTest.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.IO.Test/Configurations/MacroStabilityInwardsCalculationConfigurationImporterTest.cs
    • -1
    • +1
    /Ringtoets/Piping/test/Ringtoets.Piping.IO.Test/Configurations/PipingCalculationConfigurationImporterTest.cs
7:30 am

Elmar Kleijn

Added GeneralResultFaultTreeIllustrationPointViewInfoTest Related to Issue [WTI-1311]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10849 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 843cbed202d1ed626ca0bfd91a0a9b86ca37204d

Former-commit-id: 2afa68ce7486135492ee5b0b522aca953d154bea

Options
    • -2
    • +2
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Forms/PresentationObjects/ClosingStructuresContext.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Plugin.Test/ViewInfos/GrassCoverErosionInwardsInputViewInfoTest.cs
    • -0
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Ringtoets.Integration.Plugin.Test.csproj
    • -0
    • +93
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/ViewInfos/GeneralResultFaultTreeIllustrationPointViewInfoTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/ViewInfos/WaveConditionsInputViewInfoTest.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Plugin.Test/ViewInfos/MacroStabilityInwardsCalculationsViewInfoTest.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Plugin.Test/ViewInfos/MacroStabilityInwardsInputViewInfoTest.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Plugin.Test/ViewInfos/MacroStabilityInwardsScenariosViewInfoTest.cs
    • -1
    • +1
    /Ringtoets/Piping/test/Ringtoets.Piping.Plugin.Test/ViewInfos/PipingCalculationsViewInfoTest.cs
    • -1
    • +1
    /Ringtoets/Piping/test/Ringtoets.Piping.Plugin.Test/ViewInfos/PipingInputViewInfoTest.cs
    • -1
    • +1
    /Ringtoets/Piping/test/Ringtoets.Piping.Plugin.Test/ViewInfos/PipingScenariosViewInfoTest.cs
Monday 24 Jul 2017
4:28 pm

Marten Janssen <marten.janssen@deltares.nl>

First implementation of new StochasticSoilModelReader and SoilDatabaseVersionReader Related to Issue [WTI-1291]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10848 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 356a0bf47e679abee0d3cadf043dac7a240480bc

Former-commit-id: 6c676850c386af2433794849469cdabf2b7fc794

Options
    • -3
    • +3
    /Core/Common/src/Core.Common.IO/Readers/SqLiteDatabaseReaderBase.cs
    • -0
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.IO/Ringtoets.Common.IO.csproj
    • -0
    • +45
    /Ringtoets/Common/src/Ringtoets.Common.IO/SoilProfile/SoilDatabaseVersionReader.cs
    • -0
    • +53
    /Ringtoets/Common/src/Ringtoets.Common.IO/SoilProfile/StochasticSoilModelReader.cs
    • -0
    • +2
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/Ringtoets.Common.IO.Test.csproj
    • -0
    • +86
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/SoilProfile/SoilDatabaseVersionReaderTest.cs
    • -0
    • +86
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/SoilProfile/StochasticSoilModelReaderTest.cs
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/SoilDatabaseVersionReader/empty.soil
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/SoilDatabaseVersionReader/emptyschema.soil
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/StochasticSoilModelReader/empty.soil
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/StochasticSoilModelReader/emptyschema.soil
4:07 pm

Elmar Kleijn

Review related changes Related to Issue [WTI-1289]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10847 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7c41390836fa8fc54ce6c72437b61a86df6420fb

Former-commit-id: 0a927d28fe2bcd967afa9aa88ecd96696c0d6cd2

Options
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/IDikeProfileUpdateDataStrategy.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/Structures/IStructureUpdateStrategy.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/SurfaceLines/ISurfaceLineUpdateDataStrategy.cs
3:54 pm

Elmar Kleijn

Review related changes Related to Issue [WTI-1289]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10846 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: edafa10119afdb75252ed72140d5cb495fba8658

Former-commit-id: 9ef72f6dddff734ac3c28a856ae8ce52b36a8de3

Options
    • -2
    • +1
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Plugin/FileImporters/ClosingStructureUpdateDataStrategy.cs
    • -7
    • +6
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructureReplaceDataStrategyTest.cs
    • -3
    • +3
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructureUpdateDataStrategyTest.cs
    • -0
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Data/IMechanismSurfaceLine.cs
    • -9
    • +13
    /Ringtoets/Common/src/Ringtoets.Common.Data/UpdateDataStrategies/ReplaceDataStrategyBase.cs
    • -14
    • +19
    /Ringtoets/Common/src/Ringtoets.Common.Data/UpdateDataStrategies/UpdateDataStrategyBase.cs
    • -7
    • +4
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/IDikeProfileUpdateDataStrategy.cs
    • -7
    • +4
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/IForeshoreProfileUpdateDataStrategy.cs
    • -2
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/Structures/IStructureUpdateStrategy.cs
    • -2
    • +2
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/UpdateDataStrategies/ReplaceDataStrategyBaseTest.cs
    • -41
    • +32
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/UpdateDataStrategies/UpdateDataStrategyBaseTest.cs
    • -1
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/FileImporters/DikeProfilesImporterTest.cs
    • -2
    • +4
    /Ringtoets/Common/test/Ringtoets.Common.IO.TestUtil.Test/TestDikeProfileUpdateStrategyTest.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Plugin/FileImporters/GrassCoverErosionInwardsDikeProfileUpdateDataStrategy.cs
    • -2
    • +0
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Plugin.Test/FileImporters/GrassCoverErosionInwardsDikeProfileReplaceDataStrategyTest.cs
  16. … 17 more files in changeset.
3:14 pm

Joël van den Berg

Added SoilProfileUnderSurfaceLineFactory that will have to be used for transforming both 1D and 2D soil profiles to a collection of polygon under a given surface line. Related to Issue [WTI-1342]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10845 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 75b1915c0c7af08f1d86d469db8da31151bed9b6

Former-commit-id: d3336ff58ff3e4ab30b06709827b3f7bb18298d6

Options
    • -0
    • +5
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/Ringtoets.MacroStabilityInwards.Data.csproj
    • -0
    • +154
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/SoilProfileUnderSurfaceLineFactory.cs
    • -0
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/Ringtoets.MacroStabilityInwards.Data.Test.csproj
    • -0
    • +302
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/SoilProfileUnderSurfaceLineFactory.cs
2:28 pm

Marten Janssen <marten.janssen@deltares.nl>

Extended InvalidPathHelper to also cover invalid file path which ends in a directory Related to Issue [WTI-1291]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10844 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 22d2ecab91ececd9d275421d1cbe265d01d54642

Former-commit-id: b235428a843efc00613d2051edc5916f54cde131

Options
    • -1
    • +2
    /Core/Common/test/Core.Common.TestUtil.Test/InvalidPathHelperTest.cs
    • -1
    • +2
    /Core/Common/test/Core.Common.TestUtil/InvalidPathHelper.cs
1:48 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Improve property notification and tests covering this issue. Related to Issue [WTI-1318]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10843 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d0b159003ac595fac19262bb3cfbfab04c0e2f69

Former-commit-id: fa401436a095f9c395e7d593cae61268a8b53e31

Options
    • -6
    • +3
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Forms/PropertyClasses/GrassCoverErosionInwardsInputContextProperties.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Service/GrassCoverErosionInwardsCalculationService.cs
    • -0
    • +18
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Forms.Test/PropertyClasses/GrassCoverErosionInwardsInputContextPropertiesTest.cs
    • -0
    • +105
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Service.Test/GrassCoverErosionInwardsCalculationServiceTest.cs
1:35 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1959: Relevant comments for Converters - Removed the InvalidEnumArgumentException of the CombinationTypeConverter and turned it into a IllustrationPointConversionException -- Done because it prevents every user in the converters from wrapping an InvalidEnumArgumentException into a IllustrationPointConversionException

Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10842 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2dfb4170b55491ebd90bd15b22e22c7abc598f19

Former-commit-id: c0e736cd8416fce224aee1975cbb388408549ed4

Options
    • -5
    • +5
    /Ringtoets/Common/src/Ringtoets.Common.Service/IllustrationPoints/CombinationTypeConverter.cs
    • -20
    • +7
    /Ringtoets/Common/src/Ringtoets.Common.Service/IllustrationPoints/FaultTreeIllustrationPointConverter.cs
    • -6
    • +6
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/IllustrationPoints/CombinationTypeConverterTest.cs
    • -2
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/IllustrationPoints/FaultTreeIllustrationPointConverterTest.cs
1:12 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1959: Relevant comments for Converters - Renamed Create methods to Convert

Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10841 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5e0b94a85615f02a7c19028830441a8616e1a88a

Former-commit-id: f46ac23151fc772d5a60dc227ed4f6d222a60ce5

Options
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Service/DesignWaterLevelCalculationService.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Service/IllustrationPoints/CombinationTypeConverter.cs
    • -3
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Service/IllustrationPoints/FaultTreeIllustrationPointConverter.cs
    • -7
    • +7
    /Ringtoets/Common/src/Ringtoets.Common.Service/IllustrationPoints/GeneralResultConverter.cs
    • -6
    • +6
    /Ringtoets/Common/src/Ringtoets.Common.Service/IllustrationPoints/IllustrationPointNodeConverter.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Service/IllustrationPoints/IllustrationPointResultConverter.cs
    • -2
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.Service/IllustrationPoints/StochastConverter.cs
    • -3
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Service/IllustrationPoints/SubMechanismIllustrationPointConverter.cs
    • -7
    • +7
    /Ringtoets/Common/src/Ringtoets.Common.Service/IllustrationPoints/TopLevelFaultTreeIllustrationPointConverter.cs
    • -4
    • +4
    /Ringtoets/Common/src/Ringtoets.Common.Service/IllustrationPoints/TopLevelSubMechanismIllustrationPointConverter.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Service/IllustrationPoints/WindDirectionConverter.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Service/Structures/StructuresCalculationServiceBase.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Service/WaveHeightCalculationService.cs
    • -4
    • +4
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/IllustrationPoints/CombinationTypeConverterTest.cs
    • -6
    • +6
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/IllustrationPoints/FaultTreeIllustrationPointConverterTest.cs
  16. … 9 more files in changeset.
11:49 am

Marten Janssen <marten.janssen@deltares.nl>

Moved characteristic points to common Moved resources Related to Issue [WTI-1290]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10840 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: dd4a3b9a5dca1446da810dd1f3bc82ffd9cabb21

Former-commit-id: ece41430054bdb873ca37711c30559663d50b3f6

Options
    • -0
    • +91
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Factories/RingtoetsChartDataFactory.cs
    • -0
    • +82
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Factories/RingtoetsChartDataFactoryTest.cs
    • -82
    • +6
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Factories/MacroStabilityInwardsChartDataFactory.cs
    • -1
    • +2
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/MacroStabilityInwardsSurfaceLineSelectionDialog.cs
    • -18
    • +0
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Properties/Resources.Designer.cs
    • -6
    • +0
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Properties/Resources.resx
    • -2
    • +1
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/PropertyClasses/RingtoetsMacroStabilityInwardsSurfaceLineProperties.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/PropertyClasses/StochasticSoilProfileProperties.cs
    • -6
    • +6
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsInputView.cs
    • -72
    • +0
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Factories/MacroStabilityInwardsChartDataFactoryTest.cs
    • -54
    • +0
    /Ringtoets/Piping/src/Ringtoets.Piping.Data/Properties/Resources.Designer.cs
    • -18
    • +0
    /Ringtoets/Piping/src/Ringtoets.Piping.Data/Properties/Resources.resx
    • -75
    • +3
    /Ringtoets/Piping/src/Ringtoets.Piping.Forms/Factories/PipingChartDataFactory.cs
    • -1
    • +2
    /Ringtoets/Piping/src/Ringtoets.Piping.Forms/PipingSurfaceLineSelectionDialog.cs
    • -18
    • +0
    /Ringtoets/Piping/src/Ringtoets.Piping.Forms/Properties/Resources.Designer.cs
  16. … 6 more files in changeset.