Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 14 Jan 2019
7:41 am

Robert Tangerman <robert.tangerman@deltares.nl>

Add Sqlite core to test project. WTI-1927

Options
    • -1
    • +11
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Ringtoets.Integration.IO.Test.csproj
    • -0
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/packages.config
Sunday 13 Jan 2019
10:40 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added DoPostImportUpdates. WTI-1927

Options
    • -0
    • +10
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
    • -1
    • +41
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicLocationConfigurationDatabaseImporterTest.cs
Friday 11 Jan 2019
4:41 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted migration script: WTI-1926

- Added log messages when migrating project files that contain hydraulic boundary location entities.

Options
    • -8
    • +30
    /Ringtoets/Migration/src/Ringtoets.Migration.Core/EmbeddedResources/Migration_18.1_19.1.sql
    • -1
    • +11
    /Ringtoets/Migration/test/Ringtoets.Migration.Integration.Test/MigrationTo191IntegrationTest.cs
    • -0
    • +3
    /Ringtoets/Migration/test/Ringtoets.Migration.Test/RingtoetsProjectMigratorTest.cs
3:59 pm

Dennis Tang <dennis.tang@deltares.nl>

Added default values to migration script. WTI-1926

Options
    • -9
    • +9
    /Ringtoets/Migration/src/Ringtoets.Migration.Core/EmbeddedResources/Migration_18.1_19.1.sql
    • -8
    • +8
    /Ringtoets/Migration/test/Ringtoets.Migration.Integration.Test/MigrationTo191IntegrationTest.cs
3:37 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments PO: WTI-1925

- Changed default values for the HLCD information when there's no ScenarioInformation present in order to make it more insightful that default values are used.

Options
    • -1
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicBoundaryDatabaseUpdateHandler.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicBoundaryDatabaseUpdateHandlerTest.cs
3:25 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments PO: WTI-1925

- Added log message when there's no ScenarioInformation present in the HLCD.

Options
    • -7
    • +7
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
    • -0
    • +9
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Properties/Resources.Designer.cs
    • -0
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Properties/Resources.resx
    • -15
    • +26
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicBoundaryDatabaseImporterTest.cs
1:49 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added extra test. WTI-1927

Options
    • -0
    • +38
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicLocationConfigurationDatabaseImporterTest.cs
1:48 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added progress notification. WTI-1927

Options
    • -1
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
    • -2
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicLocationConfigurationDatabaseImporterTest.cs
1:45 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added call handler to add read data to data model. WTI-1927

Options
    • -0
    • +11
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
    • -1
    • +68
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicLocationConfigurationDatabaseImporterTest.cs
    • binary
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/test-data/HydraulicLocationConfigurationDatabaseImporter/hlcdWithValidScenarioInformation.sqlite
    • binary
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/test-data/HydraulicLocationConfigurationDatabaseImporter/hlcdWithoutScenarioInformation.sqlite
1:11 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added getting confirmation. WTI-1927

Options
    • -0
    • +17
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
    • -0
    • +29
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicLocationConfigurationDatabaseImporterTest.cs
1:05 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added methods to update handler. WTI-1927

Options
    • -1
    • +25
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Handlers/IHydraulicLocationConfigurationDatabaseUpdateHandler.cs
12:56 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added cancellation to importer. WTI-1927

Options
    • -3
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
    • -0
    • +10
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Properties/Resources.Designer.cs
    • -0
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Properties/Resources.resx
    • -0
    • +36
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicLocationConfigurationDatabaseImporterTest.cs
11:59 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added progress notifications. WTI-1927

Options
    • -0
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
    • -11
    • +51
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicLocationConfigurationDatabaseImporterTest.cs
11:52 am

Robert Tangerman <robert.tangerman@deltares.nl>

Removed trackId from data model. WTI-1927

Options
    • -5
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Data/Hydraulics/HydraulicBoundaryDatabase.cs
    • -1
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/Hydraulics/HydraulicBoundaryDatabaseTest.cs
    • -1
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicBoundaryDatabaseUpdateHandler.cs
    • -1
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicBoundaryDatabaseUpdateHandlerTest.cs
11:51 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added reading TrackId. WTI-1927

Options
    • -1
    • +30
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
    • -5
    • +61
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicLocationConfigurationDatabaseImporterTest.cs
    • binary
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/test-data/HydraulicLocationConfigurationDatabaseImporter/CorruptHrd/HLCD.sqlite
    • binary
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/test-data/HydraulicLocationConfigurationDatabaseImporter/CorruptHrd/corruptschema.sqlite
    • binary
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/test-data/HydraulicLocationConfigurationDatabaseImporter/EmptyHrd/HLCD.sqlite
    • binary
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/test-data/HydraulicLocationConfigurationDatabaseImporter/EmptyHrd/empty.sqlite
    • binary
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/test-data/HydraulicLocationConfigurationDatabaseImporter/HLCD.sqlite
    • binary
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/test-data/HydraulicLocationConfigurationDatabaseImporter/completeHrd.sqlite
11:43 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3443: WTI-1925

- Added ArgumentException when the read hydraulic location configuration database contains multiple or zero items for the database settings.

-- Added factory and factory methods to verify behaviour

-- Renamed factory methods to be more representative

- Updated logic in the importer

Options
    • -0
    • +48
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.TestUtil.Test/ReadHydraulicLocationConfigurationDatabaseSettingsTestFactoryTest.cs
    • -2
    • +24
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.TestUtil.Test/ReadHydraulicLocationConfigurationDatabaseTestFactoryTest.cs
    • -0
    • +1
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.TestUtil.Test/Ringtoets.HydraRing.IO.TestUtil.Test.csproj
    • -0
    • +43
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.TestUtil/ReadHydraulicLocationConfigurationDatabaseSettingsTestFactory.cs
    • -7
    • +20
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.TestUtil/ReadHydraulicLocationConfigurationDatabaseTestFactory.cs
    • -0
    • +1
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.TestUtil/Ringtoets.HydraRing.IO.TestUtil.csproj
    • -0
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Handlers/IHydraulicBoundaryDatabaseUpdateHandler.cs
    • -6
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
    • -9
    • +24
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicBoundaryDatabaseUpdateHandler.cs
    • -20
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Properties/Resources.Designer.cs
    • -6
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Properties/Resources.resx
    • -2
    • +38
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicBoundaryDatabaseUpdateHandlerTest.cs
11:38 am

Robert Tangerman <robert.tangerman@deltares.nl>

Made ReadTrackId public. WTI-1927

Options
    • -1
    • +1
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.IO/HydraulicBoundaryDatabase/HydraulicBoundaryDatabaseReader.cs
    • -0
    • +53
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.Test/HydraulicBoundaryDatabase/HydraulicBoundaryDatabaseReaderTest.cs
9:51 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3443: WTI-1925

- Refactored test factory and extracted private creation method to prevent code duplication.

- Renamed test

Options
    • -4
    • +3
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.TestUtil.Test/ReadHydraulicLocationConfigurationDatabaseTestFactoryTest.cs
    • -13
    • +15
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.TestUtil/ReadHydraulicLocationConfigurationDatabaseTestFactory.cs
9:43 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3443: WTI-1925

- Improved test by separating the inquiry logic from the update logic.

Options
    • -19
    • +38
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicBoundaryDatabaseImporterTest.cs
9:12 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3443: WTI-1925

- Removed the IsScenarioInformationPresent flag from the read object.

Options
    • -6
    • +3
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.IO/HydraulicLocationConfigurationDatabase/HydraulicLocationConfigurationDatabaseReader.cs
    • -11
    • +2
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.IO/HydraulicLocationConfigurationDatabase/ReadHydraulicLocationConfigurationDatabase.cs
    • -2
    • +0
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/HydraulicLocationConfigurationDatabaseReaderTest.cs
    • -4
    • +1
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/ReadHydraulicLocationConfigurationDatabaseTest.cs
    • -4
    • +0
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.TestUtil.Test/ReadHydraulicLocationConfigurationDatabaseTestFactoryTest.cs
    • -2
    • +0
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.TestUtil/ReadHydraulicLocationConfigurationDatabaseTestFactory.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicBoundaryDatabaseUpdateHandler.cs
    • -3
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicBoundaryDatabaseImporterTest.cs
    • -2
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicBoundaryDatabaseUpdateHandlerTest.cs
8:58 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3443: WTI-1925

- Return NULL when the ScenarioInformation table is missing for the read file.

Options
    • -1
    • +1
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.IO/HydraulicLocationConfigurationDatabase/HydraulicLocationConfigurationDatabaseReader.cs
    • -1
    • +1
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/HydraulicLocationConfigurationDatabaseReaderTest.cs
8:56 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3443: WTI-1925

- Changed Assert.Zero() and .NotZero() to Assert.AreEqual(0, ..) and .NotEqual(0, ...) for consistency reasons throughout the code

Options
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/Hydraulics/HydraulicLocationConfigurationSettingsTest.cs
    • -1
    • +1
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.TestUtil.Test/ReadHydraulicBoundaryDatabaseTestFactoryTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/PropertyClasses/HydraulicBoundaryDatabasePropertiesTest.cs
    • -2
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableAssessmentSectionFactoryTest.cs
    • -1
    • +1
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Read/AssessmentSectionEntityReadExtensionsTest.cs
Thursday 10 Jan 2019
4:32 pm

Dennis Tang <dennis.tang@deltares.nl>

Added migration logic: WTI-1926

- Extended test file with 2 assessment sections to verify the migration of sections with and without hydraulic boundary database.

- Fixed failing tests by saving a newer version of the Ringtoets file format

Options
    • binary
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/test-data/AssessmentSectionProvider/project.rtd
    • -1
    • +77
    /Ringtoets/Migration/src/Ringtoets.Migration.Core/EmbeddedResources/Migration_18.1_19.1.sql
    • binary
    /Ringtoets/Migration/test/Ringtoets.Migration.Core.Test/test-data/MigrationTestProject181.rtd
    • binary
    /Ringtoets/Migration/test/Ringtoets.Migration.Core.Test/test-data/MigrationTestProject191.rtd
    • -0
    • +54
    /Ringtoets/Migration/test/Ringtoets.Migration.Integration.Test/MigrationTo191IntegrationTest.cs
1:17 pm

Dennis Tang <dennis.tang@deltares.nl>

Expanded Storage integration tests: WTI-1926

- Add hydraulic boundary location settings to ensure a full integration (round) test is performed.

Options
    • -0
    • +19
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
    • -0
    • +12
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
    • -0
    • +15
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.TestUtil/RingtoetsProjectTestHelper.cs
1:14 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed obsolete cast. WTI-1926

Options
    • -1
    • +1
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/Read/HydraulicBoundaryDatabaseEntityReadExtensions.cs
1:14 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated file / storage format. WTI-1926

Options
    • -1
    • +1
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/DbContext/HydraulicBoundaryDatabaseEntity.cs
    • -4
    • +4
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/DbContext/RingtoetsEntities.edmx
    • -89
    • +89
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/DbContext/RingtoetsEntities.edmx.diagram
    • binary
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/Ringtoets.rtd
11:44 am

Dennis Tang <dennis.tang@deltares.nl>

Updated database design: WTI-1926

- Changed column type of the Year-column for the HydraulicBoundaryDatabaseEntity.

- Added auto-increment to entries in the HydraulicBoundaryDatabaseEntity table.

Options
    • -3
    • +3
    /Ringtoets/Migration/src/Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure19.1.sql
    • -3
    • +3
    /build/DatabaseStructure.sql
    • binary
    /design/DatabaseDesign.eap
11:41 am

Dennis Tang <dennis.tang@deltares.nl>

Added Read extensions for the HydraulicBoundaryDatabase(Entity). WTI-1926

Options
    • -0
    • +2
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/Read/AssessmentSectionEntityReadExtensions.cs
    • -0
    • +67
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/Read/HydraulicBoundaryDatabaseEntityReadExtensions.cs
    • -0
    • +1
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/Ringtoets.Storage.Core.csproj
    • -0
    • +101
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Read/HydraulicBoundaryDatabaseEntityReadExtensionsTest.cs
    • -0
    • +1
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Ringtoets.Storage.Core.Test.csproj
11:11 am

Dennis Tang <dennis.tang@deltares.nl>

Added Create extensions for the HydraulicBoundaryDatabase. WTI-1926

Options
    • -0
    • +2
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/Create/AssessmentSectionCreateExtensions.cs
    • -0
    • +69
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/Create/HydraulicLocationConfigurationSettingsCreateExtensions.cs
    • -0
    • +1
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/Ringtoets.Storage.Core.csproj
    • -0
    • +1
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/AssessmentSectionCreateExtensionsTest.cs
    • -0
    • +86
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/HydraulicLocationConfigurationSettingsCreateExtensionsTest.cs
    • -0
    • +1
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Ringtoets.Storage.Core.Test.csproj
11:07 am

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup. WTI-1927

Options
    • -11
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs