Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 03 Sep 2018
4:10 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3210:

- Inlined lookup dictionary within the private factory method.

WTI-1790

Options
    • -11
    • +9
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableClosingStructuresFailureMechanismFactory.cs
    • -8
    • +9
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableDuneErosionFailureMechanismFactory.cs
    • -11
    • +9
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableGrassCoverErosionInwardsFailureMechanismFactory.cs
    • -8
    • +9
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableGrassCoverErosionOutwardsFailureMechanismFactory.cs
    • -8
    • +8
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableGrassCoverSlipOffInwardsFailureMechanismFactory.cs
    • -8
    • +9
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableGrassCoverSlipOffOutwardsFailureMechanismFactory.cs
    • -11
    • +9
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableHeightStructuresFailureMechanismFactory.cs
    • -16
    • +15
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableMacroStabilityInwardsFailureMechanismFactory.cs
    • -15
    • +12
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableMacroStabilityOutwardsFailureMechanismFactory.cs
    • -8
    • +9
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableMicrostabilityFailureMechanismFactory.cs
    • -15
    • +14
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportablePipingFailureMechanismFactory.cs
    • -8
    • +9
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportablePipingStructureFailureMechanismFactory.cs
    • -11
    • +9
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableStabilityPointStructuresFailureMechanismFactory.cs
    • -8
    • +9
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableStabilityStoneCoverFailureMechanismFactory.cs
    • -8
    • +9
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableStrengthStabilityLengthwiseConstructionFailureMechanismFactory.cs
  16. … 3 more files in changeset.
3:18 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3210:

- Introduced overloaded constructor without section assembly results.

- Replaced instantiations in the failure mechanism factory

WTI-1790

Options
    • -1
    • +14
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Assembly/ExportableFailureMechanism.cs
    • -2
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableFailureMechanismFactory.cs
    • -3
    • +41
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Assembly/ExportableFailureMechanismTest.cs
3:10 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3210:

- Renamed factory

- Cleaned up src file:

-- Renamed function arguments

-- Updated XMLDoc

WTI-1790

Options
    • -13
    • +13
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/AggregatedSerializableCombinedFailureMechanismSectionAssembliesCreator.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableAssessmentSectionFactory.cs
    • -116
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableCombinedSectionAssemblyCollectionFactory.cs
    • -0
    • +116
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableCombinedSectionAssemblyFactory.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Ringtoets.Integration.IO.csproj
    • -2
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/AggregatedSerializableCombinedFailureMechanismSectionAssembliesCreatorTest.cs
    • -217
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableCombinedSectionAssemblyCollectionFactoryTest.cs
    • -0
    • +217
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableCombinedSectionAssemblyFactoryTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Ringtoets.Integration.IO.Test.csproj
2:53 pm

Dennis Tang <dennis.tang@deltares.nl>

Fixed failing tests:

- Fixed IDs for serializable components.

WTI-1789

Options
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/SerializableAssessmentProcessCreatorTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/SerializableAssessmentSectionCreatorTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/SerializableTotalAssemblyResultCreatorTest.cs
2:32 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup:

- Introduced testhelper to generate invalid ID

WTI-1789

Options
    • -3
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableAssemblyTest.cs
    • -3
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableAssessmentProcessTest.cs
    • -3
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableAssessmentSectionTest.cs
    • -3
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableCombinedFailureMechanismSectionAssemblyTest.cs
    • -3
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableFailureMechanismSectionAssemblyTest.cs
    • -6
    • +2
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableFailureMechanismSectionCollectionTest.cs
    • -3
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableFailureMechanismSectionTest.cs
    • -3
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableFailureMechanismTest.cs
    • -3
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableTotalAssemblyResultTest.cs
2:12 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup:

- Introduced testhelper to generate invalid ids for the serializable elements.

WTI-1789

Options
    • -0
    • +54
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.TestUtil.Test/InvalidIdTestHelperTest.cs
    • -0
    • +11
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.TestUtil.Test/Ringtoets.AssemblyTool.IO.TestUtil.Test.csproj
    • -0
    • +26
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.TestUtil.Test/packages.config
    • -0
    • +46
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.TestUtil/InvalidIdTestHelper.cs
    • -0
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.TestUtil/Ringtoets.AssemblyTool.IO.TestUtil.csproj
1:53 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup:

- Added IO.TestUtil.Test project

-- Added to test a testhelper for generating testcases representing invalid ids

WTI-1789

Options
    • -0
    • +15
    /Ringtoets.sln
    • -0
    • +25
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.TestUtil.Test/Properties/AssemblyInfo.cs
    • -0
    • +22
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.TestUtil.Test/Ringtoets.AssemblyTool.IO.TestUtil.Test.csproj
1:49 pm

Elmar Kleijn

Removed variable 64 from Hydra-Ring structures input. WTI-1800

Options
    • -87
    • +83
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Data/Input/Structures/StructuresStabilityPointLowSillLinearCalculationInputTest.cs
1:40 pm

Elmar Kleijn

Removed variable 64 from Hydra-Ring structures input. WTI-1800

Options
    • -87
    • +84
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Data/Input/Structures/StructuresStabilityPointFloodedCulvertQuadraticCalculationInputTest.cs
1:18 pm

Elmar Kleijn

Removed variable 64 from Hydra-Ring structures input. WTI-1800

Options
    • -63
    • +63
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Data/Input/Structures/StructuresStabilityPointCalculationInputTest.cs
    • -87
    • +83
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Data/Input/Structures/StructuresStabilityPointFloodedCulvertLinearCalculationInputTest.cs
1:00 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup:

- Fixed failing tests

WTI-1789

Options
    • -1
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/Helpers/IdValidatorTest.cs
    • -1
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableFailureMechanismSectionTest.cs
12:59 pm

Dennis Tang <dennis.tang@deltares.nl>

Added Id validation for the serializable model:

- Applied for the total assembly result.

WTI-1789

Options
    • -4
    • +6
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableTotalAssemblyResult.cs
    • -5
    • +21
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableTotalAssemblyResultTest.cs
12:55 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. WTI-1821

Options
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Helpers/ExportableFailureMechanismSectionHelper.cs
    • -2
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableAssessmentSectionFactoryTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableCombinedSectionAssemblyCollectionFactoryTest.cs
12:53 pm

Dennis Tang <dennis.tang@deltares.nl>

Added Id validation for the serializable model:

- Applied for the section collection.

WTI-1789

Options
    • -7
    • +9
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableFailureMechanismSectionCollection.cs
    • -22
    • +48
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableFailureMechanismSectionCollectionTest.cs
12:51 pm

Elmar Kleijn

Removed variable 64 from Hydra-Ring structures input. WTI-1800

Options
    • -75
    • +69
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Data/Input/Structures/StructuresStabilityPointCalculationInputTest.cs
12:40 pm

Elmar Kleijn

Removed variable 64 from Hydra-Ring structures input. WTI-1800

Options
    • -10
    • +7
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Data/Input/Structures/StructuresClosureLowSillCalculationInputTest.cs
12:39 pm

Elmar Kleijn

Removed variable 64 from Hydra-Ring structures input. WTI-1800

Options
    • -2
    • +0
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
    • -18
    • +0
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Service.Test/StabilityPointStructuresCalculationServiceTest.cs
12:36 pm

Elmar Kleijn

Removed variable 64 from Hydra-Ring structures input. WTI-1800

Options
    • -1
    • +0
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
    • -4
    • +0
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Data/Input/Structures/StructuresStabilityPointFloodedCulvertLinearCalculationInput.cs
    • -4
    • +0
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Data/Input/Structures/StructuresStabilityPointFloodedCulvertQuadraticCalculationInput.cs
    • -4
    • +0
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Data/Input/Structures/StructuresStabilityPointLowSillLinearCalculationInput.cs
    • -4
    • +0
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Data/Input/Structures/StructuresStabilityPointLowSillQuadraticCalculationInput.cs
    • -8
    • +0
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Service/StabilityPointStructuresCalculationService.cs
12:25 pm

Elmar Kleijn

Removed variable 64 from Hydra-Ring structures input. WTI-1800

Options
    • -8
    • +0
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Data/Input/Structures/StructuresClosureLowSillCalculationInput.cs
    • -8
    • +0
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Data/Input/Structures/StructuresStabilityPointCalculationInput.cs
12:03 pm

Dennis Tang <dennis.tang@deltares.nl>

Added Id validation for the serializable model:

- Applied for the section assembly

WTI-1789

Options
    • -4
    • +5
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableFailureMechanismSectionAssembly.cs
    • -6
    • +25
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableFailureMechanismSectionAssemblyTest.cs
12:01 pm

Dennis Tang <dennis.tang@deltares.nl>

Added Id validation for the serializable model:

- Applied for the failure mechanism

WTI-1789

Options
    • -5
    • +5
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableFailureMechanism.cs
    • -6
    • +25
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableFailureMechanismTest.cs
12:00 pm

Dennis Tang <dennis.tang@deltares.nl>

Added Id validation for the serializable model:

- Applied for the combined failure mechanism section assembly

WTI-1789

Options
    • -4
    • +5
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableCombinedFailureMechanismSectionAssembly.cs
    • -6
    • +22
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableCombinedFailureMechanismSectionAssemblyTest.cs
11:54 am

Dennis Tang <dennis.tang@deltares.nl>

Added Id validation for the serializable model:

- Applied for the assessment section.

WTI-1789

Options
    • -8
    • +8
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableAssessmentSection.cs
    • -6
    • +23
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableAssessmentSectionTest.cs
11:51 am

Dennis Tang <dennis.tang@deltares.nl>

Added Id validation for the serializable model:

- Applied for the assessment process

WTI-1789

Options
    • -4
    • +5
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableAssessmentProcess.cs
    • -6
    • +19
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableAssessmentProcessTest.cs
11:43 am

Dennis Tang <dennis.tang@deltares.nl>

Added Id validation for the serializable model:

- Applied for the serializable failure mechanism section

WTI-1789

Options
    • -9
    • +9
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableFailureMechanismSection.cs
    • -5
    • +25
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableFailureMechanismSectionTest.cs
11:38 am

Dennis Tang <dennis.tang@deltares.nl>

Added Id validation for the serializable model:

- Applied for the serializable assembly.

WTI-1789

Options
    • -4
    • +5
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableAssembly.cs
    • -6
    • +31
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableAssemblyTest.cs
11:38 am

Robert Tangerman <robert.tangerman@deltares.nl>

Final improvements after review. WTI-1714

Options
    • -2
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/DesignWaterLevelCalculationCategoryBoundaryProperties.cs
    • -2
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/DesignWaterLevelCalculationProperties.cs
    • -1
    • +2
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Service/MacroStabilityInwardsInputValidator.cs
11:38 am

Robert Tangerman <robert.tangerman@deltares.nl>

Final improvements after review. WTI-1714

Options
    • -2
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/DesignWaterLevelCalculationCategoryBoundaryProperties.cs
    • -2
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/DesignWaterLevelCalculationProperties.cs
    • -1
    • +2
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Service/MacroStabilityInwardsInputValidator.cs
10:41 am

Dennis Tang <dennis.tang@deltares.nl>

Introduced helper to verify the validity of an id in the serializable model. WTI-1789

Options
    • -0
    • +50
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/Helpers/IdValidator.cs
    • -0
    • +1
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Ringtoets.AssemblyTool.IO.csproj
    • -0
    • +79
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/Helpers/IdValidatorTest.cs
    • -0
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Ringtoets.AssemblyTool.IO.Test.csproj
10:21 am

Dennis Tang <dennis.tang@deltares.nl>

Fixed failing test:

- Changed reference gml file, as the sequence constraints enforces a fixed order of elements.

WTI-1789

Options
    • -11
    • +11
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/test-data/SerializableAssemblyWriterTest/configuredAssembly.gml