Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 06 Apr 2018
1:52 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2638: - Fixed inconsistent test names in the read extensions - Added ArgumentNullException when entity is NULL for the PipingSectionResultEntityReadExtension

WTI-1665

Options
    • -1
    • +6
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/Piping/PipingSectionResultEntityReadExtensions.cs
    • -2
    • +2
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/ClosingStructures/ClosingStructuresSectionResultEntityReadExtensionsTest.cs
    • -2
    • +2
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/GrassCoverErosionInwards/GrassCoverErosionInwardsSectionResultEntityReadExtensionsTest.cs
    • -2
    • +2
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/HeightStructures/HeightStructuresSectionResultEntityReadExtensionsTest.cs
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/MacroStabilityInwards/MacroStabilityInwardsSectionResultEntityReadExtensionsTest.cs
    • -1
    • +13
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/Piping/PipingSectionResultEntityReadExtensionsTest.cs
    • -2
    • +2
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/StabilityPointStructures/StabilityPointStructuresSectionResultEntityReadExtensionsTest.cs
1:38 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2638: - Fixed inconsistent test names in the create extensions - Added missing assert: parameter name was not asserted when persistence registry was null

WTI-1665

Options
    • -2
    • +3
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/ClosingStructures/ClosingStructuresFailureMechanismSectionResultCreateExtensionsTest.cs
    • -8
    • +5
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/GrassCoverErosionInwards/GrassCoverErosionInwardsFailureMechanismSectionResultCreateExtensionsTest.cs
    • -1
    • +2
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/HeightStructures/HeightStructuresFailureMechanismSectionResultCreateExtensionsTest.cs
    • -2
    • +3
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/StabilityPointStructures/StabilityPointStructuresFailureMechanismSectionResultCreateExtensionsTest.cs
1:33 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2638: - Fixed inconsistent test names

WTI-1665

Options
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsFailureMechanismSectionResultCreateExtensionsTest.cs
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/Piping/PipingFailureMechanismSectionResultCreateExtensionsTest.cs
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/StabilityPointStructures/StabilityPointStructuresFailureMechanismSectionResultCreateExtensionsTest.cs
1:31 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2638: - Removed obsolete attribute - Formatting

WTI-1665

Options
    • -1
    • +0
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/GrassCoverErosionInwards/GrassCoverErosionInwardsFailureMechanismSectionResultCreateExtensionsTest.cs
    • -1
    • +0
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/HeightStructures/HeightStructuresFailureMechanismSectionResultCreateExtensionsTest.cs
    • -0
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
1:15 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated database design for failure mechanism section results in group 3 (WaveImpactAsphaltCover, DuneErosion, GrassCoverErosionOutwards, StabilityStoneCover)

WTI-1667

Options
    • binary
    /design/DatabaseDesign.eap
12:02 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Renamed ObservableTestAssessmentSectionStub to AssessmentSectionStub WTI-1612

Options
    • -1
    • +1
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
    • -15
    • +15
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismViewTest.cs
    • -5
    • +5
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Plugin.Test/ViewInfos/ClosingStructuresFailureMechanismViewInfoTest.cs
    • -6
    • +6
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/AssessmentSection/AssessmentSectionExtensionsTest.cs
    • -0
    • +191
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil.Test/AssessmentSectionStubTest.cs
    • -191
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil.Test/ObservableTestAssessmentSectionStubTest.cs
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil.Test/Ringtoets.Common.Data.TestUtil.Test.csproj
    • -0
    • +212
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil/AssessmentSectionStub.cs
    • -212
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil/ObservableTestAssessmentSectionStub.cs
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil/Ringtoets.Common.Data.TestUtil.csproj
    • -2
    • +2
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Factories/RingtoetsMapDataFeaturesFactoryTest.cs
    • -8
    • +8
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Views/FailureMechanismViewTest.cs
    • -2
    • +2
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Views/HydraulicBoundaryCalculationsViewTest.cs
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Forms.TestUtil.Test/MapViewTestHelperTest.cs
    • -2
    • +2
    /Ringtoets/Common/test/Ringtoets.Common.Util.Test/AggregatedHydraulicBoundaryLocationFactoryTest.cs
  16. … 74 more files in changeset.
10:45 am

Dennis Tang <dennis.tang@deltares.nl>

Merge branch '1601'

Options
    • -0
    • +41
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
10:44 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2633: - Cleaned up files - Updated XMLDoc - Cleaned up SQL query formatting

WTI-1656

Options
    • -1
    • +1
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Create/HydraulicBoundaryLocationCalculationCollectionCreateExtensions.cs
    • -3
    • +3
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Create/HydraulicBoundaryLocationCalculationCreateExtensions.cs
    • -3
    • +3
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/HydraulicLocationCalculationCollectionReadExtensions.cs
    • -37
    • +25
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/AssessmentSectionCreateExtensionsTest.cs
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo171IntegrationTest.cs
    • -3
    • +3
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo172IntegrationTest.cs
    • -32
    • +32
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
    • -1
    • +0
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/AssessmentSectionEntityReadExtensionsTest.cs
    • -10
    • +9
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/HydraulicLocationCalculationEntityReadExtensionsTest.cs
    • -2
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil/Hydraulics/HydraulicLocationEntityTestFactory.cs
10:41 am

Carlos Lubbers

Final cleanup after review WTI-1657

Paired with dennis tang

Options
    • -2
    • +0
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Create/GrassCoverErosionOutwards/GrassCoverErosionOutwardsFailureMechanismCreateExtensions.cs
    • -1
    • +0
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/FailureMechanismEntityReadExtensions.cs
    • -27
    • +21
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/GrassCoverErosionOutwards/GrassCoverErosionOutwardsFailureMechanismCreateExtensionsTest.cs
8:39 am

Robert Tangerman <robert.tangerman@deltares.nl>

Merge branch '1612'

Options
8:39 am

Dennis Tang <dennis.tang@deltares.nl>

Cleanup: Fixed failing test by migrating 173 to 181 in order to be able to open the latest .rtd file

WTI-1666

Options
    • binary
    /Application/Ringtoets/test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject181.rtd
8:34 am

Dennis Tang <dennis.tang@deltares.nl>

Updated migration script in group 2 (piping, macrostability inwards)

WTI-1666

Options
    • -2
    • +38
    /Application/Ringtoets/src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • -0
    • +41
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
Thursday 05 Apr 2018
5:07 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated storage integration tests in group 2 (piping, macrostability inwards)

WTI-1666

Options
    • -4
    • +12
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
    • -2
    • +10
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
4:57 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleaned up some tests: - Removed obsolete variables - Renamed variables: ManualAssessmentProbability --> ManualAssemblyProbability

WTI-1666

Options
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/ClosingStructures/ClosingStructuresFailureMechanismSectionResultCreateExtensionsTest.cs
    • -6
    • +6
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/GrassCoverErosionInwards/GrassCoverErosionInwardsFailureMechanismSectionResultCreateExtensionsTest.cs
    • -6
    • +6
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/StabilityPointStructures/StabilityPointStructuresFailureMechanismSectionResultCreateExtensionsTest.cs
    • -4
    • +0
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/GrassCoverErosionInwards/GrassCoverErosionInwardsSectionResultEntityReadExtensionsTest.cs
4:56 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated Create and Read extensions for failure mechanism section results in group 2 (piping, macrostability inwards)

WTI-1666

Options
    • -3
    • +13
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Create/MacroStabilityInwards/MacroStabilityInwardsFailureMechanismSectionResultCreateExtensions.cs
    • -2
    • +12
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Create/Piping/PipingFailureMechanismSectionResultCreateExtensions.cs
    • -4
    • +9
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/MacroStabilityInwards/MacroStabilityInwardsSectionResultEntityReadExtensions.cs
    • -6
    • +10
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/Piping/PipingSectionResultEntityReadExtensions.cs
    • -5
    • +0
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsFailureMechanismCreateExtensionsTest.cs
    • -12
    • +36
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsFailureMechanismSectionResultCreateExtensionsTest.cs
    • -12
    • +35
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/Piping/PipingFailureMechanismSectionResultCreateExtensionsTest.cs
    • -29
    • +22
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/MacroStabilityInwards/MacroStabilityInwardsSectionResultEntityReadExtensionsTest.cs
    • -28
    • +21
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/Piping/PipingSectionResultEntityReadExtensionsTest.cs
4:16 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated database design for failure mechanism section results in group 2 (piping, macrostability inwards) - Generated entities and .sql files for the database structure

WTI-1666

Options
    • -5
    • +13
    /Application/Ringtoets/src/Application.Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure18.1.sql
    • -2
    • +6
    /Application/Ringtoets/src/Application.Ringtoets.Storage/DbContext/MacroStabilityInwardsSectionResultEntity.cs
    • -2
    • +6
    /Application/Ringtoets/src/Application.Ringtoets.Storage/DbContext/PipingSectionResultEntity.cs
    • -12
    • +36
    /Application/Ringtoets/src/Application.Ringtoets.Storage/DbContext/RingtoetsEntities.edmx
    • -86
    • +86
    /Application/Ringtoets/src/Application.Ringtoets.Storage/DbContext/RingtoetsEntities.edmx.diagram
    • binary
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Ringtoets.rtd
    • -5
    • +13
    /build/DatabaseStructure.sql
4:02 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated database design for failure mechanism section results in group 2 (piping, macrostability inwards)

WTI-1666

Options
    • binary
    /design/DatabaseDesign.eap
3:00 pm

Dennis Tang <dennis.tang@deltares.nl>

Fixed XMLDoc, corrected <see cref=""> to <paramref name="">

WTI-1665

Options
    • -1
    • +1
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Plugin/FileImporters/GrassCoverErosionInwardsDikeProfileUpdateDataStrategy.cs
2:56 pm

Elmar Kleijn

Removed redundant properties from HydraulicBoundaryLocation. WTI-1612

Options
    • -58
    • +12
    /Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/RingtoetsDataSynchronizationServiceTest.cs
2:52 pm

Elmar Kleijn

Removed redundant properties from HydraulicBoundaryLocation. WTI-1612

Options
    • -64
    • +60
    /Demo/Ringtoets/test/Demo.Ringtoets.Test/Commands/AddNewDemoAssessmentSectionCommandTest.cs
2:49 pm

Dennis Tang <dennis.tang@deltares.nl>

Merge branch 'master' into 1601

Options
2:47 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup: Fixed failing test by migrating 173 to 181 in order to be able to open the latest .rtd file

WTI-1665

Options
    • binary
    /Application/Ringtoets/test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject181.rtd
2:37 pm

Elmar Kleijn

Removed redundant properties from HydraulicBoundaryLocation. WTI-1612

Options
    • -41
    • +46
    /Demo/Ringtoets/src/Demo.Ringtoets/Commands/AddNewDemoAssessmentSectionCommand.cs
2:34 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted migration script for the remaining failure mechanism section result in group 1 (GrassCoverErosionInwards, StabilityPointStructures, ClosingStructures)

WTI-1665

Options
    • -4
    • +64
    /Application/Ringtoets/src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • -0
    • +68
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
2:32 pm

Elmar Kleijn

Removed redundant properties from HydraulicBoundaryLocation. WTI-1612

Options
    • -18
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil.Test/TestHydraulicBoundaryLocationTest.cs
    • -6
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/PropertyClasses/NormPropertiesIntegrationTest.cs
2:31 pm

Elmar Kleijn

Removed redundant properties from HydraulicBoundaryLocation. WTI-1612

Options
    • -14
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Service/RingtoetsCommonDataSynchronizationService.cs
    • -45
    • +2
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/RingtoetsCommonDataSynchronizationServiceTest.cs
2:29 pm

Elmar Kleijn

Removed redundant properties from HydraulicBoundaryLocation. WTI-1612

Options
    • -37
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Data/Hydraulics/HydraulicBoundaryLocation.cs
    • -7
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/Hydraulics/HydraulicBoundaryLocationTest.cs
2:01 pm

Elmar Kleijn

Merge branch 'master' into 1612

Options
1:58 pm

Elmar Kleijn

Fixed failing tests. WTI-1612

Options
    • -13
    • +24
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/FailureMechanismContributionNormChangeHandlerTest.cs
1:56 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated storage integration tests for the remaining failure mechanism section result in group 1 (GrassCoverErosionInwards, StabilityPointStructures, ClosingStructures)

WTI-1665

Options
    • -6
    • +21
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
    • -3
    • +18
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs