Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 30 Jul 2018
10:19 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3105:

- Renamed categoryLimits --> categories

WTI-1763

Options
    • -2
    • +2
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/Assembly/FailureMechanismAssemblyCalculator.cs
    • -30
    • +30
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Creators/AssemblyCategoryCreator.cs
    • -1
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Calculators/Assembly/FailureMechanismAssemblyCalculatorTest.cs
    • -30
    • +30
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Creators/AssemblyCategoryCreatorTest.cs
    • -6
    • +6
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil.Test/Kernels/Assembly/FailureMechanismAssemblyKernelStubTest.cs
    • -3
    • +3
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil/Kernels/Assembly/FailureMechanismAssemblyKernelStub.cs
10:07 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3105:

- Ran Cleanup

- Merged properties into a single property as on calling side it is still possible to determine which function was called

- Cleaned up src and tests by extracting common knowledge in separate functions

- Updated XMLDoc

WTI-1763

Options
    • -4
    • +3
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/Assembly/AssessmentSectionAssemblyCalculator.cs
    • -25
    • +13
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/Assembly/FailureMechanismSectionAssemblyCalculator.cs
    • -2
    • +2
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/Assembly/IAssessmentSectionAssemblyCalculator.cs
    • -47
    • +33
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Calculators/Assembly/FailureMechanismSectionAssemblyCalculatorTest.cs
    • -4
    • +4
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Calculators/Categories/AssemblyCategoriesCalculatorTest.cs
    • -0
    • +4
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil.Test/Calculators/Assembly/FailureMechanismSectionAssemblyCalculatorStubTest.cs
    • -10
    • +9
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil.Test/Kernels/Categories/AssemblyCategoriesKernelStubTest.cs
    • -4
    • +0
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil.Test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil.Test.csproj
    • -1
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil/CombinedFailureMechanismSectionsInputAssert.cs
    • -9
    • +4
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil/Kernels/Categories/AssemblyCategoriesKernelStub.cs
Friday 27 Jul 2018
3:30 pm

Dennis Tang <dennis.tang@deltares.nl>

Fixed failing test. WTI-1759

Options
    • -1
    • +1
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Read/FailureMechanismEntityReadExtensionsTest.cs
3:10 pm

Dennis Tang <dennis.tang@deltares.nl>

Fixed Migration logic:

- Migrate failuremechanisms with failuremechanism sections by inserting an empty string; null if otherwise.

- Updated 181 test project to the latest version.

WTI-1759

Options
    • -1
    • +23
    /Ringtoets/Migration/src/Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • binary
    /Ringtoets/Migration/test/Ringtoets.Migration.Core.Test/test-data/MigrationTestProject181.rtd
    • -0
    • +32
    /Ringtoets/Migration/test/Ringtoets.Migration.Integration.Test/MigrationTo181IntegrationTest.cs
2:27 pm

Dennis Tang <dennis.tang@deltares.nl>

Fixed failing tests:

- Fixed reference project that's being used for the Merge functionality

- Fixed failing tests in the storage

WTI-1759

Options
    • binary
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/test-data/AssessmentSectionProvider/project.rtd
    • -1
    • +2
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/Create/GrassCoverErosionInwards/GrassCoverErosionInwardsFailureMechanismCreateExtensions.cs
    • -1
    • +1
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/HeightStructures/HeightStructuresFailureMechanismCreateExtensionsTest.cs
    • -2
    • +2
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/WaterPressureAsphaltCover/WaterPressureAsphaltCoverFailureMechanismCreateExtensionsTest.cs
    • -0
    • +1
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Read/FailureMechanismEntityReadExtensionsTest.cs
2:24 pm

Carlos Lubbers

Fix failing test WTI-1751

Options
    • -1
    • +1
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Read/FailureMechanismEntityReadExtensionsTest.cs
2:12 pm

Carlos Lubbers

Improve section collection class with better validation and source path setting WTI-1751

Options
    • -25
    • +26
    /Ringtoets/Common/src/Ringtoets.Common.Data/FailureMechanism/FailureMechanismSectionCollection.cs
    • -9
    • +10
    /Ringtoets/Common/src/Ringtoets.Common.Data/Properties/Resources.Designer.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Data/Properties/Resources.resx
    • -3
    • +23
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/FailureMechanism/FailureMechanismSectionCollectionTest.cs
1:27 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted integration tests:

- Also assert the sourcepath for the failure mechanism sections to ensure that storage works correctly

WTI-1759

Options
    • -0
    • +1
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
    • -0
    • +11
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
    • -2
    • +2
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.TestUtil/RingtoetsProjectTestHelper.cs
12:01 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted Read extensions:

- Included reading the failure mechanism sections sourcepath from the rtd file

- Cleaned up tests:

-- On assessment section level, only the first direct layer needs to be asserted. Cleaned up file for consistency

WTI-1759

Options
    • -1
    • +4
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/Read/FailureMechanismEntityReadExtensions.cs
    • -822
    • +59
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Read/AssessmentSectionEntityReadExtensionsTest.cs
    • -9
    • +237
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Read/FailureMechanismEntityReadExtensionsTest.cs
10:40 am

Elmar Kleijn

Adapted rounding of Contribution property in PipingScenarioRow. WTI-892

Options
    • -3
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsScenarioRowTest.cs
    • -1
    • +1
    /Ringtoets/Piping/src/Ringtoets.Piping.Forms/Views/PipingScenarioRow.cs
    • -2
    • +2
    /Ringtoets/Piping/test/Ringtoets.Piping.Forms.Test/Views/PipingScenarioRowTest.cs
10:30 am

Elmar Kleijn

Adapted rounding of Contribution property in MacroStabilityInwardsScenarioRow. WTI-892

Options
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsScenarioRow.cs
    • -4
    • +7
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsScenarioRowTest.cs
10:01 am

Elmar Kleijn

Adapted GetDetailedAssessmentProbability related tests. WTI-892

Options
    • -5
    • +5
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsFailureMechanismSectionResultDetailedAssessmentExtensionsTest.cs
    • -3
    • +5
    /Ringtoets/Piping/test/Ringtoets.Piping.Data.Test/PipingFailureMechanismSectionResultDetailedAssessmentExtensionsTest.cs
9:53 am

Dennis Tang <dennis.tang@deltares.nl>

Adjusted Create extensions:

- Write the sourcepath to the entity

- Cleaned up and simplified tests

-- Attempted to make tests consistent between the various extensions.

WTI-1759

Options
    • -1
    • +2
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/Create/FailureMechanismCreateExtensions.cs
    • -30
    • +13
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/ClosingStructures/ClosingStructuresFailureMechanismCreateExtensionsTest.cs
    • -11
    • +8
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/DuneErosion/DuneErosionFailureMechanismCreateExtensionsTest.cs
    • -9
    • +10
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/FailureMechanismCreateExtensionsTest.cs
    • -16
    • +16
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/GrassCoverErosionInwards/GrassCoverErosionInwardsFailureMechanismCreateExtensionsTest.cs
    • -11
    • +8
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/GrassCoverErosionOutwards/GrassCoverErosionOutwardsFailureMechanismCreateExtensionsTest.cs
    • -11
    • +9
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/GrassCoverSlipOffInwards/GrassCoverSlipOffInwardsFailureMechanismCreateExtensionsTest.cs
    • -11
    • +9
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/GrassCoverSlipOffOutwards/GrassCoverSlipOffOutwardsFailureMechanismCreateExtensionsTest.cs
    • -62
    • +15
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/HeightStructures/HeightStructuresFailureMechanismCreateExtensionsTest.cs
    • -2
    • +6
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/MacroStabilityInwards/MacroStabilityInwardsFailureMechanismCreateExtensionsTest.cs
    • -11
    • +9
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/MacrostabilityOutwards/MacroStabilityOutwardsFailureMechanismCreateExtensionsTest.cs
    • -11
    • +9
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/Microstability/MicrostabilityFailureMechanismCreateExtensionsTest.cs
    • -2
    • +19
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/Piping/PipingFailureMechanismCreateExtensionsTest.cs
    • -11
    • +7
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/PipingStructure/PipingStructureFailureMechanismCreateExtensionsTest.cs
    • -32
    • +12
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/StabilityPointStructures/StabilityPointStructuresFailureMechanismCreateExtensionsTest.cs
  16. … 5 more files in changeset.
9:30 am

Carlos Lubbers

Call base ClearSectionResults method WTI-1751

Options
    • -0
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/FailureMechanism/FailureMechanismBaseTest.cs
9:03 am

Elmar Kleijn

Adapted GetTotalContribution related tests. WTI-892

Options
    • -3
    • +3
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsFailureMechanismSectionResultDetailedAssessmentExtensionsTest.cs
    • -3
    • +3
    /Ringtoets/Piping/test/Ringtoets.Piping.Data.Test/PipingFailureMechanismSectionResultDetailedAssessmentExtensionsTest.cs
8:30 am

Elmar Kleijn

Adapted rounding of Contribution property in MacroStabilityInwardsCalculationScenario. WTI-892

Options
    • -2
    • +1
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsCalculationScenario.cs
    • -5
    • +11
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsCalculationScenarioTest.cs
8:25 am

Elmar Kleijn

Adapted rounding of Contribution property in PipingCalculationScenario. WTI-892

Options
    • -1
    • +1
    /Ringtoets/Piping/src/Ringtoets.Piping.Data/PipingCalculationScenario.cs
    • -5
    • +8
    /Ringtoets/Piping/test/Ringtoets.Piping.Data.Test/PipingCalculationScenarioTest.cs
Thursday 26 Jul 2018
4:11 pm

Elmar Kleijn

Review related changes. WTI-1750

Options
    • -34
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Merge/AssessmentSectionProviderTest.cs
2:13 pm

Elmar Kleijn

Adapted HydraulicLocationConfigurationDatabaseReader related test-data. WTI-1766

Options
    • binary
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.Test/test-data/HydraulicLocationConfigurationDatabase/noUsePreprocessorColumn.sqlite
2:00 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted database design:

- Regenerated entities and the Ringtoets.rtd

WTI-1759

Options
    • -0
    • +1
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/DbContext/FailureMechanismEntity.cs
    • -0
    • +3
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/DbContext/RingtoetsEntities.edmx
    • -84
    • +84
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/DbContext/RingtoetsEntities.edmx.diagram
    • binary
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/Ringtoets.rtd
1:58 pm

Robert Tangerman <robert.tangerman@deltares.nl>

DisplayName should be set every time you reset the DataSource. WTI-1750

Options
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Merge/AssessmentSectionMergeDataProviderDialog.cs
1:53 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Close views of failure mechanisms that are being merged. WTI-1747

Options
    • -3
    • +28
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Merge/AssessmentSectionMergeHandler.cs
    • -2
    • +61
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Merge/AssessmentSectionMergeHandlerTest.cs
1:42 pm

Elmar Kleijn

Removed preprocessor logic from HydraulicLocationConfigurationDatabaseReader. WTI-1766

Options
    • -1
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/HydraulicBoundaryDatabaseImporter.cs
    • -12
    • +0
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.IO/HydraulicLocationConfigurationDatabase/HydraulicLocationConfigurationDatabaseQueryBuilder.cs
    • -68
    • +1
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.IO/HydraulicLocationConfigurationDatabase/HydraulicLocationConfigurationDatabaseReader.cs
    • -34
    • +0
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.IO/HydraulicLocationConfigurationDatabase/RegionsTableDefinitions.cs
    • -34
    • +0
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.IO/HydraulicLocationConfigurationDatabase/TracksTableDefinitions.cs
    • -3
    • +0
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.IO/Ringtoets.HydraRing.IO.csproj
    • -11
    • +0
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/HydraulicLocationConfigurationDatabaseQueryBuilderTest.cs
    • -95
    • +0
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/HydraulicLocationConfigurationDatabaseReaderTest.cs
    • -38
    • +0
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/RegionsTableDefinitionsTest.cs
    • -38
    • +0
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/TracksTableDefinitionsTest.cs
    • -2
    • +0
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.Test/Ringtoets.HydraRing.IO.Test.csproj
1:41 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted database design:

- Regenerated SQL scripts

WTI-1759

Options
    • -1
    • +2
    /Ringtoets/Migration/src/Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure18.1.sql
    • -1
    • +2
    /build/DatabaseStructure.sql
1:40 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted database design:

- Adjusted FailureMechanismEntity table to include a column for storing the source path of the failure mechanism section collection.

WTI-1759

Options
    • binary
    /design/DatabaseDesign.eap
1:19 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Only log HR merge message when there is something merged. WTI-1747

Options
    • -1
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Merge/AssessmentSectionMergeHandler.cs
    • -49
    • +66
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Merge/AssessmentSectionMergeHandlerTest.cs
1:19 pm

Elmar Kleijn

Removed preprocessor logic from ReadHydraulicBoundaryDatabase. WTI-1766

Options
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/HydraulicBoundaryDatabaseImporter.cs
    • -8
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/ReadHydraulicBoundaryDatabase.cs
    • -5
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/FileImporters/ReadHydraulicBoundaryDatabaseTest.cs
1:07 pm

Elmar Kleijn

Adapted HydraulicBoundaryDatabaseImporter related test-data. WTI-1766

Options
    • -3
    • +2
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/FileImporters/HydraulicBoundaryDatabaseImporterTest.cs
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/HydraulicBoundaryDatabaseImporter/withUsePreprocessor/HLCD.sqlite
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/HydraulicBoundaryDatabaseImporter/withUsePreprocessor/completeUsePreprocessorFalse.config.sqlite
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/HydraulicBoundaryDatabaseImporter/withUsePreprocessor/completeUsePreprocessorFalse.sqlite
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/HydraulicBoundaryDatabaseImporter/withUsePreprocessor/completeUsePreprocessorTrue.config.sqlite
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/HydraulicBoundaryDatabaseImporter/withUsePreprocessor/completeUsePreprocessorTrue.sqlite
1:04 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup for storage:

- Removed remaining checks for the preprocessor.

WTI-1766

Options
    • -6
    • +0
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Read/AssessmentSectionEntityReadExtensionsTest.cs
    • -3
    • +0
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
    • -4
    • +1
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.TestUtil/RingtoetsProjectTestHelper.cs
12:53 pm

Elmar Kleijn

Removed preprocessor logic from HydraulicBoundaryDatabaseImporter. WTI-1766

Options
    • -11
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/HydraulicBoundaryDatabaseImporter.cs
    • -34
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/FileImporters/HydraulicBoundaryDatabaseImporterTest.cs