Riskeer / Application / Ringtoets

src

Clone Tools

Stats

Commits this week: 0
Total Committers: 10
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 24 May 2018
12:04 pm

Dennis Tang <dennis.tang@deltares.nl>

Finalise release, made 18.1 compatible with the 'new' 17.3 release: - Adjusted migration script, table HydraRingpreprocessorEntity does not exist in the new 17.3 release -- Adjusted testfile, reopened and saved the test file in the 'new' 17.3 release to get rid of the HydraRingPreprocessorEntityTable

WTI-1710

Options
    • -1
    • +0
    ./Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
  2. … 2 more files in changeset.
Wednesday 23 May 2018
2:22 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2824, rename SetDuneLocationCalculations to SetDuneLocations: - Made the DuneLocations property an IObservableEnumerable --> modifications should not be possible from outside the SetDuneLocations() method to prevent the calculations from getting out of sync with the locations

WTI-1574

Options
    • -6
    • +5
    ./Application.Ringtoets.Storage/Read/FailureMechanismEntityReadExtensions.cs
  2. … 18 more files in changeset.
1:33 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2824: - Renamed DuneLocationOutput to DuneLocationCalculationOutput -- Adjusted CreateExtension file names -- Updated function and parameter names where necessary.

WTI-1574

Options
    • -1
    • +1
    ./Application.Ringtoets.Storage/Application.Ringtoets.Storage.csproj
    • -0
    • +58
    ./Application.Ringtoets.Storage/Create/DuneErosion/DuneLocationCalculationOutputCreateExtensions.cs
    • -2
    • +2
    ./Application.Ringtoets.Storage/Create/DuneErosion/DuneLocationCreateExtensions.cs
    • -58
    • +0
    ./Application.Ringtoets.Storage/Create/DuneErosion/DuneLocationOutputCreateExtensions.cs
    • -6
    • +6
    ./Application.Ringtoets.Storage/Read/DuneErosion/DuneLocationOutputEntityReadExtensions.cs
  6. … 39 more files in changeset.
Tuesday 15 May 2018
11:34 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2811: - Updated XMLDocs - Updated test names - Replaced type casts to byte with Convert.ToByte() calls - Formatting of the migration script

WTI-1706

Options
    • -16
    • +16
    ./Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • -1
    • +1
    ./Application.Ringtoets.Storage/Create/GrassCoverErosionOutwards/GrassCoverErosionOutwardsWaveConditionsCalculationCreateExtensions.cs
    • -1
    • +1
    ./Application.Ringtoets.Storage/Create/WaveImpactAsphaltCover/WaveImpactAsphaltCoverWaveConditionsCalculationCreateExtensions.cs
  4. … 4 more files in changeset.
Monday 14 May 2018
4:12 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated migration script to fix failing tests: - Updated target values for the Category types --> indices changed from 0 to 1 based

WTI-1706

Options
    • -6
    • +6
    ./Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
3:09 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated migration script: - Generated initial setup and tests for the migration

WTI-1706

Options
    • -8
    • +112
    ./Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
  2. … 1 more file in changeset.
10:30 am

Dennis Tang <dennis.tang@deltares.nl>

Updated ReadExtensions for StabilityStoneCover: -- Cleaned up tests, replaced testcase data with random generators and a separate test asserting NaN / NULL conversions -- Added functionality to read CategoryType

WTI-1706

Options
    • -2
    • +11
    ./Application.Ringtoets.Storage/Read/StabilityStoneCover/StabilityStoneCoverWaveConditionsCalculationEntityReadExtensions.cs
  2. … 1 more file in changeset.
10:20 am

Dennis Tang <dennis.tang@deltares.nl>

Updated CreateExtensions for StabilityStoneCover: -- Cleaned up tests, replaced testcase data with random generators and a separate test asserting NaN / NULL conversions -- Added functionality to write CategoryType to entity

WTI-1706

Options
    • -17
    • +25
    ./Application.Ringtoets.Storage/Create/StabilityStoneCover/StabilityStoneCoverWaveConditionsCalculationCreateExtensions.cs
  2. … 1 more file in changeset.
10:04 am

Dennis Tang <dennis.tang@deltares.nl>

Updated ReadExtensions for WaveImpactAsphaltCover: -- Cleaned up tests, replaced testcase data with random generators and a separate test asserting NaN / NULL conversions -- Added functionality to read CategoryType

WTI-1706

Options
    • -3
    • +13
    ./Application.Ringtoets.Storage/Read/WaveImpactAsphaltCover/WaveImpactAsphaltCoverWaveConditionsCalculationEntityReadExtensions.cs
  2. … 1 more file in changeset.
9:38 am

Dennis Tang <dennis.tang@deltares.nl>

Cleaned up GrassCoverErosionOutwards Calculation CreateExtensions -- Refactored private method -- Adjusted test

WTI-1706

Options
    • -17
    • +18
    ./Application.Ringtoets.Storage/Create/GrassCoverErosionOutwards/GrassCoverErosionOutwardsWaveConditionsCalculationCreateExtensions.cs
  2. … 1 more file in changeset.
9:36 am

Dennis Tang <dennis.tang@deltares.nl>

Updated CreateExtensions for WaveImpactAsphaltCover: -- Cleaned up tests, replaced testcase data with random generators and a separate test asserting NaN / NULL conversions -- Added functionality to write CategoryType to entity

WTI-1706

Options
    • -17
    • +26
    ./Application.Ringtoets.Storage/Create/WaveImpactAsphaltCover/WaveImpactAsphaltCoverWaveConditionsCalculationCreateExtensions.cs
  2. … 1 more file in changeset.
9:04 am

Dennis Tang <dennis.tang@deltares.nl>

Merge branch 'master' into Storage

# Conflicts:

# Application/Ringtoets/src/Application.Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure18.1.sql

# build/DatabaseStructure.sql

# design/DatabaseDesign.eap

Options
    • -4
    • +4
    ./Application.Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure18.1.sql
  2. … 2 more files in changeset.
8:58 am

Dennis Tang <dennis.tang@deltares.nl>

Updated ReadExtensions for GrassCoverErosionOutwards: - Cleaned up tests, replaced testcase data with random generators and a separate test asserting NaN / NULL conversions - Added functionality to Read CategoryType

WTI-1706

Options
    • -7
    • +19
    ./Application.Ringtoets.Storage/Read/GrassCoverErosionOutwards/GrassCoverErosionOutwardsWaveConditionsCalculationEntityReadExtensions.cs
  2. … 1 more file in changeset.
Friday 11 May 2018
10:48 am

Carlos Lubbers

Update db structure sql files WTI-1693

Options
    • -5
    • +5
    ./Application.Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure18.1.sql
  2. … 1 more file in changeset.
9:44 am

Carlos Lubbers

Update storage tests and extensions with new enum WTI-1693

Options
    • -1
    • +1
    ./Application.Ringtoets.Storage/Read/DuneErosion/DuneErosionSectionResultEntityReadExtensions.cs
    • -1
    • +1
    ./Application.Ringtoets.Storage/Read/GrassCoverErosionOutwards/GrassCoverErosionOutwardsSectionResultEntityReadExtensions.cs
    • -1
    • +1
    ./Application.Ringtoets.Storage/Read/StabilityStoneCover/StabilityStoneCoverSectionResultEntityReadExtensions.cs
    • -1
    • +1
    ./Application.Ringtoets.Storage/Read/WaveImpactAsphaltCover/WaveImpactAsphaltCoverSectionResultEntityReadExtensions.cs
  5. … 9 more files in changeset.
Wednesday 09 May 2018
4:16 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated CreateExtensions for GrassCoverErosionOutwards: - Cleaned up tests, replaced testcase data with random generators and a separate test asserting NaN / NULL conversions - Added functionality to write CategoryType

WTI-1706

Options
    • -7
    • +13
    ./Application.Ringtoets.Storage/Create/GrassCoverErosionOutwards/GrassCoverErosionOutwardsWaveConditionsCalculationCreateExtensions.cs
  2. … 1 more file in changeset.
3:23 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated database design to include columns related to the category type: - Regenerated .sql file and corresponding Ringtoets.rtd - Regenerated entities

WTI-1706

Options
    • -1
    • +4
    ./Application.Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure18.1.sql
    • -0
    • +1
    ./Application.Ringtoets.Storage/DbContext/GrassCoverErosionOutwardsWaveConditionsCalculationEntity.cs
    • -0
    • +9
    ./Application.Ringtoets.Storage/DbContext/RingtoetsEntities.edmx
    • -89
    • +89
    ./Application.Ringtoets.Storage/DbContext/RingtoetsEntities.edmx.diagram
    • -0
    • +1
    ./Application.Ringtoets.Storage/DbContext/StabilityStoneCoverWaveConditionsCalculationEntity.cs
    • -0
    • +1
    ./Application.Ringtoets.Storage/DbContext/WaveImpactAsphaltCoverWaveConditionsCalculationEntity.cs
    • binary
    ./Application.Ringtoets.Storage/Ringtoets.rtd
  8. … 1 more file in changeset.
Thursday 26 Apr 2018
1:24 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2751: - Fixed typo

Paired with ~kleijn

WTI-1657

Options
    • -1
    • +1
    ./Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
1:11 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2748: - Updated MigrationScript to JOIN on the lookup table - Editiorial changes

WTI-1657

Options
    • -11
    • +12
    ./Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
  2. … 1 more file in changeset.
Wednesday 25 Apr 2018
4:34 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted migration for the grass cover erosion outwards (GCEO) wave condition calculations: - Translated the old GCEO hydraulic boundary location (HBL) PKs to the new HBL PKs on assessment section based on the LocationID of a HBL and its corresponding assessment section. -- Introduced a lookup table, as these translations happen on multiple spots - Adjusted test project to prove the translations are made correctly

WTI-1657

Options
    • -26
    • +61
    ./Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
  2. … 2 more files in changeset.
2:21 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2745: - Applied editorial comments

WTI-1657

Options
    • -2
    • +2
    ./Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
  2. … 1 more file in changeset.
Monday 23 Apr 2018
4:28 pm

Elmar Kleijn

Renamed HydraulicBoundaryLocationOutput into HydraulicBoundaryLocationCalculationOutput. WTI-1698

Options
    • -1
    • +1
    ./Application.Ringtoets.Storage/Application.Ringtoets.Storage.csproj
    • -0
    • +60
    ./Application.Ringtoets.Storage/Create/HydraulicBoundaryLocationCalculationOutputCreateExtensions.cs
    • -60
    • +0
    ./Application.Ringtoets.Storage/Create/HydraulicBoundaryLocationOutputCreateExtensions.cs
  4. … 5 more files in changeset.
4:13 pm

Elmar Kleijn

Renamed HydraulicBoundaryLocationOutput into HydraulicBoundaryLocationCalculationOutput. WTI-1698

Options
    • -3
    • +3
    ./Application.Ringtoets.Storage/Create/HydraulicBoundaryLocationCalculationCreateExtensions.cs
    • -3
    • +3
    ./Application.Ringtoets.Storage/Create/HydraulicBoundaryLocationOutputCreateExtensions.cs
    • -12
    • +12
    ./Application.Ringtoets.Storage/Read/HydraulicLocationOutputEntityReadExtensions.cs
  4. … 86 more files in changeset.
1:32 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted JOINS on the sourceproject for the Hydraulic Boundary Location of Grass Cover Erosion Outwards: - Do not join on the PK of the HBL entries, because these can be different between grass outwards and the hbls on assessment section level, instead join on the LocationID and the containing assessment section -- Adjusted migration logic for the outputs -- Adjusted migration logic for the HBL entries of grass cover erosion outwards --> take the HydraulicLocationEntityId as leading PK - Adjusted test files to represent the following scenarios situation: -- An HBL on the grass cover erosion failure mechanism that has a PK corresponding with a HBL that is not in the same assessment section -- Two HBLs on the grass cover erosion failure mechanism in the same assessment section that differs from the PKs of the HBLs on the assessment section

WTI-1657

Options
    • -15
    • +34
    ./Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
  2. … 3 more files in changeset.
11:16 am

Dennis Tang <dennis.tang@deltares.nl>

Adjusted JOINS on the sourceproject for the Hydraulic Boundary Locations of Grass Cover Erosion Outwards: - Do not join on the PK, because these can be different between grass outwards and the hbls on assessment section level, instead join on the LocationID and the containing assessment section

WTI-1657

Options
    • -2
    • +11
    ./Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
  2. … 2 more files in changeset.
Wednesday 18 Apr 2018
8:25 am

Elmar Kleijn

Improved migration log messages. WTI-1663

Options
    • -14
    • +14
    ./Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
  2. … 1 more file in changeset.
Thursday 12 Apr 2018
3:04 pm

Dennis Tang <dennis.tang@deltares.nl>

Added missing EF and SQLite references to the Application.Ringtoets.csproj: - This was done for clarity sake, because the app.config file depends on these references -- Note that the solution still worked without explicitly adding these references, because it was build and put together in a single folder with all the other dependencies that are dependent on EF and SQLite. As a consequence, EF and SQLite was always present when running the solution.

Paired with ~carloslubbers

WTI-1663

Options
    • -0
    • +22
    ./Application.Ringtoets/Application.Ringtoets.csproj
    • -1
    • +4
    ./Application.Ringtoets/packages.config
Wednesday 11 Apr 2018
4:37 pm

Carlos Lubbers

Review related changes, cleanup and added log for technical innovations WTI-1663

Options
    • -8
    • +21
    ./Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
  2. … 2 more files in changeset.
1:32 pm

Carlos Lubbers

Add migration log messages WTI-1663

Options
    • -0
    • +438
    ./Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
Tuesday 10 Apr 2018
2:21 pm

Carlos Lubbers

Update migration script for failure mechanisms in group 4 WTI-1663

Options
    • -9
    • +49
    ./Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql