Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Implemented review comments (cleanup, removed parametered constructor Related to Issue [WTI-975]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@13169 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 592b175ad64613145c6116fd48db486f37c43806

Former-commit-id: e8e5e377be506ad0351ef3097112480bee5f922a

    • -1
    • +1
    ./PipingFailureMechanismCreateExtensionsTest.cs
  1. … 50 more files in changeset.
Removed IsNameEditable from the data model Related to Issue [WTI-975]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@13012 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 98c5b0af23598a6c2ee6ce188b9f0b3dd947fc6c

Former-commit-id: d4a7a6940b06b448fb84f2c916cfc3b10f6baf16

    • -1
    • +1
    ./PipingFailureMechanismCreateExtensionsTest.cs
  1. … 71 more files in changeset.
Implemented review comments from review 2267 Related to Issue [WTI-1298]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12720 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e35a56a0daed4a728dc120c2054f1318de189d08

Former-commit-id: 35409add7a8a1a7fdbf85242db5c5f3593812733

    • -1
    • +1
    ./PipingSoilLayerCreateExtensionsTest.cs
  1. … 14 more files in changeset.
Introduced ColorConversionExtensions to convert from Color to Rgb and back Related to Issue [WTI-1451]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12481 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0740b07ebff9385abacbfe50c973b2d77d4c3c90

Former-commit-id: 028c0d9e94da2a6df0fb0556c8288183061b16a9

    • -1
    • +1
    ./PipingSoilLayerCreateExtensionsTest.cs
  1. … 15 more files in changeset.
- Expanded ProjectTestHelper with MacroStability Calculation (group) configurations for round tests - Added missing functional test for the piping calculation create extension Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12149 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c0ee746d2cbf910d9758c3a9b95f8ae12923c274

Former-commit-id: 673793797d2a172cb375868d70faad226a964d17

    • -0
    • +25
    ./PipingCalculationScenarioCreateExtensionsTest.cs
  1. … 3 more files in changeset.
Reimplemented revision 12140 from trunk after fixing failed tests: - Added fix for migration: -- Insert a temporary calculation group row entry during the migration and update the foreign key of the MacroStabilityInwards related failure mechanism rows. This prevents the CalculationGroupReadExtension from throwing a NULL reference exception when it reads the root calculation group

---

Added read and create extensions:

- Expanded the calculation group

-- Read and Create added to read or create the entities for macrostability inwards calculation (scenario)

- Expanded asserts on the piping side:

-- Removed .Value access in the tests => use .GetAccuracy instead of accessing the private variable of a RoundedDouble

-- Added asserts on the output values when creating or reading piping (semiprobabilistic) output entities

- Added entities to explicitly load in the PartialRingtoetsEntities

Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12146 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3a73e8a635472b17ac9eebc627e378c1378a7118

Former-commit-id: 6c8fb17a4b3381ed6e591ddde5b4ea3a8a8b94ae

    • -10
    • +18
    ./PipingFailureMechanismCreateExtensionsTest.cs
  1. … 9 more files in changeset.
Temporarily reverted revision 12140 from trunk: Added read and create extensions: - Expanded the calculation group -- Read and Create added to read or create the entities for macrostability inwards calculation (scenario) - Expanded asserts on the piping side: -- Removed .Value access in the tests => use .GetAccuracy instead of accessing the private variable of a RoundedDouble -- Added asserts on the output values when creating or reading piping (semiprobabilistic) output entities - Added entities to explicitly load in the PartialRingtoetsEntities

Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12144 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c7233860a302774e36a2afb8369cd52fefc6e9d5

Former-commit-id: bda4a8bc802d69ec5dfc2a61f5175b5e91b846d1

    • -18
    • +10
    ./PipingFailureMechanismCreateExtensionsTest.cs
  1. … 7 more files in changeset.
Added read and create extensions: - Expanded the calculation group -- Read and Create added to read or create the entities for macrostability inwards calculation (scenario) - Expanded asserts on the piping side: -- Removed .Value access in the tests => use .GetAccuracy instead of accessing the private variable of a RoundedDouble -- Added asserts on the output values when creating or reading piping (semiprobabilistic) output entities - Added entities to explicitly load in the PartialRingtoetsEntities

Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12140 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6e7e81968638b8b31efb48bc2d1e418987134250

Former-commit-id: 6164cd4f05cdc0196dc7c5b9b5b5b33a9dfb189d

    • -10
    • +18
    ./PipingFailureMechanismCreateExtensionsTest.cs
  1. … 7 more files in changeset.
Added read and create extensions: - Expanded the calculation group -- Read and Create added to read or create the entities for macrostability inwards calculation (scenario) - Expanded asserts on the piping side: -- Removed .Value access in the tests => use .GetAccuracy instead of accessing the private variable of a RoundedDouble -- Added asserts on the output values when creating or reading piping (semiprobabilistic) output entities

Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12139 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 488e140c131a119129b7ba14f39c0f5242e92369

Former-commit-id: 5f69943fcc1b44c327c7997be19f002f1f4dc2c3

    • -2
    • +32
    ./PipingCalculationScenarioCreateExtensionsTest.cs
  1. … 5 more files in changeset.
Added read and create extensions: - Done for the calculation scenario -- Improved for the piping equivalent - Introduced entity testhelper to assert entity property values for the macrostability inwards calculations scenarios - Renamed functions to better reflect what they do

Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12135 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a0e33b7f224bb8df0e64ab081d2e265290785d81

Former-commit-id: 5c8ec47fa3cf57b16e93955326a97b3e4630de91

    • -7
    • +2
    ./PipingCalculationScenarioCreateExtensionsTest.cs
  1. … 13 more files in changeset.
Added read and create extensions: - Done for the output - Synchronised implementations of piping with MacroStabilityInwards => when NULL arguments are passed, ArgumentNullException thrown - Replaced CollectionAssert with TestHelper assert which uses an EqualityComparer - Introduced entity test helper to assert the macro stability inwards output entity values Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12118 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 52251d30085ed9d1788770c79e711eeb607b461f

Former-commit-id: e7c9cc3302b31e7a805515cf01c77620e44aaafe

    • -6
    • +12
    ./PipingOutputCreateExtensionsTest.cs
  1. … 12 more files in changeset.
- Removed obsolete columns for the output entity: -- GridAutomaticallyCalculated -- ForbiddenZonesAutomaticallyCalculated - Renamed TangentLinesXml to SlipPlaneTangentLinesXml to indicate it belongs to a slipplane - Cleaned up test Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12110 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8820f65107597f06dc52f25ff51b5faa9b7de68e

Former-commit-id: 2659f888f976aff2e2757017d09468b89a5cc3a7

    • -6
    • +0
    ./PipingSemiProbabilisticOutputCreateExtensionsTest.cs
  1. … 6 more files in changeset.
Added read and create extensions: - Done for the semi probabilistic output - Renamed column name for the factor of stability -- Updated database, entities and sql files - Synchronised implementations of piping with MacroStabilityInwards => when NULL arguments are passed, ArgumentNullException thrown Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12097 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 74daeaea7a3522e36dc91931346a65599610abdc

Former-commit-id: ee9127a39b16e5ca0897c8f87bc54ca442c107b0

    • -0
    • +11
    ./PipingSemiProbabilisticOutputCreateExtensionsTest.cs
  1. … 15 more files in changeset.
- (Re)added the SourceType byte property in the entity => Create was never writing to this property. Added missing assert to maintain behaviour - Added resource string representations for the SoilProfileType => associated properties class can use the EnumTypeConverter instead of explicit returning strings with an if-else structure Related to Issue [WTI-1433]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12031 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a55d3e224480f04a30526a6245a75e6743f9fc73

Former-commit-id: c14ead5c2ea7e99492b6bf8281648e10bc1be400

    • -3
    • +8
    ./PipingSoilProfileCreateExtensionsTest.cs
  1. … 10 more files in changeset.
Incorporated comments dev: - Cleaned up some files - Moved validation logic from readers to transformers and RT datamodel (stochastic soil profiles, Piping only): -- Moved StochasticSoilProfile property of the PipingStochasticSoilModel as a mandatory constructor argument -- Changed property from List to IEnumerable => provides readonly access of the collection -- Introduced additional test factory method --- Replaced explicit constructor calls with factory calls when possible

Related to Issue [WTI-1340]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12023 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8cf27edcf482fb639d692d19f6840bb78219dc98

Former-commit-id: dbc10165755b4dc91a62d7f21e6749d2850ed2b3

    • -1
    • +1
    ./PipingFailureMechanismCreateExtensionsTest.cs
    • -9
    • +3
    ./PipingStochasticSoilModelCreateExtensionsTest.cs
  1. … 33 more files in changeset.
Incorporated comments dev: - Moved validation logic from readers to transformers and RT datamodel (Piping only): -- Validates if the geometry is not empty and is not NULL -- Expanded test factory -- Replaced explicit constructor calls with test factory calls when possible -- Added additional tests for the transformers to verify behaviour

Related to Issue [WTI-1340]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11985 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bb6368c63b7448360bce377e2d29d1303b379d9c

Former-commit-id: 73622e310bf3c785e9bbc7acb4d2021bfc9a7674

    • -2
    • +4
    ./PipingCalculationScenarioCreateExtensionsTest.cs
    • -2
    • +3
    ./PipingFailureMechanismCreateExtensionsTest.cs
    • -10
    • +11
    ./PipingStochasticSoilModelCreateExtensionsTest.cs
  1. … 39 more files in changeset.
Review related changes Related to Issue [WTI-1378]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11923 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 364cf974ccb2fdf30c65347f32da73bdbe090465

Former-commit-id: 23d9c6c350030a289ed8c10551b655b62fd665e2

    • -4
    • +2
    ./PipingSurfaceLineCreateExtensionsTest.cs
Review related changes Related to Issue [WTI-1378]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11921 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 260e6e991f9d78cc6e2b72ca84f426691ed68a16

Former-commit-id: 7857ad0c775ad8e78c7c3c99f6fa5119742de809

    • -4
    • +3
    ./PipingStochasticSoilModelCreateExtensionsTest.cs
  1. … 7 more files in changeset.
Renamed input variable Renamed tests Added asserts Simplified tests Refactored legacy tests from ReadConversionCollectorTest to new implementation (by deriving from CollectorTest) Related to Issue [WTI-1378]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11804 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f83841c6d264b3dc62aab965f21b44ace1e3e3a5

Former-commit-id: 37dc48ce7bf54ade88b0c2e8ba82b23671f342da

    • -1
    • +1
    ./PipingFailureMechanismCreateExtensionsTest.cs
  1. … 8 more files in changeset.
Simplified tests Supported ReferenceLineIntersectionWorldPoint that is null Renamed variables Tets added Removed legacy code Related to Issue [WTI-1378]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11792 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 9b657a48ed543573f3370b214b96b521cb1a82b5

Former-commit-id: eac3233d76636c5237d0100c358b740589444b43

    • -2
    • +2
    ./PipingFailureMechanismCreateExtensionsTest.cs
    • -19
    • +21
    ./PipingSurfaceLineCreateExtensionsTest.cs
  1. … 15 more files in changeset.
Added NotSupportedException for MacroStabilityInwardsStochasticSoilProfileEntity Simplified tests Renamed tests Added MacroStabilityInwardsSoilProfile2DTestFactory Fixed XMLdoc Related to Issue [WTI-1378]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11791 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ee0b376dfe603cfb43ebd2b1750b42db78186351

Former-commit-id: 8834c07b2f6befea57224a423dec83b08ff32987

    • -10
    • +10
    ./PipingFailureMechanismCreateExtensionsTest.cs
    • -2
    • +2
    ./PipingStochasticSoilModelCreateExtensionsTest.cs
  1. … 13 more files in changeset.
Reverted rename of XML serializers, because the internal XML name will differ as well Related to Issue [WTI-1378]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11787 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7780ac82facd3159219ebbcbdf0fde4bfaae5d53

Former-commit-id: 8c5887bdf4a0d3f0fbf889259a06e6415e6092de

    • -2
    • +2
    ./PipingStochasticSoilModelCreateExtensionsTest.cs
    • -4
    • +4
    ./PipingSurfaceLineCreateExtensionsTest.cs
  1. … 61 more files in changeset.
Renamed XML serializers Related to Issue [WTI-1378]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11786 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a7485b96dc030d91d392a214a5b415e6c35c48ee

Former-commit-id: 2cd8760543138ae8bd076178ff0d2aba20da5362

    • -2
    • +2
    ./PipingStochasticSoilModelCreateExtensionsTest.cs
    • -4
    • +4
    ./PipingSurfaceLineCreateExtensionsTest.cs
  1. … 61 more files in changeset.
Updated legacy code Related to Issue [WTI-1378]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11784 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 35af7492713d370ad4efa479810a3cfb329c5da0

Former-commit-id: eda6e7e5b4841bc3bedf275f8d0215c42b9fadb5

    • -2
    • +8
    ./PipingStochasticSoilModelCreateExtensionsTest.cs
    • -0
    • +1
    ./PipingStochasticSoilProfileCreateExtensionsTest.cs
    • -2
    • +0
    ./PipingSurfaceLineCreateExtensionsTest.cs
Grouped BelowPhreaticLevel properties in PipingSoilLayerEntity Updated XMLdoc Updated legacy code to newer standards Reverted any changes on Empty valid Release 17.1.rtd

Related to Issue [WTI-1378]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11782 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0e39134125c1ede94ce32c4db48ca9c8323eff45

Former-commit-id: cd332c0cbb0f37aee26c89e3704b166a312ef342

    • -3
    • +2
    ./PipingSoilProfileCreateExtensionsTest.cs
    • -6
    • +0
    ./PipingSurfaceLineCreateExtensionsTest.cs
  1. … 9 more files in changeset.
Renamed PipingCalculationEntity.StochasticSoilProfileEntityId to PipingCalculationEntity.PipingStochasticSoilProfileEntityId Changed enum note of MacroStabilityInwardsSoilLayer*DEntity.ShearStrengthModel Set XML properties to NOT NULL Removed SectionLength form storage Updated format of database triggers Added NULL check for PipingSoilLayerCreateExtensions Refactored static call to TestHelper.SolutionRoot to a method that is called while running the test Related to Issue [WTI-1378]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11781 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ffc212f543edb5fe3e4647c5f87ebed29cbce0dc

Former-commit-id: 31f4b4630ce9bdade4eedf7b1adf7488748df9d9

    • -0
    • +11
    ./PipingSoilLayerCreateExtensionsTest.cs
  1. … 19 more files in changeset.
Updated storage for MacroStabilityInwardsFailureMechanism (and cleanup for PipingFailureMechanism) Related to Issue [WTI-1378]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11703 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 847e276b39b5c8f2f55aafdb81ed1a84fbfe2fb0

Former-commit-id: 13ab412e175e2f736785bde7cea4aee3b5eac6a5

    • -35
    • +51
    ./PipingFailureMechanismCreateExtensionsTest.cs
  1. … 3 more files in changeset.
Added storage for MacroStabilityInwardsSurfaceLine - Renamed piping specific surface line storage classes Related to Issue [WTI-1378]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11701 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c556f75f65810b22aa057f65aaa8301aa1db1d3b

Former-commit-id: 7b621877af072dca5669903944266da95e03e1d4

    • -64
    • +62
    ./PipingSurfaceLineCreateExtensionsTest.cs
  1. … 13 more files in changeset.
Updated XMLdoc Created MacroStabilityInwardsStochasticSoilModelCreateExtensions Related to Issue [WTI-1378]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11688 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 80df15dd50b87507ba13a5421805776951cabbf1

Former-commit-id: 9620c498ad2615748661f006b5dd07913b3dc6b5

    • -8
    • +27
    ./PipingStochasticSoilModelCreateExtensionsTest.cs
  1. … 14 more files in changeset.
- Updated property names - Created MacroStabilityInwardsSoilLayer1DCreateExtensions - Updated PipingSoilLayerCreateExtensions Related to Issue [WTI-1378]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11677 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c1666baf3b502ff456deb41f39aa9795b6e716ef

Former-commit-id: 0a95832cf4992a61bb736ea6361decc2d03c45e5

    • -21
    • +47
    ./PipingSoilLayerCreateExtensionsTest.cs
  1. … 13 more files in changeset.