Riskeer / Application / Ringtoets / test / Application.Ringtoets.Storage.Test

Create

Clone Tools

Stats

Commits this week: 0
Total Committers: 8
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 20 Oct 2017
1:38 pm

Marten Janssen <marten.janssen@deltares.nl>

Added validation in MacroStabilityInwardsGrid: - NumberOfHorizontalPoints [1, 100], default set to 5 - NumberOfVerticalPoints [1, 100], default set to 5 Related to Issue [WTI-1400]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12270 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2aba5bbcced6dfcafc4908a727ff829c6e38d6ee

Former-commit-id: 919adf3dbad612b4ecfb29b689ae84d7f86866f6

Options
    • -4
    • +4
    ./MacroStabilityInwards/MacroStabilityInwardsCalculationScenarioCreateExtensionsTest.cs
  2. … 14 more files in changeset.
10:48 am

Marten Janssen <marten.janssen@deltares.nl>

Refactored MacroStabilityInwardsGrid to be able to set the x left/right and z top/bottom via the constructor Related to Issue [WTI-1400]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12265 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0f86def14d70aa807cabae1394b52f0c1f8334c5

Former-commit-id: 9ff2c4efb5bcb5ba77076d98eb057631ad27c736

Options
    • -8
    • +7
    ./MacroStabilityInwards/MacroStabilityInwardsOutputCreateExtensionsTest.cs
  2. … 9 more files in changeset.
Thursday 19 Oct 2017
4:49 pm

Dennis Tang <dennis.tang@deltares.nl>

Converted the TestMacroStabilityInwardsOutput test object to a test factory: - Created objects are to be used for asserting composite objects that can clone. These asserts should be preferably done with the original object rather than a derived (test) object

Related to Issue [WTI-1366]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12260 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 9692ca616baffd96345a37e0f605fc8573337e86

Former-commit-id: 9abe379937333a2a121c54329d4dc57ee5d128a3

Options
    • -1
    • +1
    ./MacroStabilityInwards/MacroStabilityInwardsCalculationScenarioCreateExtensionsTest.cs
  2. … 31 more files in changeset.
4:12 pm

Marten Janssen <marten.janssen@deltares.nl>

- Removed TrafficLoadInside and TrafficLoadOutside from our data model. - - Only the CharacteristicPointsCsvReader in Ringtoets.Common.IO.SurfaceLines has knowledge of the existence of these traffic load properties Related to Issue [WTI-1443]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12258 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 81160300b03498fde6c5dd16d23a54992961ea78

Former-commit-id: 18cd599b8704c1b45334953e1fbe944524939564

Options
    • -7
    • +5
    ./MacroStabilityInwards/MacroStabilityInwardsFailureMechanismCreateExtensionsTest.cs
    • -31
    • +13
    ./MacroStabilityInwards/MacroStabilityInwardsSurfaceLineCreateExtensionsTest.cs
  3. … 32 more files in changeset.
4:01 pm

Dennis Tang <dennis.tang@deltares.nl>

Converted the TestMacroStabilityInwardsSemiProbabilisticOutput test object to a test factory: - Created objects are to be used for asserting composite objects that can clone. These asserts should be preferably done with the original object rather than a derived (test) object - Added test class Related to Issue [WTI-1366]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12257 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5e2c6799a5a83569ca93d3c253dbe99043f93213

Former-commit-id: 8f8e4f479c2b0fb04a31740690f9cfd710f91b77

Options
    • -1
    • +1
    ./MacroStabilityInwards/MacroStabilityInwardsCalculationScenarioCreateExtensionsTest.cs
  2. … 17 more files in changeset.
3:20 pm

Dennis Tang <dennis.tang@deltares.nl>

- Implemented .Clone() for the MacroStabilityInwardsInput and its derived classes -- Added helper in the clone assert - Added missing asserts in the CreateExtensions for MacroStabilityInwardsCalculationScenario Related to Issue [WTI-1366]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12252 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e373eaec8dec7739fb5f1ea3a79950d6785fccc1

Former-commit-id: 6472a83d5430723a59a80b0cc7f97579997fcecf

Options
    • -0
    • +2
    ./MacroStabilityInwards/MacroStabilityInwardsCalculationScenarioCreateExtensionsTest.cs
  2. … 3 more files in changeset.
Wednesday 18 Oct 2017
1:06 pm

Carlos Lubbers

Implement extra interfaces for the macro stability soil layers/profiles to access their Data property more easily. Related to Issue [WTI-1298]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12211 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7f4f2ba86e9206ad63a4d043bb61858655dc255f

Former-commit-id: f06b465a7b1a8c269df3e5ab562bbd0cd6836b8b

Options
    • -5
    • +5
    ./MacroStabilityInwards/MacroStabilityInwardsStochasticSoilProfileCreateExtensionsTest.cs
    • -1
    • +1
    ./PersistenceRegistryTest.cs
  3. … 29 more files in changeset.
Tuesday 17 Oct 2017
10:51 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2195 - Added asserts for the integration tests - Added .ToNaNAsNull() call for the contribution when storing a macro stability inwards calculation scenario Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12201 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2c03f5e682f4a76928ed694ca17d97db3c3efca1

Former-commit-id: 5a58149288c5f337146a460441390c150c91bd01

Options
    • -1
    • +4
    ./MacroStabilityInwards/MacroStabilityInwardsCalculationScenarioCreateExtensionsTest.cs
  2. … 4 more files in changeset.
9:06 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2195 - Editorial changes - Explicit set values explicitly for NaN cases for the Create and Read extensions related to macrostability inwards - Changed internal methods in internal classes to public (synchronised across macrostability inwards and piping) Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12199 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4de72b78ffab0ed0177ed39b702efde0e177c033

Former-commit-id: 49bf1469e0f1890ad528ef1b638ee66c76755d91

Options
    • -2
    • +45
    ./MacroStabilityInwards/MacroStabilityInwardsCalculationScenarioCreateExtensionsTest.cs
    • -3
    • +15
    ./MacroStabilityInwards/MacroStabilityInwardsOutputCreateExtensionsTest.cs
  3. … 18 more files in changeset.
Monday 16 Oct 2017
11:17 am

Robert Tangerman <robert.tangerman@deltares.nl>

Introduced interfaces for decoupling input objects so that they can be used for the waternet calculation. Related to Issue [WTI-1345]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12175 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 38c446a34b1b58b7db8e1431e7dce6177e19d68c

Former-commit-id: dc970feeec16f79716d129ef808e94a9474aa7bd

Options
    • -1
    • +1
    ./MacroStabilityInwards/MacroStabilityInwardsSoilLayer1DCreateExtensionsTest.cs
    • -1
    • +1
    ./MacroStabilityInwards/MacroStabilityInwardsSoilLayer2DCreateExtensionsTest.cs
  3. … 47 more files in changeset.
Friday 13 Oct 2017
11:25 am

Dennis Tang <dennis.tang@deltares.nl>

Corrected asserts to improve coverage: - Added missing asserts, corrected asserts - Added values to missing property setters

Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12156 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3c8cc7b9b691089232a26132c5de67f55dffc374

Former-commit-id: 97d5f344b06b48831fa1cffacf2017be3eba216c

Options
    • -4
    • +5
    ./MacroStabilityInwards/MacroStabilityInwardsCalculationScenarioCreateExtensionsTest.cs
    • -1
    • +1
    ./MacroStabilityInwards/MacroStabilityInwardsOutputCreateExtensionsTest.cs
  3. … 5 more files in changeset.
10:04 am

Dennis Tang <dennis.tang@deltares.nl>

- Expanded ProjectTestHelper with MacroStability Calculation (group) configurations for round tests - Added missing functional test for the piping calculation create extension Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12149 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c0ee746d2cbf910d9758c3a9b95f8ae12923c274

Former-commit-id: 673793797d2a172cb375868d70faad226a964d17

Options
    • -0
    • +25
    ./Piping/PipingCalculationScenarioCreateExtensionsTest.cs
  2. … 3 more files in changeset.
8:23 am

Dennis Tang <dennis.tang@deltares.nl>

Reimplemented revision 12140 from trunk after fixing failed tests: - Added fix for migration: -- Insert a temporary calculation group row entry during the migration and update the foreign key of the MacroStabilityInwards related failure mechanism rows. This prevents the CalculationGroupReadExtension from throwing a NULL reference exception when it reads the root calculation group

---

Added read and create extensions:

- Expanded the calculation group

-- Read and Create added to read or create the entities for macrostability inwards calculation (scenario)

- Expanded asserts on the piping side:

-- Removed .Value access in the tests => use .GetAccuracy instead of accessing the private variable of a RoundedDouble

-- Added asserts on the output values when creating or reading piping (semiprobabilistic) output entities

- Added entities to explicitly load in the PartialRingtoetsEntities

Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12146 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3a73e8a635472b17ac9eebc627e378c1378a7118

Former-commit-id: 6c8fb17a4b3381ed6e591ddde5b4ea3a8a8b94ae

Options
    • -0
    • +11
    ./MacroStabilityInwards/MacroStabilityInwardsCalculationScenarioCreateExtensionsTest.cs
    • -0
    • +40
    ./MacroStabilityInwards/MacroStabilityInwardsFailureMechanismCreateExtensionsTest.cs
    • -0
    • +2
    ./MacroStabilityInwards/MacroStabilityInwardsOutputCreateExtensionsTest.cs
    • -10
    • +18
    ./Piping/PipingFailureMechanismCreateExtensionsTest.cs
  5. … 6 more files in changeset.
Thursday 12 Oct 2017
4:30 pm

Dennis Tang <dennis.tang@deltares.nl>

Temporarily reverted revision 12140 from trunk: Added read and create extensions: - Expanded the calculation group -- Read and Create added to read or create the entities for macrostability inwards calculation (scenario) - Expanded asserts on the piping side: -- Removed .Value access in the tests => use .GetAccuracy instead of accessing the private variable of a RoundedDouble -- Added asserts on the output values when creating or reading piping (semiprobabilistic) output entities - Added entities to explicitly load in the PartialRingtoetsEntities

Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12144 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c7233860a302774e36a2afb8369cd52fefc6e9d5

Former-commit-id: bda4a8bc802d69ec5dfc2a61f5175b5e91b846d1

Options
    • -11
    • +0
    ./MacroStabilityInwards/MacroStabilityInwardsCalculationScenarioCreateExtensionsTest.cs
    • -40
    • +0
    ./MacroStabilityInwards/MacroStabilityInwardsFailureMechanismCreateExtensionsTest.cs
    • -2
    • +0
    ./MacroStabilityInwards/MacroStabilityInwardsOutputCreateExtensionsTest.cs
    • -18
    • +10
    ./Piping/PipingFailureMechanismCreateExtensionsTest.cs
  5. … 4 more files in changeset.
3:02 pm

Dennis Tang <dennis.tang@deltares.nl>

Added read and create extensions: - Expanded the calculation group -- Read and Create added to read or create the entities for macrostability inwards calculation (scenario) - Expanded asserts on the piping side: -- Removed .Value access in the tests => use .GetAccuracy instead of accessing the private variable of a RoundedDouble -- Added asserts on the output values when creating or reading piping (semiprobabilistic) output entities - Added entities to explicitly load in the PartialRingtoetsEntities

Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12140 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6e7e81968638b8b31efb48bc2d1e418987134250

Former-commit-id: 6164cd4f05cdc0196dc7c5b9b5b5b33a9dfb189d

Options
    • -0
    • +11
    ./MacroStabilityInwards/MacroStabilityInwardsCalculationScenarioCreateExtensionsTest.cs
    • -0
    • +40
    ./MacroStabilityInwards/MacroStabilityInwardsFailureMechanismCreateExtensionsTest.cs
    • -0
    • +2
    ./MacroStabilityInwards/MacroStabilityInwardsOutputCreateExtensionsTest.cs
    • -10
    • +18
    ./Piping/PipingFailureMechanismCreateExtensionsTest.cs
  5. … 4 more files in changeset.
2:15 pm

Dennis Tang <dennis.tang@deltares.nl>

Added read and create extensions: - Expanded the calculation group -- Read and Create added to read or create the entities for macrostability inwards calculation (scenario) - Expanded asserts on the piping side: -- Removed .Value access in the tests => use .GetAccuracy instead of accessing the private variable of a RoundedDouble -- Added asserts on the output values when creating or reading piping (semiprobabilistic) output entities

Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12139 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 488e140c131a119129b7ba14f39c0f5242e92369

Former-commit-id: 5f69943fcc1b44c327c7997be19f002f1f4dc2c3

Options
    • -0
    • +89
    ./CalculationGroupCreateExtensionsTest.cs
    • -2
    • +32
    ./Piping/PipingCalculationScenarioCreateExtensionsTest.cs
    • -5
    • +6
    ./Piping/PipingOutputCreateExtensionsTest.cs
  4. … 4 more files in changeset.
1:19 pm

Dennis Tang <dennis.tang@deltares.nl>

Added read and create extensions: - Done for the calculation scenario -- Improved for the piping equivalent - Introduced entity testhelper to assert entity property values for the macrostability inwards calculations scenarios - Renamed functions to better reflect what they do

Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12135 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a0e33b7f224bb8df0e64ab081d2e265290785d81

Former-commit-id: 5c8ec47fa3cf57b16e93955326a97b3e4630de91

Options
    • -0
    • +379
    ./MacroStabilityInwards/MacroStabilityInwardsCalculationScenarioCreateExtensionsTest.cs
    • -1
    • +34
    ./MacroStabilityInwards/MacroStabilityInwardsOutputCreateExtensionsTest.cs
    • -7
    • +2
    ./Piping/PipingCalculationScenarioCreateExtensionsTest.cs
  4. … 11 more files in changeset.
Wednesday 11 Oct 2017
2:20 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduced test factory to create slices with concrete values Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12122 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4b4bf28e1db3343c10d773aa84f25ed19c05e07f

Former-commit-id: fdcce846d6e3d7696034175f86fc0c88d3dd6e43

Options
    • -55
    • +8
    ./MacroStabilityInwards/MacroStabilityInwardsOutputCreateExtensionsTest.cs
  2. … 5 more files in changeset.
2:03 pm

Dennis Tang <dennis.tang@deltares.nl>

Added read and create extensions: - Done for the output - Synchronised implementations of piping with MacroStabilityInwards => when NULL arguments are passed, ArgumentNullException thrown - Replaced CollectionAssert with TestHelper assert which uses an EqualityComparer - Introduced entity test helper to assert the macro stability inwards output entity values Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12118 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 52251d30085ed9d1788770c79e711eeb607b461f

Former-commit-id: e7c9cc3302b31e7a805515cf01c77620e44aaafe

Options
    • -0
    • +207
    ./MacroStabilityInwards/MacroStabilityInwardsOutputCreateExtensionsTest.cs
    • -6
    • +12
    ./Piping/PipingOutputCreateExtensionsTest.cs
  3. … 11 more files in changeset.
11:31 am

Dennis Tang <dennis.tang@deltares.nl>

- Removed obsolete columns for the output entity: -- GridAutomaticallyCalculated -- ForbiddenZonesAutomaticallyCalculated - Renamed TangentLinesXml to SlipPlaneTangentLinesXml to indicate it belongs to a slipplane - Cleaned up test Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12110 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8820f65107597f06dc52f25ff51b5faa9b7de68e

Former-commit-id: 2659f888f976aff2e2757017d09468b89a5cc3a7

Options
    • -6
    • +0
    ./Piping/PipingSemiProbabilisticOutputCreateExtensionsTest.cs
  2. … 6 more files in changeset.
Tuesday 10 Oct 2017
5:11 pm

Dennis Tang <dennis.tang@deltares.nl>

Added read and create extensions: - Done for the semi probabilistic output - Renamed column name for the factor of stability -- Updated database, entities and sql files - Synchronised implementations of piping with MacroStabilityInwards => when NULL arguments are passed, ArgumentNullException thrown Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12097 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 74daeaea7a3522e36dc91931346a65599610abdc

Former-commit-id: ee9127a39b16e5ca0897c8f87bc54ca442c107b0

Options
    • -0
    • +102
    ./MacroStabilityInwards/MacroStabilityInwardsSemiProbabilisticOutputCreateExtensionsTest.cs
    • -0
    • +11
    ./Piping/PipingSemiProbabilisticOutputCreateExtensionsTest.cs
  3. … 14 more files in changeset.
4:09 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated database design to enable NaN values for the stochastic distribution properties of preconsolidation stresses: - Updated Create and Read extensions - Regenerated affected entities

Related to Issue [WTI-1341]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12091 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 941b6380ef22f6ecbc2ad888f86259ac97d1f131

Former-commit-id: 7b36beb1a8a2b33c953ede3bcec0ba3a0511ef68

Options
    • -0
    • +24
    ./MacroStabilityInwards/MacroStabilityInwardsPreconsolidationStressCreateExtensionsTest.cs
  2. … 9 more files in changeset.
Friday 06 Oct 2017
11:00 am

Carlos Lubbers

Implement review comments, change test names and use test objects Related to Issue [WTI-1391]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12038 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6fa9f00269e9942f554d425998fc4e5fb1f7df8d

Former-commit-id: e98c0531b4907bb6f6b5c4887605d6b89f839797

Options
    • -3
    • +3
    ./IllustrationPoints/TopLevelFaultTreeIllustrationPointCreateExtensionsTest.cs
  2. … 2 more files in changeset.
Thursday 05 Oct 2017
11:49 am

Dennis Tang <dennis.tang@deltares.nl>

- (Re)added the SourceType byte property in the entity => Create was never writing to this property. Added missing assert to maintain behaviour - Added resource string representations for the SoilProfileType => associated properties class can use the EnumTypeConverter instead of explicit returning strings with an if-else structure Related to Issue [WTI-1433]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12031 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a55d3e224480f04a30526a6245a75e6743f9fc73

Former-commit-id: c14ead5c2ea7e99492b6bf8281648e10bc1be400

Options
    • -3
    • +8
    ./Piping/PipingSoilProfileCreateExtensionsTest.cs
  2. … 10 more files in changeset.
Wednesday 04 Oct 2017
5:20 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments dev: - Cleaned up some files - Moved validation logic from readers to transformers and RT datamodel (stochastic soil profiles, Piping only): -- Moved StochasticSoilProfile property of the PipingStochasticSoilModel as a mandatory constructor argument -- Changed property from List to IEnumerable => provides readonly access of the collection -- Introduced additional test factory method --- Replaced explicit constructor calls with factory calls when possible

Related to Issue [WTI-1340]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12023 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8cf27edcf482fb639d692d19f6840bb78219dc98

Former-commit-id: dbc10165755b4dc91a62d7f21e6749d2850ed2b3

Options
    • -1
    • +1
    ./Piping/PipingFailureMechanismCreateExtensionsTest.cs
    • -9
    • +3
    ./Piping/PipingStochasticSoilModelCreateExtensionsTest.cs
  3. … 33 more files in changeset.
2:38 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments dev: - Moved validation logic from readers to transformers and RT datamodel (stochastic soil profiles, MacroStabilityInwards only): -- Moved StochasticSoilProfile property of the MacroStabilityInwardsStochasticSoilModel as a mandatory constructor argument -- Changed property from List to IEnumerable => provides readonly access of the collection -- Introduced additional test factory method --- Replaced explicit constructor calls with factory calls when possible

Related to Issue [WTI-1340]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12020 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 793e8b7ce8d28a571d22d61fd01a1c14280c75c6

Former-commit-id: 4ba95330a9300a647b62dfa413c36a5a581ee392

Options
    • -1
    • +1
    ./MacroStabilityInwards/MacroStabilityInwardsFailureMechanismCreateExtensionsTest.cs
    • -17
    • +12
    ./MacroStabilityInwards/MacroStabilityInwardsStochasticSoilModelCreateExtensionsTest.cs
  3. … 32 more files in changeset.
Monday 02 Oct 2017
5:59 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments dev: - Moved validation logic from readers to transformers and RT datamodel (Piping only): -- Validates if the geometry is not empty and is not NULL -- Expanded test factory -- Replaced explicit constructor calls with test factory calls when possible -- Added additional tests for the transformers to verify behaviour

Related to Issue [WTI-1340]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11985 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bb6368c63b7448360bce377e2d29d1303b379d9c

Former-commit-id: 73622e310bf3c785e9bbc7acb4d2021bfc9a7674

Options
    • -2
    • +3
    ./PersistenceRegistryTest.cs
    • -2
    • +4
    ./Piping/PipingCalculationScenarioCreateExtensionsTest.cs
    • -2
    • +3
    ./Piping/PipingFailureMechanismCreateExtensionsTest.cs
    • -10
    • +11
    ./Piping/PipingStochasticSoilModelCreateExtensionsTest.cs
  5. … 38 more files in changeset.
Friday 29 Sep 2017
8:30 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments dev: - Fixed failing tests on buildserver - Moved validation logic from readers to transformers and RT datamodel (Macrostability only): -- Introduced testfactories to create valid RT and Reader soil models (with geometry defined) -- Removed obsolete constructor Related to Issue [WTI-1340]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11965 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f2f84a442ab3fc8368459e5118dc2db35b5f9a4a

Former-commit-id: 62456eff75ae7a3761bf0a3b3d5ba34092394db1

Options
    • -2
    • +3
    ./MacroStabilityInwards/MacroStabilityInwardsFailureMechanismCreateExtensionsTest.cs
    • -11
    • +17
    ./MacroStabilityInwards/MacroStabilityInwardsStochasticSoilModelCreateExtensionsTest.cs
    • -1
    • +1
    ./PersistenceRegistryTest.cs
  4. … 33 more files in changeset.
5:07 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments dev: - Cleaned up unused resources - Moved validation logic from the Reader to the transformers and respective RT data structures: -- Performed for the SoilModel: - Removed geometry validation in the reader, but: - Implemented for MacroStability only at this stage: -- Check if geometry is not empty Related to Issue [WTI-1340]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11964 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 31fb365b2611d19fafeef02d50d223c477b45431

Former-commit-id: 123d35eb149285fe827c58fb12bc95af78eb71ad

Options
    • -2
    • +2
    ./MacroStabilityInwards/MacroStabilityInwardsStochasticSoilModelCreateExtensionsTest.cs
  2. … 41 more files in changeset.
1:03 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments dev: - Moved validation logic from the Reader to the transformers and respective RT data structures: -- Performed for the SoilProfile2D: => Amount of layers > 0 => All layer tops > bottom Moved to their respective transformers - Adjusted SoilProfile2D query to cope with files without soil layers - Added missing asserts for the 1D profiles => assert exception messages

Related to Issue [WTI-1340]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11954 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: eacb5a09716a4f76ca79c990a88775a7ecfdcfd6

Former-commit-id: 22556b45a12fb6ebacd14366a6228ccb1a65a514

Options
    • -1
    • +0
    ./MacroStabilityInwards/MacroStabilityInwardsSoilProfile1DCreateExtensionsTest.cs
  2. … 12 more files in changeset.