Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Review related changes Related to Issue [WTI-1321]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11058 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0888b5df96dd15d899e5f0a2236ae7deb4803528

Former-commit-id: a0b15ae4420301228126961cb7f52511d04a7135

    • -11
    • +10
    ./GrassCoverErosionInwards/GrassCoverErosionInwardsOutputCreateExtensionsTest.cs
  1. … 11 more files in changeset.
Updated CreateExtensions for the GrassCoverErosionInwards outputs: - Introduced GeneralResultEntityTestHelper to assert general result entities for fault tree illustration points -- Testhelper only asserts the direct properties, not the values of the items it is composed of -- Implemented for all relevant create extensions - Updated tests for DistributionAssertTest: used nameof operator

Related to Issue [WTI-1319]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11045 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: abe34a42f830b568964ec0124f95fa6f1ea1060a

Former-commit-id: 26d5905c04f9f45d23cdad6cb5cf5d387f3df85c

    • -26
    • +5
    ./GrassCoverErosionInwards/DikeHeightOutputCreateExtensionsTest.cs
    • -23
    • +4
    ./GrassCoverErosionInwards/GrassCoverErosionInwardsOutputCreateExtensionsTest.cs
    • -25
    • +4
    ./GrassCoverErosionInwards/OvertoppingRateOutputCreateExtensionsTest.cs
    • -26
    • +4
    ./StructuresOutputCreateExtensionsTest.cs
  1. … 5 more files in changeset.
Updated CreateExtensions for the GrassCoverErosionInwards outputs: - Added support for including create extensions of the general result within the output entities

Related to Issue [WTI-1319]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11039 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2ff940540cb473f51e68c8dce6e78d69a822c09f

Former-commit-id: ed5c1f5d7132db924f31943a7ce80a6e7a2a68da

    • -0
    • +48
    ./GrassCoverErosionInwards/DikeHeightOutputCreateExtensionsTest.cs
    • -2
    • +44
    ./GrassCoverErosionInwards/GrassCoverErosionInwardsOutputCreateExtensionsTest.cs
    • -0
    • +48
    ./GrassCoverErosionInwards/OvertoppingRateOutputCreateExtensionsTest.cs
  1. … 3 more files in changeset.
Incorporated comments review 2000 - Removed superfluous GeneralResult assertions - Added missing assertions - Renamed variables and fixed typos

Paired with ~janssen

Related to Issue [WTI-1309]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11026 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 66ce181cb0df03c034bbe0d0b71960ce91f8f964

Former-commit-id: 99935a220f1560d9d3aa04f6aad2269d90f96065

    • -14
    • +14
    ./IllustrationPoints/GeneralResultCreateExtensionsTest.cs
    • -6
    • +10
    ./IllustrationPoints/TopLevelFaultTreeIllustrationPointCreateExtensionsTest.cs
    • -97
    • +14
    ./StructuresCalculationCreateExtensionsTest.cs
    • -0
    • +11
    ./StructuresOutputCreateExtensionsTest.cs
  1. … 8 more files in changeset.
Added StructuresCalculationCreateExtensions Related to Issue [WTI-1309]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11015 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bbda6d13c7bf5bb2ce84b33c9188df4feaff679d

Former-commit-id: b1367e9d784077bd00f18cd7e4db95dc11aeb065

    • -0
    • +146
    ./StructuresOutputCreateExtensionsTest.cs
  1. … 4 more files in changeset.
Incorporated relevant review comments 1999 for storage: - Removed irrelevant parts of tests - Cleaned up files (removed unused references) Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11012 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7d1ac860a5ef942d9c535dd91c034beb4f909135

Former-commit-id: 2f5c02359ba787c0a3177f462d3b9ec11d5d36e2

    • -62
    • +48
    ./HydraulicBoundaryLocationOutputCreateExtensionsTest.cs
  1. … 2 more files in changeset.
Renamed variables Added Asserts Added calculated structure calculations without illustration points in RingtoetsProjectTestHelper Cleanup Related to Issue [WTI-1309]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11001 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ce54f1e2a9e510d875193a2dbe7199795c376922

Former-commit-id: d6084a4cc056b814eb536ddcff5f384abba8d6ae

    • -7
    • +20
    ./IllustrationPoints/TopLevelFaultTreeIllustrationPointCreateExtensionsTest.cs
  1. … 8 more files in changeset.
Added TestStructuresOutput with GeneralResult Added asserts Added test for 'Should*IllustrationPointsBeCalculated' flag for hydraulic boundary locations when migrating Related to Issue [WTI-1309]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10995 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3ea6c64c90c6fb15206b8112c0793fe6c8df1187

Former-commit-id: ae27ceba75904d5d52345d2e67cc2d21b25ea9e5

    • -1
    • +1
    ./HydraulicBoundaryLocationCreateExtensionsTest.cs
    • -9
    • +16
    ./HydraulicBoundaryLocationOutputCreateExtensionsTest.cs
    • -19
    • +45
    ./StructuresCalculationCreateExtensionsTest.cs
  1. … 5 more files in changeset.
Incorporated refactoring comments regarding the SetGeneralResult function and constructor arguments for Grass Inwards: - Removed obsolete constructor, it is necessary to always specify a GeneralResult upon instantiation of an output object - Adjusted tests, substituted NULL for elements that do not support GeneralResult yet (e.g. storage)

Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10989 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 628349d572b7af4ff0c049ce0e5dd6479b5eb0bb

Former-commit-id: 14085456e9f03245ac44ce30487deb1601609787

    • -4
    • +4
    ./GrassCoverErosionInwards/GrassCoverErosionInwardsOutputCreateExtensionsTest.cs
  1. … 12 more files in changeset.
Incorporated refactoring comments regarding the SetGeneralResult function and constructor arguments for GrassInwards: - Removed SetGeneralResult for the HydraulicLoadsOutput - Adjusted tests, substituted NULL for elements that do not support GeneralResult yet (e.g. storage) - Preparation to remove obsolete constructor in the HydraulicLoadsOutput Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10983 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5e5569719cf08a0f102f9cd65e89c2c26b28a915

Former-commit-id: 4c7170cf81cc17cc6fbb398ca948efaed8cfaae3

    • -2
    • +2
    ./GrassCoverErosionInwards/DikeHeightOutputCreateExtensionsTest.cs
    • -2
    • +2
    ./GrassCoverErosionInwards/GrassCoverErosionInwardsOutputCreateExtensionsTest.cs
    • -2
    • +2
    ./GrassCoverErosionInwards/OvertoppingRateOutputCreateExtensionsTest.cs
  1. … 18 more files in changeset.
Changed InvalidOperationException to NotSupportedException Renamed variables Added asserts Related to Issue [WTI-1309]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10981 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 72e7493d9fa15dd02253cbcbbc65c7137c1dd004

Former-commit-id: 2da692df54cdbbaa5f6dfa32db122634ec2bcedb

    • -0
    • +2
    ./IllustrationPoints/GeneralResultCreateExtensionsTest.cs
    • -7
    • +12
    ./IllustrationPoints/IllustrationPointNodeCreateExtensionsTest.cs
    • -0
    • +33
    ./IllustrationPoints/TopLevelFaultTreeIllustrationPointCreateExtensionsTest.cs
    • -0
    • +81
    ./IllustrationPoints/TopLevelSubMechanismIllustrationPointCreateExtensionsTest.cs
    • -81
    • +0
    ./IllustrationPoints/TopLevelSubMechanismIllustrationPointTest.cs
  1. … 5 more files in changeset.
Review related changes Removed ITopLevelIllustrationPointEntity interface Related to Issue [WTI-1309]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10977 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8fe8d635e821e7a77cc178226436303116646151

Former-commit-id: 45618fc03476af0b96196cd671313fce795f0e7d

    • -16
    • +42
    ./IllustrationPoints/GeneralResultCreateExtensionsTest.cs
  1. … 8 more files in changeset.
Incorporated refactoring comments regarding the SetGeneralResult function and constructor arguments for Structures: - Removed SetGeneralResult function - Preparation for removing the constructor without GeneralResult

Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10973 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4ff595cc45ef3da259be523660cb018058c8e23b

Former-commit-id: 478f3d8d407b0da1a72aca9e87fb958f50166390

    • -5
    • +2
    ./StructuresCalculationCreateExtensionsTest.cs
  1. … 8 more files in changeset.
Incorporated refactoring comments regarding the SetGeneralResult function and constructor arguments for HBL: - Moved responsibility from location to the output create extensions for creating general result entities. GeneralResult is now part of the output and should therefore be created by the corresponding create extension.

Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10972 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 830f5949c0c0d184fc2dd9a50e303446903ee4f0

Former-commit-id: 1d62aee8d5fc987d06ffb430e2024e07452a3cdf

    • -12
    • +102
    ./HydraulicBoundaryLocationOutputCreateExtensionsTest.cs
  1. … 2 more files in changeset.
Incorporated refactoring comments regarding the SetGeneralResult function and constructor arguments for HBL: - Removed obsolete constructor, it is necessary to always specify a GeneralResult upon instantiation of an output object Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10970 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: eb41f0ab4833bc48bad8991c82fb8c0db2c75733

Former-commit-id: dcf7d62e6779933485bbc11d2c8533cc16ce159c

    • -4
    • +4
    ./HydraulicBoundaryLocationCreateExtensionsTest.cs
    • -4
    • +4
    ./HydraulicBoundaryLocationOutputCreateExtensionsTest.cs
  1. … 12 more files in changeset.
Incorporated refactoring comments regarding the SetGeneralResult function and constructor arguments for HBL: - Removed SetGeneralResult function - Preparation for removing the constructor without GeneralResult - Added HBL testoutput without the necessity to set the result Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10968 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e2d4b83e0f419027400c12339b6a76ce6dd6035e

Former-commit-id: 42e3857807291e0d52a5c547af300ae6923e8c25

    • -8
    • +8
    ./HydraulicBoundaryLocationCreateExtensionsTest.cs
  1. … 20 more files in changeset.
GrassCoverErosionInwardsOvertoppingOutput => GrassCoverErosionInwardsOvertoppingOutput Related to Issue [WTI-1321]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10957 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2760c3ca3ab850b0f02523f976f9881e6ff103c6

Former-commit-id: c67373deb8b1c052232aff4c8b8ef6e021ac2410

    • -6
    • +4
    ./GrassCoverErosionInwards/GrassCoverErosionInwardsOutputCreateExtensionsTest.cs
  1. … 45 more files in changeset.
Rename related changes Related to Issue [WTI-1289]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10889 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 92048a8ec9e185731a056949d5bf655f39519647

Former-commit-id: 0d1dafb90d09cff5e7ba9fb7f05d721ba389008c

    • -0
    • +314
    ./Piping/PipingSurfaceLineCreateExtensionsTest.cs
    • -314
    • +0
    ./Piping/RingtoetsPipingSurfaceLineCreateExtensionsTest.cs
  1. … 70 more files in changeset.
Renamed RingtoetsPipingSurfaceLine to PipingSurfaceLine Related to Issue [WTI-1289]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10887 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 44625899e5ec1f895255bb80a4681e2e7e024bc5

Former-commit-id: a96b95d95796b665ec69d9f16e94467d265dabc0

    • -1
    • +1
    ./Piping/PipingCalculationScenarioCreateExtensionsTest.cs
    • -2
    • +2
    ./Piping/PipingFailureMechanismCreateExtensionsTest.cs
    • -8
    • +8
    ./Piping/RingtoetsPipingSurfaceLineCreateExtensionsTest.cs
  1. … 110 more files in changeset.
Implement review comments 1970: - Refactor HasIllustrationPoints and SetIllustrationPoints to HasGeneralResult and SetGeneralResult - ProbabilityAssessmentOutput in GrassCoverErosionInwardsOvertoppingOutput cannot be null - Improve tests for services and output objects - Move Resources to Common - Correct implementation of IllustrationPointsParserErrorMessage - Made ConvertIllustrationPointsResult private Related to Issue [WTI-1318]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10867 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 26b18ecde3707516f72159c322b00f31c74271a9

Former-commit-id: 693f5a23203efef71b2a492062c80e2d8e3202e3

    • -6
    • +6
    ./HydraulicBoundaryLocationCreateExtensionsTest.cs
    • -8
    • +8
    ./StructuresCalculationCreateExtensionsTest.cs
  1. … 55 more files in changeset.
Incorporated comments review 1959: - Relevant comments for output and some XMLDocs -- Dropped suffix from the GeneralResult in property or functions when relevant Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10804 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4a227e730c8ae252cafc7fe1ad9eaff37fc0ec0f

Former-commit-id: f1ff4647b1b297b3168cf6a96925f192ad8b0948

    • -10
    • +10
    ./HydraulicBoundaryLocationCreateExtensionsTest.cs
  1. … 25 more files in changeset.
Incorporated comments review 1959: - Relevant comments for storage and core.common -- Updated XMLDoc -- Renamed function -- Improved tests

Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10800 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6e23272a101a01689cf7052727e04e17e8520c98

Former-commit-id: 51c5084c3e9669df022cda3f54bdbd92bd624d51

    • -15
    • +3
    ./StructuresCalculationCreateExtensionsTest.cs
  1. … 7 more files in changeset.
Renamed InterfaceExtensions to loose the prefix I Related to Issue [WTI-1309]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10799 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 729fc66975cc5a7291099a220a9f4841b4c2718a

Former-commit-id: 9904632de82905abecd744690b03fd0c5d0b5661

    • -0
    • +121
    ./FailureMechanismCreateExtensionsTest.cs
    • -121
    • +0
    ./IFailureMechanismCreateExtensionsTest.cs
  1. … 18 more files in changeset.
Extended IllustrationPointNodeCreateExtensions to write stochasts Extended StorageSqLiteIntegrationTest Related to Issue [WTI-1309]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10757 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5f438835692add6bcbed4e725a61ed82c2ea219e

Former-commit-id: 42a4d2facb550dd8b1c52c98bff7dde62ce82157

    • -1
    • +43
    ./IllustrationPoints/IllustrationPointNodeCreateExtensionsTest.cs
  1. … 2 more files in changeset.
Added tests Related to Issue [WTI-1309]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10745 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: dd4db502e7a3460aa2d2ec4f0c8decac26a12345

Former-commit-id: 3f5fe6f0a5e59cec226a3b47d6ff2ab42e3c3ffc

    • -0
    • +76
    ./StructuresCalculationCreateExtensionsTest.cs
Saved ShouldIllustrationPointsBeCalculated flag for all structures Related to Issue [WTI-1309]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10711 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b9a8596c55f21c16c75f6e01bea43889d24db57e

Former-commit-id: 07b0f2e0469fa5345e47d0aa775872b30172610c

    • -39
    • +16
    ./StructuresCalculationCreateExtensionsTest.cs
  1. … 2 more files in changeset.
Re-added tests Related to Issue [WTI-1309]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10710 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6dafa6ead32da7246fcca72a109be9e1eb50b700

Former-commit-id: b09342576cced1824753f51138b1dfeb795a677e

    • -0
    • +29
    ./IllustrationPoints/GeneralResultCreateExtensionsTest.cs
    • -0
    • +27
    ./IllustrationPoints/TopLevelFaultTreeIllustrationPointCreateExtensionsTest.cs
Extended IllustrationPointNodeCreateExtensions tests with recursive behaviour Related to Issue [WTI-1309]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10709 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0c6f3c364224e6774f377f50e78de37db14a1e61

Former-commit-id: 0613270164e94ceeb4dec1ac02c60c3eac5a8ec4

    • -0
    • +112
    ./IllustrationPoints/IllustrationPointNodeCreateExtensionsTest.cs
  1. … 5 more files in changeset.
Updated SubMechanismIllustrationPointCreateExtensions to save the order Related to Issue [WTI-1309]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10700 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1e923dfac1210af4600ea62cc8912e155fa61146

Former-commit-id: f2bdf514f5cef6bff64897096a66a598bd738af0

    • -7
    • +10
    ./IllustrationPoints/SubMechanismIllustrationPointCreateExtensionsTest.cs
  1. … 3 more files in changeset.
Added extension method for IllustrationPointNode Related to Issue [WTI-1309]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10699 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: eb9e818b822c03559a4d219d057fd71d45c8f070

Former-commit-id: 22598bf5c70568570deb4574deebfeeb2ee9b9ae

    • -74
    • +0
    ./IllustrationPoints/FaultTreeIllustrationPointCreateExtensionsTest.cs
    • -29
    • +0
    ./IllustrationPoints/GeneralResultCreateExtensionsTest.cs
    • -0
    • +92
    ./IllustrationPoints/IllustrationPointNodeCreateExtensionsTest.cs
    • -28
    • +0
    ./IllustrationPoints/TopLevelFaultTreeIllustrationPointCreateExtensionsTest.cs
  1. … 5 more files in changeset.