Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Implement review comments, update tests, xmldoc and cleanup WTI-1654

    • -2
    • +2
    ./DuneErosion/DuneLocationCalculationCollectionEntityReadExtensionsTest.cs
    • -3
    • +3
    ./DuneErosion/DuneLocationCalculationEntityReadExtensionsTest.cs
    • -2
    • +2
    ./DuneErosion/DuneLocationCalculationOutputEntityReadExtensionsTest.cs
  1. … 4 more files in changeset.
Cleanup - Rename DuneLocationOutputEntity to DuneLocationCalculationOutputEntity: - Fixed compiling errors - Renamed read extension and corresponding test

WTI-1654

    • -2
    • +2
    ./DuneErosion/DuneLocationCalculationCollectionEntityReadExtensionsTest.cs
    • -2
    • +2
    ./DuneErosion/DuneLocationCalculationEntityReadExtensionsTest.cs
    • -0
    • +117
    ./DuneErosion/DuneLocationCalculationOutputEntityReadExtensionsTest.cs
    • -117
    • +0
    ./DuneErosion/DuneLocationOutputEntityReadExtensionsTest.cs
    • -2
    • +2
    ./FailureMechanismEntityReadExtensionsTest.cs
  1. … 12 more files in changeset.
Adjusted StorageSQLIntegrationTest to verify the round trip saving and opening RT projects: - Fixed failiing test: -- CollectionEntities should always be set for the dune failure mechanism meta entity to prevent ArgumentNullExceptions

WTI-1654

    • -2
    • +12
    ./AssessmentSectionEntityReadExtensionsTest.cs
Implement Create and Read Extensions: - Implement read extension methods for the DuneErosionFailureMechanism

WTI-1654

    • -4
    • +132
    ./FailureMechanismEntityReadExtensionsTest.cs
  1. … 1 more file in changeset.
Implement Create and Read Extensions: - Implement read extension methods for collections of DuneLocationCalculation

WTI-1654

    • -0
    • +139
    ./DuneErosion/DuneLocationCalculationCollectionEntityReadExtensionsTest.cs
  1. … 3 more files in changeset.
Implement Create and Read Extensions: - Implement read extension methods for the DuneLocationCalculation

WTI-1654

    • -0
    • +130
    ./DuneErosion/DuneLocationCalculationEntityReadExtensionsTest.cs
  1. … 3 more files in changeset.
Adapt Create and Read Extensions: - Modified extension methods for the DuneLocationOutput --> Cleaned up files, implemented missing NULL check - Adjusted implementation of the Hydraulic Boundary Location Output create extensions --> replaced cast to byte with a convert according to our own guidelines

WTI-1654

    • -1
    • +11
    ./DuneErosion/DuneLocationOutputEntityReadExtensionsTest.cs
  1. … 4 more files in changeset.
Adapt Create and Read Extensions: - Modified extension methods for the DuneLocation --> it has no reference to an output anymore

WTI-1654

    • -63
    • +0
    ./DuneErosion/DuneLocationEntityReadExtensionsTest.cs
  1. … 3 more files in changeset.
Incorporated comments review 2824, rename SetDuneLocationCalculations to SetDuneLocations: - Made the DuneLocations property an IObservableEnumerable --> modifications should not be possible from outside the SetDuneLocations() method to prevent the calculations from getting out of sync with the locations

WTI-1574

    • -4
    • +4
    ./FailureMechanismEntityReadExtensionsTest.cs
  1. … 18 more files in changeset.
Incorporated comments review 2824: - Renamed DuneLocationOutput to DuneLocationCalculationOutput -- Adjusted CreateExtension file names -- Updated function and parameter names where necessary.

WTI-1574

    • -2
    • +2
    ./DuneErosion/DuneLocationEntityReadExtensionsTest.cs
    • -2
    • +2
    ./DuneErosion/DuneLocationOutputEntityReadExtensionsTest.cs
  1. … 42 more files in changeset.
Updated test files for ReadExtensions of the WaveConditionsCalculations: - Added asserts to verify the reference dependent output remains null when the entity has null values

WTI-1706

    • -0
    • +4
    ./GrassCoverErosionOutwards/GrassCoverErosionOutwardsWaveConditionsCalculationEntityReadExtensionsTest.cs
    • -0
    • +4
    ./StabilityStoneCover/StabilityStoneCoverWaveConditionsCalculationEntityReadExtensionsTest.cs
    • -0
    • +4
    ./WaveImpactAsphaltCover/WaveImpactAsphaltCoverWaveConditionsCalculationEntityReadExtensionsTest.cs
Updated ReadExtensions for StabilityStoneCover: -- Cleaned up tests, replaced testcase data with random generators and a separate test asserting NaN / NULL conversions -- Added functionality to read CategoryType

WTI-1706

    • -74
    • +69
    ./StabilityStoneCover/StabilityStoneCoverWaveConditionsCalculationEntityReadExtensionsTest.cs
  1. … 1 more file in changeset.
Updated ReadExtensions for WaveImpactAsphaltCover: -- Cleaned up tests, replaced testcase data with random generators and a separate test asserting NaN / NULL conversions -- Added functionality to read CategoryType

WTI-1706

    • -74
    • +69
    ./WaveImpactAsphaltCover/WaveImpactAsphaltCoverWaveConditionsCalculationEntityReadExtensionsTest.cs
  1. … 1 more file in changeset.
Updated ReadExtensions for GrassCoverErosionOutwards: - Cleaned up tests, replaced testcase data with random generators and a separate test asserting NaN / NULL conversions - Added functionality to Read CategoryType

WTI-1706

    • -74
    • +69
    ./GrassCoverErosionOutwards/GrassCoverErosionOutwardsWaveConditionsCalculationEntityReadExtensionsTest.cs
  1. … 1 more file in changeset.
Update storage tests and extensions with new enum WTI-1693

    • -1
    • +1
    ./DuneErosion/DuneErosionSectionResultEntityReadExtensionsTest.cs
    • -1
    • +1
    ./GrassCoverErosionOutwards/GrassCoverErosionOutwardsSectionResultEntityReadExtensionsTest.cs
    • -1
    • +1
    ./StabilityStoneCover/StabilityStoneCoverSectionResultEntityReadExtensionsTest.cs
    • -1
    • +1
    ./WaveImpactAsphaltCover/WaveImpactAsphaltCoverSectionResultEntityReadExtensionsTest.cs
  1. … 9 more files in changeset.
Applied some final renames. WTI-1698

    • -3
    • +3
    ./HydraulicLocationCalculationEntityReadExtensionsTest.cs
  1. … 4 more files in changeset.
Renamed HydraulicBoundaryLocationOutput into HydraulicBoundaryLocationCalculationOutput. WTI-1698

    • -3
    • +3
    ./HydraulicLocationOutputEntityReadExtensionsTest.cs
  1. … 7 more files in changeset.
Renamed HydraulicBoundaryLocationOutput into HydraulicBoundaryLocationCalculationOutput. WTI-1698

    • -1
    • +1
    ./HydraulicLocationCalculationEntityReadExtensionsTest.cs
    • -3
    • +3
    ./HydraulicLocationOutputEntityReadExtensionsTest.cs
  1. … 87 more files in changeset.
Performed some final cleanups. WTI-1612

    • -6
    • +6
    ./ClosingStructures/ClosingStructuresCalculationEntityReadExtensionsTest.cs
    • -8
    • +8
    ./GrassCoverErosionInwards/GrassCoverErosionInwardsCalculationEntityReadExtensionsTest.cs
    • -6
    • +6
    ./StabilityPointStructures/StabilityPointStructuresCalculationEntityReadExtensionsTest.cs
  1. … 8 more files in changeset.
Review related changes. WTI-1612

    • -1
    • +1
    ./HydraulicLocationOutputEntityReadExtensionsTest.cs
  1. … 6 more files in changeset.
Incorporated comments review 2652: - Updated XMLDocs - Cleaned up tests for consistency

Paired with ~carloslubbers

WTI-1668

    • -3
    • +3
    ./GrassCoverSlipOffInwardsSectionResultEntityReadExtensionsTest.cs
    • -4
    • +4
    ./GrassCoverSlipOffOutwardsSectionResultEntityReadExtensionsTest.cs
    • -4
    • +4
    ./MacroStabilityOutwards/MacroStabilityOutwardsSectionResultEntityReadExtensionsTest.cs
    • -3
    • +3
    ./MicrostabilitySectionResultEntityReadExtensionsTest.cs
    • -3
    • +3
    ./StrengthStabilityLengthwiseConstructionSectionResultEntityReadExtensionsTest.cs
    • -3
    • +3
    ./TechnicalInnovationSectionResultEntityReadExtensionsTest.cs
    • -3
    • +3
    ./WaterPressureAsphaltCoverSectionResultEntityReadExtensionsTest.cs
  1. … 18 more files in changeset.
Adapt read extensions for the section result entities WTI-1668

    • -16
    • +34
    ./GrassCoverSlipOffInwardsSectionResultEntityReadExtensionsTest.cs
    • -17
    • +34
    ./GrassCoverSlipOffOutwardsSectionResultEntityReadExtensionsTest.cs
    • -35
    • +40
    ./MacroStabilityOutwards/MacroStabilityOutwardsSectionResultEntityReadExtensionsTest.cs
    • -39
    • +29
    ./MicrostabilitySectionResultEntityReadExtensionsTest.cs
    • -18
    • +34
    ./PipingStructure/PipingStructureSectionResultEntityReadExtensionsTest.cs
    • -15
    • +31
    ./StrengthStabilityLengthwiseConstructionSectionResultEntityReadExtensionsTest.cs
    • -15
    • +31
    ./TechnicalInnovationSectionResultEntityReadExtensionsTest.cs
    • -15
    • +31
    ./WaterPressureAsphaltCoverSectionResultEntityReadExtensionsTest.cs
  1. … 8 more files in changeset.
Updated Create and read extensions for failure mechanism section results in group 3 (WaveImpactAsphaltCover, DuneErosion, GrassCoverErosionOutwards, StabilityStoneCover) - For Wave Impact

WTI-1667

    • -41
    • +42
    ./WaveImpactAsphaltCover/WaveImpactAsphaltCoverSectionResultEntityReadExtensionsTest.cs
  1. … 3 more files in changeset.
Updated Create and read extensions for failure mechanism section results in group 3 (WaveImpactAsphaltCover, DuneErosion, GrassCoverErosionOutwards, StabilityStoneCover) - For Stability Stone Cover

WTI-1667

    • -41
    • +42
    ./StabilityStoneCover/StabilityStoneCoverSectionResultEntityReadExtensionsTest.cs
  1. … 3 more files in changeset.
Updated Create and read extensions for failure mechanism section results in group 3 (WaveImpactAsphaltCover, DuneErosion, GrassCoverErosionOutwards, StabilityStoneCover) - For Grass Cover Erosion Outwards

WTI-1667

    • -15
    • +43
    ./GrassCoverErosionOutwards/GrassCoverErosionOutwardsSectionResultEntityReadExtensionsTest.cs
  1. … 3 more files in changeset.
Updated Create and read extensions for failure mechanism section results in group 3 (WaveImpactAsphaltCover, DuneErosion, GrassCoverErosionOutwards, StabilityStoneCover) - For dunes - Added missing reference in Storage project

WTI-1667

    • -15
    • +43
    ./DuneErosion/DuneErosionSectionResultEntityReadExtensionsTest.cs
  1. … 5 more files in changeset.
Incorporated comments review 2638: - Fixed inconsistent test names in the read extensions - Added ArgumentNullException when entity is NULL for the PipingSectionResultEntityReadExtension

WTI-1665

    • -2
    • +2
    ./ClosingStructures/ClosingStructuresSectionResultEntityReadExtensionsTest.cs
    • -2
    • +2
    ./GrassCoverErosionInwards/GrassCoverErosionInwardsSectionResultEntityReadExtensionsTest.cs
    • -2
    • +2
    ./HeightStructures/HeightStructuresSectionResultEntityReadExtensionsTest.cs
    • -1
    • +1
    ./MacroStabilityInwards/MacroStabilityInwardsSectionResultEntityReadExtensionsTest.cs
    • -1
    • +13
    ./Piping/PipingSectionResultEntityReadExtensionsTest.cs
    • -2
    • +2
    ./StabilityPointStructures/StabilityPointStructuresSectionResultEntityReadExtensionsTest.cs
  1. … 1 more file in changeset.
Incorporated comments review 2633: - Cleaned up files - Updated XMLDoc - Cleaned up SQL query formatting

WTI-1656

    • -1
    • +0
    ./AssessmentSectionEntityReadExtensionsTest.cs
    • -10
    • +9
    ./HydraulicLocationCalculationEntityReadExtensionsTest.cs
  1. … 8 more files in changeset.
Cleaned up some tests: - Removed obsolete variables - Renamed variables: ManualAssessmentProbability --> ManualAssemblyProbability

WTI-1666

    • -4
    • +0
    ./GrassCoverErosionInwards/GrassCoverErosionInwardsSectionResultEntityReadExtensionsTest.cs
  1. … 3 more files in changeset.
Updated Create and Read extensions for failure mechanism section results in group 2 (piping, macrostability inwards)

WTI-1666

    • -29
    • +22
    ./MacroStabilityInwards/MacroStabilityInwardsSectionResultEntityReadExtensionsTest.cs
    • -28
    • +21
    ./Piping/PipingSectionResultEntityReadExtensionsTest.cs
  1. … 7 more files in changeset.