Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Incorporated comments review 2453: - Removed all combinatorial [Values()] attributes from tests that make use of enums as arguments - Improved tests

WTI-1579

    • -7
    • +7
    ./AssessmentSectionEntityReadExtensionsTest.cs
    • -9
    • +35
    ./ClosingStructures/ClosingStructuresSectionResultEntityReadExtensionsTest.cs
    • -9
    • +37
    ./DuneErosion/DuneErosionSectionResultEntityReadExtensionsTest.cs
    • -7
    • +36
    ./GrassCoverErosionInwards/GrassCoverErosionInwardsSectionResultEntityReadExtensionsTest.cs
    • -11
    • +7
    ./GrassCoverErosionOutwards/GrassCoverErosionOutwardsHydraulicLocationOutputEntityReadExtensionsTest.cs
    • -9
    • +38
    ./GrassCoverErosionOutwards/GrassCoverErosionOutwardsSectionResultEntityReadExtensionsTest.cs
    • -9
    • +38
    ./GrassCoverSlipOffInwardsSectionResultEntityReadExtensionsTest.cs
    • -8
    • +39
    ./GrassCoverSlipOffOutwardsSectionResultEntityReadExtensionsTest.cs
    • -9
    • +35
    ./HeightStructures/HeightStructuresSectionResultEntityReadExtensionsTest.cs
    • -9
    • +6
    ./HydraulicLocationOutputEntityReadExtensionsTest.cs
    • -11
    • +39
    ./MacroStabilityOutwards/MacroStabilityOutwardsSectionResultEntityReadExtensionsTest.cs
    • -9
    • +38
    ./MicrostabilitySectionResultEntityReadExtensionsTest.cs
    • -9
    • +35
    ./Piping/PipingSectionResultEntityReadExtensionsTest.cs
    • -8
    • +39
    ./PipingStructures/PipingStructureSectionResultEntityReadExtensionsTest.cs
    • -7
    • +35
    ./StabilityPointStructures/StabilityPointStructuresSectionResultEntityReadExtensionsTest.cs
  1. … 14 more files in changeset.
Incorporated comments review 2453: - Removed unnecessary casts from the Read- and Create Extensions when the asserts are not driven by the entity, but by the parameters set onto the entity

WTI-1579

    • -5
    • +5
    ./DuneErosion/DuneLocationOutputEntityReadExtensionsTest.cs
    • -3
    • +3
    ./GrassCoverErosionOutwards/GrassCoverErosionOutwardsHydraulicLocationOutputEntityReadExtensionsTest.cs
    • -1
    • +1
    ./HeightStructures/HeightStructuresCalculationEntityReadExtensionsTest.cs
    • -3
    • +3
    ./HydraulicLocationOutputEntityReadExtensionsTest.cs
Incorporated comments review 2453: - Adjusted .gitignore file - Moved files to correct locations - Added ArgumentNullExceptions when missing - Simplified tests - Updated XMLDoc

WTI-1579

    • -1
    • +12
    ./GrassCoverErosionOutwards/GrassCoverErosionOutwardsHydraulicLocationOutputEntityReadExtensionsTest.cs
    • -0
    • +11
    ./HydraulicLocationOutputEntityReadExtensionsTest.cs
  1. … 11 more files in changeset.
Removed derived output from storage. WTI-1591

    • -12
    • +0
    ./GrassCoverErosionInwards/GrassCoverErosionInwardsOutputEntityReadExtensionsTest.cs
  1. … 31 more files in changeset.
Removed read and create extensions for ProbabilityAssessmentOutput. WTI-1590

    • -98
    • +0
    ./ProbabilityAssessmentOutputEntityReadExtensionsTest.cs
  1. … 5 more files in changeset.
Removed ProbabilityAssessmentOutput from StructuresOutput constructor. WTI-1590

    • -7
    • +1
    ./ClosingStructures/ClosingStructuresCalculationEntityReadExtensionsTest.cs
    • -7
    • +1
    ./HeightStructures/HeightStructuresCalculationEntityReadExtensionsTest.cs
    • -7
    • +1
    ./StabilityPointStructures/StabilityPointStructuresCalculationEntityReadExtensionsTest.cs
  1. … 17 more files in changeset.
Removed height stability point specific section result. WTI-1590

    • -4
    • +3
    ./StabilityPointStructures/StabilityPointStructuresSectionResultEntityReadExtensionsTest.cs
  1. … 33 more files in changeset.
Removed height structures specific section result. WTI-1590

    • -3
    • +3
    ./HeightStructures/HeightStructuresSectionResultEntityReadExtensionsTest.cs
  1. … 31 more files in changeset.
Removed closing structures specific section result. WTI-1590

    • -3
    • +3
    ./ClosingStructures/ClosingStructuresSectionResultEntityReadExtensionsTest.cs
  1. … 33 more files in changeset.
Removed closing structures specific section result. WTI-1590

    • -3
    • +3
    ./ClosingStructures/ClosingStructuresSectionResultEntityReadExtensionsTest.cs
  1. … 33 more files in changeset.
Add delta L property to storage WTI-1531

    • -12
    • +40
    ./AssessmentSectionEntityReadExtensionsTest.cs
    • -1
    • +13
    ./ClosingStructures/ClosingStructuresFailureMechanismMetaEntityReadExtensionsTest.cs
    • -0
    • +14
    ./DuneErosion/DuneErosionFailureMechanismMetaEntityReadExtensionsTest.cs
    • -12
    • +30
    ./FailureMechanismEntityReadExtensionsTest.cs
    • -0
    • +14
    ./GrassCoverErosionInwards/GrassCoverErosionInwardsFailureMechanismMetaEntityReadExtensionsTest.cs
    • -0
    • +14
    ./GrassCoverErosionOutwards/GrassCoverErosionOutwardsFailureMechanismMetaEntityReadExtensionsTest.cs
    • -1
    • +14
    ./HeightStructures/HeightStructuresFailureMechanismMetaEntityReadExtensionsTest.cs
    • -48
    • +0
    ./StabilityPointStructures/StabilityPointStructureFailureMechanismMetaEntityReadExtensionsTest.cs
    • -0
    • +62
    ./StabilityPointStructures/StabilityPointStructuresFailureMechanismMetaEntityReadExtensionsTest.cs
    • -1
    • +14
    ./StabilityStoneCover/StabilityStoneCoverFailureMechanismMetaEntityReadExtensionsTest.cs
    • -0
    • +62
    ./WaveImpactAsphaltCover/WaveImpactAsphaltCoverFailureMechanismMetaEntityReadExtensionsTest.cs
  1. … 31 more files in changeset.
Add delta L property to storage WTI-1531

    • -12
    • +40
    ./AssessmentSectionEntityReadExtensionsTest.cs
    • -1
    • +13
    ./ClosingStructures/ClosingStructuresFailureMechanismMetaEntityReadExtensionsTest.cs
    • -0
    • +14
    ./DuneErosion/DuneErosionFailureMechanismMetaEntityReadExtensionsTest.cs
    • -12
    • +30
    ./FailureMechanismEntityReadExtensionsTest.cs
    • -0
    • +14
    ./GrassCoverErosionInwards/GrassCoverErosionInwardsFailureMechanismMetaEntityReadExtensionsTest.cs
    • -0
    • +14
    ./GrassCoverErosionOutwards/GrassCoverErosionOutwardsFailureMechanismMetaEntityReadExtensionsTest.cs
    • -1
    • +14
    ./HeightStructures/HeightStructuresFailureMechanismMetaEntityReadExtensionsTest.cs
    • -48
    • +0
    ./StabilityPointStructures/StabilityPointStructureFailureMechanismMetaEntityReadExtensionsTest.cs
    • -0
    • +62
    ./StabilityPointStructures/StabilityPointStructuresFailureMechanismMetaEntityReadExtensionsTest.cs
    • -1
    • +14
    ./StabilityStoneCover/StabilityStoneCoverFailureMechanismMetaEntityReadExtensionsTest.cs
    • -0
    • +62
    ./WaveImpactAsphaltCover/WaveImpactAsphaltCoverFailureMechanismMetaEntityReadExtensionsTest.cs
  1. … 31 more files in changeset.
Updated mappings Create and Read Extensions for HBL calculations: - Entity framework maps the entities in a reverse order on the foreign keys when mapping

WTI-1579

    • -24
    • +24
    ./HydraulicLocationEntityReadExtensionsTest.cs
  1. … 3 more files in changeset.
Merge branch '1579'

# Conflicts:

# Application/Ringtoets/src/Application.Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure18.1.sql

# Application/Ringtoets/src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql

# Application/Ringtoets/src/Application.Ringtoets.Storage/DbContext/RingtoetsEntities.edmx.diagram

# Application/Ringtoets/src/Application.Ringtoets.Storage/Ringtoets.rtd

# Application/Ringtoets/test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject181.rtd

# Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs

# build/DatabaseStructure.sql

# design/DatabaseDesign.eap

    • -20
    • +19
    ./AssessmentSectionEntityReadExtensionsTest.cs
  1. … 107 more files in changeset.
Adapt storage with the N parameter for the Piping Structure failure mechanism WTI-1531

    • -0
    • +248
    ./FailureMechanismEntityReadExtensionsTest.cs
  1. … 21 more files in changeset.
Removed semi probabilistic output property from overtopping output. WTI-1589

    • -13
    • +0
    ./GrassCoverErosionInwards/GrassCoverErosionInwardsOutputEntityReadExtensionsTest.cs
  1. … 18 more files in changeset.
Adapt storage to include the macro stability outwards probability assessment input WTI-1531

    • -11
    • +48
    ./AssessmentSectionEntityReadExtensionsTest.cs
    • -0
    • +79
    ./MacroStabilityOutwards/MacroStabilityOutwardsFailureMechanismMetaEntityReadExtensionsTest.cs
    • -0
    • +83
    ./MacroStabilityOutwards/MacroStabilityOutwardsSectionResultEntityReadExtensionsTest.cs
    • -82
    • +0
    ./MacroStabilityOutwardsSectionResultEntityReadExtensionsTest.cs
  1. … 32 more files in changeset.
Resolved by: - Discarding their changes on binary files - Merging .sql files

Merge branch 'master' into 1579

# Conflicts:

# Application/Ringtoets/src/Application.Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure18.1.sql

# Application/Ringtoets/src/Application.Ringtoets.Storage/DbContext/RingtoetsEntities.edmx.diagram

# Application/Ringtoets/src/Application.Ringtoets.Storage/Ringtoets.rtd

# build/DatabaseStructure.sql

# design/DatabaseDesign.eap

    • -2
    • +6
    ./AssessmentSectionEntityReadExtensionsTest.cs
  1. … 5 more files in changeset.
Start renaming MacrostabilityOutwards -> MacroStabilityOutwards Start implementing probability assessment input and properties for macro stability outwards failure mechanism WTI-1531

    • -2
    • +2
    ./AssessmentSectionEntityReadExtensionsTest.cs
    • -0
    • +82
    ./MacroStabilityOutwardsSectionResultEntityReadExtensionsTest.cs
    • -81
    • +0
    ./MacrostabilityOutwardsSectionResultEntityReadExtensionsTest.cs
  1. … 62 more files in changeset.
Fixed test in storage. WTI-1589

    • -0
    • +2
    ./GrassCoverErosionInwards/GrassCoverErosionInwardsOutputEntityReadExtensionsTest.cs
  1. … 2 more files in changeset.
Adapt N parameter in stability point structures failure mechanism to be a double on the data model and storage WTI-1531

    • -2
    • +2
    ./FailureMechanismEntityReadExtensionsTest.cs
  1. … 16 more files in changeset.
Add N parameter to the grass cover erosion inwards, outwards and height structures failuremechanism database entities WTI-1531

    • -2
    • +6
    ./AssessmentSectionEntityReadExtensionsTest.cs
    • -3
    • +7
    ./FailureMechanismEntityReadExtensionsTest.cs
    • -2
    • +3
    ./GrassCoverErosionInwards/GrassCoverErosionInwardsFailureMechanismMetaEntityReadExtensionsTest.cs
    • -2
    • +3
    ./GrassCoverErosionOutwards/GrassCoverErosionOutwardsFailureMechanismMetaEntityReadExtensionsTest.cs
    • -1
    • +2
    ./HeightStructures/HeightStructuresFailureMechanismMetaEntityReadExtensionsTest.cs
  1. … 19 more files in changeset.
Resolved by: - temporarily discarding their changes when concerning a binary file - .sql files were merged accordingly

Merge branch 'master' into 1579

# Conflicts:

# Application/Ringtoets/src/Application.Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure18.1.sql

# Application/Ringtoets/src/Application.Ringtoets.Storage/DbContext/RingtoetsEntities.edmx

# Application/Ringtoets/src/Application.Ringtoets.Storage/DbContext/RingtoetsEntities.edmx.diagram

# Application/Ringtoets/src/Application.Ringtoets.Storage/Ringtoets.rtd

# build/DatabaseStructure.sql

# design/DatabaseDesign.eap

    • -3
    • +10
    ./AssessmentSectionEntityReadExtensionsTest.cs
  1. … 5 more files in changeset.
Adapt data model to include an N length effect parameter for the grass cover in/outwards, height structures and dune erosion failure mechanisms. WTI-1531

    • -2
    • +2
    ./AssessmentSectionEntityReadExtensionsTest.cs
    • -1
    • +1
    ./ClosingStructures/ClosingStructuresFailureMechanismMetaEntityReadExtensionsTest.cs
    • -5
    • +7
    ./FailureMechanismEntityReadExtensionsTest.cs
    • -3
    • +5
    ./GrassCoverErosionInwards/GrassCoverErosionInwardsFailureMechanismMetaEntityReadExtensionsTest.cs
    • -3
    • +5
    ./GrassCoverErosionOutwards/GrassCoverErosionOutwardsFailureMechanismMetaEntityReadExtensionsTest.cs
    • -2
    • +2
    ./HeightStructures/HeightStructuresFailureMechanismMetaEntityReadExtensionsTest.cs
    • -1
    • +1
    ./StabilityPointStructures/StabilityPointStructureFailureMechanismMetaEntityReadExtensionsTest.cs
  1. … 30 more files in changeset.
Adapted MacroStabilityInwardsInput (only holds manual assessment level). WTI-1562

    • -2
    • +4
    ./MacroStabilityInwards/MacroStabilityInwardsCalculationEntityReadExtensionsTest.cs
  1. … 1 more file in changeset.
Introduced a HydraulicLocationEntityTestFactory: - Used te generate minimal hydraulic location entities that are accepted by the its read extensions - Implemented factory creation method in the tests that make use of HydraulicLocationEntities

WTI-1579

    • -20
    • +19
    ./AssessmentSectionEntityReadExtensionsTest.cs
    • -4
    • +2
    ./GrassCoverErosionInwards/GrassCoverErosionInwardsCalculationEntityReadExtensionsTest.cs
    • -5
    • +2
    ./Piping/PipingCalculationEntityReadExtensionsTest.cs
    • -5
    • +2
    ./StabilityStoneCover/StabilityStoneCoverWaveConditionsCalculationEntityReadExtensionsTest.cs
    • -5
    • +2
    ./WaveImpactAsphaltCover/WaveImpactAsphaltCoverWaveConditionsCalculationEntityReadExtensionsTest.cs
  1. … 4 more files in changeset.
Fixed test for the HydraulicLocationEntity read extensions

WTI-1579

    • -1
    • +10
    ./HydraulicLocationEntityReadExtensionsTest.cs
Adjusted the read extensions for the HydraulicBoundaryLocations

WTI-1579

    • -107
    • +139
    ./HydraulicLocationEntityReadExtensionsTest.cs
  1. … 1 more file in changeset.
Separated the read extensions for the HydraulicBoundaryLocationOutput into two separate implementations: - Removed obsolete interface => there's no 100% common ground between the entities anymore and thus the extensions should be separated.

WTI-1579

    • -1
    • +1
    ./GrassCoverErosionOutwards/GrassCoverErosionOutwardsHydraulicLocationEntityReadExtensionsTest.cs
  1. … 6 more files in changeset.
Separated the read extensions for the Hydraulic Boundary Location Output into two separate implementations

WTI-1579

    • -0
    • +222
    ./GrassCoverErosionOutwards/GrassCoverErosionOutwardsHydraulicLocationOutputEntityReadExtensionsTest.cs
    • -16
    • +3
    ./HydraulicLocationOutputEntityReadExtensionsTest.cs
  1. … 5 more files in changeset.