Riskeer / Application / Ringtoets

test

Clone Tools

Stats

Commits this week: 0
Total Committers: 9
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 03 Apr 2018
2:58 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup - Fixed failing migrationintegration tests on older files ( fileversion < 17.3): - Adjusted row entries for the GrassCoverErosionOutwardsHydraulicLocationEntity to match with the hydraulic location rows on assessment section level (HydraulicLocationEntity) --> not possible to have different HBL on failure mechanism level and assessment section level in application

WTI-1657

Options
    • binary
    ./Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject164.rtd
    • binary
    ./Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject171.rtd
    • binary
    ./Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject172.rtd
2:48 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup - Fixed failing test: - Migrated project to 181 standards such that the latest project can be opened as well

WTI-1656

Options
    • binary
    ./Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject181.rtd
2:48 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup - Fixed failing test: - Migrated project to 181 standards such that the latest project can be opened as well

WTI-1657

Options
    • binary
    ./Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject181.rtd
2:38 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup: - Extracted generic subqueries to separate functions when validating hydraulic boundary locations on failure mechanism level - Fixed typo - Ran DeltaresClean

WTI-1656

Options
    • -46
    • +33
    ./Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
2:38 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup: - Extracted generic subqueries to separate functions when validating hydraulic boundary locations on failure mechanism level - Fixed typo - Ran DeltaresClean

WTI-1657

Options
    • -46
    • +33
    ./Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
2:27 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup: - Extracted generic subqueries to separate functions when validating hydraulic boundary locations on assessment section level

WTI-1657

Options
    • -44
    • +30
    ./Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
2:27 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup: - Extracted generic subqueries to separate functions when validating hydraulic boundary locations on assessment section level

WTI-1656

Options
    • -44
    • +30
    ./Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
1:40 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup: - Renamed the query generator for generating validation queries of HBL on AssessmentSection level

WTI-1657

Options
    • -26
    • +26
    ./Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
1:40 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup: - Renamed the query generator for generating validation queries of HBL on AssessmentSection level

WTI-1656

Options
    • -26
    • +26
    ./Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
1:35 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted Migration to 181 integration scripts - Added asserts for the hydraulic boundary location inputs for grass cover erosion outwards - Adjusted migration script and the database structure.sql file for 181

WTI-1657

Options
    • -3
    • +388
    ./Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
  2. … 2 more files in changeset.
1:35 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted Migration to 181 integration scripts - Added asserts for the hydraulic boundary location inputs for grass cover erosion outwards - Adjusted migration script and the database structure.sql file for 181

WTI-1657

Options
    • -3
    • +388
    ./Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
  2. … 2 more files in changeset.
10:50 am

Dennis Tang <dennis.tang@deltares.nl>

Adjusted Migration to 181 integration test - Renamed query generator to indicate it's only relevant for generating queries on assessment section level - Extracted functions to a higher level when asserting the general properties of hydraulic boundary locations (e.g. calculations, property values etc.) - Moved NormativeNormType enum to a higher level such that it can be used for the query generator on failure mechanism level

WTI-1657

Options
    • -120
    • +120
    ./Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
Friday 30 Mar 2018
11:54 am

Dennis Tang <dennis.tang@deltares.nl>

Adjusted test file for migration: - Adjusted row entries for the GrassCoverErosionOutwardsHydraulicLocationEntity to match with the hydraulic location rows on assessment section level (HydraulicLocationEntity) --> not possible to have different HBL on failure mechanism level and assessment section level in application

WTI-1657

Options
    • binary
    ./Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject173.rtd
11:36 am

Dennis Tang <dennis.tang@deltares.nl>

Adjusted test file for migration: - Generated calculation output for grass cover erosion outwards HBL

WTI-1657

Options
    • binary
    ./Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject173.rtd
11:00 am

Dennis Tang <dennis.tang@deltares.nl>

Adjusted StorageSQLiteIntegrationTest for grass cover erosion outwards failure mechanism - Added missing asserts for asserting the configuration of the hydraulic boundary locations on failure mechanism level

WTI-1657

Options
    • -0
    • +19
    ./Application.Ringtoets.Storage.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
10:49 am

Dennis Tang <dennis.tang@deltares.nl>

Adjusted RingtoetsProjectTestHelper for grass cover erosion outwards failure mechanism - Removed setting hydraulic boundary locations on the failure mechanism --> feature will become obsolete - Added functionality to set the values on the calculations of the failure mechanism - Refactored: -- Made configuration of HBL more generic across the testhelper

WTI-1657

Options
    • -2
    • +58
    ./Application.Ringtoets.Storage.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
    • -44
    • +100
    ./Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
9:34 am

Dennis Tang <dennis.tang@deltares.nl>

Adjusted Create and Read extensions for grass cover erosion outwards failure mechanism - Rewired calculations to read and create references of hydraulic location entities

WTI-1657

Options
    • -7
    • +8
    ./Application.Ringtoets.Storage.Test/Create/GrassCoverErosionOutwards/GrassCoverErosionOutwardsWaveConditionsCalculationCreateExtensionsTest.cs
    • -26
    • +4
    ./Application.Ringtoets.Storage.Test/Read/GrassCoverErosionOutwards/GrassCoverErosionOutwardsWaveConditionsCalculationEntityReadExtensionsTest.cs
  3. … 2 more files in changeset.
9:18 am

Dennis Tang <dennis.tang@deltares.nl>

Adjusted Create and Read extensions for grass cover erosion outwards failure mechanism - Removed typed Get-function for the hydraulic boundary locations in the persistence registry --> only one type of HydraulicBoundaryLocationEntity exists and thus is typing not necessary

WTI-1657

Options
    • -1
    • +1
    ./Application.Ringtoets.Storage.Test/Create/PersistenceRegistryTest.cs
  2. … 7 more files in changeset.
9:07 am

Dennis Tang <dennis.tang@deltares.nl>

Adjusted Create and Read extensions for grass cover erosion outwards failure mechanism - Removed all files and functionality related to creating/reading the HydraulicBoundaryLocationEntity and the HydraulicBoundaryLocationOutputEntity for specific grass cover erosion outwards failure mechanism

WTI-1657

Options
    • -2
    • +0
    ./Application.Ringtoets.Storage.Test/Application.Ringtoets.Storage.Test.csproj
    • -176
    • +0
    ./Application.Ringtoets.Storage.Test/Create/HydraulicBoundaryLocationCreateExtensionsTest.cs
    • -89
    • +0
    ./Application.Ringtoets.Storage.Test/Create/HydraulicBoundaryLocationOutputCreateExtensionsTest.cs
    • -19
    • +0
    ./Application.Ringtoets.Storage.Test/Create/PersistenceRegistryTest.cs
    • -294
    • +0
    ./Application.Ringtoets.Storage.Test/Read/GrassCoverErosionOutwards/GrassCoverErosionOutwardsHydraulicLocationEntityReadExtensionsTest.cs
    • -229
    • +0
    ./Application.Ringtoets.Storage.Test/Read/GrassCoverErosionOutwards/GrassCoverErosionOutwardsHydraulicLocationOutputEntityReadExtensionsTest.cs
    • -20
    • +0
    ./Application.Ringtoets.Storage.Test/Read/ReadConversionCollectorTest.cs
  8. … 10 more files in changeset.
Thursday 29 Mar 2018
4:07 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted ReadExtensions for grass cover erosion outwards failure mechanism - Adjusted the AssessmentSectionReadExtensions --> should be responsible for configuring the failuremechanism before reading failure mechanism related data -- Cleaned up tests and fixed failing ones

WTI-1657

Options
    • -58
    • +100
    ./Application.Ringtoets.Storage.Test/Read/AssessmentSectionEntityReadExtensionsTest.cs
  2. … 1 more file in changeset.
4:07 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted ReadExtensions for grass cover erosion outwards failure mechanism - Adjusted the FailureMechanismSectionEntityReadExtensions

WTI-1657

Options
    • -39
    • +135
    ./Application.Ringtoets.Storage.Test/Read/FailureMechanismEntityReadExtensionsTest.cs
  2. … 1 more file in changeset.
4:07 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted CreateExtensions for grass cover erosion outwards failure mechanism: - Adjusted tests to verify that the HBL Calculations are written to the correct entities

WTI-1657

Options
    • -18
    • +97
    ./Application.Ringtoets.Storage.Test/Create/GrassCoverErosionOutwards/GrassCoverErosionOutwardsFailureMechanismCreateExtensionsTest.cs
  2. … 1 more file in changeset.
Wednesday 28 Mar 2018
12:01 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup: - Removed constraint on the combination of FKs of calculation collections (constraint was not present in the previous implementation)

WTI-1656

Options
    • binary
    ./Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject181.rtd
  2. … 5 more files in changeset.
11:24 am

Dennis Tang <dennis.tang@deltares.nl>

Cleanup: - Added missing asserts upon migration - Renamed the query generator functions to better distinct between HBL calculations that are migrated and HBL calculations that are newly created

WTI-1656

Options
    • -30
    • +54
    ./Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
10:41 am

Dennis Tang <dennis.tang@deltares.nl>

Cleanup: - Updated the latest file version for the migration scripts to fix failing test

WTI-1656

Options
    • binary
    ./Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject181.rtd
10:19 am

Dennis Tang <dennis.tang@deltares.nl>

Adjusted migration script and asserts: - Migrated the hydraulic location output based on the normative norm and mapped them onto the new HydraulicLocationOutputEntity and the corresponding HydraulicLocationCalculationEntities

WTI-1656

Options
    • -35
    • +157
    ./Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
  2. … 1 more file in changeset.
Tuesday 27 Mar 2018
3:31 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted migration script and asserts: - Migrated the hydraulic location input based on the normative norm and mapped them onto the new HydraulicLocationCalculationEntity - Refactored test

Note: output is not migrated yet

WTI-1656

Options
    • -13
    • +140
    ./Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
  2. … 1 more file in changeset.
11:52 am

Dennis Tang <dennis.tang@deltares.nl>

Adjusted migration script and asserts: - Migrated the hydraulic location calculations and mapped them onto the assessment section conform the new design of the database - Removed obsolete queries from the generator

Note: output is not migrated yet

WTI-1656

Options
    • -192
    • +150
    ./Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
  2. … 1 more file in changeset.
Thursday 22 Mar 2018
3:54 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted StorageIntegrationTest: - Removed asserting calculation input on the location calculations (due to deprecated feature) - Added assertion logic on the assessment section instead

WTI-1656

Options
    • -8
    • +34
    ./Application.Ringtoets.Storage.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
3:14 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted RingtoetsProjectTestHelper: - Removed setting calculation input on the location calculations (due to deprecated feature) - Added hydraulic boundary location input settings on the assessment section instead

WTI-1656

Options
    • -31
    • +60
    ./Application.Ringtoets.Storage.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
    • -58
    • +59
    ./Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs