Riskeer / Application / Ringtoets

test

Clone Tools

Stats

Commits this week: 0
Total Committers: 9
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 12 Oct 2017
4:30 pm

Dennis Tang <dennis.tang@deltares.nl>

Temporarily reverted revision 12140 from trunk: Added read and create extensions: - Expanded the calculation group -- Read and Create added to read or create the entities for macrostability inwards calculation (scenario) - Expanded asserts on the piping side: -- Removed .Value access in the tests => use .GetAccuracy instead of accessing the private variable of a RoundedDouble -- Added asserts on the output values when creating or reading piping (semiprobabilistic) output entities - Added entities to explicitly load in the PartialRingtoetsEntities

Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12144 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c7233860a302774e36a2afb8369cd52fefc6e9d5

Former-commit-id: bda4a8bc802d69ec5dfc2a61f5175b5e91b846d1

Options
    • -11
    • +0
    ./Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsCalculationScenarioCreateExtensionsTest.cs
    • -40
    • +0
    ./Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsFailureMechanismCreateExtensionsTest.cs
    • -2
    • +0
    ./Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsOutputCreateExtensionsTest.cs
    • -18
    • +10
    ./Application.Ringtoets.Storage.Test/Create/Piping/PipingFailureMechanismCreateExtensionsTest.cs
    • -48
    • +0
    ./Application.Ringtoets.Storage.Test/Read/FailureMechanismEntityReadExtensionsTest.cs
  6. … 3 more files in changeset.
3:02 pm

Dennis Tang <dennis.tang@deltares.nl>

Added read and create extensions: - Expanded the calculation group -- Read and Create added to read or create the entities for macrostability inwards calculation (scenario) - Expanded asserts on the piping side: -- Removed .Value access in the tests => use .GetAccuracy instead of accessing the private variable of a RoundedDouble -- Added asserts on the output values when creating or reading piping (semiprobabilistic) output entities - Added entities to explicitly load in the PartialRingtoetsEntities

Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12140 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6e7e81968638b8b31efb48bc2d1e418987134250

Former-commit-id: 6164cd4f05cdc0196dc7c5b9b5b5b33a9dfb189d

Options
    • -0
    • +11
    ./Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsCalculationScenarioCreateExtensionsTest.cs
    • -0
    • +40
    ./Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsFailureMechanismCreateExtensionsTest.cs
    • -0
    • +2
    ./Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsOutputCreateExtensionsTest.cs
    • -10
    • +18
    ./Application.Ringtoets.Storage.Test/Create/Piping/PipingFailureMechanismCreateExtensionsTest.cs
    • -0
    • +48
    ./Application.Ringtoets.Storage.Test/Read/FailureMechanismEntityReadExtensionsTest.cs
  6. … 3 more files in changeset.
2:15 pm

Dennis Tang <dennis.tang@deltares.nl>

Added read and create extensions: - Expanded the calculation group -- Read and Create added to read or create the entities for macrostability inwards calculation (scenario) - Expanded asserts on the piping side: -- Removed .Value access in the tests => use .GetAccuracy instead of accessing the private variable of a RoundedDouble -- Added asserts on the output values when creating or reading piping (semiprobabilistic) output entities

Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12139 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 488e140c131a119129b7ba14f39c0f5242e92369

Former-commit-id: 5f69943fcc1b44c327c7997be19f002f1f4dc2c3

Options
    • -0
    • +89
    ./Application.Ringtoets.Storage.Test/Create/CalculationGroupCreateExtensionsTest.cs
    • -2
    • +32
    ./Application.Ringtoets.Storage.Test/Create/Piping/PipingCalculationScenarioCreateExtensionsTest.cs
    • -5
    • +6
    ./Application.Ringtoets.Storage.Test/Create/Piping/PipingOutputCreateExtensionsTest.cs
    • -0
    • +199
    ./Application.Ringtoets.Storage.Test/Read/CalculationGroupEntityReadExtentionsTest.cs
    • -6
    • +32
    ./Application.Ringtoets.Storage.Test/Read/Piping/PipingCalculationEntityReadExtensionsTest.cs
  6. … 2 more files in changeset.
1:19 pm

Dennis Tang <dennis.tang@deltares.nl>

Added read and create extensions: - Done for the calculation scenario -- Improved for the piping equivalent - Introduced entity testhelper to assert entity property values for the macrostability inwards calculations scenarios - Renamed functions to better reflect what they do

Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12135 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a0e33b7f224bb8df0e64ab081d2e265290785d81

Former-commit-id: 5c8ec47fa3cf57b16e93955326a97b3e4630de91

Options
    • -0
    • +2
    ./Application.Ringtoets.Storage.Test/Application.Ringtoets.Storage.Test.csproj
    • -0
    • +379
    ./Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsCalculationScenarioCreateExtensionsTest.cs
    • -1
    • +34
    ./Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsOutputCreateExtensionsTest.cs
    • -7
    • +2
    ./Application.Ringtoets.Storage.Test/Create/Piping/PipingCalculationScenarioCreateExtensionsTest.cs
    • -0
    • +306
    ./Application.Ringtoets.Storage.Test/Read/MacroStabilityInwards/MacroStabilityInwardsCalculationEntityReadExtensionsTest.cs
    • -1
    • +1
    ./Application.Ringtoets.Storage.Test/Read/Piping/PipingCalculationEntityReadExtensionsTest.cs
    • -0
    • +1
    ./Application.Ringtoets.Storage.TestUtil/Application.Ringtoets.Storage.TestUtil.csproj
    • -0
    • +160
    ./Application.Ringtoets.Storage.TestUtil/MacroStabilityInwards/MacroStabilityInwardsCalculationEntityTestHelper.cs
    • -1
    • +2
    ./Application.Ringtoets.Storage.TestUtil/MacroStabilityInwards/MacroStabilityInwardsCalculationOutputEntityTestHelper.cs
  10. … 5 more files in changeset.
Wednesday 11 Oct 2017
2:20 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduced test factory to create slices with concrete values Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12122 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4b4bf28e1db3343c10d773aa84f25ed19c05e07f

Former-commit-id: fdcce846d6e3d7696034175f86fc0c88d3dd6e43

Options
    • -55
    • +8
    ./Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsOutputCreateExtensionsTest.cs
    • -49
    • +8
    ./Application.Ringtoets.Storage.Test/Read/MacroStabilityInwards/MacroStabilityInwardsCalculationOutputEntityReadExtensionsTest.cs
  3. … 4 more files in changeset.
2:03 pm

Dennis Tang <dennis.tang@deltares.nl>

Added read and create extensions: - Done for the output - Synchronised implementations of piping with MacroStabilityInwards => when NULL arguments are passed, ArgumentNullException thrown - Replaced CollectionAssert with TestHelper assert which uses an EqualityComparer - Introduced entity test helper to assert the macro stability inwards output entity values Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12118 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 52251d30085ed9d1788770c79e711eeb607b461f

Former-commit-id: e7c9cc3302b31e7a805515cf01c77620e44aaafe

Options
    • -0
    • +2
    ./Application.Ringtoets.Storage.Test/Application.Ringtoets.Storage.Test.csproj
    • -0
    • +207
    ./Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsOutputCreateExtensionsTest.cs
    • -6
    • +12
    ./Application.Ringtoets.Storage.Test/Create/Piping/PipingOutputCreateExtensionsTest.cs
    • -0
    • +204
    ./Application.Ringtoets.Storage.Test/Read/MacroStabilityInwards/MacroStabilityInwardsCalculationOutputEntityReadExtensionsTest.cs
    • -0
    • +12
    ./Application.Ringtoets.Storage.Test/Read/Piping/PipingCalculationOutputEntityReadExtensionsTest.cs
    • -45
    • +44
    ./Application.Ringtoets.Storage.Test/Serializers/MacroStabilityInwardsSliceXmlSerializerTest.cs
    • -0
    • +1
    ./Application.Ringtoets.Storage.TestUtil/Application.Ringtoets.Storage.TestUtil.csproj
    • -0
    • +145
    ./Application.Ringtoets.Storage.TestUtil/MacroStabilityInwards/MacroStabilityInwardsCalculationOutputEntityTestHelper.cs
  9. … 5 more files in changeset.
11:31 am

Dennis Tang <dennis.tang@deltares.nl>

- Removed obsolete columns for the output entity: -- GridAutomaticallyCalculated -- ForbiddenZonesAutomaticallyCalculated - Renamed TangentLinesXml to SlipPlaneTangentLinesXml to indicate it belongs to a slipplane - Cleaned up test Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12110 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8820f65107597f06dc52f25ff51b5faa9b7de68e

Former-commit-id: 2659f888f976aff2e2757017d09468b89a5cc3a7

Options
    • -6
    • +0
    ./Application.Ringtoets.Storage.Test/Create/Piping/PipingSemiProbabilisticOutputCreateExtensionsTest.cs
  2. … 6 more files in changeset.
Tuesday 10 Oct 2017
5:11 pm

Dennis Tang <dennis.tang@deltares.nl>

Added read and create extensions: - Done for the semi probabilistic output - Renamed column name for the factor of stability -- Updated database, entities and sql files - Synchronised implementations of piping with MacroStabilityInwards => when NULL arguments are passed, ArgumentNullException thrown Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12097 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 74daeaea7a3522e36dc91931346a65599610abdc

Former-commit-id: ee9127a39b16e5ca0897c8f87bc54ca442c107b0

Options
    • -0
    • +2
    ./Application.Ringtoets.Storage.Test/Application.Ringtoets.Storage.Test.csproj
    • -0
    • +102
    ./Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsSemiProbabilisticOutputCreateExtensionsTest.cs
    • -0
    • +11
    ./Application.Ringtoets.Storage.Test/Create/Piping/PipingSemiProbabilisticOutputCreateExtensionsTest.cs
    • -0
    • +105
    ./Application.Ringtoets.Storage.Test/Read/MacroStabilityInwards/MacroStabilityInwardsSemiProbabilisticOutputEntityReadExtensionsTest.cs
    • -0
    • +12
    ./Application.Ringtoets.Storage.Test/Read/Piping/PipingSemiProbabilisticOutputEntityReadExtensionsTest.cs
  6. … 11 more files in changeset.
4:09 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated database design to enable NaN values for the stochastic distribution properties of preconsolidation stresses: - Updated Create and Read extensions - Regenerated affected entities

Related to Issue [WTI-1341]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12091 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 941b6380ef22f6ecbc2ad888f86259ac97d1f131

Former-commit-id: 7b36beb1a8a2b33c953ede3bcec0ba3a0511ef68

Options
    • -0
    • +24
    ./Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsPreconsolidationStressCreateExtensionsTest.cs
    • -4
    • +31
    ./Application.Ringtoets.Storage.Test/Read/MacroStabilityInwards/MacroStabilityInwardsPreconsolidationStressEntityReadExtensionsTest.cs
  3. … 8 more files in changeset.
Monday 09 Oct 2017
1:12 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2151 - Editorial edits Related to Issue [WTI-1340]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12060 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 89aedbfe61d9ae43c0e08e9f026e83d7e2849153

Former-commit-id: e3a88f9aaf5cfbb664aa3ab4a2d3e5e64909b899

Options
    • -1
    • +0
    ./Application.Ringtoets.Storage.Test/Read/MacroStabilityInwards/MacroStabilityInwardsSoilProfileTwoDEntityReadExtensionsTest.cs
    • -114
    • +13
    ./Application.Ringtoets.Storage.Test/Read/StochasticSoilModelEntityReadExtensionsTest.cs
  3. … 8 more files in changeset.
8:07 am

Robert Tangerman <robert.tangerman@deltares.nl>

Applied review comments. Related to Issue [WTI-1405]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12048 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 709f60eea6e3a7e6fd8903174f90c1668aee26b1

Former-commit-id: 72bcaa67392ff9215e48ce7643feed5c6c2242b3

Options
    • -1
    • +1
    ./Application.Ringtoets.Storage.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
  2. … 4 more files in changeset.
Friday 06 Oct 2017
2:31 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Applied review comments. Related to Issue [WTI-1405]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12042 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6c420511eed191349016b3037be537fe75317235

Former-commit-id: 3b853d5c09d573b9a0dbfabeee4526006f76d657

Options
    • -3
    • +3
    ./Application.Ringtoets.Storage.Test/Read/MacroStabilityInwards/MacroStabilityInwardsSoilLayerTwoDEntityReadExtensionsTest.cs
  2. … 2 more files in changeset.
11:00 am

Carlos Lubbers

Implement review comments, change test names and use test objects Related to Issue [WTI-1391]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12038 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6fa9f00269e9942f554d425998fc4e5fb1f7df8d

Former-commit-id: e98c0531b4907bb6f6b5c4887605d6b89f839797

Options
    • -3
    • +3
    ./Application.Ringtoets.Storage.Test/Create/IllustrationPoints/TopLevelFaultTreeIllustrationPointCreateExtensionsTest.cs
  2. … 2 more files in changeset.
Thursday 05 Oct 2017
3:04 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed unsupported unicode characters to align nr. of tests between the buildserver agents

Discussed with ~kleijn

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12035 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: df47312e7039933edf6aadf02940fe411115a731

Former-commit-id: 0ea85c37790a4f4b484a2bd737e134a731a9692e

Options
    • -3
    • +0
    ./Application.Ringtoets.Storage.Test/IntegrationTests/MigrationIntegrationTest.cs
11:49 am

Dennis Tang <dennis.tang@deltares.nl>

- (Re)added the SourceType byte property in the entity => Create was never writing to this property. Added missing assert to maintain behaviour - Added resource string representations for the SoilProfileType => associated properties class can use the EnumTypeConverter instead of explicit returning strings with an if-else structure Related to Issue [WTI-1433]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12031 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a55d3e224480f04a30526a6245a75e6743f9fc73

Former-commit-id: c14ead5c2ea7e99492b6bf8281648e10bc1be400

Options
    • -3
    • +8
    ./Application.Ringtoets.Storage.Test/Create/Piping/PipingSoilProfileCreateExtensionsTest.cs
  2. … 10 more files in changeset.
9:50 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments dev: - Moved validation logic from readers to transformers and RT datamodel (stochastic soil profiles, piping only): -- Added validation logic to determine whether the stochastic soil profiles are empty => If empty, exception Related to Issue [WTI-1340]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12025 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 10207106ad89bcf18173ad96dc33515ef9afdfe6

Former-commit-id: 90740578a43ce5bb34875e3231ca8fec36977b84

Options
    • -2
    • +11
    ./Application.Ringtoets.Storage.Test/Read/AssessmentSectionEntityReadExtensionsTest.cs
    • -0
    • +9
    ./Application.Ringtoets.Storage.Test/Read/FailureMechanismEntityReadExtensionsTest.cs
    • -5
    • +16
    ./Application.Ringtoets.Storage.Test/Read/StochasticSoilModelEntityReadExtensionsTest.cs
    • -0
    • +1
    ./Application.Ringtoets.Storage.TestUtil.Test/Application.Ringtoets.Storage.TestUtil.Test.csproj
    • -0
    • +48
    ./Application.Ringtoets.Storage.TestUtil.Test/PipingStochasticSoilProfileEntityTestFactoryTest.cs
    • -0
    • +1
    ./Application.Ringtoets.Storage.TestUtil/Application.Ringtoets.Storage.TestUtil.csproj
    • -0
    • +52
    ./Application.Ringtoets.Storage.TestUtil/PipingStochasticSoilProfileEntityTestFactory.cs
  8. … 4 more files in changeset.
Wednesday 04 Oct 2017
5:44 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed .Test reference in a test project Related to Issue [WTI-1340]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12024 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 943960bde822513b9b77998e44675ba969b38b8c

Former-commit-id: 33d08a6960157b6c92ad12b42a699bdf7c4eca31

Options
    • -4
    • +0
    ./Application.Ringtoets.Storage.Test/Application.Ringtoets.Storage.Test.csproj
5:20 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments dev: - Cleaned up some files - Moved validation logic from readers to transformers and RT datamodel (stochastic soil profiles, Piping only): -- Moved StochasticSoilProfile property of the PipingStochasticSoilModel as a mandatory constructor argument -- Changed property from List to IEnumerable => provides readonly access of the collection -- Introduced additional test factory method --- Replaced explicit constructor calls with factory calls when possible

Related to Issue [WTI-1340]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12023 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8cf27edcf482fb639d692d19f6840bb78219dc98

Former-commit-id: dbc10165755b4dc91a62d7f21e6749d2850ed2b3

Options
    • -1
    • +1
    ./Application.Ringtoets.Storage.Test/Create/Piping/PipingFailureMechanismCreateExtensionsTest.cs
    • -9
    • +3
    ./Application.Ringtoets.Storage.Test/Create/Piping/PipingStochasticSoilModelCreateExtensionsTest.cs
    • -2
    • +0
    ./Application.Ringtoets.Storage.Test/Read/AssessmentSectionEntityReadExtensionsTest.cs
    • -2
    • +0
    ./Application.Ringtoets.Storage.Test/Read/FailureMechanismEntityReadExtensionsTest.cs
    • -1
    • +0
    ./Application.Ringtoets.Storage.Test/Read/MacroStabilityInwards/MacroStabilityInwardsStochasticSoilProfileEntityReadExtensionsTest.cs
    • -3
    • +1
    ./Application.Ringtoets.Storage.Test/Read/StochasticSoilModelEntityReadExtensionsTest.cs
    • -1
    • +1
    ./Application.Ringtoets.Storage.TestUtil.Test/MacroStabilityInwards/MacroStabilityInwardsSoilLayerTwoDEntityTestFactoryTest.cs
    • -3
    • +5
    ./Application.Ringtoets.Storage.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
    • -7
    • +4
    ./Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
  10. … 26 more files in changeset.
3:20 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments dev: - Moved validation logic from readers to transformers and RT datamodel (stochastic soil profiles, MacroStabilityInwards only): -- Added validation logic to determine whether the stochastic soil profiles are empty => If empty, exception Related to Issue [WTI-1340]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12022 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: da6fdf99b72f5f4507ca76cef500c9c5fe7953b3

Former-commit-id: 678db481bbd9a6b32e1dac26455628b63fa932ff

Options
    • -0
    • +4
    ./Application.Ringtoets.Storage.Test/Application.Ringtoets.Storage.Test.csproj
    • -2
    • +13
    ./Application.Ringtoets.Storage.Test/Read/AssessmentSectionEntityReadExtensionsTest.cs
    • -0
    • +11
    ./Application.Ringtoets.Storage.Test/Read/FailureMechanismEntityReadExtensionsTest.cs
    • -0
    • +1
    ./Application.Ringtoets.Storage.Test/Read/MacroStabilityInwards/MacroStabilityInwardsSoilProfileTwoDEntityReadExtensionsTest.cs
    • -1
    • +1
    ./Application.Ringtoets.Storage.Test/Read/MacroStabilityInwards/MacroStabilityInwardsStochasticSoilProfileEntityReadExtensionsTest.cs
    • -5
    • +17
    ./Application.Ringtoets.Storage.Test/Read/StochasticSoilModelEntityReadExtensionsTest.cs
    • -1
    • +2
    ./Application.Ringtoets.Storage.TestUtil.Test/Application.Ringtoets.Storage.TestUtil.Test.csproj
    • -0
    • +48
    ./Application.Ringtoets.Storage.TestUtil.Test/MacroStabilityInwards/MacroStabilityInwardsSoilLayerTwoDEntityTestFactoryTest.cs
    • -0
    • +49
    ./Application.Ringtoets.Storage.TestUtil.Test/MacroStabilityInwards/MacroStabilityInwardsStochasticSoilProfileEntityTestFactoryTest.cs
    • -47
    • +0
    ./Application.Ringtoets.Storage.TestUtil.Test/MacroStabilityInwardsSoilLayerTwoDEntityTestFactoryTest.cs
    • -1
    • +2
    ./Application.Ringtoets.Storage.TestUtil/Application.Ringtoets.Storage.TestUtil.csproj
    • -0
    • +56
    ./Application.Ringtoets.Storage.TestUtil/MacroStabilityInwards/MacroStabilityInwardsSoilLayerTwoDEntityTestFactory.cs
    • -0
    • +52
    ./Application.Ringtoets.Storage.TestUtil/MacroStabilityInwards/MacroStabilityInwardsStochasticSoilProfileEntityTestFactory.cs
    • -56
    • +0
    ./Application.Ringtoets.Storage.TestUtil/MacroStabilityInwardsSoilLayerTwoDEntityTestFactory.cs
  15. … 6 more files in changeset.
2:38 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments dev: - Moved validation logic from readers to transformers and RT datamodel (stochastic soil profiles, MacroStabilityInwards only): -- Moved StochasticSoilProfile property of the MacroStabilityInwardsStochasticSoilModel as a mandatory constructor argument -- Changed property from List to IEnumerable => provides readonly access of the collection -- Introduced additional test factory method --- Replaced explicit constructor calls with factory calls when possible

Related to Issue [WTI-1340]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12020 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 793e8b7ce8d28a571d22d61fd01a1c14280c75c6

Former-commit-id: 4ba95330a9300a647b62dfa413c36a5a581ee392

Options
    • -1
    • +1
    ./Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsFailureMechanismCreateExtensionsTest.cs
    • -17
    • +12
    ./Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsStochasticSoilModelCreateExtensionsTest.cs
    • -1
    • +1
    ./Application.Ringtoets.Storage.Test/Read/StochasticSoilModelEntityReadExtensionsTest.cs
    • -3
    • +5
    ./Application.Ringtoets.Storage.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
    • -7
    • +4
    ./Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
  6. … 29 more files in changeset.
Monday 02 Oct 2017
5:59 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments dev: - Moved validation logic from readers to transformers and RT datamodel (Piping only): -- Validates if the geometry is not empty and is not NULL -- Expanded test factory -- Replaced explicit constructor calls with test factory calls when possible -- Added additional tests for the transformers to verify behaviour

Related to Issue [WTI-1340]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11985 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bb6368c63b7448360bce377e2d29d1303b379d9c

Former-commit-id: 73622e310bf3c785e9bbc7acb4d2021bfc9a7674

Options
    • -2
    • +3
    ./Application.Ringtoets.Storage.Test/Create/PersistenceRegistryTest.cs
    • -2
    • +4
    ./Application.Ringtoets.Storage.Test/Create/Piping/PipingCalculationScenarioCreateExtensionsTest.cs
    • -2
    • +3
    ./Application.Ringtoets.Storage.Test/Create/Piping/PipingFailureMechanismCreateExtensionsTest.cs
    • -10
    • +11
    ./Application.Ringtoets.Storage.Test/Create/Piping/PipingStochasticSoilModelCreateExtensionsTest.cs
    • -3
    • +8
    ./Application.Ringtoets.Storage.Test/Read/AssessmentSectionEntityReadExtensionsTest.cs
    • -3
    • +8
    ./Application.Ringtoets.Storage.Test/Read/FailureMechanismEntityReadExtensionsTest.cs
    • -2
    • +8
    ./Application.Ringtoets.Storage.Test/Read/Piping/PipingCalculationEntityReadExtensionsTest.cs
    • -2
    • +3
    ./Application.Ringtoets.Storage.Test/Read/ReadConversionCollectorTest.cs
    • -4
    • +19
    ./Application.Ringtoets.Storage.Test/Read/StochasticSoilModelEntityReadExtensionsTest.cs
    • -7
    • +6
    ./Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
  11. … 32 more files in changeset.
Friday 29 Sep 2017
8:30 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments dev: - Fixed failing tests on buildserver - Moved validation logic from readers to transformers and RT datamodel (Macrostability only): -- Introduced testfactories to create valid RT and Reader soil models (with geometry defined) -- Removed obsolete constructor Related to Issue [WTI-1340]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11965 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f2f84a442ab3fc8368459e5118dc2db35b5f9a4a

Former-commit-id: 62456eff75ae7a3761bf0a3b3d5ba34092394db1

Options
    • -2
    • +3
    ./Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsFailureMechanismCreateExtensionsTest.cs
    • -11
    • +17
    ./Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsStochasticSoilModelCreateExtensionsTest.cs
    • -1
    • +1
    ./Application.Ringtoets.Storage.Test/Create/PersistenceRegistryTest.cs
    • -3
    • +7
    ./Application.Ringtoets.Storage.Test/Read/AssessmentSectionEntityReadExtensionsTest.cs
    • -3
    • +8
    ./Application.Ringtoets.Storage.Test/Read/FailureMechanismEntityReadExtensionsTest.cs
    • -1
    • +1
    ./Application.Ringtoets.Storage.Test/Read/ReadConversionCollectorTest.cs
    • -4
    • +21
    ./Application.Ringtoets.Storage.Test/Read/StochasticSoilModelEntityReadExtensionsTest.cs
  8. … 29 more files in changeset.
5:07 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments dev: - Cleaned up unused resources - Moved validation logic from the Reader to the transformers and respective RT data structures: -- Performed for the SoilModel: - Removed geometry validation in the reader, but: - Implemented for MacroStability only at this stage: -- Check if geometry is not empty Related to Issue [WTI-1340]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11964 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 31fb365b2611d19fafeef02d50d223c477b45431

Former-commit-id: 123d35eb149285fe827c58fb12bc95af78eb71ad

Options
    • -2
    • +2
    ./Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsStochasticSoilModelCreateExtensionsTest.cs
    • -7
    • +6
    ./Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
  3. … 40 more files in changeset.
1:03 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments dev: - Moved validation logic from the Reader to the transformers and respective RT data structures: -- Performed for the SoilProfile2D: => Amount of layers > 0 => All layer tops > bottom Moved to their respective transformers - Adjusted SoilProfile2D query to cope with files without soil layers - Added missing asserts for the 1D profiles => assert exception messages

Related to Issue [WTI-1340]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11954 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: eacb5a09716a4f76ca79c990a88775a7ecfdcfd6

Former-commit-id: 22556b45a12fb6ebacd14366a6228ccb1a65a514

Options
    • -1
    • +0
    ./Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsSoilProfile1DCreateExtensionsTest.cs
  2. … 12 more files in changeset.
Thursday 28 Sep 2017
3:31 pm

Marten Janssen <marten.janssen@deltares.nl>

Removed MacroStabilityInwardsSectionResultEntity.LayerTwoA from database Refactored MacroStabilityInwardsSectionResultEntityReadExtensionsTest.cs Removed redundant cast to RoundedDouble, since the MacroStabilityInwardsFailureMechanismSectionResult.AssessmentLayerThree is a double Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11944 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0b5b77b702e87bae619860a184111114b2996ef9

Former-commit-id: 5685148d8e3970f65ae9b63fc7001e92ac975e1c

Options
    • -8
    • +48
    ./Application.Ringtoets.Storage.Test/Read/MacroStabilityInwards/MacroStabilityInwardsSectionResultEntityReadExtensionsTest.cs
  2. … 8 more files in changeset.
2:42 pm

Marten Janssen <marten.janssen@deltares.nl>

Added XML serializer for tangent line (doubles) Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11942 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6df682be17f107ce9c8b0c920f1c83e08ffde7b5

Former-commit-id: 14d52cc8c25d7179b28c726de7a2a3d74e7d9fbf

Options
    • -0
    • +1
    ./Application.Ringtoets.Storage.Test/Application.Ringtoets.Storage.Test.csproj
    • -0
    • +61
    ./Application.Ringtoets.Storage.Test/Serializers/TangentLinesXmlSerializerTest.cs
  3. … 3 more files in changeset.
2:09 pm

Carlos Lubbers

Implement validation in structures, waveheight and designwaterlevel calculation with corresponding tests. Improve GeneralResult validation with stochast check for toplevel submechanism points. Adapt old tests so they will pass. Related to Issue [WTI-1391]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11940 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7c5475baca39b2e50fd92cffcd066cb90035b84d

Former-commit-id: 7371f7aa9c2fe4da40051f708686731a7b20ad61

Options
    • -2
    • +2
    ./Application.Ringtoets.Storage.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
    • -2
    • +2
    ./Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
  3. … 11 more files in changeset.
1:42 pm

Marten Janssen <marten.janssen@deltares.nl>

Added class constrains to DataCollectionSerializer Added XMLDocs to DataCollectionSerializer Added XML serializer for MacroStabilityInwardsSlice Removed roundtrip tests with empty arrays in derived classes of DataCollectionSerializer (this is already tested in DataCollectionSerializerTest Fixed test name in RoughnessPointXmlSerializerTest Related to Issue [WTI-1379]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11939 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0265913e7df0b7f9e925f5f770fd232bb76aebbd

Former-commit-id: 0080580ae7ba1f3757af66edf3a58b59651d6b9a

Options
    • -0
    • +1
    ./Application.Ringtoets.Storage.Test/Application.Ringtoets.Storage.Test.csproj
    • -0
    • +155
    ./Application.Ringtoets.Storage.Test/Serializers/MacroStabilityInwardsSliceXmlSerializerTest.cs
    • -15
    • +0
    ./Application.Ringtoets.Storage.Test/Serializers/Point2DXmlSerializerTest.cs
    • -15
    • +0
    ./Application.Ringtoets.Storage.Test/Serializers/Point3DXmlSerializerTest.cs
    • -15
    • +0
    ./Application.Ringtoets.Storage.Test/Serializers/RingXmlSerializerTest.cs
    • -16
    • +1
    ./Application.Ringtoets.Storage.Test/Serializers/RoughnessPointXmlSerializerTest.cs
  7. … 3 more files in changeset.
9:02 am

Carlos Lubbers

Implement validation in the data model, add tests to data model and started adding tests to calculator services. Old tests have been adapted to create valid generalresult/faulttrees so they won't throw exceptions when creating them. Related to Issue [WTI-1391]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11925 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 50fbd65dee53f455a510032c25787207ef0332d9

Former-commit-id: 89df2cfd12e7ddc527716a82d3325da29e8bfaef

Options
    • -11
    • +11
    ./Application.Ringtoets.Storage.Test/Create/IllustrationPoints/IllustrationPointNodeCreateExtensionsTest.cs
    • -3
    • +3
    ./Application.Ringtoets.Storage.Test/Create/IllustrationPoints/TopLevelFaultTreeIllustrationPointCreateExtensionsTest.cs
    • -3
    • +3
    ./Application.Ringtoets.Storage.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
    • -1
    • +1
    ./Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
  5. … 36 more files in changeset.
Wednesday 27 Sep 2017
4:07 pm

Marten Janssen <marten.janssen@deltares.nl>

Review related changes Related to Issue [WTI-1378]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11923 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 364cf974ccb2fdf30c65347f32da73bdbe090465

Former-commit-id: 23d9c6c350030a289ed8c10551b655b62fd665e2

Options
    • -4
    • +2
    ./Application.Ringtoets.Storage.Test/Create/Piping/PipingSurfaceLineCreateExtensionsTest.cs