Riskeer / Application

Ringtoets

Clone Tools

Stats

Commits this week: 0
Total Committers: 10
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 26 Apr 2018
10:22 am

Dennis Tang <dennis.tang@deltares.nl>

Cleaned up test projects: - Renamed FullTestProjects to MigrationTestProjects, as they do not represent a full project that is configured with all options.

WTI-1657

Options
    • -2
    • +2
    ./test/Application.Ringtoets.Migration.Core.Test/RingtoetsVersionedFileTest.cs
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject164.rtd
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject171.rtd
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject172.rtd
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject173.rtd
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject181.rtd
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/MigrationTestProject164.rtd
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/MigrationTestProject171.rtd
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/MigrationTestProject172.rtd
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/MigrationTestProject173.rtd
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/MigrationTestProject181.rtd
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo171IntegrationTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo172IntegrationTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo173IntegrationTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
  16. … 3 more files in changeset.
10:08 am

Dennis Tang <dennis.tang@deltares.nl>

Cleaned up test projects: - Test projects should only contain the information that is necessary to prove that relevant migration items for that version was performed. Due to chaining it is not necessary to repeat this validation for subsequent projects

WTI-1657

Options
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject172.rtd
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject173.rtd
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject181.rtd
Wednesday 25 Apr 2018
4:34 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted migration for the grass cover erosion outwards (GCEO) wave condition calculations: - Translated the old GCEO hydraulic boundary location (HBL) PKs to the new HBL PKs on assessment section based on the LocationID of a HBL and its corresponding assessment section. -- Introduced a lookup table, as these translations happen on multiple spots - Adjusted test project to prove the translations are made correctly

WTI-1657

Options
    • -26
    • +61
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject173.rtd
    • -0
    • +54
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
2:21 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2745: - Applied editorial comments

WTI-1657

Options
    • -2
    • +2
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • -3
    • +3
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
9:10 am

Elmar Kleijn

Applied some final renames. WTI-1698

Options
    • -3
    • +3
    ./test/Application.Ringtoets.Storage.Test/Read/HydraulicLocationCalculationEntityReadExtensionsTest.cs
  2. … 4 more files in changeset.
Monday 23 Apr 2018
4:28 pm

Elmar Kleijn

Renamed HydraulicBoundaryLocationOutput into HydraulicBoundaryLocationCalculationOutput. WTI-1698

Options
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Application.Ringtoets.Storage.csproj
    • -0
    • +60
    ./src/Application.Ringtoets.Storage/Create/HydraulicBoundaryLocationCalculationOutputCreateExtensions.cs
    • -60
    • +0
    ./src/Application.Ringtoets.Storage/Create/HydraulicBoundaryLocationOutputCreateExtensions.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Application.Ringtoets.Storage.Test.csproj
    • -0
    • +151
    ./test/Application.Ringtoets.Storage.Test/Create/HydraulicBoundaryLocationCalculationOutputCreateExtensionsTest.cs
    • -151
    • +0
    ./test/Application.Ringtoets.Storage.Test/Create/HydraulicBoundaryLocationOutputCreateExtensionsTest.cs
    • -3
    • +3
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
    • -3
    • +3
    ./test/Application.Ringtoets.Storage.Test/Read/HydraulicLocationOutputEntityReadExtensionsTest.cs
4:13 pm

Elmar Kleijn

Renamed HydraulicBoundaryLocationOutput into HydraulicBoundaryLocationCalculationOutput. WTI-1698

Options
    • -3
    • +3
    ./src/Application.Ringtoets.Storage/Create/HydraulicBoundaryLocationCalculationCreateExtensions.cs
    • -3
    • +3
    ./src/Application.Ringtoets.Storage/Create/HydraulicBoundaryLocationOutputCreateExtensions.cs
    • -12
    • +12
    ./src/Application.Ringtoets.Storage/Read/HydraulicLocationOutputEntityReadExtensions.cs
    • -3
    • +3
    ./test/Application.Ringtoets.Storage.Test/Create/HydraulicBoundaryLocationCalculationCreateExtensionsTest.cs
    • -7
    • +7
    ./test/Application.Ringtoets.Storage.Test/Create/HydraulicBoundaryLocationOutputCreateExtensionsTest.cs
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Read/HydraulicLocationCalculationEntityReadExtensionsTest.cs
    • -3
    • +3
    ./test/Application.Ringtoets.Storage.Test/Read/HydraulicLocationOutputEntityReadExtensionsTest.cs
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
    • -6
    • +6
    ./test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
  11. … 79 more files in changeset.
1:32 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted JOINS on the sourceproject for the Hydraulic Boundary Location of Grass Cover Erosion Outwards: - Do not join on the PK of the HBL entries, because these can be different between grass outwards and the hbls on assessment section level, instead join on the LocationID and the containing assessment section -- Adjusted migration logic for the outputs -- Adjusted migration logic for the HBL entries of grass cover erosion outwards --> take the HydraulicLocationEntityId as leading PK - Adjusted test files to represent the following scenarios situation: -- An HBL on the grass cover erosion failure mechanism that has a PK corresponding with a HBL that is not in the same assessment section -- Two HBLs on the grass cover erosion failure mechanism in the same assessment section that differs from the PKs of the HBLs on the assessment section

WTI-1657

Options
    • -15
    • +34
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject173.rtd
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject181.rtd
    • -4
    • +22
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
11:16 am

Dennis Tang <dennis.tang@deltares.nl>

Adjusted JOINS on the sourceproject for the Hydraulic Boundary Locations of Grass Cover Erosion Outwards: - Do not join on the PK, because these can be different between grass outwards and the hbls on assessment section level, instead join on the LocationID and the containing assessment section

WTI-1657

Options
    • -2
    • +11
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject173.rtd
    • -4
    • +20
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
Wednesday 18 Apr 2018
8:25 am

Elmar Kleijn

Improved migration log messages. WTI-1663

Options
    • -14
    • +14
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • -28
    • +28
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
Friday 13 Apr 2018
3:04 pm

Elmar Kleijn

Performed some final cleanups. WTI-1612

Options
    • -3
    • +3
    ./test/Application.Ringtoets.Storage.Test/Create/GrassCoverErosionInwards/GrassCoverErosionInwardsCalculationCreateExtensionsTest.cs
    • -6
    • +6
    ./test/Application.Ringtoets.Storage.Test/Create/StructuresCalculationCreateExtensionsTest.cs
    • -6
    • +6
    ./test/Application.Ringtoets.Storage.Test/Read/ClosingStructures/ClosingStructuresCalculationEntityReadExtensionsTest.cs
    • -8
    • +8
    ./test/Application.Ringtoets.Storage.Test/Read/GrassCoverErosionInwards/GrassCoverErosionInwardsCalculationEntityReadExtensionsTest.cs
    • -6
    • +6
    ./test/Application.Ringtoets.Storage.Test/Read/StabilityPointStructures/StabilityPointStructuresCalculationEntityReadExtensionsTest.cs
    • -6
    • +6
    ./test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
  7. … 5 more files in changeset.
Thursday 12 Apr 2018
5:01 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup. WTI-1569

Options
    • -1
    • +0
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
3:04 pm

Dennis Tang <dennis.tang@deltares.nl>

Added missing EF and SQLite references to the Application.Ringtoets.csproj: - This was done for clarity sake, because the app.config file depends on these references -- Note that the solution still worked without explicitly adding these references, because it was build and put together in a single folder with all the other dependencies that are dependent on EF and SQLite. As a consequence, EF and SQLite was always present when running the solution.

Paired with ~carloslubbers

WTI-1663

Options
    • -0
    • +22
    ./src/Application.Ringtoets/Application.Ringtoets.csproj
    • -1
    • +4
    ./src/Application.Ringtoets/packages.config
Wednesday 11 Apr 2018
4:37 pm

Carlos Lubbers

Review related changes, cleanup and added log for technical innovations WTI-1663

Options
    • -8
    • +21
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • -0
    • +2
    ./test/Application.Ringtoets.Migration.Test/RingtoetsProjectMigratorTest.cs
    • -5
    • +9
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
1:33 pm

Carlos Lubbers

Adapt tests and test project WTI-1663

Options
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject173.rtd
    • -37
    • +67
    ./test/Application.Ringtoets.Migration.Test/RingtoetsProjectMigratorTest.cs
    • -1
    • +186
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
1:32 pm

Carlos Lubbers

Add migration log messages WTI-1663

Options
    • -0
    • +438
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
Tuesday 10 Apr 2018
3:24 pm

Carlos Lubbers

Adapt remaining migration tests WTI-1663

Options
    • -25
    • +59
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
3:14 pm

Carlos Lubbers

Adapt test projects WTI-1663

Options
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject173.rtd
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject181.rtd
2:51 pm

Carlos Lubbers

Adapt migration tests for failure mechanisms in group 1 WTI-1663

Options
    • -12
    • +12
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
2:48 pm

Elmar Kleijn

Review related changes. WTI-1612

Options
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Read/HydraulicLocationOutputEntityReadExtensionsTest.cs
  2. … 6 more files in changeset.
2:21 pm

Carlos Lubbers

Update migration script for failure mechanisms in group 4 WTI-1663

Options
    • -9
    • +49
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
1:30 pm

Carlos Lubbers

Update migration script for failure mechanisms in group 3 WTI-1663

Options
    • -4
    • +14
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
1:21 pm

Carlos Lubbers

Update migration script for failure mechanisms in group 2 WTI-1663

Options
    • -6
    • +26
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
12:56 pm

Carlos Lubbers

Update migration script for failure mechanisms in group 1 WTI-1663

Options
    • -12
    • +42
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
9:43 am

Carlos Lubbers

Set parrallelizable attribute to test projects

Options
    • -0
    • +2
    ./test/Application.Ringtoets.Integration.Test/Properties/AssemblyInfo.cs
    • -0
    • +2
    ./test/Application.Ringtoets.Migration.Console.Test/Properties/AssemblyInfo.cs
    • -0
    • +2
    ./test/Application.Ringtoets.Migration.Core.Test/Properties/AssemblyInfo.cs
    • -0
    • +2
    ./test/Application.Ringtoets.Migration.Test/Properties/AssemblyInfo.cs
    • -0
    • +2
    ./test/Application.Ringtoets.Storage.Test/Properties/AssemblyInfo.cs
    • -0
    • +2
    ./test/Application.Ringtoets.Storage.TestUtil.Test/Properties/AssemblyInfo.cs
    • -0
    • +2
    ./test/Application.Ringtoets.Storage.TestUtil/Properties/AssemblyInfo.cs
    • -0
    • +2
    ./test/Application.Ringtoets.Test/Properties/AssemblyInfo.cs
  9. … 190 more files in changeset.
Monday 09 Apr 2018
4:28 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2652: - Updated XMLDocs - Cleaned up tests for consistency

Paired with ~carloslubbers

WTI-1668

Options
    • -2
    • +2
    ./src/Application.Ringtoets.Storage/Read/ClosingStructures/ClosingStructuresSectionResultEntityReadExtensions.cs
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Read/DuneErosion/DuneErosionSectionResultEntityReadExtensions.cs
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Read/GrassCoverErosionInwards/GrassCoverErosionInwardsSectionResultEntityReadExtensions.cs
    • -1
    • +2
    ./src/Application.Ringtoets.Storage/Read/GrassCoverErosionOutwards/GrassCoverErosionOutwardsSectionResultEntityReadExtensions.cs
    • -3
    • +1
    ./src/Application.Ringtoets.Storage/Read/GrassCoverSlipOffInwardsSectionResultEntityReadExtensions.cs
    • -3
    • +1
    ./src/Application.Ringtoets.Storage/Read/GrassCoverSlipOffOutwardsSectionResultEntityReadExtensions.cs
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Read/HeightStructures/HeightStructuresSectionResultEntityReadExtensions.cs
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Read/MacroStabilityInwards/MacroStabilityInwardsSectionResultEntityReadExtensions.cs
    • -3
    • +1
    ./src/Application.Ringtoets.Storage/Read/MacroStabilityOutwards/MacroStabilityOutwardsSectionResultEntityReadExtensions.cs
    • -3
    • +1
    ./src/Application.Ringtoets.Storage/Read/MicrostabilitySectionResultEntityReadExtensions.cs
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Read/Piping/PipingSectionResultEntityReadExtensions.cs
    • -4
    • +3
    ./src/Application.Ringtoets.Storage/Read/PipingStructure/PipingStructureSectionResultEntityReadExtensions.cs
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Read/StabilityPointStructures/StabilityPointStructuresSectionResultEntityReadExtensions.cs
    • -1
    • +2
    ./src/Application.Ringtoets.Storage/Read/StabilityStoneCover/StabilityStoneCoverSectionResultEntityReadExtensions.cs
    • -4
    • +2
    ./src/Application.Ringtoets.Storage/Read/StrengthStabilityLengthwiseConstructionSectionResultEntityReadExtensions.cs
  16. … 10 more files in changeset.
2:46 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup: - Removed unused references in the FailureMechanismCreateExtensions - Added missing assert for the MacrostabilityInwardsFailureMechanismCreateExtensions

WTI-1669

Options
    • -1
    • +0
    ./test/Application.Ringtoets.Storage.Test/Create/GrassCoverErosionInwards/GrassCoverErosionInwardsFailureMechanismCreateExtensionsTest.cs
    • -0
    • +1
    ./test/Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsFailureMechanismCreateExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Create/Piping/PipingFailureMechanismCreateExtensionsTest.cs
    • -1
    • +0
    ./test/Application.Ringtoets.Storage.Test/Create/PipingStructure/PipingStructureFailureMechanismCreateExtensionsTest.cs
    • -1
    • +0
    ./test/Application.Ringtoets.Storage.Test/Create/StabilityPointStructures/StabilityPointStructuresFailureMechanismCreateExtensionsTest.cs
    • -1
    • +0
    ./test/Application.Ringtoets.Storage.Test/Create/StabilityStoneCover/StabilityStoneCoverFailureMechanismCreateExtensionsTest.cs
2:39 pm

Carlos Lubbers

Update asserts and project test helper WTI-1668

Options
    • -12
    • +67
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
    • -14
    • +44
    ./test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
2:18 pm

Carlos Lubbers

Update migration integration test WTI-1668

Options
    • -0
    • +152
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
2:17 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup - Fixed failing test: - Migrated project to 181 standards such that the latest project can be opened as well

WTI-1657

Options
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject181.rtd