Riskeer / Application

Ringtoets

Clone Tools

Stats

Commits this week: 0
Total Committers: 10
Last Commit: 16 Jan
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 04 Sep 2017
3:14 pm

Marten Janssen <marten.janssen@deltares.nl>

Added test case for unknown traject id Related to Issue [WTI-1364]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11594 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a8d08c244660d9cf9e746a8222440fb06e0cf3e4

Former-commit-id: 52b16e4bd32a530d9f7c00ad9dadba375a5238e7

Options
    • -1
    • +1
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.1_17.2.sql
    • -0
    • +6
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo172IntegrationTest.cs
2:51 pm

Marten Janssen <marten.janssen@deltares.nl>

Complied to the following demand: In case the ID cannot be found in the shape file, use the old norm both as Ondergrens and Signaleringswaarde and use the Signaleringswaarde as Norm van het dijktraject. Related to Issue [WTI-1364]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11592 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 43ca6e9c98405b50eb06d64970f0b8704c4ca5f4

Former-commit-id: 37d42a2ee46a21073ebc89a3eef2575448db1a2a

Options
    • -2
    • +2
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.1_17.2.sql
2:41 pm

Marten Janssen <marten.janssen@deltares.nl>

Fixed culture bug in tests Related to Issue [WTI-1364]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11591 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1a6b1cd7472c7e612a8adba87526c89266baa151

Former-commit-id: 857ad94f00142631c15cac3d95b703f776289967

Options
    • -0
    • +1
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo172IntegrationTest.cs
2:22 pm

Marten Janssen <marten.janssen@deltares.nl>

Updated migration to update either the Signaling of LowerLimit norm and set the probable norm type Related to Issue [WTI-1364]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11590 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: eb5452d5fc4198a7d7d8e378d2618454050a556c

Former-commit-id: d9efbad12e051f7b41450867bcdac1a24b68997b

Options
    • -7
    • +35
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.1_17.2.sql
    • -0
    • +335
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo172IntegrationTest.cs
Friday 01 Sep 2017
6:41 pm

Marten Janssen <marten.janssen@deltares.nl>

Updated EDMX to make traject id NOT NULL Updated RingtoetsProjectTestHelper to have an Id set Related to Issue [WTI-1364]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11583 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0e9aec0f6381272554bedc773494731b0c826335

Former-commit-id: 87be1c59879868a6fed0e7731adba99fc57dd601

Options
    • -3
    • +3
    ./src/Application.Ringtoets.Storage/DbContext/RingtoetsEntities.edmx
    • -73
    • +73
    ./src/Application.Ringtoets.Storage/DbContext/RingtoetsEntities.edmx.diagram
    • -0
    • +1
    ./test/Application.Ringtoets.Storage.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
    • -1
    • +2
    ./test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
5:54 pm

Marten Janssen <marten.janssen@deltares.nl>

Updated database design to make traject id NOT NULL Introduced temp table with signaling and lower limit norm to use later on Related to Issue [WTI-1364]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11582 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f1b560ae8eba928e9f0cd3033549632342469e4b

Former-commit-id: 5da0fefac7ed2d2da293bb66d97b15e9e61425a4

Options
    • -1
    • +1
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure17.2.sql
    • -1
    • +251
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.1_17.2.sql
  3. … 2 more files in changeset.
4:41 pm

Marten Janssen <marten.janssen@deltares.nl>

Updated database design to store both Signaling and LowerLimit Norm Related to Issue [WTI-1364]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11581 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 16d9a5df0c1888856fb9c27197cc114d2e753eec

Former-commit-id: 1d602d2a75cf42648bfc09e77e8844874db64ff1

Options
    • -2
    • +4
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure17.2.sql
    • -1
    • +29
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.1_17.2.sql
    • -2
    • +6
    ./src/Application.Ringtoets.Storage/Create/AssessmentSectionCreateExtensions.cs
    • -1
    • +3
    ./src/Application.Ringtoets.Storage/DbContext/AssessmentSectionEntity.cs
    • -7
    • +13
    ./src/Application.Ringtoets.Storage/DbContext/RingtoetsEntities.edmx
    • -68
    • +68
    ./src/Application.Ringtoets.Storage/DbContext/RingtoetsEntities.edmx.diagram
    • -2
    • +4
    ./src/Application.Ringtoets.Storage/Read/AssessmentSectionEntityReadExtensions.cs
    • -5
    • +14
    ./test/Application.Ringtoets.Storage.Test/Create/AssessmentSectionCreateExtensionsTest.cs
    • -5
    • +16
    ./test/Application.Ringtoets.Storage.Test/Read/AssessmentSectionEntityReadExtensionsTest.cs
    • -3
    • +10
    ./test/Application.Ringtoets.Storage.Test/Read/ProjectEntityReadExtensionsTest.cs
  11. … 2 more files in changeset.
Thursday 31 Aug 2017
10:17 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2080: - Incorporated migration steps for the MacroStabilityInwardsFailureMechanismSectionResult -- Set property values on the backing fields instead of the property for the applicable section results Related to Issue [WTI-1373]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11549 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4436959ee09d9851f1960c6b97d271e1fa165232

Former-commit-id: cb5101a24db9c4e0ef55aad0b1b386c3f2025730

Options
    • -1
    • +19
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.1_17.2.sql
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject171.rtd
    • -2
    • +11
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo172IntegrationTest.cs
  4. … 5 more files in changeset.
Tuesday 29 Aug 2017
1:37 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2075: - Changed AssessmentLayerThree from RoundedDouble -> Double as a probability representation - Cleaned up tests Related to Issue [WTI-1373]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11519 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ee6f62149d9a55dbd61d4e74e617b8339d4b2ddf

Former-commit-id: eebacb9e5817d12a5d63575fc2ec85a5b0acf3d3

Options
    • -5
    • +5
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.1_17.2.sql
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsFailureMechanismSectionResultCreateExtensionsTest.cs
  3. … 21 more files in changeset.
8:59 am

Elmar Kleijn

Eliminated Children.ToArray Related to Issue [WTI-1372]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11510 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 436ea82b5b4d0f0e15dfe4c1254a4cb9ba60f0c9

Former-commit-id: ef38a52116e6456fca56f2ef2f63b90ecf3bb0cd

Options
    • -49
    • +49
    ./test/Application.Ringtoets.Storage.Test/Read/CalculationGroupEntityReadExtentionsTest.cs
8:50 am

Elmar Kleijn

Ensured Children in CalculationGroup are exposed as List Related to Issue [WTI-1372]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11509 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 83c6e2ad8006bcc7a9c377ece383c83ca1d8ee77

Former-commit-id: 75b4822230a809ef95c25678bac852a5fb9a0762

Options
    • -5
    • +5
    ./test/Application.Ringtoets.Storage.Test/Read/AssessmentSectionEntityReadExtensionsTest.cs
  2. … 11 more files in changeset.
Wednesday 23 Aug 2017
8:02 am

Elmar Kleijn

Review related changes Related to Issue [WTI-1383]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11391 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1702b79e797c25e915e23241f5dd8bf0bfdc390b

Former-commit-id: 24609f3c60ed0f17bcb230dad409f98bc4370171

Options
    • -0
    • +71
    ./src/Application.Ringtoets.Setup/licenses/LicenseGraphSharp.txt
    • -0
    • +31
    ./src/Application.Ringtoets.Setup/licenses/LicenseQuickGraph.txt
    • -0
    • +31
    ./src/Application.Ringtoets.Setup/licenses/LicenseWPFExtensions.txt
  4. … 5 more files in changeset.
Monday 21 Aug 2017
3:05 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted migration script from 171 tot 172 to incorporate requirements: - Added log messages for after migration: indicate what has changed for LayerThree when relevant - Updated FullProject171 test file: removed extra testcase, each relevant failure mechanisms tests one positive, one negative value (<0 or >1) Related to Issue [WTI-1373]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11374 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 11699a4aac6f9b455e80cc581f4eda9b484a6627

Former-commit-id: eaafbe7c7940152b1957af6ae923fe80accbfb97

Options
    • -0
    • +65
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.1_17.2.sql
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject171.rtd
    • -1
    • +57
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo172IntegrationTest.cs
11:26 am

Dennis Tang <dennis.tang@deltares.nl>

Adjusted migration script from 171 tot 172 to incorporate requirements: - AssessmentLayerThree for relevant failure mechanisms are converted to probabilities. Every other value not matching criteria >0 and <1 are removed - Adjusted test file: appended an assessmentSection which contains invalid results for the relevant failure mechanisms -- Updated FullProject172 test file: is in sync with the 171 equivalent

Related to Issue [WTI-1373]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11369 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c86b02fd5f703468518712f5ddfd1fb2732a3fe1

Former-commit-id: e34ef7ad7e078ebca5adc44d28dde29d95c5c0ba

Options
    • -5
    • +92
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.1_17.2.sql
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject171.rtd
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject172.rtd
    • -0
    • +18
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo172IntegrationTest.cs
8:46 am

Elmar Kleijn

Ensured enumerations are directly evaluated during clone Related to Issue [WTI-1365]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11365 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 87d4754b4f8d59c83c433c9fdc721ec296e225e9

Former-commit-id: 3620c9e1332623da8fb6804dfd934afa24872335

Options
    • -2
    • +4
    ./src/Application.Ringtoets.Migration.Core/RingtoetsSqLiteDatabaseFileMigrator.cs
  2. … 4 more files in changeset.
Friday 18 Aug 2017
12:07 pm

Elmar Kleijn

Ensured enumerations are directly evaluated in storage Related to Issue [WTI-1365]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11351 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d425fc0f117724370d3c0af63b23b2cbcb463bca

Former-commit-id: c9ccab4f026bb6b2a2b2cdc83c640a446b2f5672

Options
    • -2
    • +4
    ./src/Application.Ringtoets.Migration.Core/RingtoetsSqLiteDatabaseFileMigrator.cs
    • -18
    • +27
    ./src/Application.Ringtoets.Storage/Read/FailureMechanismEntityReadExtensions.cs
    • -1
    • +4
    ./src/Application.Ringtoets.Storage/Read/GrassCoverErosionOutwards/GrassCoverErosionOutwardsWaveConditionsCalculationEntityReadExtensions.cs
    • -1
    • +2
    ./src/Application.Ringtoets.Storage/Read/IllustrationPoints/FaultTreeIllustrationPointEntityReadExtensions.cs
    • -2
    • +4
    ./src/Application.Ringtoets.Storage/Read/IllustrationPoints/GeneralResultFaultTreeIllustrationPointEntityReadExtensions.cs
    • -2
    • +4
    ./src/Application.Ringtoets.Storage/Read/IllustrationPoints/GeneralResultSubMechanismIllustrationPointEntityReadExtensions.cs
    • -2
    • +4
    ./src/Application.Ringtoets.Storage/Read/IllustrationPoints/SubMechanismIllustrationPointEntityReadExtensions.cs
    • -1
    • +3
    ./src/Application.Ringtoets.Storage/Read/Piping/SoilProfileEntityReadExtensions.cs
    • -1
    • +2
    ./src/Application.Ringtoets.Storage/Read/WaveImpactAsphaltCover/WaveImpactAsphaltCoverWaveConditionsCalculationEntityReadExtensions.cs
8:43 am

Dennis Tang <dennis.tang@deltares.nl>

Adjusted data model for the failure mechanism section result: - Simplified tests for the relevant CreateExtensions Related to Issue [WTI-1373]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11342 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f3e395466a5957b6dd3e40a5bdae8f6bf3605f4e

Former-commit-id: 856b6859e8c64f1303de63cadbf05f7d2cdddca5

Options
    • -6
    • +7
    ./test/Application.Ringtoets.Storage.Test/Create/ClosingStructures/ClosingStructuresFailureMechanismSectionResultCreateExtensionsTest.cs
    • -5
    • +7
    ./test/Application.Ringtoets.Storage.Test/Create/GrassCoverErosionInwards/GrassCoverErosionInwardsFailureMechanismSectionResultCreateExtensionsTest.cs
    • -5
    • +7
    ./test/Application.Ringtoets.Storage.Test/Create/HeightStructures/HeightStructuresFailureMechanismSectionResultCreateExtensionsTest.cs
    • -5
    • +7
    ./test/Application.Ringtoets.Storage.Test/Create/Piping/PipingFailureMechanismSectionResultCreateExtensionsTest.cs
    • -5
    • +7
    ./test/Application.Ringtoets.Storage.Test/Create/StabilityPointStructures/StabilityPointStructuresFailureMechanismSectionResultCreateExtensionsTest.cs
Thursday 17 Aug 2017
3:54 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted data model for the failure mechanism section result: - For GEKB, structures, piping and macrostability, AssessmentLayerThree became a probability -- Adjusted tests -- Added missing (functional) tests in the views for when and when not to display the tooltip

Related to Issue [WTI-1373]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11337 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 42a770e3ba5cec759666e993de128fd4c7913689

Former-commit-id: 047d21217f54b6bbad523cd40af5ebb6f5e750dc

Options
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Create/ClosingStructures/ClosingStructuresFailureMechanismSectionResultCreateExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Create/GrassCoverErosionInwards/GrassCoverErosionInwardsFailureMechanismSectionResultCreateExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Create/HeightStructures/HeightStructuresFailureMechanismSectionResultCreateExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsFailureMechanismSectionResultCreateExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Create/Piping/PipingFailureMechanismSectionResultCreateExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Create/StabilityPointStructures/StabilityPointStructuresFailureMechanismSectionResultCreateExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Read/ClosingStructures/ClosingStructuresSectionResultEntityReadExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Read/GrassCoverErosionInwards/GrassCoverErosionInwardsSectionResultEntityReadExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Read/HeightStructures/HeightStructuresSectionResultEntityReadExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Read/Piping/PipingSectionResultEntityReadExtensionsTest.cs
  11. … 16 more files in changeset.
3:18 pm

Marten Janssen <marten.janssen@deltares.nl>

Initialized MechanismSurfaceLineBase.Name from constructor and added check for Null Related to Issue [WTI-1343]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11334 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2e9213487250cbc814b3b91307890cf7b5979f23

Former-commit-id: 1af404f013ac6e0a765c468b3c13ec22aa80a186

Options
    • -2
    • +2
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure17.2.sql
    • -1
    • +22
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.1_17.2.sql
    • -2
    • +1
    ./src/Application.Ringtoets.Storage/Read/Piping/SurfaceLineEntityReadExtensions.cs
    • -8
    • +8
    ./test/Application.Ringtoets.Storage.Test/Create/PersistenceRegistryTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Create/Piping/PipingCalculationScenarioCreateExtensionsTest.cs
    • -2
    • +1
    ./test/Application.Ringtoets.Storage.Test/Create/Piping/PipingFailureMechanismCreateExtensionsTest.cs
    • -13
    • +8
    ./test/Application.Ringtoets.Storage.Test/Create/Piping/PipingSurfaceLineCreateExtensionsTest.cs
    • -1
    • +2
    ./test/Application.Ringtoets.Storage.Test/Read/Piping/PipingCalculationEntityReadExtensionsTest.cs
    • -7
    • +30
    ./test/Application.Ringtoets.Storage.Test/Read/Piping/SurfaceLineEntityReadExtensionsTest.cs
    • -5
    • +5
    ./test/Application.Ringtoets.Storage.Test/Read/ReadConversionCollectorTest.cs
    • -2
    • +1
    ./test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
  12. … 89 more files in changeset.
11:45 am

Marten Janssen <marten.janssen@deltares.nl>

Set SoilProfileEntity.Name to be not null Related to Issue [WTI-1343]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11319 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e97e925d1e5f2d25d11f65496dbb566aca98356a

Former-commit-id: c9392fd939ffe39f33d1a7c8f8eba64ae146bdac

Options
    • -2
    • +2
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure17.2.sql
    • -1
    • +6
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.1_17.2.sql
  3. … 2 more files in changeset.
11:32 am

Marten Janssen <marten.janssen@deltares.nl>

Fixed tests where name is NULL

Related to Issue [WTI-1343]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11318 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 54f9550c0d0c1a8e110e2091a4378df3345ad1cd

Former-commit-id: 7a8204ec0113e37b535cbd23ccb2771195c70721

Options
    • -0
    • +2
    ./test/Application.Ringtoets.Storage.Test/Read/Piping/PipingCalculationEntityReadExtensionsTest.cs
    • -0
    • +3
    ./test/Application.Ringtoets.Storage.Test/Read/Piping/StochasticSoilModelEntityReadExtensionsTest.cs
    • -0
    • +3
    ./test/Application.Ringtoets.Storage.Test/Read/Piping/StochasticSoilProfileEntityReadExtensionsTest.cs
8:55 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2036: - Surrounded relevant test code with a try-finally block to ensure File.Delete is always executed (and thus cleaning up files)

Paired with ~lubbers

Related to Issue [WTI-1380]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11306 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e1674d1b4199817038178e8787198a60f4df1282

Former-commit-id: 032b28a9b8366ba2ab702ca92cdc0d14aaad1b6d

Options
    • -8
    • +13
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationIntegrationTest.cs
Wednesday 16 Aug 2017
12:07 pm

Marten Janssen <marten.janssen@deltares.nl>

Refactored such that TestPipingSoilProfile is replaced by PipingSoilProfileTestFactory Removed TestPipingSoilProfile and TestPipingSoilProfileTest Updated XMLdoc Related to Issue [WTI-1343]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11288 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b93aee9fdf473e06f7ebe6688e61524de9bcd925

Former-commit-id: 8b99185fd3f10ccde82b0dbfdc5fcbf64c5697a0

Options
    • -17
    • +17
    ./test/Application.Ringtoets.Storage.Test/Create/PersistenceRegistryTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Create/Piping/PipingCalculationScenarioCreateExtensionsTest.cs
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.Test/Create/Piping/PipingSoilProfileCreateExtensionsTest.cs
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.Test/Create/Piping/PipingStochasticSoilModelCreateExtensionsTest.cs
    • -4
    • +5
    ./test/Application.Ringtoets.Storage.Test/Create/Piping/PipingStochasticSoilProfileCreateExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Read/Piping/PipingCalculationEntityReadExtensionsTest.cs
    • -10
    • +13
    ./test/Application.Ringtoets.Storage.Test/Read/ReadConversionCollectorTest.cs
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
  9. … 15 more files in changeset.
11:46 am

Marten Janssen <marten.janssen@deltares.nl>

Upgraded nunit3-console.exe and NUnit to 3.7.1

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11286 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bd8ef3d5d0e001dd3753e950743d282d431939b8

Former-commit-id: 0e6297e2ce8a35cf9bdb3d58436513012a5379e6

Options
    • -2
    • +2
    ./test/Application.Ringtoets.Integration.Test/Application.Ringtoets.Integration.Test.csproj
    • -2
    • +3
    ./test/Application.Ringtoets.Integration.Test/packages.config
    • -2
    • +2
    ./test/Application.Ringtoets.Migration.Console.Test/Application.Ringtoets.Migration.Console.Test.csproj
    • -2
    • +3
    ./test/Application.Ringtoets.Migration.Console.Test/packages.config
    • -2
    • +2
    ./test/Application.Ringtoets.Migration.Core.Test/Application.Ringtoets.Migration.Core.Test.csproj
    • -2
    • +3
    ./test/Application.Ringtoets.Migration.Core.Test/packages.config
    • -2
    • +2
    ./test/Application.Ringtoets.Migration.Test/Application.Ringtoets.Migration.Test.csproj
    • -2
    • +3
    ./test/Application.Ringtoets.Migration.Test/packages.config
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.Test/Application.Ringtoets.Storage.Test.csproj
    • -2
    • +3
    ./test/Application.Ringtoets.Storage.Test/packages.config
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.TestUtil.Test/Application.Ringtoets.Storage.TestUtil.Test.csproj
    • -2
    • +3
    ./test/Application.Ringtoets.Storage.TestUtil.Test/packages.config
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.TestUtil/Application.Ringtoets.Storage.TestUtil.csproj
    • -2
    • +3
    ./test/Application.Ringtoets.Storage.TestUtil/packages.config
    • -2
    • +2
    ./test/Application.Ringtoets.Test/Application.Ringtoets.Test.csproj
  16. … 411 more files in changeset.
11:39 am

Marten Janssen <marten.janssen@deltares.nl>

Renamed PipingSoilProfile.SoilProfileType to PipingSoilProfile.SoilProfileSourceType Related to Issue [WTI-1343]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11285 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d60436f8bab80595d32c7ce042b3b858349fdb56

Former-commit-id: 9c860f686e38eb9e5c49787906bfed35264090ba

Options
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Read/Piping/SoilProfileEntityReadExtensionsTest.cs
  2. … 12 more files in changeset.
10:53 am

Elmar Kleijn

Review related changes Related to Issue [WTI-1370]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11281 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e4819c635c1e25ad6270f132fc67163e3c244a05

Former-commit-id: 8c026f15e8355d01e852dba8b5fd890a03a2ec90

Options
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Create/GrassCoverErosionOutwards/GrassCoverErosionOutwardsWaveConditionsCalculationCreateExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Create/StabilityStoneCover/StabilityStoneCoverWaveConditionsCalculationCreateExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Create/WaveImpactAsphaltCover/WaveImpactAsphaltCoverWaveConditionsCalculationCreateExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Read/GrassCoverErosionOutwards/GrassCoverErosionOutwardsWaveConditionsCalculationEntityReadExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Read/StabilityStoneCover/StabilityStoneCoverWaveConditionsCalculationEntityReadExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Read/WaveImpactAsphaltCover/WaveImpactAsphaltCoverWaveConditionsCalculationEntityReadExtensionsTest.cs
  7. … 4 more files in changeset.
9:54 am

Joël van den Berg

Xml-doc fix Reviewed by: tang_ds Related to Issue [WTI-1319]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11279 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 35bebd22f0e09d00b230ba3161eb30a740900c81

Former-commit-id: 8accba104192fb5765dbfd2c28b355283b8b4d8b

Options
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.TestUtil.Test/IllustrationPoints/GeneralResultEntityTestHelperTest.cs
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.TestUtil/IllustrationPoints/GeneralResultEntityTestHelper.cs
9:32 am

Marten Janssen <marten.janssen@deltares.nl>

Removed 'database id' from PipingSoilProfile Related to Issue [WTI-1343]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11276 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a52ff6f6f0456d2690a53f6788e8d22a3d2e5d11

Former-commit-id: cf760532ddcd32c80aa33bad404e2774959ffd2f

Options
    • -2
    • +1
    ./src/Application.Ringtoets.Storage/Read/Piping/SoilProfileEntityReadExtensions.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Create/PersistenceRegistryTest.cs
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.Test/Create/Piping/PipingSoilProfileCreateExtensionsTest.cs
  4. … 31 more files in changeset.
8:34 am

Marten Janssen <marten.janssen@deltares.nl>

Moved 'Type' from StochasticSoilProfileEntity to 'SourceType' SoilProfileEntity in database Ran Cleanup for storage Related to Issue [WTI-1343]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11272 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5390416ecba199da438854b0481ab20184862a17

Former-commit-id: 2102fe55684e8b3215a87aa15960a2dd62b27852

Options
    • -3
    • +3
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure17.2.sql
    • -2
    • +29
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.1_17.2.sql
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Create/AssessmentSectionCreateExtensions.cs
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Create/IllustrationPoints/IllustrationPointResultCreateExtensions.cs
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Create/StructuresOutputCreateExtensions.cs
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/DbContext/RingtoetsEntities.Designer.cs
    • -4
    • +4
    ./src/Application.Ringtoets.Storage/DbContext/RingtoetsEntities.edmx
    • -73
    • +73
    ./src/Application.Ringtoets.Storage/DbContext/RingtoetsEntities.edmx.diagram
    • -0
    • +1
    ./src/Application.Ringtoets.Storage/DbContext/SoilProfileEntity.cs
    • -1
    • +0
    ./src/Application.Ringtoets.Storage/DbContext/StochasticSoilProfileEntity.cs
    • -2
    • +0
    ./src/Application.Ringtoets.Storage/Read/FailureMechanismEntityReadExtensions.cs
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Read/HydraulicLocationOutputEntityReadExtensions.cs
    • -1
    • +5
    ./src/Application.Ringtoets.Storage/Read/Piping/SoilProfileEntityReadExtensions.cs
    • -1
    • +14
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo172IntegrationTest.cs
    • -8
    • +16
    ./test/Application.Ringtoets.Storage.Test/Read/Piping/SoilProfileEntityReadExtensionsTest.cs
  16. … 3 more files in changeset.
Tuesday 15 Aug 2017
5:02 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2026: - Removed unnecessary asserts - Added explicit assert for when GeneralResult(Entity) should be NULL - Removed redundant helper, adjusted corresponding test - Renamed variables Related to Issue [WTI-1319]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11257 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c46aabd66c518d0237a99d48b8aeb80ce9d8fb55

Former-commit-id: 094346e814ae75487da2bcbbdcf1b5b7039bda2a

Options
    • -9
    • +3
    ./test/Application.Ringtoets.Storage.Test/Create/GrassCoverErosionInwards/DikeHeightOutputCreateExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Create/GrassCoverErosionInwards/GrassCoverErosionInwardsCalculationCreateExtensionsTest.cs
    • -3
    • +3
    ./test/Application.Ringtoets.Storage.Test/Create/GrassCoverErosionInwards/GrassCoverErosionInwardsOutputCreateExtensionsTest.cs
    • -9
    • +3
    ./test/Application.Ringtoets.Storage.Test/Create/GrassCoverErosionInwards/OvertoppingRateOutputCreateExtensionsTest.cs
    • -3
    • +3
    ./test/Application.Ringtoets.Storage.Test/Create/StructuresOutputCreateExtensionsTest.cs
    • -12
    • +4
    ./test/Application.Ringtoets.Storage.Test/Read/GrassCoverErosionInwards/GrassCoverErosionInwardsDikeHeightOutputEntityReadExtensionsTest.cs
    • -14
    • +3
    ./test/Application.Ringtoets.Storage.Test/Read/GrassCoverErosionInwards/GrassCoverErosionInwardsOutputEntityReadExtensionsTest.cs
    • -13
    • +4
    ./test/Application.Ringtoets.Storage.Test/Read/GrassCoverErosionInwards/GrassCoverErosionInwardsOvertoppingRateOutputEntityReadExtensionsTest.cs
    • -134
    • +31
    ./test/Application.Ringtoets.Storage.TestUtil.Test/IllustrationPoints/GeneralResultEntityTestHelperTest.cs
    • -15
    • +15
    ./test/Application.Ringtoets.Storage.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
    • -52
    • +13
    ./test/Application.Ringtoets.Storage.TestUtil/IllustrationPoints/GeneralResultEntityTestHelper.cs
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs