Riskeer / Application

Ringtoets

Clone Tools

Stats

Commits this week: 0
Total Committers: 10
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 15 Feb 2018
3:10 pm

Dennis Tang <dennis.tang@deltares.nl>

Rewired SectionResult to the mirror property SectionResult2 for HeightStructures in storage: - Adjusted Create and ReadExtensions - Adjusted Integration test (helpers)

WTI-1621

Options
    • -4
    • +3
    ./src/Application.Ringtoets.Storage/Create/HeightStructures/HeightStructuresFailureMechanismCreateExtensions.cs
    • -4
    • +4
    ./src/Application.Ringtoets.Storage/Create/HeightStructures/HeightStructuresFailureMechanismSectionResultCreateExtensions.cs
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Read/FailureMechanismEntityReadExtensions.cs
    • -6
    • +7
    ./src/Application.Ringtoets.Storage/Read/HeightStructures/HeightStructuresSectionResultEntityReadExtensions.cs
    • -4
    • +4
    ./test/Application.Ringtoets.Storage.Test/Create/HeightStructures/HeightStructuresFailureMechanismSectionResultCreateExtensionsTest.cs
    • -4
    • +4
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
    • -4
    • +4
    ./test/Application.Ringtoets.Storage.Test/Read/HeightStructures/HeightStructuresSectionResultEntityReadExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
    • -3
    • +3
    ./test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
2:34 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed mirror property SectionResults2 for ClosingStructures: - Replaced the old generic SectionResults property with the mirror property - Cleaned up XMLDocs

WTI-1621

Options
    • -3
    • +2
    ./src/Application.Ringtoets.Storage/Read/ClosingStructures/ClosingStructuresSectionResultEntityReadExtensions.cs
  2. … 1 more file in changeset.
1:55 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed mirror property SectionResults2: - Replaced the old generic SectionResults property with the mirror property

WTI-1621

Options
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Create/ClosingStructures/ClosingStructuresFailureMechanismCreateExtensions.cs
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Read/FailureMechanismEntityReadExtensions.cs
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
  6. … 16 more files in changeset.
Wednesday 14 Feb 2018
5:22 pm

Dennis Tang <dennis.tang@deltares.nl>

Merge branch 'master' of https://github.com/Deltares/Riskeer

# Conflicts:

# Application/Ringtoets/src/Application.Ringtoets.Setup/Licentie.rtf

# Ringtoets.sln

# Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs

Options
    • -118
    • +119
    ./src/Application.Ringtoets.Setup/Licentie.rtf
  2. … 5 more files in changeset.
2:19 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduced Util project for closing structures: - Required to separate the generic StructuresHelper implementation into specific (ClosingStructure) implementation

WTI-1621

Options
    • -126
    • +131
    ./src/Application.Ringtoets.Setup/Licentie.rtf
  2. … 5 more files in changeset.
12:45 pm

Elmar Kleijn

Review related changes => Further unified storage related tests

WTI-1531

Options
    • -15
    • +62
    ./test/Application.Ringtoets.Storage.Test/Read/AssessmentSectionEntityReadExtensionsTest.cs
    • -3
    • +3
    ./test/Application.Ringtoets.Storage.Test/Read/FailureMechanismEntityReadExtensionsTest.cs
    • -1
    • +0
    ./test/Application.Ringtoets.Storage.Test/Read/GrassCoverErosionInwards/GrassCoverErosionInwardsFailureMechanismMetaEntityReadExtensionsTest.cs
12:29 pm

Elmar Kleijn

Review related changes => Further unified FailureMechanismReadExtensions tests

WTI-1531

Options
    • -5
    • +4
    ./test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneErosionFailureMechanismMetaEntityReadExtensionsTest.cs
    • -5
    • +2
    ./test/Application.Ringtoets.Storage.Test/Read/GrassCoverErosionInwards/GrassCoverErosionInwardsFailureMechanismMetaEntityReadExtensionsTest.cs
    • -6
    • +2
    ./test/Application.Ringtoets.Storage.Test/Read/GrassCoverErosionOutwards/GrassCoverErosionOutwardsFailureMechanismMetaEntityReadExtensionsTest.cs
    • -5
    • +4
    ./test/Application.Ringtoets.Storage.Test/Read/MacroStabilityInwards/MacroStabilityInwardsFailureMechanismMetaEntityReadExtensionsTest.cs
    • -5
    • +4
    ./test/Application.Ringtoets.Storage.Test/Read/MacroStabilityOutwards/MacroStabilityOutwardsFailureMechanismMetaEntityReadExtensionsTest.cs
    • -6
    • +6
    ./test/Application.Ringtoets.Storage.Test/Read/Piping/PipingFailureMechanismMetaEntityReadExtensionsTest.cs
12:05 pm

Elmar Kleijn

Review related changes => Completed StorageSqLiteIntegrationTest

WTI-1531

Options
    • -21
    • +0
    ./test/Application.Ringtoets.Storage.Test/Create/GrassCoverErosionOutwards/GrassCoverErosionOutwardsFailureMechanismCreateExtensionsTest.cs
    • -4
    • +4
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
    • -65
    • +64
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
11:41 am

Robert Tangerman <robert.tangerman@deltares.nl>

Created new project Ringtoets.Common.Primitives. WTI-1616

Options
    • -86
    • +87
    ./src/Application.Ringtoets.Setup/Licentie.rtf
  2. … 5 more files in changeset.
11:32 am

Elmar Kleijn

Review related changes => Unified unit tests for FailureMechanismCreateExtensions

WTI-1531

Options
    • -3
    • +2
    ./test/Application.Ringtoets.Storage.Test/Create/ClosingStructures/ClosingStructuresFailureMechanismCreateExtensionsTest.cs
    • -3
    • +8
    ./test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneErosionFailureMechanismCreateExtensionsTest.cs
    • -1
    • +2
    ./test/Application.Ringtoets.Storage.Test/Create/GrassCoverErosionInwards/GrassCoverErosionInwardsFailureMechanismCreateExtensionsTest.cs
    • -0
    • +8
    ./test/Application.Ringtoets.Storage.Test/Create/GrassCoverErosionOutwards/GrassCoverErosionOutwardsFailureMechanismCreateExtensionsTest.cs
    • -1
    • +2
    ./test/Application.Ringtoets.Storage.Test/Create/HeightStructures/HeightStructuresFailureMechanismCreateExtensionsTest.cs
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.Test/Create/Piping/PipingFailureMechanismCreateExtensionsTest.cs
    • -3
    • +3
    ./test/Application.Ringtoets.Storage.Test/Create/PipingStructure/PipingStructureFailureMechanismCreateExtensionsTest.cs
    • -1
    • +2
    ./test/Application.Ringtoets.Storage.Test/Create/StabilityPointStructures/StabilityPointStructuresFailureMechanismCreateExtensionsTest.cs
    • -1
    • +2
    ./test/Application.Ringtoets.Storage.Test/Create/StabilityStoneCover/StabilityStoneCoverFailureMechanismCreateExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Create/WaveImpactAsphaltCover/WaveImpactAsphaltCoverFailureMechanismCreateExtensionsTest.cs
11:16 am

Dennis Tang <dennis.tang@deltares.nl>

Rewired SectionResult to the mirror property SectionResult2 for ClosingStructures in storage: - Adjusted Create and ReadExtensions - Adjusted Integration test (helpers)

WTI-1621

Options
    • -3
    • +3
    ./src/Application.Ringtoets.Storage/Create/ClosingStructures/ClosingStructuresFailureMechanismCreateExtensions.cs
    • -4
    • +6
    ./src/Application.Ringtoets.Storage/Create/ClosingStructures/ClosingStructuresFailureMechanismSectionResultCreateExtensions.cs
    • -3
    • +6
    ./src/Application.Ringtoets.Storage/Read/ClosingStructures/ClosingStructuresSectionResultEntityReadExtensions.cs
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Read/FailureMechanismEntityReadExtensions.cs
    • -4
    • +4
    ./test/Application.Ringtoets.Storage.Test/Create/ClosingStructures/ClosingStructuresFailureMechanismSectionResultCreateExtensionsTest.cs
    • -4
    • +4
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
    • -4
    • +4
    ./test/Application.Ringtoets.Storage.Test/Read/ClosingStructures/ClosingStructuresSectionResultEntityReadExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
    • -3
    • +3
    ./test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
11:12 am

Elmar Kleijn

Review related changes => Fixed test names

WTI-1531

Options
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Read/ClosingStructures/ClosingStructuresFailureMechanismMetaEntityReadExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneErosionFailureMechanismMetaEntityReadExtensionsTest.cs
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.Test/Read/GrassCoverErosionInwards/GrassCoverErosionInwardsFailureMechanismMetaEntityReadExtensionsTest.cs
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.Test/Read/GrassCoverErosionOutwards/GrassCoverErosionOutwardsFailureMechanismMetaEntityReadExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Read/HeightStructures/HeightStructuresFailureMechanismMetaEntityReadExtensionsTest.cs
    • -3
    • +3
    ./test/Application.Ringtoets.Storage.Test/Read/MacroStabilityInwards/MacroStabilityInwardsFailureMechanismMetaEntityReadExtensionsTest.cs
    • -3
    • +3
    ./test/Application.Ringtoets.Storage.Test/Read/MacroStabilityOutwards/MacroStabilityOutwardsFailureMechanismMetaEntityReadExtensionsTest.cs
    • -4
    • +4
    ./test/Application.Ringtoets.Storage.Test/Read/Piping/PipingFailureMechanismMetaEntityReadExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Read/StabilityPointStructures/StabilityPointStructuresFailureMechanismMetaEntityReadExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Read/StabilityStoneCover/StabilityStoneCoverFailureMechanismMetaEntityReadExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Read/WaveImpactAsphaltCover/WaveImpactAsphaltCoverFailureMechanismMetaEntityReadExtensionsTest.cs
  12. … 1 more file in changeset.
10:51 am

Robert Tangerman <robert.tangerman@deltares.nl>

Revert 'Removed redundant AssemblyTool data project.' WTI-1616

Options
    • -103
    • +105
    ./src/Application.Ringtoets.Setup/Licentie.rtf
  2. … 12 more files in changeset.
10:01 am

Elmar Kleijn

Review related changes => Ensured WaveImpactAsphaltCoverFailureMechanismMetaEntityReadExtensions is actually used

WTI-1531

Options
    • -7
    • +10
    ./src/Application.Ringtoets.Storage/Read/FailureMechanismEntityReadExtensions.cs
    • -8
    • +9
    ./src/Application.Ringtoets.Storage/Read/PipingStructure/PipingStructureSectionResultEntityReadExtensions.cs
9:30 am

Elmar Kleijn

Review related changes => Made summaries consistent

WTI-1531

Options
    • -4
    • +4
    ./src/Application.Ringtoets.Storage/Read/ClosingStructures/ClosingStructuresFailureMechanismMetaEntityReadExtensions.cs
    • -5
    • +4
    ./src/Application.Ringtoets.Storage/Read/DuneErosion/DuneErosionFailureMechanismMetaEntityReadExtensions.cs
    • -4
    • +4
    ./src/Application.Ringtoets.Storage/Read/GrassCoverErosionInwards/GrassCoverErosionInwardsFailureMechanismMetaEntityReadExtensions.cs
    • -5
    • +4
    ./src/Application.Ringtoets.Storage/Read/GrassCoverErosionOutwards/GrassCoverErosionInwardsFailureMechanismMetaEntityReadExtensions.cs
    • -4
    • +4
    ./src/Application.Ringtoets.Storage/Read/HeightStructures/HeightStructuresFailureMechanismMetaEntityReadExtensions.cs
    • -6
    • +5
    ./src/Application.Ringtoets.Storage/Read/MacroStabilityInwards/MacroStabilityInwardsFailureMechanismMetaEntityReadExtensions.cs
    • -7
    • +6
    ./src/Application.Ringtoets.Storage/Read/MacroStabilityOutwards/MacroStabilityOutwardsFailureMechanismMetaEntityReadExtensions.cs
    • -13
    • +13
    ./src/Application.Ringtoets.Storage/Read/Piping/PipingFailureMechanismMetaEntityReadExtensions.cs
    • -4
    • +4
    ./src/Application.Ringtoets.Storage/Read/StabilityPointStructures/StabilityPointStructureFailureMechanismMetaEntityReadExtensions.cs
    • -4
    • +4
    ./src/Application.Ringtoets.Storage/Read/StabilityStoneCover/StabilityStoneCoverFailureMechanismMetaEntityReadExtensions.cs
    • -4
    • +4
    ./src/Application.Ringtoets.Storage/Read/WaveImpactAsphaltCover/WaveImpactAsphaltCoverFailureMechanismMetaEntityReadExtensions.cs
Tuesday 13 Feb 2018
4:49 pm

Elmar Kleijn

Review related changes => Completed some rename actions

WTI-1531

Options
    • -2
    • +2
    ./src/Application.Ringtoets.Storage/Read/AssessmentSectionEntityReadExtensions.cs
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Read/FailureMechanismEntityReadExtensions.cs
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Read/PipingStructure/PipingStructureSectionResultEntityReadExtensions.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Application.Ringtoets.Storage.Test.csproj
    • -0
    • +114
    ./test/Application.Ringtoets.Storage.Test/Read/PipingStructure/PipingStructureSectionResultEntityReadExtensionsTest.cs
    • -114
    • +0
    ./test/Application.Ringtoets.Storage.Test/Read/PipingStructures/PipingStructureSectionResultEntityReadExtensionsTest.cs
  7. … 3 more files in changeset.
Thursday 08 Feb 2018
8:53 am

Elmar Kleijn

Review related changes. WTI-1562

Options
    • -4
    • +2
    ./test/Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsCalculationScenarioCreateExtensionsTest.cs
    • -13
    • +14
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
    • -4
    • +2
    ./test/Application.Ringtoets.Storage.Test/Read/MacroStabilityInwards/MacroStabilityInwardsCalculationEntityReadExtensionsTest.cs
Tuesday 06 Feb 2018
5:13 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Removed redundant AssemblyTool data project. WTI-1618

Options
    • -105
    • +103
    ./src/Application.Ringtoets.Setup/Licentie.rtf
  2. … 12 more files in changeset.
Monday 05 Feb 2018
11:05 am

Carlos Lubbers

Rename "toetslaag 3" to "toets op maat" in the migration script 17.1->17.2 WTI-1543

Options
    • -6
    • +6
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.1_17.2.sql
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo172IntegrationTest.cs
10:21 am

Robert Tangerman <robert.tangerman@deltares.nl>

* Removed TestPipingOutput. * Introduced PipingOutputTestFactory. * Fixed updating problem in PipingScenarioView. WTI-1588

Options
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Create/Piping/PipingCalculationScenarioCreateExtensionsTest.cs
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
  3. … 34 more files in changeset.
10:15 am

Carlos Lubbers

Remove unused properties WTI-1591

Paired with roberttangerman

Options
    • -4
    • +0
    ./test/Application.Ringtoets.Storage.Test/Create/StructuresOutputCreateExtensionsTest.cs
9:07 am

Carlos Lubbers

Cleanup after review WTI-1579

Paired with siuhintang

Options
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Create/HydraulicBoundaryLocationOutputCreateExtensions.cs
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Read/HydraulicLocationOutputEntityReadExtensions.cs
    • -0
    • +1
    ./test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneErosionSectionResultEntityReadExtensionsTest.cs
Friday 02 Feb 2018
2:54 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2453: - Removed all combinatorial [Values()] attributes from tests that make use of enums as arguments - Improved tests

WTI-1579

Options
    • -9
    • +8
    ./test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneErosionFailureMechanismSectionResultCreateExtensionsTest.cs
    • -9
    • +8
    ./test/Application.Ringtoets.Storage.Test/Create/GrassCoverErosionOutwards/GrassCoverErosionOutwardsFailureMechanismSectionResultCreateExtensionsTest.cs
    • -9
    • +8
    ./test/Application.Ringtoets.Storage.Test/Create/GrassCoverSlipOffInwards/GrassCoverSlipOffInwardsFailureMechanismSectionResultCreateExtensionsTest.cs
    • -9
    • +8
    ./test/Application.Ringtoets.Storage.Test/Create/GrassCoverSlipOffOutwards/GrassCoverSlipOffOutwardsFailureMechanismSectionResultCreateExtensionsTest.cs
    • -9
    • +8
    ./test/Application.Ringtoets.Storage.Test/Create/Microstability/MicrostabilityFailureMechanismSectionResultCreateExtensionsTest.cs
    • -9
    • +8
    ./test/Application.Ringtoets.Storage.Test/Create/PipingStructure/PipingStructureFailureMechanismSectionResultCreateExtensionsTest.cs
    • -9
    • +8
    ./test/Application.Ringtoets.Storage.Test/Create/StabilityStoneCover/StabilityStoneCoverFailureMechanismSectionResultCreateExtensionsTest.cs
    • -6
    • +6
    ./test/Application.Ringtoets.Storage.Test/Create/StrengthStabilityLengthwise/StrengthStabilityLengthwiseConstructionFailureMechanismSectionResultCreateExtensionsTest.cs
    • -6
    • +6
    ./test/Application.Ringtoets.Storage.Test/Create/TechnicalInnovation/TechnicalInnovationFailureMechanismSectionResultCreateExtensionsTest.cs
    • -7
    • +7
    ./test/Application.Ringtoets.Storage.Test/Read/AssessmentSectionEntityReadExtensionsTest.cs
    • -9
    • +35
    ./test/Application.Ringtoets.Storage.Test/Read/ClosingStructures/ClosingStructuresSectionResultEntityReadExtensionsTest.cs
    • -9
    • +37
    ./test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneErosionSectionResultEntityReadExtensionsTest.cs
    • -7
    • +36
    ./test/Application.Ringtoets.Storage.Test/Read/GrassCoverErosionInwards/GrassCoverErosionInwardsSectionResultEntityReadExtensionsTest.cs
    • -11
    • +7
    ./test/Application.Ringtoets.Storage.Test/Read/GrassCoverErosionOutwards/GrassCoverErosionOutwardsHydraulicLocationOutputEntityReadExtensionsTest.cs
    • -9
    • +38
    ./test/Application.Ringtoets.Storage.Test/Read/GrassCoverErosionOutwards/GrassCoverErosionOutwardsSectionResultEntityReadExtensionsTest.cs
  16. … 14 more files in changeset.
10:52 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2453: - Removed combinatorial test cases when enums are set on data - Performed for the CreateExtensions

WTI-1579

Options
    • -7
    • +7
    ./test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneErosionFailureMechanismSectionResultCreateExtensionsTest.cs
    • -8
    • +7
    ./test/Application.Ringtoets.Storage.Test/Create/GrassCoverErosionOutwards/GrassCoverErosionOutwardsFailureMechanismSectionResultCreateExtensionsTest.cs
    • -7
    • +7
    ./test/Application.Ringtoets.Storage.Test/Create/GrassCoverSlipOffInwards/GrassCoverSlipOffInwardsFailureMechanismSectionResultCreateExtensionsTest.cs
    • -8
    • +7
    ./test/Application.Ringtoets.Storage.Test/Create/GrassCoverSlipOffOutwards/GrassCoverSlipOffOutwardsFailureMechanismSectionResultCreateExtensionsTest.cs
    • -6
    • +7
    ./test/Application.Ringtoets.Storage.Test/Create/Microstability/MicrostabilityFailureMechanismSectionResultCreateExtensionsTest.cs
    • -7
    • +7
    ./test/Application.Ringtoets.Storage.Test/Create/PipingStructure/PipingStructureFailureMechanismSectionResultCreateExtensionsTest.cs
    • -7
    • +7
    ./test/Application.Ringtoets.Storage.Test/Create/StabilityStoneCover/StabilityStoneCoverFailureMechanismSectionResultCreateExtensionsTest.cs
    • -5
    • +6
    ./test/Application.Ringtoets.Storage.Test/Create/StrengthStabilityLengthwise/StrengthStabilityLengthwiseConstructionFailureMechanismSectionResultCreateExtensionsTest.cs
    • -5
    • +6
    ./test/Application.Ringtoets.Storage.Test/Create/TechnicalInnovation/TechnicalInnovationFailureMechanismSectionResultCreateExtensionsTest.cs
10:29 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2453: - Removed unnecessary casts from the Read- and Create Extensions when the asserts are not driven by the entity, but by the parameters set onto the entity

WTI-1579

Options
    • -5
    • +5
    ./test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationOutputEntityReadExtensionsTest.cs
    • -3
    • +3
    ./test/Application.Ringtoets.Storage.Test/Read/GrassCoverErosionOutwards/GrassCoverErosionOutwardsHydraulicLocationOutputEntityReadExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Read/HeightStructures/HeightStructuresCalculationEntityReadExtensionsTest.cs
    • -3
    • +3
    ./test/Application.Ringtoets.Storage.Test/Read/HydraulicLocationOutputEntityReadExtensionsTest.cs
10:05 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2453: - Adjusted .gitignore file - Moved files to correct locations - Added ArgumentNullExceptions when missing - Simplified tests - Updated XMLDoc

WTI-1579

Options
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Application.Ringtoets.Storage.csproj
    • -15
    • +5
    ./src/Application.Ringtoets.Storage/Create/GrassCoverErosionInwards/DikeHeightOutputCreateExtensions.cs
    • -15
    • +5
    ./src/Application.Ringtoets.Storage/Create/GrassCoverErosionInwards/OvertoppingRateOutputCreateExtensions.cs
    • -52
    • +0
    ./src/Application.Ringtoets.Storage/Create/GrassCoverErosionOutwards/GrassCoverErosionOutwardsHydraulicLocationOutputEntityReadExtensions.cs
    • -8
    • +20
    ./src/Application.Ringtoets.Storage/Create/HydraulicBoundaryLocationCreateExtensions.cs
    • -36
    • +19
    ./src/Application.Ringtoets.Storage/Create/HydraulicBoundaryLocationOutputCreateExtensions.cs
    • -0
    • +59
    ./src/Application.Ringtoets.Storage/Read/GrassCoverErosionOutwards/GrassCoverErosionOutwardsHydraulicLocationOutputEntityReadExtensions.cs
    • -0
    • +7
    ./src/Application.Ringtoets.Storage/Read/HydraulicLocationOutputEntityReadExtensions.cs
    • -62
    • +8
    ./test/Application.Ringtoets.Storage.Test/Create/HydraulicBoundaryLocationCalculationCreateExtensionsTest.cs
    • -73
    • +29
    ./test/Application.Ringtoets.Storage.Test/Create/HydraulicBoundaryLocationCreateExtensionsTest.cs
    • -1
    • +12
    ./test/Application.Ringtoets.Storage.Test/Read/GrassCoverErosionOutwards/GrassCoverErosionOutwardsHydraulicLocationOutputEntityReadExtensionsTest.cs
    • -0
    • +11
    ./test/Application.Ringtoets.Storage.Test/Read/HydraulicLocationOutputEntityReadExtensionsTest.cs
  13. … 1 more file in changeset.
8:30 am

Robert Tangerman <robert.tangerman@deltares.nl>

Removed derived output from storage. WTI-1591

Options
    • -131
    • +67
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure18.1.sql
    • -6
    • +50
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • -7
    • +1
    ./src/Application.Ringtoets.Storage/Application.Ringtoets.Storage.csproj
    • -2
    • +1
    ./src/Application.Ringtoets.Storage/Create/StructuresOutputCreateExtensions.cs
    • -4
    • +0
    ./src/Application.Ringtoets.Storage/DbContext/ClosingStructuresOutputEntity.cs
    • -4
    • +0
    ./src/Application.Ringtoets.Storage/DbContext/GrassCoverErosionInwardsOutputEntity.cs
    • -4
    • +0
    ./src/Application.Ringtoets.Storage/DbContext/HeightStructuresOutputEntity.cs
    • -54
    • +0
    ./src/Application.Ringtoets.Storage/DbContext/IProbabilityAssessmentOutputEntity.cs
    • -0
    • +34
    ./src/Application.Ringtoets.Storage/DbContext/IStructuresOutputEntity.cs
    • -4
    • +0
    ./src/Application.Ringtoets.Storage/DbContext/MacroStabilityInwardsCalculationEntity.cs
    • -46
    • +0
    ./src/Application.Ringtoets.Storage/DbContext/MacroStabilityInwardsSemiProbabilisticOutputEntity.cs
    • -2
    • +2
    ./src/Application.Ringtoets.Storage/DbContext/PartialClosingStructuresOutputEntity.cs
    • -2
    • +2
    ./src/Application.Ringtoets.Storage/DbContext/PartialHeightStructuresOutputEntity.cs
    • -2
    • +0
    ./src/Application.Ringtoets.Storage/DbContext/PartialRingtoetsEntities.cs
    • -2
    • +2
    ./src/Application.Ringtoets.Storage/DbContext/PartialStabilityPointStructuresOutputEntity.cs
  16. … 17 more files in changeset.
Thursday 01 Feb 2018
2:05 pm

Carlos Lubbers

Remove redundant imports and targets WTI-1587

Options
    • -3
    • +0
    ./src/Application.Ringtoets.Storage/Application.Ringtoets.Storage.csproj
    • -1
    • +0
    ./test/Application.Ringtoets.Migration.Core.Test/Application.Ringtoets.Migration.Core.Test.csproj
  3. … 4 more files in changeset.
Wednesday 31 Jan 2018
2:26 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Removed read and create extensions for ProbabilityAssessmentOutput. WTI-1590

Options
    • -2
    • +0
    ./src/Application.Ringtoets.Storage/Application.Ringtoets.Storage.csproj
    • -52
    • +0
    ./src/Application.Ringtoets.Storage/Create/ProbabilityAssessmentOutputCreateExtensions.cs
    • -49
    • +0
    ./src/Application.Ringtoets.Storage/Read/ProbabilityAssessmentOutputEntityReadExtensions.cs
    • -2
    • +0
    ./test/Application.Ringtoets.Storage.Test/Application.Ringtoets.Storage.Test.csproj
    • -80
    • +0
    ./test/Application.Ringtoets.Storage.Test/Create/ProbabilityAssessmentOutputCreateExtensionsTest.cs
    • -98
    • +0
    ./test/Application.Ringtoets.Storage.Test/Read/ProbabilityAssessmentOutputEntityReadExtensionsTest.cs
2:24 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Removed ProbabilityAssessmentOutput from StructuresOutput constructor. WTI-1590

Options
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Read/ClosingStructures/ClosingStructuresCalculationEntityReadExtensions.cs
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Read/HeightStructures/HeightStructuresCalculationEntityReadExtensions.cs
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Read/StabilityPointStructures/StabilityPointStructuresCalculationEntityReadExtensions.cs
    • -17
    • +5
    ./test/Application.Ringtoets.Storage.Test/Create/StructuresOutputCreateExtensionsTest.cs
    • -7
    • +1
    ./test/Application.Ringtoets.Storage.Test/Read/ClosingStructures/ClosingStructuresCalculationEntityReadExtensionsTest.cs
    • -7
    • +1
    ./test/Application.Ringtoets.Storage.Test/Read/HeightStructures/HeightStructuresCalculationEntityReadExtensionsTest.cs
    • -7
    • +1
    ./test/Application.Ringtoets.Storage.Test/Read/StabilityPointStructures/StabilityPointStructuresCalculationEntityReadExtensionsTest.cs
    • -10
    • +3
    ./test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
  9. … 12 more files in changeset.