Riskeer / Core / Common / src

Core.Common.Base

Clone Tools

Stats

Commits this week: 0
Total Committers: 12
Last Commit: 08 Apr
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 05 Jan 2017
4:32 pm

Dennis Tang <dennis.tang@deltares.nl>

FileImporters should call Observers in case the import was successfull AND was cancelled at an uncancellable stage.

Note: test is missing to verify this behaviour

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/WTI-490@7633 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e83b44b0f9859bd3ab8158432cbbb7e8f6fcea42

Former-commit-id: 2d24eded9c720fa9d27095f2fe3beee65d42f323

Options
    • -0
    • +1
    ./IO/FileImporterBase.cs
1:47 pm

Dennis Tang <dennis.tang@deltares.nl>

Fixed tests of the PipingSurfaceLinesCsvImporter: - Added test to verify behaviour when canceling at the two stages during the import - Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base - Added resource value for the ImportActivity (missing file commit)

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/WTI-490@7618 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 57abd999d6185e5e4841d6fa1c380dc3c8c9cc39

Former-commit-id: 836f2fc05903415944c167b13983d49f290d5216

Options
    • -1
    • +10
    ./Properties/Resources.Designer.cs
    • -0
    • +3
    ./Properties/Resources.resx
  3. … 4 more files in changeset.
1:37 pm

Dennis Tang <dennis.tang@deltares.nl>

Fixed tests of the FileImporterBase and Activity: - Checks on the states are made for the 4 different paths of the Import: -- Import successful, canceled or not -- Import not successful, canceled or not - Moved logging from the activity to the importer - Added tests to assert mentioned behaviour

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/WTI-490@7617 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b54ccb13a0780daf3321fcbc02998200ae3283da

Former-commit-id: 22fd647c89a1cc3b0d4f812e4018335057f64e80

Options
    • -6
    • +52
    ./IO/FileImporterBase.cs
    • -9
    • +2
    ./Service/FileImportActivity.cs
  3. … 2 more files in changeset.
9:58 am

Robert Tangerman <robert.tangerman@deltares.nl>

Changed the log message for when failure mechanism contribution is zero. Related to Issue [WTI-777]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7606 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c77e204f8e881e2c6155133b7acf54832702ee0f

Former-commit-id: ef70a113ba014154b93c39241fec8aec9f16f9c4

Options
    • -4
    • +1
    ./Service/Activity.cs
  2. … 5 more files in changeset.
Wednesday 04 Jan 2017
2:01 pm

Dennis Tang <dennis.tang@deltares.nl>

Initial commit of changes from kleijn: - Removed HandleUserCancellingImport: FileImporter should not decide on its own how to handle Canceled actions. Consequently removed the messages that are generated by these handles - Added logic to the importers: Cancelling is not possible when putting data on the data model. Action will always execute when it is in this stage - Added branching paths in the activity: Import() returns false when it has failed or is cancelled

Note: failing tests will be fixed in following commits

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/WTI-490@7598 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 409bfee1e3deebb4fe4368cb7010a8c4c37dae5e

Former-commit-id: 98175da77f6910f259097a90626bbb10450e2c8f

Options
    • -1
    • +17
    ./Service/FileImportActivity.cs
  2. … 20 more files in changeset.
11:38 am

Elmar Kleijn

Reverted some changes Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7594 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 393a81aac4454cde27f7e6d667c125be4feb4c81

Former-commit-id: 9f0e2dd030a3f7922b3d222910b7f7c36eff6e02

Options
    • -0
    • +5
    ./IO/FileImporterBase.cs
    • -1
    • +2
    ./IO/IFileImporter.cs
  3. … 3 more files in changeset.
Monday 02 Jan 2017
9:13 am

Elmar Kleijn

Ensured PostImportUpdates are also performed for import routines that are canceled Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7538 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e656c1c86281862b19fcbed4d24fb1ad93a27d17

Former-commit-id: 64de80ca92d93bfd541aabe98834020536dda166

Options
    • -5
    • +0
    ./IO/FileImporterBase.cs
    • -2
    • +1
    ./IO/IFileImporter.cs
  3. … 3 more files in changeset.
Friday 30 Dec 2016
10:55 am

Dennis Tang <dennis.tang@deltares.nl>

Fixed bug when cancelling an import action results in a failed state of the activity: - Activity checks if it wasn't cancelled. If it was, do not set the activity state to failed; otherwise check the result of the import action - Added test to assert the behaviour

Related to Issue [WTI-982]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7509 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 130e530ddcc3eea92352e5a4e389a83109f89119

Former-commit-id: ffaf023f8720c812f357f0d8b9fd4e2739c39336

Options
    • -1
    • +1
    ./Service/FileImportActivity.cs
  2. … 1 more file in changeset.
Tuesday 27 Dec 2016
10:05 am

Marten Janssen <marten.janssen@deltares.nl>

Updated SQLite to latest version (104) paired with berg_jl

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7441 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b7f49496d25e38cc4ff409d44a86b09d8ab5b536

Former-commit-id: b44681b37cdf650d516bbce670eef9e8de813e4a

Options
    • -7
    • +2
    ./Core.Common.Base.csproj
    • -2
    • +1
    ./packages.config
  3. … 215 more files in changeset.
Friday 23 Dec 2016
11:20 am

Marten Janssen <marten.janssen@deltares.nl>

- Upgraded Project ToolsVersion="4.0" to ToolsVersion="14.0" - Ignored ".vs" folder in trunk paired with tang_ds

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7422 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: beca2918e38aa1e3900b6bc17a0df7e8d1f9c8e3

Former-commit-id: 681a7a3764b91f67e1e97dc0d30f930c901276e0

Options
    • -1
    • +1
    ./Core.Common.Base.csproj
  2. … 219 more files in changeset.
Friday 16 Dec 2016
10:02 am

Dennis Tang <dennis.tang@deltares.nl>

Changed the behavior in the FileImportActivity. If the fileImporter.Import() returns FALSE (failed import), the Activity state will be set to ActivityState.Failed to indicate that the import action was unsuccessful. Related to Issue [WTI-982]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7353 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 252f988a74852e53593cd278cf5d3ea682a9fd0e

Former-commit-id: 1782136886b4160733dad2821df1635b8d0d0d5d

Options
    • -1
    • +4
    ./Service/FileImportActivity.cs
  2. … 1 more file in changeset.
Thursday 15 Dec 2016
10:32 am

Joël van den Berg

Performed Resharper cleanup

Related to Issue [WTI-1008]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7334 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 23d17fd6b5257a25b167839d9106eea6fa7be554

Former-commit-id: 4a817a07bc646924777514e78010c89bc0fdf9b5

Options
    • -2
    • +2
    ./IO/FileImporterBase.cs
  2. … 114 more files in changeset.
Monday 12 Dec 2016
5:05 pm

Joël van den Berg

fixed some of the issues found by visual studio code analysis. Related to Issue [WTI-1008]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7240 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: fef2b3d374da75bd0bf1cb0a7e0052ed2ed1b76a

Former-commit-id: 78097e95edb99bbc2b4ba6a5e9ce21be8d5f5d39

Options
    • -1
    • +1
    ./Core.Common.Base.csproj
    • -2
    • +4
    ./Geometry/Segment2DIntersectSegment2DResult.cs
    • -2
    • +2
    ./IO/FileImporterBase.cs
    • -1
    • +1
    ./IO/IFileImporter.cs
    • -0
    • +31
    ./IO/OnProgressChanged.cs
    • -31
    • +0
    ./IO/ProgressChangedDelegate.cs
  7. … 11 more files in changeset.
2:56 pm

Joël van den Berg

fixed compiler warnings and performed some "common practices and code improvements"

Related to Issue [WTI-1008]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7233 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 169b334c71ef8e8ee74a6d270195b6b9014f7af7

Former-commit-id: 0f42a6f6a5da6ae2c62f051a5f65d0890abd2183

Options
    • -1
    • +1
    ./IO/FileImporterBase.cs
  2. … 3 more files in changeset.
1:57 pm

Joël van den Berg

Fixing Resharper code issues. Related to Issue [WTI-1008]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7225 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ed7bdaf426b549dfa60896ccf59854697ad97eff

Former-commit-id: fa5e42a5f1f12ee8bcf3aefb993b7da5b4e4e3f7

Options
    • -1
    • +1
    ./Data/RoundedPoint2DCollection.cs
    • -1
    • +1
    ./Geometry/Math2D.cs
  3. … 27 more files in changeset.
Monday 28 Nov 2016
3:28 pm

bouvrie <bouvrie@example.com>

* Fixed typos. * Refactored common code to new methods. * Fixed correct responsibility of filtering out duplicate observable notification. * Improved XML docs. * Improved returning all affected objects by some 'clear' methods of DataSynchronisationService classes. * Readded license header. * Simplified RhinoMock argument restraints. * Fixed test filename. * Fixed test structure of Integration tests conform coding conventions. Related to Issue [WTI-440]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6902 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 575f790757a486d0efa5b560c8170dc02cefb1f5

Former-commit-id: 8f94dd18882a6eaa65a1a9ca5592839b0d8b8084

Options
    • -2
    • +2
    ./IO/FileImporterBase.cs
  2. … 33 more files in changeset.
Friday 25 Nov 2016
4:50 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1223: - Implemented IComparable in the RoundedDouble - Added null-check in the HydraulicBoundaryLocationEditor, because the GetPropertiesObject(context) can be null.

Related to Issue [WTI-989]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6879 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: dc360d26af8ec209a0b13225ace1db5328197df8

Former-commit-id: 58cbfed5222b113a4bb1b48c9c86b4d6bc8a9ad1

Options
    • -1
    • +32
    ./Data/RoundedDouble.cs
  2. … 3 more files in changeset.
Wednesday 23 Nov 2016
3:38 pm

Joël van den Berg

Removed some logic which checked whether project was null on IProjectOwner (Not possible anymore). Updated doc and method names for more consistency. Related to Issue [WTI-961]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6818 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a786487651e30f71544fd103a075c42a4d6cc2be

Former-commit-id: 24961c5bd7492e96c3e84f71e7da7d348ffdea24

Options
    • -2
    • +2
    ./Storage/IStoreProject.cs
  2. … 9 more files in changeset.
Monday 21 Nov 2016
10:45 am

Robert Tangerman <robert.tangerman@deltares.nl>

- Moved resources to right file. - Removed default for SelectedMetaDataAttribute. Related to Issue [WTI-957]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6770 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bda15918b710d189aacf8aef09f1a1e63c572049

Former-commit-id: 6bfddd45053e6318b8ef8e52b878ef33725107f5

Options
    • -60
    • +0
    ./Properties/Resources.Designer.cs
    • -18
    • +0
    ./Properties/Resources.resx
  3. … 9 more files in changeset.
9:59 am

Robert Tangerman <robert.tangerman@deltares.nl>

- Moved label keys to resources. - Implemented separate method for right labels in grass outwards. Related to Issue [WTI-957]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6767 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: fb4f35e9cf7bbeda14963fa3e5c27a710a296e12

Former-commit-id: e900dfe47725fe03c061d08afc1390580f6c2c01

Options
    • -1
    • +61
    ./Properties/Resources.Designer.cs
    • -0
    • +18
    ./Properties/Resources.resx
  3. … 12 more files in changeset.
8:34 am

Joël van den Berg

IProjectOwner now should be implemented in such a way that null can never be returned or set. Introduced StagedProject in StorageSqLite to always have a coupling between the model and the loaded entity. connectionString is no longer maintained in StorageSqLite, but the filepath is passed along the method calls. StorageCommandHandler is responsible for logging feedback to the user. Removed interface methods regarding closing of a project (invalid use case in Ringtoets) Added SetProject method in IProjectOwner and removed setters for Project and ProjectPath, so that Project and ProjectPath are always set together. Related to Issue [WTI-961]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6764 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ca0bf302faa996815ebc7f8d434ad15fb38246db

Former-commit-id: 679b97e980241449cfd6da32ba0fd19b28e85029

Options
    • -10
    • +9
    ./Storage/IStoreProject.cs
  2. … 20 more files in changeset.
Thursday 17 Nov 2016
9:13 am

bouvrie <bouvrie@example.com>

* Introduced IReferenceLineReplaceHandler and its implementation. ** Applied Dependency Injection on ReferenceLineImporter to abstract ReferenceLine replacement specifics (also removing dependencies such as View logic!) * Moved integration test data production methods to generally available location (new test project created for it) ** Created DataImportHelper class (Replaced several IntegrationTestHelper classes with identical implementation) Related to Issue [WTI-440]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6706 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 327965238ad610377b99e3b293193784bb2ef163

Former-commit-id: efce33cd742bfd09ba26d9337f1508223c8a2559

Options
    • -1
    • +1
    ./IO/FileImporterBase.cs
  2. … 90 more files in changeset.
Monday 14 Nov 2016
3:33 pm

Marten Janssen <marten.janssen@deltares.nl>

- Review related changes paired with bouvrie Related to Issue [WTI-931]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6606 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 08d3502c090c09a8bda1840af9595e3a1ff50965

Former-commit-id: 021b9a30c3d0ce21272912dee24e3d2b6dac4318

Options
    • -5
    • +8
    ./Geometry/Point2D.cs
  2. … 14 more files in changeset.
Wednesday 09 Nov 2016
4:11 pm

Dennis Tang <dennis.tang@deltares.nl>

(Editorial) Applied comments review 1178 - Corrected typo in XMLdoc Related to Issue [WTI-931]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6558 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a27634f3f9d77e477ba65feb22f2beb7dcdcb92f

Former-commit-id: c4921ba297daafcba2d1f5cf7add3fc6a44ca6b6

Options
    • -1
    • +1
    ./Storage/IStoreProject.cs
3:18 pm

Dennis Tang <dennis.tang@deltares.nl>

(Editorial) Applied comments review 1178 - Removed redundant references in XML docs (e.g. System.X when System was already referenced) - Standardized XML docs regarding exceptions: Thrown is prefixed for the cause of the exception (e.g. <exception cref="X">Thrown when Lorus Ipsum</exception>)

Related to Issue [WTI-931]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6553 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c9a908b16e966485b3c2f38d472d9628b6f581ff

Former-commit-id: 71660f2e2159bfbb2e958ce8211bb236f66286e4

Options
    • -2
    • +2
    ./Data/RoundedDouble.cs
    • -1
    • +1
    ./Geometry/Point2D.cs
    • -2
    • +2
    ./Storage/IStoreProject.cs
  4. … 29 more files in changeset.
Friday 04 Nov 2016
2:27 pm

bouvrie <bouvrie@example.com>

* parameter null validation added. * renamed 'object' to 'value'. Related to Issue [WTI-931]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6496 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: dabe727b5cf43fa26a054b71b83f3dbabfae4224

Former-commit-id: e3290a26dfa352699943ea96e1275e3fb375403b

Options
    • -1
    • +23
    ./Geometry/Point2D.cs
    • -5
    • +11
    ./Geometry/Segment2D.cs
  3. … 35 more files in changeset.
1:58 pm

Marten Janssen <marten.janssen@deltares.nl>

- Ensure the technical reference guide can be build via Doxygen - Ran Deltares cleanup on every project that was touched Related to Issue [WTI-931]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6491 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8f75344419774da76c09075d5ac8308830a35a8b

Former-commit-id: e26553796c0f3ada7c458ada2db8e053610b8161

Options
    • -2
    • +2
    ./Geometry/Math2D.cs
    • -2
    • +2
    ./Geometry/Point2D.cs
    • -1
    • +1
    ./Storage/IStoreProject.cs
  4. … 113 more files in changeset.
1:28 pm

Marten Janssen <marten.janssen@deltares.nl>

Ensure the technical reference guide can be build via Doxygen Related to Issue [WTI-931]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6485 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a0a385c25fa4abc7082b69ad1a56c6afbbb51b50

Former-commit-id: c4bffa03b65993b5fe35820abbbe3029586d025b

Options
    • -1
    • +1
    ./Storage/CouldNotConnectException.cs
  2. … 28 more files in changeset.
9:07 am

bouvrie <bouvrie@example.com>

* Added standard serialization constructor to all Exception classes. * Explicitly defined culture for string.Format methods. * Replaced IFileImporter.ProgressChanged property to method (recommendation by C# coding conventions) * Renamed classes containing win32.dll invokes to NativeMethods (recommendation by C# coding conventions)

Related to Issue [WTI-931]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6471 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 78fae4fb038935c7a58a0fb534baa750b173d589

Former-commit-id: fc7d0938a3677be66218915a3e665a9cc6757df9

Options
    • -1
    • +2
    ./Data/RoundedDouble.cs
    • -2
    • +6
    ./Geometry/Point2D.cs
    • -1
    • +5
    ./Geometry/Point3D.cs
    • -1
    • +6
    ./IO/FileImporterBase.cs
    • -1
    • +1
    ./IO/IFileImporter.cs
    • -3
    • +5
    ./Service/FileImportActivity.cs
    • -0
    • +3
    ./Storage/CouldNotConnectException.cs
    • -0
    • +3
    ./Storage/StorageException.cs
    • -0
    • +3
    ./Storage/StorageValidationException.cs
    • -0
    • +3
    ./Storage/UpdateStorageException.cs
    • -1
    • +1
    ./TypeConverters/RoundedDoubleConverter.cs
  12. … 154 more files in changeset.
Thursday 03 Nov 2016
2:07 pm

bouvrie <bouvrie@example.com>

* Removed unused references in the solution. Related to Issue [WTI-931]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6450 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d3103841ab6e9adba07b05cb228ae2e636a5274c

Former-commit-id: a03541460ccbd16a759c489bef9b4312fe0a0b80

Options
    • -8
    • +0
    ./Core.Common.Base.csproj
  2. … 40 more files in changeset.