Core.Common.Gui

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improvements after review. Related to Issue [WTI-1143]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9010 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 61a3ea7e63971f7dac1d89909003a39621ea4894

Former-commit-id: e0301c2944a13792c06369904cb0b5ae415a777d

    • -3
    • +3
    ./ContextMenu/ContextMenuBuilderException.cs
  1. … 34 more files in changeset.
* Moved default values from dialogs to *Info objects to improved testability ** Unable to properly test images on the dialogs themselves, due to background color in dialog. Related to Issue [WTI-1159]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8856 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 9134e97086c6967f193b7a698ed75d7623df7e92

Former-commit-id: 9cdcdaa9d82d067e5bd0c0e621ff3e32b662d655

    • -27
    • +27
    ./Properties/Resources.Designer.cs
  1. … 23 more files in changeset.
Made exporter selection dialog related implementations more consistent Related to Issue [WTI-1159]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8822 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 71b6907dbac0d33bd693865bf214afce401de1ba

Former-commit-id: 91f335999b83d187813a849b745baa3dfcf76817

Made exporter selection dialog related implementations more consistent Related to Issue [WTI-1159]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8820 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8691e0af6a3aa753d34101091880a7192daa55bc

Former-commit-id: 20223018eac665d10a44a58ea930c8132e86ce45

  1. … 3 more files in changeset.
Removed unused references fixed typo paired with bouvrie Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8809 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3d002b4243d9f0109eb93ae7554f04834585ac76

Former-commit-id: b8dc47f846a37f8df0cfe56d8ce83faee121aab7

  1. … 3 more files in changeset.
* Fixed typos. * Renamed MigrationNeeded to MigrationRequired. * Cleanup. * Asserting log messages improved by taking type of message into account. * Moved CriticalFileReadException from Core.Common.IO\Exceptions to Core.Common.Base\IO * Task is now disposed when disposing ActivityProgressDialog * Put license header back Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8786 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 54560eb7ca6c0a99cdcf14b0406c23b9eca57311

Former-commit-id: 3b703601071d34a3cca2779d0c671f3d3ddabcd9

    • -14
    • +24
    ./Commands/StorageCommandHandler.cs
  1. … 118 more files in changeset.
* Refactored IInquiryHelper such that it no longer depends on FileFilterGenerator. ** From the abstraction level point of view, it just feels incorrect to pass generators around. * Extended IInquiryHelper with a method to check if a certain optional step should be performed or not. * Refactored StorageCommandHandler to use IInquiryHelper instead of showing dialogs itself. ** This should solve some issues we're having on the build server (expected dialogs not appearing) ** Also improves consistency with other code. * CalculationConfigurationWriter.WriteDistributionProperties now based on IDictionary instead of IEnumerable<Tuple> * Cleanup Related to Issue [WTI-1153]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8775 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: dec4df77800b65c57be1a8c2b6783e85a0f2c900

Former-commit-id: 9288f6b609cf96bdfa62d1fefa7e13ba956a85b7

    • -27
    • +17
    ./Commands/StorageCommandHandler.cs
    • -0
    • +44
    ./OptionalStepResult.cs
  1. … 14 more files in changeset.
* StorageCommandHandler now used SaveProjectActivity for saving a project. Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8749 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b8a3b475daa67df690ffd26a1c074ce0dcfef462

Former-commit-id: 6602462746c5f97cfb226d0d0f53dcc4ba0df72b

    • -65
    • +6
    ./Commands/StorageCommandHandler.cs
  1. … 1 more file in changeset.
* Defined activity for saving a IProject instance. Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8746 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5af9950e900268761408fba8893c9b5de179fc19

Former-commit-id: c98abd125d6387efba1f28228285c59882984fe6

    • -0
    • +174
    ./SaveProjectActivity.cs
  1. … 2 more files in changeset.
* Extended OpenProjectActivity such that Cancel works as expected. * Removed obsolete Memory Fix. Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8729 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 19f1e1967a00db9cb01dc715aa3be62eb5b3e7bb

Former-commit-id: 8923f8d5c406e5405957bca74677284dc6b10352

  1. … 2 more files in changeset.
* Progress text for OpenProjectActivity Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8710 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0732d59ab594223d4bbc1bfa411122049a8178e9

Former-commit-id: b9efe454a5381a031fdda9311e36ae3e2def5cee

    • -22
    • +56
    ./Properties/Resources.Designer.cs
  1. … 1 more file in changeset.
* Refactored StorageCommandHandler to use OpenProjectActivity. * Fixed bug in ActivityProgressDialog related to cross-threading exceptions. ** Implementation was not guaranteed to use the correct SynchronizationContext. ** Removed ProgressReporter, due to now being obsolete. ** Setting of SynchronizationContext no longer required in unit tests. * Changed default value for MigrationNeeded.

Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8699 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 40eb861411768c4a895eae17f71470458887712d

Former-commit-id: b19c95c5b04582cf50f772cb1dbfcc34f8b1fb6d

    • -39
    • +92
    ./Commands/StorageCommandHandler.cs
    • -79
    • +0
    ./Forms/ProgressDialog/ProgressReporter.cs
  1. … 8 more files in changeset.
Implemented review comments: - Set the owner of the dialog windows of the DialogBasedInquiryHelper -- Fixed affected tests - Added assertions for the log level severity - Corrected typos in XML docs - Corrected reference settings - Added missing integration tests Related to Issue [WTI-1095]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8692 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ee73e748a0bfbe46c7cc81b43aeae35429b04b5f

Former-commit-id: 6de73e069e8defde63b355a77826f15c39e4ec30

  1. … 6 more files in changeset.
* Defined OpenProjectActivity class. ** Class handles opening a project and optionally migrating it first to the current version. Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8666 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 871238779ed91c9968d4deba9f60c6a84534cda4

Former-commit-id: b7e95c17580c13c42e8b5a2b00b30b6418c30283

    • -0
    • +211
    ./OpenProjectActivity.cs
  1. … 3 more files in changeset.
* Refactored RingtoetsProjectMigrator to move responsibility of determining target location for migrated project to seperate method. * Fixed 2 failing tests. Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8660 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e725e71ba9d80444c8a49d6618832bee6ccd237d

Former-commit-id: 457b058abc9f8baa453a165f511492c49c895042

  1. … 10 more files in changeset.
* Some refactoring to RingtoetsProjectMigrator ** Now more clear return result for ShouldMigrate method between the need for migration or not or when the migration workflow is aborted. ** Moved responsibility of asking user for accepting migration from Migrate to ShouldMigrate method.

These steps have been taken as preparation to ask user for confirmation and location before starting an Activity to perform the actual migration and subsequently opening the migrated project.

Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8654 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3d793cf304e5f7f685b1d4341368297a7cbebdc7

Former-commit-id: 61ca241d865cafa2dc91367fd1dbf780aa790f73

    • -21
    • +19
    ./Commands/StorageCommandHandler.cs
  1. … 7 more files in changeset.
Incorporated the RingtoetsProjectMigrator in the StorageCommandHandler: - Fixed compilation errors of affected tests -- Introduced mocks where necessary - Ran DeltaresClean Related to Issue [WTI-1095]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8618 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d546ad32067db464f96e9faa5a55aaa2b5eef6ca

Former-commit-id: c73bfdeaf395de90207b9bdedc43baf05869ac0b

    • -5
    • +39
    ./Commands/StorageCommandHandler.cs
  1. … 13 more files in changeset.
Investigate alternative for failing SaveDialogTests on the buildserver: - Expanded the IInquiryHelper with a GetTargetFileLocation which takes a file filter and a suggested initial name as argument - Incorporated mentioned feature in the RingtoetsProjectMigrator - Adjusted failing tests Related to Issue [WTI-1095]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8594 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5dcba28f6f531f2c0cc17da88348f279e582a6e1

Former-commit-id: b94f1c1b7bad927661d5eae11fecd6e414e30e71

  1. … 3 more files in changeset.
Added tests for DataUpdateHelper and DataImportHelper. Cleanups. Related to Issue [WTI-1070]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8542 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d96afbfae2a50b332eee871ff0f4729ab2a24ef9

Former-commit-id: 5839f98a1d02d5b8885e51b59f84d309d4ea0c78

  1. … 9 more files in changeset.
Review suggestion - SettingsHelper only retrieves the special folders and is no longer responsible for creating these folder paths. Related to Issue [WTI-1091]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8491 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 65f6eb6eea38d45afd5142a8254f858e9982cf31

Former-commit-id: 0e8eb0141038b77efac381790f8d821ae2626204

    • -1
    • +1
    ./Appenders/RingtoetsUserDataFolderConverter.cs
  1. … 12 more files in changeset.
Separated the responsibilities of OpenExistingProject: - Parameterless OpenExistingProject renamed to GetExistingProjectFilePath and is now responsible to get a file path pointing to the user selected file, instead of asking and loading the project - Added tests to verify the behaviour of the GetExistingProjectFilePath - Adjusted the usage of parameterless OpenExistingProject() into a combination of GetExistingProjectFilePath and OpenExistingProject Related to Issue [WTI-1095]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8485 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b165cbf531530ff9ff9ce4ac815a07c10f9fb8be

Former-commit-id: 0b88ca194e85df8cda0fa374d3c2887574ba5a73

  1. … 1 more file in changeset.
Added messages in the GuiImportHandler and GuiUpdateHandler Related to Issue [WTI-1070]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8421 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ca4f344a6a1c7b7692057be7598d2f27cbd267a3

Former-commit-id: c89d511fb3f44f799b397c308776764de9e8b7ab

  1. … 2 more files in changeset.
Reverted PropertyGridView re-attaching IObserverable Related to Issue [WTI-1144]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8413 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ee0a5be13469faadc9cbf84489cb9cb11b100a38

Former-commit-id: 5a3acffe063f8c5c541c1efcba5c3d64241767c6

  1. … 1 more file in changeset.
replaced old distribution property implementations with the new. Related to Issue [WTI-1128]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8410 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a9d0789154bb9ea8643a8784131b23e535bc6326

Former-commit-id: d49e09d2fa8efd06dd497008c201bbc29d35a430

  1. … 51 more files in changeset.
Fixed bug in MapControl where the map was not correctly updated when a new MapData was set and notified Fixed XMLdoc typo Modified PropertyGridView to Detach and Attach to the found IObserverable Extended tests of PropertyGridView Related to Issue [WTI-1144]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8400 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b291ad2bc0f1164df6892e0333acc993d03cab5c

Former-commit-id: 52d298155154293f5875dad657eaba093190d2e4

  1. … 4 more files in changeset.
Renamed FileFilter property to FileFilterGenerator and related variable names. Related to Issue [WTI-1070]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8354 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 26fa00f166cf716d8128b6e85a5e47b43d87f8ff

Former-commit-id: 205364c3370b26b230c4f5dcd7ddb5a86ce7f874

  1. … 41 more files in changeset.
Modified RingtoetsSettingsHelper as derived class of SettingsHelper Modified BruTileSettings to use SettingsHelper and has no knowledge of either "WTI" or "Ringtoets" in the 'Core' namespace Related to Issue [WTI-1091]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8316 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 85e2fe435c64ef34dfd52e0bd99c4d90e5aa87c9

Former-commit-id: 89a20a7c5dcc99cb2a9ed2c7c9c5b42a0f465a13

  1. … 12 more files in changeset.
Removed obsolete FileResult. Renamed ExpectedFile to FileFilterGenerator. Updated doc and performed cleanups. Other small improvements. Related to Issue [WTI-1070]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8297 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c7a7dde63238ab597409a15fa06e4403571bd27c

Former-commit-id: 20d5e5224cd7fb10ee003e29defbe3c4268fe344

    • -10
    • +7
    ./ContextMenu/ContextMenuBuilder.cs
    • -3
    • +5
    ./ContextMenu/GuiContextMenuItemFactory.cs
    • -0
    • +106
    ./FileFilterGenerator.cs
  1. … 55 more files in changeset.
Changed parameter postfix to params string[] to be able to create an entire path Related to Issue [WTI-1091]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8292 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 27209e36ab0c696556e6e15709cbc89e5c2d1f00

Former-commit-id: b9dc7a6b3099a9b307e614aa6270959d0a9a5a1f

  1. … 3 more files in changeset.
Tested singleton implementation to SettingsHelper Related to Issue [WTI-1091]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8291 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5d5ff5dc26bbbe794b1f807c1271580097a6a89d

Former-commit-id: 4c001e8fbbecdf4ce5d11c446c28f13567bf74bd

  1. … 6 more files in changeset.