Riskeer / Core / Common / test

Core.Common.Gui.Test

Clone Tools

Stats

Commits this week: 0
Total Committers: 11
Last Commit: 16:28
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 18 Apr 2017
2:07 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Changes after review. Related to Issue [WTI-1108]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9341 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1a30b373d0cabf2adab5866e8f31bc8ab0bf43ea

Former-commit-id: 760c0609bfc169d4671144d76a33c13d8aef9da8

Options
    • -4
    • +4
    ./Commands/GuiUpdateHandlerTest.cs
  2. … 1 more file in changeset.
8:47 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments tester: - Changed log message of the UpdateHandlers in case there's no CurrentPath set - Formatting Related to Issue [WTI-1108]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9327 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 04fb354a8759802b4d95f0f142f8f0019f684298

Former-commit-id: 7f38f5d976210d69e3ca98aa1e6b0e9257309949

Options
    • -2
    • +48
    ./Commands/GuiUpdateHandlerTest.cs
  2. … 4 more files in changeset.
Monday 20 Mar 2017
11:55 am

bouvrie <bouvrie@example.com>

* Moved default values from dialogs to *Info objects to improved testability ** Unable to properly test images on the dialogs themselves, due to background color in dialog. Related to Issue [WTI-1159]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8856 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 9134e97086c6967f193b7a698ed75d7623df7e92

Former-commit-id: 9cdcdaa9d82d067e5bd0c0e621ff3e32b662d655

Options
    • -6
    • +8
    ./Plugin/ExportInfoTest.cs
    • -6
    • +8
    ./Plugin/ImportInfoTest.cs
    • -6
    • +8
    ./Plugin/UpdateInfoTest.cs
  4. … 28 more files in changeset.
Thursday 16 Mar 2017
2:20 pm

Elmar Kleijn

Added missing test coverage Related to Issue [WTI-1159]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8829 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a2a972181152d7f3863913453e0be62d3870444d

Former-commit-id: 5b8fd8c3df3a1fa26aa00097b87e826264ab488a

Options
    • -1
    • +93
    ./Commands/GuiExportHandlerTest.cs
Wednesday 15 Mar 2017
2:36 pm

Marten Janssen <marten.janssen@deltares.nl>

Removed unused references fixed typo paired with bouvrie Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8809 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3d002b4243d9f0109eb93ae7554f04834585ac76

Former-commit-id: b8dc47f846a37f8df0cfe56d8ce83faee121aab7

Options
    • -1
    • +0
    ./Commands/StorageCommandHandlerTest.cs
    • -8
    • +0
    ./Core.Common.Gui.Test.csproj
  3. … 4 more files in changeset.
Tuesday 14 Mar 2017
4:26 pm

bouvrie <bouvrie@example.com>

* Fixed typos. * Renamed MigrationNeeded to MigrationRequired. * Cleanup. * Asserting log messages improved by taking type of message into account. * Moved CriticalFileReadException from Core.Common.IO\Exceptions to Core.Common.Base\IO * Task is now disposed when disposing ActivityProgressDialog * Put license header back Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8786 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 54560eb7ca6c0a99cdcf14b0406c23b9eca57311

Former-commit-id: 3b703601071d34a3cca2779d0c671f3d3ddabcd9

Options
    • -10
    • +38
    ./Commands/StorageCommandHandlerTest.cs
    • -0
    • +4
    ./Core.Common.Gui.Test.csproj
    • -4
    • +4
    ./GuiCoreTest.cs
    • -6
    • +9
    ./OpenProjectActivityTest.cs
  5. … 121 more files in changeset.
1:36 pm

bouvrie <bouvrie@example.com>

* Refactored IInquiryHelper such that it no longer depends on FileFilterGenerator. ** From the abstraction level point of view, it just feels incorrect to pass generators around. * Extended IInquiryHelper with a method to check if a certain optional step should be performed or not. * Refactored StorageCommandHandler to use IInquiryHelper instead of showing dialogs itself. ** This should solve some issues we're having on the build server (expected dialogs not appearing) ** Also improves consistency with other code. * CalculationConfigurationWriter.WriteDistributionProperties now based on IDictionary instead of IEnumerable<Tuple> * Cleanup Related to Issue [WTI-1153]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8775 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: dec4df77800b65c57be1a8c2b6783e85a0f2c900

Former-commit-id: 9288f6b609cf96bdfa62d1fefa7e13ba956a85b7

Options
    • -3
    • +3
    ./Commands/GuiImportHandlerTest.cs
    • -3
    • +3
    ./Commands/GuiUpdateHandlerTest.cs
    • -53
    • +69
    ./Commands/StorageCommandHandlerTest.cs
    • -0
    • +50
    ./DialogBasedInquiryHelperTest.cs
  5. … 18 more files in changeset.
Monday 13 Mar 2017
2:00 pm

bouvrie <bouvrie@example.com>

Revert commit 8755

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8756 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 943b3c0670fec2b02077c57b2e49a7d22e8adc63

Former-commit-id: 402c5eff0d8c3acbc9a89f36e890e455e4e66d4c

Options
    • -3
    • +3
    ./Commands/StorageCommandHandlerTest.cs
1:44 pm

bouvrie <bouvrie@example.com>

Attempt to fix failing test on builder server (locally the changed test works without problems)

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8755 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 9aa647cabd3a49d93f0e82c2843b87607446dd4e

Former-commit-id: 9502c6632c0bbaf2ae9261efd422e0de39107364

Options
    • -3
    • +3
    ./Commands/StorageCommandHandlerTest.cs
12:35 pm

bouvrie <bouvrie@example.com>

* StorageCommandHandler now used SaveProjectActivity for saving a project. Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8749 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b8a3b475daa67df690ffd26a1c074ce0dcfef462

Former-commit-id: 6602462746c5f97cfb226d0d0f53dcc4ba0df72b

Options
    • -4
    • +24
    ./Commands/StorageCommandHandlerTest.cs
  2. … 3 more files in changeset.
11:15 am

bouvrie <bouvrie@example.com>

* Defined activity for saving a IProject instance. Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8746 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5af9950e900268761408fba8893c9b5de179fc19

Former-commit-id: c98abd125d6387efba1f28228285c59882984fe6

Options
    • -0
    • +1
    ./Core.Common.Gui.Test.csproj
    • -0
    • +541
    ./SaveProjectActivityTest.cs
  3. … 4 more files in changeset.
Friday 10 Mar 2017
2:13 pm

Dennis Tang <dennis.tang@deltares.nl>

Implemented review comments: - Removed obsolete lines in project file - Added assertions for the log level of the generated log messages - Renamed tests for naming consistency - Replaced testcases with a general source for the invalid file paths

Related to Issue [WTI-1095]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8730 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: fe2b47099a1213a7a063bf08564abb9c1b5562bb

Former-commit-id: 5564b6705928765ed5bc716661f2ba635da89681

Options
    • -42
    • +45
    ./Commands/StorageCommandHandlerTest.cs
  2. … 2 more files in changeset.
2:01 pm

bouvrie <bouvrie@example.com>

* Extended OpenProjectActivity such that Cancel works as expected. * Removed obsolete Memory Fix. Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8729 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 19f1e1967a00db9cb01dc715aa3be62eb5b3e7bb

Former-commit-id: 8923f8d5c406e5405957bca74677284dc6b10352

Options
    • -0
    • +149
    ./OpenProjectActivityTest.cs
  2. … 2 more files in changeset.
10:54 am

bouvrie <bouvrie@example.com>

* Progress text for OpenProjectActivity Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8710 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0732d59ab594223d4bbc1bfa411122049a8178e9

Former-commit-id: b9efe454a5381a031fdda9311e36ae3e2def5cee

Options
    • -3
    • +304
    ./OpenProjectActivityTest.cs
  2. … 3 more files in changeset.
Thursday 09 Mar 2017
4:46 pm

bouvrie <bouvrie@example.com>

* Refactored StorageCommandHandler to use OpenProjectActivity. * Fixed bug in ActivityProgressDialog related to cross-threading exceptions. ** Implementation was not guaranteed to use the correct SynchronizationContext. ** Removed ProgressReporter, due to now being obsolete. ** Setting of SynchronizationContext no longer required in unit tests. * Changed default value for MigrationNeeded.

Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8699 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 40eb861411768c4a895eae17f71470458887712d

Former-commit-id: b19c95c5b04582cf50f772cb1dbfcc34f8b1fb6d

Options
    • -13
    • +96
    ./Commands/StorageCommandHandlerTest.cs
    • -1
    • +0
    ./Core.Common.Gui.Test.csproj
    • -7
    • +0
    ./Forms/ProgressDialog/ActivityProgressDialogTest.cs
    • -88
    • +0
    ./Forms/ProgressDialog/ProgressReporterTest.cs
    • -4
    • +4
    ./GuiCoreTest.cs
  6. … 10 more files in changeset.
3:06 pm

Dennis Tang <dennis.tang@deltares.nl>

Implemented review comments: - Set the owner of the dialog windows of the DialogBasedInquiryHelper -- Fixed affected tests - Added assertions for the log level severity - Corrected typos in XML docs - Corrected reference settings - Added missing integration tests Related to Issue [WTI-1095]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8692 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ee73e748a0bfbe46c7cc81b43aeae35429b04b5f

Former-commit-id: 6de73e069e8defde63b355a77826f15c39e4ec30

Options
    • -0
    • +6
    ./DialogBasedInquiryHelperTest.cs
    • -19
    • +20
    ./GuiCoreTest.cs
  3. … 6 more files in changeset.
Wednesday 08 Mar 2017
4:55 pm

bouvrie <bouvrie@example.com>

* Defined OpenProjectActivity class. ** Class handles opening a project and optionally migrating it first to the current version. Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8666 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 871238779ed91c9968d4deba9f60c6a84534cda4

Former-commit-id: b7e95c17580c13c42e8b5a2b00b30b6418c30283

Options
    • -0
    • +1
    ./Core.Common.Gui.Test.csproj
    • -0
    • +764
    ./OpenProjectActivityTest.cs
  3. … 3 more files in changeset.
3:06 pm

bouvrie <bouvrie@example.com>

* Refactored RingtoetsProjectMigrator to move responsibility of determining target location for migrated project to seperate method. * Fixed 2 failing tests. Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8660 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e725e71ba9d80444c8a49d6618832bee6ccd237d

Former-commit-id: 457b058abc9f8baa453a165f511492c49c895042

Options
    • -15
    • +80
    ./Commands/StorageCommandHandlerTest.cs
    • -2
    • +4
    ./GuiCoreTest.cs
  3. … 9 more files in changeset.
11:51 am

bouvrie <bouvrie@example.com>

* Some refactoring to RingtoetsProjectMigrator ** Now more clear return result for ShouldMigrate method between the need for migration or not or when the migration workflow is aborted. ** Moved responsibility of asking user for accepting migration from Migrate to ShouldMigrate method.

These steps have been taken as preparation to ask user for confirmation and location before starting an Activity to perform the actual migration and subsequently opening the migrated project.

Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8654 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3d793cf304e5f7f685b1d4341368297a7cbebdc7

Former-commit-id: 61ca241d865cafa2dc91367fd1dbf780aa790f73

Options
    • -3
    • +6
    ./Commands/StorageCommandHandlerTest.cs
    • -2
    • +4
    ./GuiCoreTest.cs
  3. … 6 more files in changeset.
Tuesday 07 Mar 2017
3:10 pm

Dennis Tang <dennis.tang@deltares.nl>

- Removed obsolete stub method calls - Added "integration" tests for the GUICore (in order to be consistent with the LoadProject calls) Related to Issue [WTI-1095]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8620 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0100264b833c99c20a87a8c2c89594c654606557

Former-commit-id: fd375e6dd84716598c2c0e5916711362b03546d2

Options
    • -3
    • +0
    ./Commands/StorageCommandHandlerTest.cs
    • -2
    • +156
    ./GuiCoreTest.cs
2:51 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated the RingtoetsProjectMigrator in the StorageCommandHandler: - Fixed compilation errors of affected tests -- Introduced mocks where necessary - Ran DeltaresClean Related to Issue [WTI-1095]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8618 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d546ad32067db464f96e9faa5a55aaa2b5eef6ca

Former-commit-id: c73bfdeaf395de90207b9bdedc43baf05869ac0b

Options
    • -29
    • +259
    ./Commands/StorageCommandHandlerTest.cs
    • -2
    • +4
    ./Forms/MainWindow/MainWindowTest.cs
    • -41
    • +81
    ./GuiCoreTest.cs
  4. … 12 more files in changeset.
7:59 am

Joël van den Berg

used PropertyTestHelper.GetAllVisiblePropertyDescriptors where possible and sensible. Related to Issue [WTI-1051]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8589 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d3287464ebea6a899a1eb3c6908575438c55f63b

Former-commit-id: 344cd82a211c6c64b21cc9ff55e08a51d98bc46a

Options
    • -37
    • +36
    ./PropertyBag/DynamicPropertyBagTest.cs
  2. … 13 more files in changeset.
Monday 06 Mar 2017
3:58 pm

Dennis Tang <dennis.tang@deltares.nl>

Created RingtoetsProjectMigrator: - GUI handler for determining when a file should be migrated and performs the migration - Added tests - Removed unused reference Related to Issue [WTI-1095]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8580 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d94000a2583fb23bc4f5a00fdaf6ebe6764791a3

Former-commit-id: 23536a9d5c9045d0ba7526835a4da47bab7b0ff4

Options
    • -1
    • +0
    ./Commands/StorageCommandHandlerTest.cs
  2. … 8 more files in changeset.
Thursday 02 Mar 2017
2:33 pm

Joël van den Berg

Added tests for DataUpdateHelper and DataImportHelper. Cleanups. Related to Issue [WTI-1070]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8542 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d96afbfae2a50b332eee871ff0f4729ab2a24ef9

Former-commit-id: 5839f98a1d02d5b8885e51b59f84d309d4ea0c78

Options
    • -1
    • +1
    ./Commands/GuiImportHandlerTest.cs
    • -2
    • +2
    ./Commands/GuiUpdateHandlerTest.cs
  3. … 8 more files in changeset.
Wednesday 01 Mar 2017
4:27 pm

Marten Janssen <marten.janssen@deltares.nl>

Applied review suggestions mentioned in WTI-REVIEW-1471 to move Asserts from the DialogBoxHandler to later in the method Related to Issue [WTI-1070]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8526 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 88b61e16b1c535b6c29c4b2cd2b44518f8fb96d1

Former-commit-id: f69a10ce1ff831be7efd23a76cc4842b36ef8227

Options
    • -10
    • +8
    ./Commands/GuiImportHandlerTest.cs
    • -10
    • +8
    ./Commands/GuiUpdateHandlerTest.cs
Tuesday 28 Feb 2017
3:42 pm

Marten Janssen <marten.janssen@deltares.nl>

Review suggestion - SettingsHelper only retrieves the special folders and is no longer responsible for creating these folder paths. Related to Issue [WTI-1091]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8491 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 65f6eb6eea38d45afd5142a8254f858e9982cf31

Former-commit-id: 0e8eb0141038b77efac381790f8d821ae2626204

Options
    • -1
    • +1
    ./Appenders/RingtoetsUserDataFolderConverterTest.cs
    • -31
    • +31
    ./Settings/SettingsHelperTest.cs
  3. … 13 more files in changeset.
3:11 pm

Dennis Tang <dennis.tang@deltares.nl>

Separated the responsibilities of OpenExistingProject: - Parameterless OpenExistingProject renamed to GetExistingProjectFilePath and is now responsible to get a file path pointing to the user selected file, instead of asking and loading the project - Added tests to verify the behaviour of the GetExistingProjectFilePath - Adjusted the usage of parameterless OpenExistingProject() into a combination of GetExistingProjectFilePath and OpenExistingProject Related to Issue [WTI-1095]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8485 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b165cbf531530ff9ff9ce4ac815a07c10f9fb8be

Former-commit-id: 0b88ca194e85df8cda0fa374d3c2887574ba5a73

Options
    • -0
    • +75
    ./Commands/StorageCommandHandlerTest.cs
  2. … 3 more files in changeset.
8:23 am

Marten Janssen <marten.janssen@deltares.nl>

Review related suggestions Related to Issue [WTI-1144]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8451 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1727fc14aecff4df000b090c26b960939e388d0e

Former-commit-id: c2321b11dec0e3dde4240ccf1e35c30d68b7dc28

Options
    • -12
    • +12
    ./Forms/PropertyGridView/PropertyGridViewTest.cs
  2. … 4 more files in changeset.
Monday 27 Feb 2017
2:22 pm

Marten Janssen <marten.janssen@deltares.nl>

Review suggestion - Explicit types - Extended tests - Moved UseCustomSettingsHelper to Core.Common.Gui.TestUtil Related to Issue [WTI-1091]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8440 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ff142b1c5f7f09290831c940e8089533a7250a52

Former-commit-id: c7bda8c1d641aadd567c2a4c2c746816149f4c49

Options
    • -5
    • +5
    ./Settings/SettingsHelperTest.cs
  2. … 13 more files in changeset.
9:00 am

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. Related to Issue [WTI-1133]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8428 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 331f6ea0cfe5494ebfc1e4fb917ee42212e8a114

Former-commit-id: e779a2129e8567975f4f85e6bb8e1ac14bd3bc43

Options
    • -1
    • +1
    ./Commands/GuiImportHandlerTest.cs
    • -2
    • +2
    ./Commands/GuiUpdateHandlerTest.cs
  3. … 25 more files in changeset.