Riskeer / Core

Common

Clone Tools

Stats

Commits this week: 2
Total Committers: 16
Last Commit: 22 Apr
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 25 Sep 2018
11:12 am

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup: Made methods and properties private where possible. WTI-1767

Options
    • -1
    • +2
    ./src/Core.Common.IO/Readers/SqLiteDatabaseReaderBase.cs
  2. … 4 more files in changeset.
Monday 24 Sep 2018
2:15 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup: Removed unused usings. WTI-1767

Options
    • -1
    • +0
    ./src/Core.Common.Controls.TreeView/DragDropHandler.cs
    • -1
    • +0
    ./test/Core.Common.Controls.Test/PresentationObjects/WrappedObjectContextBaseTest.cs
    • -1
    • +0
    ./test/Core.Common.Gui.Test/Commands/StorageCommandHandlerTest.cs
  4. … 28 more files in changeset.
1:58 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup: Conditional access qualifier expression is known to be not null. WTI-1767

Options
    • -1
    • +1
    ./src/Core.Common.Gui/Converters/KeyValueExpandableArrayConverter.cs
1:58 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Revert "Cleanup: Conditional access qualifier expression is known to be not null. WTI-1767"

This reverts commit c4b24c0a4946d7cd20c0fb302aa9c8e30f10afc6.

Options
    • -1
    • +1
    ./src/Core.Common.Gui/Converters/KeyValueExpandableArrayConverter.cs
1:48 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup: Fixed localizable string. WTI-1767

Options
    • -1
    • +1
    ./src/Core.Common.Base/Data/Range.cs
    • -2
    • +2
    ./src/Core.Common.Gui/OpenProjectActivity.cs
    • -1
    • +1
    ./test/Core.Common.TestUtil/TestHelper.cs
1:37 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup: Fixed Expression is always null. WTI-1767

Options
    • -16
    • +4
    ./test/Core.Common.TestUtil.Test/RandomExtensionsTest.cs
    • -4
    • +1
    ./test/Core.Common.Util.Test/Drawing/GraphicsExtensionsTest.cs
    • -4
    • +1
    ./test/Core.Common.Util.Test/Extensions/CollectionExtensionsTest.cs
    • -12
    • +3
    ./test/Core.Common.Util.Test/Extensions/EnumerableExtensionsTest.cs
  5. … 21 more files in changeset.
1:00 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup: Fixed typos. WTI-1767

Options
    • -1
    • +1
    ./src/Core.Common.Geometry/AdvancedMath2D.cs
    • -7
    • +7
    ./test/Core.Common.Base.Test/Geometry/Point2DTest.cs
  3. … 1 more file in changeset.
Thursday 20 Sep 2018
5:11 pm

Robert Tangerman <robert.tangerman@deltares.nl>

"<geen>" => "<selecteer>". WTI-1691

Options
    • -2
    • +2
    ./src/Core.Common.Controls/Properties/Resources.Designer.cs
    • -1
    • +1
    ./src/Core.Common.Controls/Properties/Resources.resx
    • -1
    • +1
    ./test/Core.Common.Controls.Test/DataGrid/DataGridViewComboBoxItemWrapperTest.cs
  4. … 12 more files in changeset.
5:11 pm

Robert Tangerman <robert.tangerman@deltares.nl>

"<geen>" => "<selecteer>". WTI-1691

Options
    • -2
    • +2
    ./src/Core.Common.Controls/Properties/Resources.Designer.cs
    • -1
    • +1
    ./src/Core.Common.Controls/Properties/Resources.resx
    • -1
    • +1
    ./test/Core.Common.Controls.Test/DataGrid/DataGridViewComboBoxItemWrapperTest.cs
  4. … 12 more files in changeset.
4:30 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Set combobox FlatStyle to flat. WTI-1691

Options
    • -1
    • +2
    ./src/Core.Common.Controls/DataGrid/DataGridViewControl.cs
    • -0
    • +3
    ./test/Core.Common.Controls.Test/DataGrid/DataGridViewControlTest.cs
Monday 17 Sep 2018
11:10 am

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. WTI-1787

Options
    • -31
    • +33
    ./src/Core.Common.Gui/Forms/MainWindow/MainWindow.xaml.cs
    • -2
    • +4
    ./src/Core.Common.Gui/Forms/ViewHost/AvalonDockViewHost.xaml.cs
    • -3
    • +0
    ./src/Core.Common.Util/IO/EmbeddedResourceFileWriter.cs
    • -1
    • +2
    ./test/Core.Common.TestUtil.Test/InvalidPathHelperTest.cs
    • -1
    • +2
    ./test/Core.Common.TestUtil/InvalidPathHelper.cs
  6. … 9 more files in changeset.
Wednesday 12 Sep 2018
11:58 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Reduce bugs in sonarqube, improve assigning of values to arrays with suspicious operator WTI-1787

Options
    • -4
    • +6
    ./src/Core.Common.Util/Drawing/ColorAccess.cs
  2. … 2 more files in changeset.
Tuesday 11 Sep 2018
10:41 am

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. WTI-1803

Options
    • -6
    • +6
    ./test/Core.Common.TestUtil.Test/RandomExtensionsTest.cs
  2. … 1 more file in changeset.
9:50 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3233:

- Updated XMLDocs

- Cleaned tests

- Improved src of the IdGenerator

WTI-1803

Options
    • -19
    • +12
    ./test/Core.Common.TestUtil.Test/RandomExtensionsTest.cs
    • -3
    • +3
    ./test/Core.Common.TestUtil/RandomExtensions.cs
  3. … 4 more files in changeset.
Friday 07 Sep 2018
3:14 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3223:

- Introduced random extensions to select a subset of enums

- Applied to affected tests

-- Applied to AssessmentSectionAssemblyResult as none and notapplicable are invalid results and will cause a NotSupportedException when generated.

WTI-1803

Options
    • -1
    • +86
    ./test/Core.Common.TestUtil.Test/RandomExtensionsTest.cs
    • -0
    • +37
    ./test/Core.Common.TestUtil/RandomExtensions.cs
  3. … 7 more files in changeset.
Thursday 30 Aug 2018
10:50 am

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup: Fix implementation of IDisposable to conform to the dispose pattern. WTI-1787

Options
    • -1
    • +10
    ./src/Core.Common.Base/Observer.cs
    • -1
    • +10
    ./src/Core.Common.Base/RecursiveObserver.cs
    • -2
    • +11
    ./src/Core.Common.Controls.TreeView/TreeViewControl.cs
    • -2
    • +9
    ./src/Core.Common.Gui/Forms/MainWindow/MainWindow.xaml.cs
    • -5
    • +17
    ./src/Core.Common.Gui/Forms/ViewHost/AvalonDockViewHost.xaml.cs
    • -3
    • +11
    ./src/Core.Common.Gui/Forms/ViewHost/DocumentViewController.cs
    • -2
    • +11
    ./src/Core.Common.Gui/Plugin/PluginBase.cs
    • -2
    • +9
    ./src/Core.Common.Util/IO/EmbeddedResourceFileWriter.cs
  9. … 32 more files in changeset.
8:41 am

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup: Parameter validation in yielding methods should be wrapped. WTI-1787

Options
    • -0
    • +6
    ./src/Core.Common.Geometry/AdvancedMath2D.cs
Wednesday 29 Aug 2018
1:50 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup: use an immutable collection or reduce the accessibility of the field. WTI-1787

Options
    • -6
    • +12
    ./test/Core.Common.TestUtil/InvalidPathHelper.cs
Friday 24 Aug 2018
2:27 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Reduce sonarqube Bugs WTI-1787

Options
    • -6
    • +11
    ./src/Core.Common.Util/EnumTypeConverter.cs
    • -1
    • +5
    ./src/Core.Common.Util/NullableEnumConverter.cs
  3. … 2 more files in changeset.
12:58 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Reduce code smells from sonarqube in Core namespace WTI-1787

Options
    • -5
    • +3
    ./src/Core.Common.Base/Geometry/Point3DCollectionExtensions.cs
  2. … 4 more files in changeset.
Thursday 23 Aug 2018
2:30 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated 3190:

- Removed obsolete test fixture tests

- Updated XMLDoc

Paired with ~carloslubbers

WTI-1789

Options
    • -1
    • +1
    ./src/Core.Common.Util/Reflection/TypeUtils.cs
    • -2
    • +0
    ./test/Core.Common.TestUtil.Test/Core.Common.TestUtil.Test.csproj
    • -74
    • +0
    ./test/Core.Common.TestUtil.Test/EnumValuesTestFixtureTest.cs
    • -86
    • +0
    ./test/Core.Common.TestUtil.Test/EnumWithDisplayNameTestFixtureTest.cs
10:31 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Improve typeutil test WTI-1789

Options
    • -5
    • +13
    ./test/Core.Common.Util.Test/Reflection/TypeUtilsTest.cs
10:25 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Improve utils WTI-1789

Options
    • -1
    • +2
    ./src/Core.Common.Util/Reflection/TypeUtils.cs
    • -1
    • +1
    ./test/Core.Common.TestUtil.Test/EnumWithDisplayNameTestFixtureTest.cs
    • -1
    • +2
    ./test/Core.Common.TestUtil/Core.Common.TestUtil.csproj
    • -62
    • +0
    ./test/Core.Common.TestUtil/EnumWithDisplayNameTestFixture.cs
    • -0
    • +65
    ./test/Core.Common.TestUtil/EnumWithNameTestFixture.cs
    • -0
    • +35
    ./test/Core.Common.TestUtil/EnumWithResourcesDisplayNameTestFixture.cs
    • -31
    • +3
    ./test/Core.Common.TestUtil/EnumWithXmlEnumNameTestFixture.cs
  8. … 35 more files in changeset.
Friday 17 Aug 2018
10:42 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Update tests and introduce writer class WTI-1789

Options
    • -0
    • +3
    ./test/Core.Common.TestUtil.Test/TestHelperTest.cs
    • -0
    • +5
    ./test/Core.Common.TestUtil/TestDataPath.cs
  3. … 8 more files in changeset.
Thursday 09 Aug 2018
2:49 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Add enum for serializable failure mechanism category groups WTI-1789

Options
    • -0
    • +2
    ./test/Core.Common.TestUtil/Core.Common.TestUtil.csproj
    • -0
    • +63
    ./test/Core.Common.TestUtil/EnumWithXmlEnumNameTestFixture.cs
  3. … 7 more files in changeset.
Wednesday 08 Aug 2018
2:45 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Add method to typeutils WTI-1789

Options
    • -0
    • +22
    ./src/Core.Common.Util/Reflection/TypeUtils.cs
    • -0
    • +31
    ./test/Core.Common.Util.Test/Reflection/TypeUtilsTest.cs
  3. … 1 more file in changeset.
Tuesday 07 Aug 2018
11:17 am

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. WTI-1022

Options
    • -1
    • +1
    ./test/Core.Common.TestUtil.Test/TestHelperTest.cs
Monday 06 Aug 2018
3:37 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added thread sleep. WTI-1022

Options
    • -2
    • +6
    ./test/Core.Common.TestUtil/TestHelper.cs
2:46 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added thread sleep.

Options
    • -1
    • +5
    ./test/Core.Common.TestUtil/TestHelper.cs
Friday 03 Aug 2018
11:47 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added method to TestHelper to help with testing when timers are involved. WTI-1022

Options
    • -1
    • +22
    ./test/Core.Common.TestUtil.Test/TestHelperTest.cs
    • -0
    • +36
    ./test/Core.Common.TestUtil/TestHelper.cs