Riskeer / Core

Components

Clone Tools

Stats

Commits this week: 2
Total Committers: 13
Last Commit: 20 Apr
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 29 Nov 2018
4:28 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3395: WTI-1887

- Added typed derivative of the FeatureBasedMapData in order to prevent duplication of specific converters

Options
    • -1
    • +29
    ./src/Core.Components.Gis/Data/FeatureBasedMapData.cs
    • -1
    • +33
    ./test/Core.Components.Gis.Test/Data/FeatureBasedMapDataTest.cs
Tuesday 27 Nov 2018
1:59 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed obsolete helper. WTI-1894

Options
    • -34
    • +0
    ./src/Core.Components.Gis/Helpers/MapDataCollectionHelper.cs
    • -67
    • +0
    ./test/Core.Components.Gis.Test/Helpers/MapDataCollectionHelperTest.cs
1:54 pm

Dennis Tang <dennis.tang@deltares.nl>

Added display names to MapDataCollectionVisisbility. WTI-1894

Options
    • -0
    • +6
    ./src/Core.Components.Gis/Data/MapDataCollectionVisibility.cs
    • -2
    • +29
    ./src/Core.Components.Gis/Properties/Resources.Designer.cs
    • -0
    • +9
    ./src/Core.Components.Gis/Properties/Resources.resx
    • -1
    • +20
    ./test/Core.Components.Gis.Test/Data/MapDataCollectionVisibilityTest.cs
Tuesday 20 Nov 2018
3:45 pm

Dennis Tang <dennis.tang@deltares.nl>

Ran intermediate cleanup across affected projects. WTI-1887

Options
    • -38
    • +38
    ./src/Core.Components.DotSpatial/Converter/FeatureBasedMapDataConverter.cs
    • -1
    • +0
    ./src/Core.Components.Gis/Theme/LineCategoryTheme.cs
    • -1
    • +0
    ./src/Core.Components.Gis/Theme/PointCategoryTheme.cs
    • -1
    • +0
    ./src/Core.Components.Gis/Theme/PolygonCategoryTheme.cs
    • -1
    • +1
    ./test/Core.Components.DotSpatial.Test/Converter/MapLineDataConverterTest.cs
  6. … 5 more files in changeset.
1:33 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed obsolete test factory. WTI-1887

Options
    • -43
    • +0
    ./test/Core.Components.Gis.TestUtil.Test/CategoryThemeTestFactoryTest.cs
    • -1
    • +0
    ./test/Core.Components.Gis.TestUtil.Test/Core.Components.Gis.TestUtil.Test.csproj
    • -46
    • +0
    ./test/Core.Components.Gis.TestUtil/CategoryThemeTestFactory.cs
    • -1
    • +0
    ./test/Core.Components.Gis.TestUtil/Core.Components.Gis.TestUtil.csproj
  5. … 1 more file in changeset.
Friday 16 Nov 2018
1:12 pm

Dennis Tang <dennis.tang@deltares.nl>

Added missing tests WTI-1887

- Added for the derived classes: default category should be added when a theme is defined for an attribute that's not present in the features.

- Added for the filter expression, test in the base class to guarantee it always gives the expected expression.

- Fixed parameter names

Options
    • -1
    • +29
    ./test/Core.Components.DotSpatial.Test/Converter/FeatureBasedMapDataConverterTest.cs
    • -0
    • +50
    ./test/Core.Components.DotSpatial.Test/Converter/MapLineDataConverterTest.cs
    • -3
    • +57
    ./test/Core.Components.DotSpatial.Test/Converter/MapPointDataConverterTest.cs
    • -7
    • +57
    ./test/Core.Components.DotSpatial.Test/Converter/MapPolygonDataConverterTest.cs
11:51 am

Dennis Tang <dennis.tang@deltares.nl>

Fixed converters. WTI-1887

- Added category creation logic in the converters and pushed tests downwards for the derived datatypes from the converter base class.

Options
    • -2
    • +7
    ./src/Core.Components.DotSpatial/Converter/FeatureBasedMapDataConverter.cs
    • -10
    • +35
    ./src/Core.Components.DotSpatial/Converter/MapLineDataConverter.cs
    • -15
    • +34
    ./src/Core.Components.DotSpatial/Converter/MapPointDataConverter.cs
    • -10
    • +36
    ./src/Core.Components.DotSpatial/Converter/MapPolygonDataConverter.cs
    • -11
    • +5
    ./test/Core.Components.DotSpatial.Test/Converter/FeatureBasedMapDataConverterTest.cs
    • -20
    • +89
    ./test/Core.Components.DotSpatial.Test/Converter/MapLineDataConverterTest.cs
    • -21
    • +98
    ./test/Core.Components.DotSpatial.Test/Converter/MapPointDataConverterTest.cs
    • -15
    • +88
    ./test/Core.Components.DotSpatial.Test/Converter/MapPolygonDataConverterTest.cs
Thursday 15 Nov 2018
4:04 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted base converter WTI-1887

- Turned the base converter into a template pattern class, as the derived classes should provide the implementations to convert categories

Options
    • -44
    • +17
    ./src/Core.Components.DotSpatial/Converter/FeatureBasedMapDataConverter.cs
    • -109
    • +67
    ./test/Core.Components.DotSpatial.Test/Converter/FeatureBasedMapDataConverterTest.cs
2:24 pm

Dennis Tang <dennis.tang@deltares.nl>

Pushed (Map)Theme property from the base down to derived classes. WTI-1887

- Pushed down as the derived classes each has their own specific styling options and thus their own categorical theming.

Options
    • -6
    • +0
    ./src/Core.Components.Gis/Data/FeatureBasedMapData.cs
    • -0
    • +6
    ./src/Core.Components.Gis/Data/MapLineData.cs
    • -0
    • +6
    ./src/Core.Components.Gis/Data/MapPointData.cs
    • -0
    • +6
    ./src/Core.Components.Gis/Data/MapPolygonData.cs
    • -1
    • +0
    ./test/Core.Components.Gis.Test/Data/FeatureBasedMapDataTest.cs
    • -3
    • +9
    ./test/Core.Components.Gis.Test/Data/MapLineDataTest.cs
    • -4
    • +10
    ./test/Core.Components.Gis.Test/Data/MapPointDataTest.cs
    • -4
    • +9
    ./test/Core.Components.Gis.Test/Data/MapPolygonDataTest.cs
    • -2
    • +0
    ./test/Core.Components.Gis.Test/TestFeatureBasedMapDataTest.cs
1:56 pm

Dennis Tang <dennis.tang@deltares.nl>

Made MapTheme typed. WTI-1887

- Made it typed as a preparation for pushing the MapTheme property down to its derived classes for the FeatureBasedMapData

Options
    • -5
    • +6
    ./src/Core.Components.Gis/Theme/MapTheme.cs
    • -11
    • +18
    ./test/Core.Components.Gis.Test/Theme/MapThemeTest.cs
1:42 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated CategoryTheme. WTI-1887

- Made class abstract, as it serves as a base for the specific Map type data

- Removed Color property as it is already contained within the derived classes and their specific styling

Options
    • -10
    • +2
    ./src/Core.Components.Gis/Theme/CategoryTheme.cs
    • -1
    • +1
    ./src/Core.Components.Gis/Theme/LineCategoryTheme.cs
    • -1
    • +1
    ./src/Core.Components.Gis/Theme/PointCategoryTheme.cs
    • -1
    • +1
    ./src/Core.Components.Gis/Theme/PolygonCategoryTheme.cs
    • -14
    • +9
    ./test/Core.Components.Gis.Test/Theme/CategoryThemeTest.cs
1:14 pm

Dennis Tang <dennis.tang@deltares.nl>

Added derived CategoryThemes. WTI-1887

- Added derived themes to represent the individual styling of each possible data type.

Options
    • -0
    • +3
    ./src/Core.Components.Gis/Core.Components.Gis.csproj
    • -0
    • +55
    ./src/Core.Components.Gis/Theme/LineCategoryTheme.cs
    • -0
    • +55
    ./src/Core.Components.Gis/Theme/PointCategoryTheme.cs
    • -0
    • +55
    ./src/Core.Components.Gis/Theme/PolygonCategoryTheme.cs
    • -0
    • +3
    ./test/Core.Components.Gis.Test/Core.Components.Gis.Test.csproj
    • -0
    • +60
    ./test/Core.Components.Gis.Test/Theme/LineCategoryThemeTest.cs
    • -0
    • +60
    ./test/Core.Components.Gis.Test/Theme/PointCategoryThemeTest.cs
    • -0
    • +60
    ./test/Core.Components.Gis.Test/Theme/PolygonCategoryThemeTest.cs
11:44 am

Dennis Tang <dennis.tang@deltares.nl>

Added test factory to create instance of ValueCriterion. WTI-1887

Options
    • -0
    • +1
    ./test/Core.Components.Gis.TestUtil.Test/Core.Components.Gis.TestUtil.Test.csproj
    • -0
    • +41
    ./test/Core.Components.Gis.TestUtil.Test/ValueCriterionTestFactoryTest.cs
    • -0
    • +1
    ./test/Core.Components.Gis.TestUtil/Core.Components.Gis.TestUtil.csproj
    • -0
    • +40
    ./test/Core.Components.Gis.TestUtil/ValueCriterionTestFactory.cs
Wednesday 14 Nov 2018
9:37 am

Robert Tangerman <robert.tangerman@deltares.nl>

Possible fix for background map bug. WTI-1210

Options
    • -24
    • +9
    ./src/Core.Components.DotSpatial/Layer/BruTile/BruTileLayer.cs
Thursday 01 Nov 2018
4:10 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added extra method to helper to get nested collections. WTI-1889

Options
    • -1
    • +34
    ./src/Core.Components.Gis/Helpers/MapDataCollectionHelper.cs
    • -1
    • +59
    ./test/Core.Components.Gis.Test/Helpers/MapDataCollectionHelperTest.cs
Monday 29 Oct 2018
9:52 am

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed getting right state when nested collection state is mixed. WTI-1889

Options
    • -12
    • +19
    ./src/Core.Components.Gis/Data/MapDataCollection.cs
    • -0
    • +45
    ./test/Core.Components.Gis.Test/Data/MapDataCollectionTest.cs
Thursday 25 Oct 2018
1:56 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup. WTI-1889

Options
    • -13
    • +1
    ./test/Core.Components.Gis.Test/Data/MapDataCollectionTest.cs
1:53 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Adjusted IsVisible getter. WTI-1889

Options
    • -7
    • +1
    ./src/Core.Components.Gis/Data/MapDataCollection.cs
    • -2
    • +23
    ./test/Core.Components.Gis.Test/Data/MapDataCollectionTest.cs
1:50 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added extra method in MapDataCollection to get visibility state. WTI-1889

Options
    • -0
    • +27
    ./src/Core.Components.Gis/Data/MapDataCollection.cs
    • -0
    • +86
    ./test/Core.Components.Gis.Test/Data/MapDataCollectionTest.cs
1:28 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added enum for map data collection visibility. WTI-1889

Options
    • -0
    • +1
    ./src/Core.Components.Gis/Core.Components.Gis.csproj
    • -0
    • +44
    ./src/Core.Components.Gis/Data/MapDataCollectionVisibility.cs
    • -0
    • +1
    ./test/Core.Components.Gis.Test/Core.Components.Gis.Test.csproj
    • -0
    • +51
    ./test/Core.Components.Gis.Test/Data/MapDataCollectionVisibilityTest.cs
Tuesday 23 Oct 2018
10:47 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Fix exception in map views when a map layer is cleared of its features but has several category themes WTI-1876

Options
    • -4
    • +13
    ./src/Core.Components.DotSpatial/Converter/FeatureBasedMapDataConverter.cs
    • -0
    • +54
    ./test/Core.Components.DotSpatial.Test/Converter/FeatureBasedMapDataConverterTest.cs
Friday 19 Oct 2018
1:30 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Cleanup after review WTI-1552 Paired with roberttangerman

Options
    • -1
    • +1
    ./src/Core.Components.Gis/Helpers/MapDataCollectionHelper.cs
  2. … 3 more files in changeset.
10:25 am

Robert Tangerman <robert.tangerman@deltares.nl>

Use helper in MapDataCollectionProperties. WTI-1552

Options
    • -1
    • +0
    ./test/Core.Components.Gis.Test/Helpers/MapDataCollectionHelperTest.cs
  2. … 1 more file in changeset.
10:22 am

Robert Tangerman <robert.tangerman@deltares.nl>

Introduced MapDataCollection helper to get all child visibility states. WTI-1552

Options
    • -0
    • +1
    ./src/Core.Components.Gis/Core.Components.Gis.csproj
    • -1
    • +1
    ./src/Core.Components.Gis/Data/MapDataCollectionExtensions.cs
    • -0
    • +68
    ./src/Core.Components.Gis/Helpers/MapDataCollectionHelper.cs
    • -0
    • +1
    ./test/Core.Components.Gis.Test/Core.Components.Gis.Test.csproj
    • -0
    • +102
    ./test/Core.Components.Gis.Test/Helpers/MapDataCollectionHelperTest.cs
Thursday 18 Oct 2018
9:20 am

Robert Tangerman <robert.tangerman@deltares.nl>

Ignore empty nested collections when determining visibility. WTI-1552

Options
    • -1
    • +7
    ./src/Core.Components.Gis/Data/MapDataCollection.cs
    • -1
    • +20
    ./test/Core.Components.Gis.Test/Data/MapDataCollectionTest.cs
Wednesday 17 Oct 2018
2:39 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Overridden IsVisible in MapDataCollection. WTI-1552

Options
    • -1
    • +1
    ./src/Core.Components.Gis/Data/MapData.cs
    • -3
    • +16
    ./src/Core.Components.Gis/Data/MapDataCollection.cs
    • -0
    • +66
    ./test/Core.Components.Gis.Test/Data/MapDataCollectionTest.cs
  4. … 1 more file in changeset.
Wednesday 10 Oct 2018
2:09 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added extra constructor to TestFeatureBasedMapData. WTI-1552

Options
    • -1
    • +18
    ./test/Core.Components.Gis.Test/TestFeatureBasedMapDataTest.cs
    • -0
    • +5
    ./test/Core.Components.Gis.TestUtil/TestFeatureBasedMapData.cs
10:30 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Fix typo WTI-1553

Options
    • -1
    • +1
    ./test/Core.Components.DotSpatial.Test/Projections/TileReprojectorTest.cs
10:30 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Only add default category if metadata cannot be found in attribute mapping WTI-1553

Options
    • -7
    • +9
    ./src/Core.Components.DotSpatial/Converter/FeatureBasedMapDataConverter.cs
    • -4
    • +4
    ./test/Core.Components.DotSpatial.Test/Converter/FeatureBasedMapDataConverterTest.cs
Tuesday 09 Oct 2018
2:54 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3328:

- Improved tests and test factory

Paired with ~carloslubbers

WTI-1881

Options
    • -1
    • +1
    ./test/Core.Components.Gis.Test/Theme/CategoryThemeTest.cs
    • -1
    • +3
    ./test/Core.Components.Gis.TestUtil.Test/CategoryThemeTestFactoryTest.cs
    • -1
    • +1
    ./test/Core.Components.Gis.TestUtil/CategoryThemeTestFactory.cs