Riskeer / Ringtoets / AssemblyTool / src / Ringtoets.AssemblyTool.IO

Model

Clone Tools

Stats

Commits this week: 0
Total Committers: 3
Last Commit: 22 Apr
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 11 Sep 2018
2:38 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup FailureMechanismSectionCollection:

- Made private constructor public to create collections with only an ID as constructor argument.

WTI-1833

Options
    • -1
    • +1
    ./SerializableFailureMechanismSectionCollection.cs
  2. … 1 more file in changeset.
2:34 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup FailureMechanismSectionCollection - Remove connection with AssessmentSection:

- Removed obsolete ID property

WTI-1833

Options
    • -6
    • +0
    ./SerializableFailureMechanismSectionCollection.cs
  2. … 4 more files in changeset.
2:32 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup FailureMechanismSectionCollection - Remove connection with AssessmentSection:

- Removed constructor

WTI-1833

Options
    • -20
    • +1
    ./SerializableFailureMechanismSectionCollection.cs
  2. … 4 more files in changeset.
2:27 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup FailureMechanismSectionCollection - Remove connection with FailureMechanism:

- Removed obsolete id property

WTI-1833

Options
    • -7
    • +1
    ./SerializableFailureMechanismSectionCollection.cs
  2. … 3 more files in changeset.
2:23 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup FailureMechanismSectionCollection - Remove connection with FailureMechanism:

- Remove overloaded constructor which takes a failure mechanism as argument.

WTI-1833

Options
    • -19
    • +0
    ./SerializableFailureMechanismSectionCollection.cs
  2. … 6 more files in changeset.
2:10 pm

Dennis Tang <dennis.tang@deltares.nl>

Changed attribute header for FailureMechanismSection:

- Changed from Waterkeringsectie to Toetsvak

WTI-1833

Options
    • -1
    • +1
    ./AssemblyXmlIdentifiers.cs
  2. … 2 more files in changeset.
Wednesday 05 Sep 2018
3:29 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3211:

- Updated XMLDocs for consumers of the SerializableIdValidator

WTI-1789

Options
    • -1
    • +1
    ./SerializableAssembly.cs
    • -1
    • +1
    ./SerializableAssessmentProcess.cs
    • -1
    • +1
    ./SerializableAssessmentSection.cs
    • -1
    • +1
    ./SerializableCombinedFailureMechanismSectionAssembly.cs
    • -1
    • +1
    ./SerializableFailureMechanism.cs
    • -1
    • +1
    ./SerializableFailureMechanismSection.cs
    • -1
    • +1
    ./SerializableFailureMechanismSectionAssembly.cs
    • -3
    • +2
    ./SerializableFailureMechanismSectionCollection.cs
    • -1
    • +1
    ./SerializableTotalAssemblyResult.cs
3:12 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3211:

- Renamed IDValidator, as it is intended to be used by the serializable model only

- Cleaned up *.csproj file

WTI-1789

Options
    • -48
    • +0
    ./Helpers/IdValidator.cs
    • -0
    • +48
    ./Helpers/SerializableIdValidator.cs
    • -1
    • +1
    ./SerializableAssembly.cs
    • -1
    • +1
    ./SerializableAssessmentProcess.cs
    • -1
    • +1
    ./SerializableAssessmentSection.cs
    • -1
    • +1
    ./SerializableCombinedFailureMechanismSectionAssembly.cs
    • -1
    • +1
    ./SerializableFailureMechanism.cs
    • -1
    • +1
    ./SerializableFailureMechanismSection.cs
    • -1
    • +1
    ./SerializableFailureMechanismSectionAssembly.cs
    • -1
    • +1
    ./SerializableFailureMechanismSectionCollection.cs
    • -1
    • +1
    ./SerializableTotalAssemblyResult.cs
  12. … 5 more files in changeset.
3:06 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3211:

- Fixed issues with the IdValidator:

-- Do not throw exceptions, return boolean in all cases. Fixed tests on the consuming sides

-- Updated XMLDocs

-- Expanded general testcase generator with additional cases for the consumers

WTI-1789

Options
    • -7
    • +5
    ./Helpers/IdValidator.cs
  2. … 12 more files in changeset.
2:52 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3211:

- Updated XMLDoc

- Separated tests for ShouldSerialize tests

WTI-1789

Options
    • -1
    • +1
    ./DataTypes/SerializableFailureMechanismAssemblyResult.cs
    • -1
    • +1
    ./DataTypes/SerializableFailureMechanismSectionAssemblyResult.cs
  3. … 2 more files in changeset.
9:40 am

Dennis Tang <dennis.tang@deltares.nl>

Reverted commit 4b1149de407862f37e58b78bcf8409602ec3031f:

- Reverted because section assembly result should NOT be exported in case there's no result --> no reason anymore to make the category group NULLABLE.

WTI-1789

Options
    • -11
    • +2
    ./DataTypes/SerializableFailureMechanismSectionAssemblyResult.cs
  2. … 1 more file in changeset.
Monday 03 Sep 2018
12:59 pm

Dennis Tang <dennis.tang@deltares.nl>

Added Id validation for the serializable model:

- Applied for the total assembly result.

WTI-1789

Options
    • -4
    • +6
    ./SerializableTotalAssemblyResult.cs
  2. … 1 more file in changeset.
12:53 pm

Dennis Tang <dennis.tang@deltares.nl>

Added Id validation for the serializable model:

- Applied for the section collection.

WTI-1789

Options
    • -7
    • +9
    ./SerializableFailureMechanismSectionCollection.cs
  2. … 1 more file in changeset.
12:03 pm

Dennis Tang <dennis.tang@deltares.nl>

Added Id validation for the serializable model:

- Applied for the section assembly

WTI-1789

Options
    • -4
    • +5
    ./SerializableFailureMechanismSectionAssembly.cs
  2. … 1 more file in changeset.
12:01 pm

Dennis Tang <dennis.tang@deltares.nl>

Added Id validation for the serializable model:

- Applied for the failure mechanism

WTI-1789

Options
    • -5
    • +5
    ./SerializableFailureMechanism.cs
  2. … 1 more file in changeset.
12:00 pm

Dennis Tang <dennis.tang@deltares.nl>

Added Id validation for the serializable model:

- Applied for the combined failure mechanism section assembly

WTI-1789

Options
    • -4
    • +5
    ./SerializableCombinedFailureMechanismSectionAssembly.cs
  2. … 1 more file in changeset.
11:54 am

Dennis Tang <dennis.tang@deltares.nl>

Added Id validation for the serializable model:

- Applied for the assessment section.

WTI-1789

Options
    • -8
    • +8
    ./SerializableAssessmentSection.cs
  2. … 1 more file in changeset.
11:51 am

Dennis Tang <dennis.tang@deltares.nl>

Added Id validation for the serializable model:

- Applied for the assessment process

WTI-1789

Options
    • -4
    • +5
    ./SerializableAssessmentProcess.cs
  2. … 1 more file in changeset.
11:43 am

Dennis Tang <dennis.tang@deltares.nl>

Added Id validation for the serializable model:

- Applied for the serializable failure mechanism section

WTI-1789

Options
    • -9
    • +9
    ./SerializableFailureMechanismSection.cs
  2. … 1 more file in changeset.
11:38 am

Dennis Tang <dennis.tang@deltares.nl>

Added Id validation for the serializable model:

- Applied for the serializable assembly.

WTI-1789

Options
    • -4
    • +5
    ./SerializableAssembly.cs
  2. … 1 more file in changeset.
10:41 am

Dennis Tang <dennis.tang@deltares.nl>

Introduced helper to verify the validity of an id in the serializable model. WTI-1789

Options
    • -0
    • +50
    ./Helpers/IdValidator.cs
  2. … 3 more files in changeset.
10:19 am

Dennis Tang <dennis.tang@deltares.nl>

Rearranged order for the failure mechanism section assembly result:

- Done to satisfy the new sequence constraint of the xsd

WTI-1789

Options
    • -6
    • +6
    ./DataTypes/SerializableFailureMechanismSectionAssemblyResult.cs
  2. … 1 more file in changeset.
10:15 am

Dennis Tang <dennis.tang@deltares.nl>

Rearranged order for the combined failure mechanism section assembly result:

- Done to satisfy the sequence constraint of the xsd

WTI-1789

Options
    • -6
    • +6
    ./DataTypes/SerializableCombinedFailureMechanismSectionAssemblyResult.cs
  2. … 1 more file in changeset.
10:06 am

Dennis Tang <dennis.tang@deltares.nl>

Rearranged order for the total assembly result:

- Done in order to satisfy the new sequence constraint in the XSD for the total assembly result.

WTI-1789

Options
    • -6
    • +6
    ./SerializableTotalAssemblyResult.cs
  2. … 1 more file in changeset.
Friday 31 Aug 2018
11:45 am

Dennis Tang <dennis.tang@deltares.nl>

Adjusted serializable model:

- Made the failure mechanism section assembly result category group nullable in order to export section assembly results that have no result.

WTI-1789

Options
    • -2
    • +11
    ./DataTypes/SerializableFailureMechanismSectionAssemblyResult.cs
  2. … 1 more file in changeset.
Thursday 23 Aug 2018
3:14 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3192:

- Updated XMLDoc

- Improved the testhelper

Paired ~carloslubbers

WTI-1789

Options
    • -1
    • +1
    ./DataTypes/SerializableFailureMechanismSectionAssemblyResult.cs
  2. … 1 more file in changeset.
2:26 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Add null or empty check to id's WTI-1789

Options
    • -3
    • +4
    ./SerializableAssembly.cs
    • -4
    • +4
    ./SerializableAssessmentProcess.cs
    • -4
    • +9
    ./SerializableAssessmentSection.cs
    • -3
    • +4
    ./SerializableCombinedFailureMechanismSectionAssembly.cs
    • -3
    • +5
    ./SerializableFailureMechanism.cs
    • -4
    • +9
    ./SerializableFailureMechanismSection.cs
    • -3
    • +4
    ./SerializableFailureMechanismSectionAssembly.cs
    • -5
    • +7
    ./SerializableFailureMechanismSectionCollection.cs
    • -3
    • +4
    ./SerializableTotalAssemblyResult.cs
  10. … 11 more files in changeset.
1:12 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Add enum value and fix tests WTI-1789

Options
    • -0
    • +5
    ./Enums/AssemblyXmlEnumIdentifiers.cs
    • -1
    • +7
    ./Enums/SerializableAssessmentSectionCategoryGroup.cs
  3. … 10 more files in changeset.
11:46 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Review related changes and cleanup WTI-1789

Options
    • -7
    • +7
    ./SerializableAssessmentSection.cs
    • -1
    • +1
    ./SerializableTotalAssemblyResult.cs
  3. … 11 more files in changeset.
10:59 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Improve assembly ctor WTI-1789

Options
    • -18
    • +15
    ./SerializableAssembly.cs
  2. … 2 more files in changeset.