Riskeer / Ringtoets / ClosingStructures / src / Ringtoets.ClosingStructures.Forms / Views

ClosingStructuresFailureMechanismResultView.cs

Clone Tools

Stats

Commits this week: 0
Total Committers: 7
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 26 Apr 2017
3:08 pm

Robert Tangerman <robert.tangerman@deltares.nl>

- Merged conditional ?: expressions into conditional access. - Merged sequential checks in && or || expressions.

Paired with berg_jl

Related to Issue [WTI-1242]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9469 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 046b2480e95cfbe00503c7529eef55b577d7c563

Former-commit-id: b458cfeda0d4eeff999fab9ba59e439bcb9c9526

Options
    • -1
    • +1
    ./ClosingStructuresFailureMechanismResultView.cs
  2. … 39 more files in changeset.
Monday 21 Nov 2016
11:56 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated review comments review 1210: - Added missing tests to cover the various possibilities of AssessmentLayerOneState - Renamed ShowAssessmentLayerTwoAErrors to SetAssessmentLayerTwoAError in FailureMechanismSectionResultRowHelper to better reflect its action - Changed logic in the PipingFailureMechanismResultView: determine the status of AssessmentLayerOneState before getting all relevant scenarios - Renamed some Resources to better reflect the message values Related to Issue [WTI-943]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6777 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e9d0f76c53289d4888c0187849f46046d4cfdf04

Former-commit-id: 5d2087eac71f71f7cddc8b070fb5537f04e7c84c

Options
    • -4
    • +4
    ./ClosingStructuresFailureMechanismResultView.cs
  2. … 13 more files in changeset.
11:03 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1208 - Renamed DataGridViewCellTester to DataGridViewCellTestHelper - Introduced protected AssessmentLayerOneColumnIndex for the FailureMechanismResultView, replaced all local definitions for the derived classes when relevant - Added Core.Common.Version dependencies to the Common.Forms.TestUtil and its Common.Forms.TestUtil.Test

Related to Issue [WTI-985]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6771 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 58e7647abfb79ad27d29c407da8ba6b8141e8195

Former-commit-id: 3a457868facc8a1a0d885a7fb668c95d909fb0ac

Options
    • -2
    • +1
    ./ClosingStructuresFailureMechanismResultView.cs
  2. … 42 more files in changeset.
Thursday 17 Nov 2016
3:25 pm

Dennis Tang <dennis.tang@deltares.nl>

- Resolved compilation errors by introducing the AssessmentLayerOneState when applicable - Added the DataGridViewCellTester for the tests that explicitly tested the cell Style properties

Merged revision(s) 6630-6714 from branches/WTI-985:

Added enum indicating the state of assessment layer one

........

Added enum indicating the state of assessment layer one

........

- Incorporated enum for AssessmentLayerOne in the failure mechanism section

- Fixed tests that are directly related to the failure mechanism section

Note: derived views and corresponding tests are NOT fixed yet

........

- Fixed tests for Q-variant failureMechanisms

........

- Fixed ReadExtensions for storage

........

- Fixed ReadExtension tests for storage

........

Fixed issues on the RingtoetsProjectTestHelper:

- Introduced private method to generate a random state of AssessmentLayerOne

........

Fixed issues on the AssessmentLayerOneState:

- Corrected strings that are displayed in the view

- Created a protected method to provide access for every derived failure mechanism view to the Enumwrapper for AssessmentLayerOneState

........

Implemented feature on the ClosingStructuresFailureMechanismResultView:

- Replaced the checkbox with a dropdown colum containing the AssessmentLayerOneState value

- Fixed or expanded tests

........

Implemented feature on the GrassCoverErosionInwardsFailureMechanismResultView:

- Replaced the checkbox with a dropdown column containing the AssessmentLayerOneState value

- Fixed failing/not working tests

- Removed test that asserts the toggling of the checkbox: test is obsolete because it's replaced with a dropdown box

- Extended test for assessing that the right columns are visible when a failure mechanism is present

(Editorial) For the closing structure failure mechanism

- Write out string resource values when testing

........

Implemented feature on the GrassCoverErosionOutwardsFailureMechanismResultView:

- Replaced the checkbox with a dropdown column containing the AssessmentLayerOneState value

- Fixed failing test

........

Extended tests:

- Assess the behaviour of the datagrid row for every state of AssessmentLayerOneState

........

Implemented feature on the GrassCoverErosionInwardsFailureMechanismResultView:

- Replaced the checkbox with a dropdown column containing the AssessmentLayerOneState value

- Fixed failing/not working tests

- Removed test that asserts the toggling of the checkbox: test is obsolete because it's replaced with a dropdown box

- Extended test for assessing that the right columns are visible when a failure mechanism is present

........

Implemented feature on the Piping FailureMechanism:

- Replaced the checkbox with a dropdown column containing the AssessmentLayerOneState value

- Fixed failing/not working tests

- Removed test that asserts the toggling of the checkbox: test is obsolete because it's replaced with a dropdown box

- Extended test for assessing that the right columns are visible when a failure mechanism is present

........

Extended tests:

- Added additional section when assessing the behaviour of the three possible states of AssessmentLayerOne

........

Implemented feature on the Stability point structures FailureMechanism:

- Replaced the checkbox with a dropdown column containing the AssessmentLayerOneState value

- Fixed failing/not working tests

- Typed out string values when asserting column headers

........

(Editorial) For the grass cover erosion outwards failure mechanism

- Write out string resource values when testing string values of the column headers

........

Implemented feature on the Stability stone cover FailureMechanism:

- Replaced the checkbox with a dropdown column containing the AssessmentLayerOneState value

- Fixed failing/not working tests

- Typed out string values when asserting column headers

- Added assertions for when cells are enabled. This includes an additional test that verifies the behaviour when the state changes to "sufficient" for assessmentLayerOne

........

Implemented feature on the wave impact asphalt cover FailureMechanism:

- Replaced the checkbox with a dropdown column containing the AssessmentLayerOneState value

- Fixed failing/not working tests

- Typed out string values when asserting column headers

........

Removed obsolete reference to RingtoetsCommonFormsResources in the tests

........

Created project to include helper classes for asserting Forms related projects

........

Created project to include helper classes for asserting Forms related projects:

- Reverted accidental change on Common.Data.TestUtil project

........

Created project to include helper classes for asserting Forms related projects:

- Created helper class to assert whether DataGridViewCells are in an enabled or disabled state

........

Created project to include helper classes for asserting Forms related projects:

- Created helper class to assert whether DataGridViewCells are in an enabled or disabled state

........

Extracted base method to add assessment section name and assessment section layer one columns

........

Improved helper class DataGridViewCellsTester:

- Enabled state does not always mean readonly, assertion behaviour can be toggled

- Documented when AssertionException can be thrown

........

Refactoring:

- For the mechanisms that already implement the dropdown box for assessment layer one: use an override of the AddDataGridColumns to set the correct columns

- Aforementioned function already sets the section name and dropdown box for assessment layer one per default

........

Incorporated helper class DataGridViewCellsTester:

- Replaced every instance of a local cell enabled/disabled assertion with the DataGridViewCellsTester

........

Implemented feature on the dune erosion failure mechanism:

- Replaced the checkbox with a dropdown column containing the AssessmentLayerOneState value

- Fixed failing/not working tests

- Typed out string values when asserting column headers

- Replaced local cell assertions with the DataGridViewCellTester

........

Implemented feature on the grass cover slipoff inwards failure mechanism:

- Replaced the checkbox with a dropdown column containing the AssessmentLayerOneState value

- Fixed failing/not working tests

- Typed out string values when asserting column headers

- Replaced local cell assertions with the DataGridViewCellTester

........

Removed obsolete RingtoetsCommonResource reference

........

Implemented feature on the grass cover slipoff outwards failure mechanism:

- Replaced the checkbox with a dropdown column containing the AssessmentLayerOneState value

- Fixed failing/not working tests

- Typed out string values when asserting column headers

- Replaced local cell assertions with the DataGridViewCellTester

........

Implemented feature for the macro stability related failure mechanisms:

- Replaced the checkbox with a dropdown column containing the AssessmentLayerOneState value

- Fixed failing/not working tests

- Typed out string values when asserting column headers

- Replaced local cell assertions with the DataGridViewCellTester

........

Implemented feature for piping structure failure mechanisms:

- Replaced the checkbox with a dropdown column containing the AssessmentLayerOneState value

- Fixed failing/not working tests

- Typed out string values when asserting column headers

- Replaced local cell assertions with the DataGridViewCellTester

........

Implemented feature for strength stability lengthwise construction failure mechanisms:

- Replaced the checkbox with a dropdown column containing the AssessmentLayerOneState value

- Fixed failing/not working tests

- Typed out string values when asserting column headers

- Replaced local cell assertions with the DataGridViewCellTester

........

Implemented feature for technical innovation failure mechanisms:

- Replaced the checkbox with a dropdown column containing the AssessmentLayerOneState value

- Fixed failing/not working tests

- Typed out string values when asserting column headers

- Replaced local cell assertions with the DataGridViewCellTester

........

Implemented feature for water pressure asphalt cover failure mechanisms:

- Replaced the checkbox with a dropdown column containing the AssessmentLayerOneState value

- Fixed failing/not working tests

- Typed out string values when asserting column headers

- Replaced local cell assertions with the DataGridViewCellTester

........

Fixed ReadExtension tests for storage:

- Compilation error when trying to run this test due to invalid cast from bool to the AssessmentLayerOneState

........

Fixed ReadExtension entity tests for storage:

- Adapted read entity tests to assess for the enum AssessmentLayerOneState instead of a boolean for LayerOne. Entities were already adjusted due to changes in the FailureMechanismSectionResult

........

* Updated database design (new comments added).

* Defined default value for FailureMechanismSectionResult.

* Specified concrete values for AssessmentLayerOneState.

........

Related to Issue [WTI-985]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6730 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 417e584767297df8e93c02b36a0af938af02894c

Former-commit-id: 03a26b4cac7f05f4cf9dfde404b76d15b41d82cb

Options
    • -10
    • +3
    ./ClosingStructuresFailureMechanismResultView.cs
  2. … 185 more files in changeset.
Wednesday 16 Nov 2016
3:29 pm

Dennis Tang <dennis.tang@deltares.nl>

Refactoring: - For the mechanisms that already implement the dropdown box for assessment layer one: use an override of the AddDataGridColumns to set the correct columns - Aforementioned function already sets the section name and dropdown box for assessment layer one per default

Related to Issue [WTI-985]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/WTI-985@6680 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bb4a43d4e03538b4777514d0d692081f8b8bdb0b

Former-commit-id: c8aa6934bf0d9ad346ad1c5f5e68f0f2b824dafa

Options
    • -15
    • +3
    ./ClosingStructuresFailureMechanismResultView.cs
  2. … 7 more files in changeset.
11:33 am

Marten Janssen <marten.janssen@deltares.nl>

- Added test for height structures - Updated Error texts for section result with and without calculation for stability point structures Related to Issue [WTI-943]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6662 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d54e2bc567b1c4828fd0d3dc40f0fb58bf2ca3a9

Former-commit-id: fc165afd4bfd3f3e8f01792a0841beca4dec742f

Options
    • -9
    • +6
    ./ClosingStructuresFailureMechanismResultView.cs
  2. … 9 more files in changeset.
Tuesday 15 Nov 2016
4:48 pm

Marten Janssen <marten.janssen@deltares.nl>

Updated Error texts for section result with and without calculation for closing structures Related to Issue [WTI-943]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6641 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 49b86618b6cbca970e8e41ff9fd832c92e6d55da

Former-commit-id: 6d532d588b4865479811bcf30cc2ef1109cce1a8

Options
    • -1
    • +24
    ./ClosingStructuresFailureMechanismResultView.cs
  2. … 3 more files in changeset.
4:40 pm

Dennis Tang <dennis.tang@deltares.nl>

Implemented feature on the ClosingStructuresFailureMechanismResultView: - Replaced the checkbox with a dropdown colum containing the AssessmentLayerOneState value - Fixed or expanded tests

Related to Issue [WTI-985]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/WTI-985@6640 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: fe039fa813cde6831ceceaef471f98d429705d0a

Former-commit-id: ea72a21deaaa4ad6fc113faf94f65f820a195a00

Options
    • -2
    • +7
    ./ClosingStructuresFailureMechanismResultView.cs
  2. … 1 more file in changeset.
Wednesday 09 Nov 2016
4:33 pm

Elmar Kleijn

Got rid of GetObservableInput and GetObservableOutput Related to Issue [WTI-953]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6560 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8b46be132cb72a8c6ba82fa1453cfda998ac0806

Former-commit-id: 50ec7a58f9489ec3e95cf1e6e4687d5dae60fdcf

Options
    • -2
    • +2
    ./ClosingStructuresFailureMechanismResultView.cs
  2. … 20 more files in changeset.
Monday 31 Oct 2016
9:46 am

bouvrie <bouvrie@example.com>

* Made type explicit or more concrete. * Reformatted code to improve readability and better adherence to code-conventions. Related to Issue [WTI-596]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6287 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b843544708d2da78f91008dbddb0c9bc748e51cb

Former-commit-id: a132052d0d6e775430eca5ca1ccaa8c2730ec7fb

Options
    • -14
    • +8
    ./ClosingStructuresFailureMechanismResultView.cs
  2. … 4 more files in changeset.
Thursday 27 Oct 2016
2:03 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Made sure result view of closing structures updates when there is a change in the calculations and sections. Related to Issue [WTI-596]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6221 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2f2928ad823cb072cc7e161e27f61c2dc10fa32f

Former-commit-id: 10380ff8b8922ec56f57620e3e665c14b8d2748f

Options
    • -0
    • +49
    ./ClosingStructuresFailureMechanismResultView.cs
  2. … 4 more files in changeset.
Monday 26 Sep 2016
4:12 pm

Marten Janssen <marten.janssen@deltares.nl>

- Added ClosingStructuresFailureMechanismContext.cs - Added tests - optimised references Related to Issue [WTI-547]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5547 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6b492461ff5005261bd64dfa7fa76d74fa613c99

Former-commit-id: b731f49770775c04ffe066bb1a6d92d0e8d9a905

Options
    • -0
    • +91
    ./ClosingStructuresFailureMechanismResultView.cs
  2. … 29 more files in changeset.