Riskeer / Ringtoets / ClosingStructures / src / Ringtoets.ClosingStructures.Service

ClosingStructuresCalculationService.cs

Clone Tools

Stats

Commits this week: 0
Total Committers: 8
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 02 Nov 2016
4:12 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated review comments: - Editorial changes: moved lines around to improve coherence in the validation rules - Incorporated all changes related to the validation rules: changed resource name and documentation, removed unnecessary aliases and renamed function Related to Issue [WTI-927]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6410 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 23de8d55848dbe268d4cf73c0900c9cfe03b4f0f

Former-commit-id: dd70d0530bc045690a16927f5fc56ddbf5cfb98e

Options
    • -12
    • +6
    ./ClosingStructuresCalculationService.cs
  2. … 20 more files in changeset.
3:28 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated review comments: - Editorial changes: moved lines around to improve consistency. Checked for similar tests across the Structures - Extracted function to retrieve validation rules depending on the calculation type in ClosingStructuresCalculationService - Changed parameter names

Related to Issue [WTI-927]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6407 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e1580d2ed171698fd39b5bc43af134da09314a84

Former-commit-id: f5567d00dde1ac54ef7a753d24bc7c9d73dc1ff8

Options
    • -17
    • +24
    ./ClosingStructuresCalculationService.cs
  2. … 8 more files in changeset.
1:50 pm

Marten Janssen <marten.janssen@deltares.nl>

Deltares clean-up for Demo and Ringtoets.ClosingStructures Related to Issue [WTI-931]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6394 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6d9cbf33f673a9fc02f238e6bc59877b871277db

Former-commit-id: 436f5d6c5a25e7fd20bd93ae2077b05e5abaf038

Options
    • -1
    • +1
    ./ClosingStructuresCalculationService.cs
  2. … 11 more files in changeset.
10:29 am

Robert Tangerman <robert.tangerman@deltares.nl>

Implemented Hydra-Ring last error handling for closing structures. Related to Issue [WTI-928]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6382 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8850e43dc957389dec4b2678e670f944ac539e95

Former-commit-id: 43c617ccbf325a3fc501d4e31e880a837167d5bc

Options
    • -3
    • +32
    ./ClosingStructuresCalculationService.cs
  2. … 9 more files in changeset.
Tuesday 01 Nov 2016
2:09 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Show temp Hydra-Ring working directory in log messages instead of output file contents. Related to Issue [WTI-928]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6362 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ffee509c70a3b27af0b78536abc002b38b1a3d2a

Former-commit-id: 8c1f43038a30d3db98b08807548c7fee71164814

Options
    • -1
    • +1
    ./ClosingStructuresCalculationService.cs
  2. … 72 more files in changeset.
Monday 31 Oct 2016
2:49 pm

Dennis Tang <dennis.tang@deltares.nl>

Implement validation service: - Implemented validation rule for calculation inputs that implement IUseBreakWater - Added validation tests for the structures (as they do not contain validation procedures with foreshore and/or breakwater combinations)

Related to Issue [WTI-927]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6315 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2c05a30a764e39a06d4e7719b7bc726e175d6e97

Former-commit-id: 195e28eced78cf9d4502788d927d419420fb3f32

Options
    • -0
    • +3
    ./ClosingStructuresCalculationService.cs
  2. … 15 more files in changeset.
12:00 pm

Dennis Tang <dennis.tang@deltares.nl>

Implement validation service: - Implemented validation rules for the ClosingStructuresCalculationService Related to Issue [WTI-927]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6300 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7374bcf7bc271ac3908eb5fd9224251d5d528dfb

Former-commit-id: 22326ff17213d83e8d2d2c368acdbcdd857d3840

Options
    • -101
    • +85
    ./ClosingStructuresCalculationService.cs
11:53 am

bouvrie <bouvrie@example.com>

* Made variabletype explicit. * Added xml docs to method to make it clear what it's behavior is. * Added InvalidEnumArgumentException to default sections of switch statements. * Renamed resource (and reused it)

Related to Issue [WTI-926]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6299 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bc454db9c282f8f142b9ddd4e0d6b2f7141a5ef6

Former-commit-id: f83d1d7387f86e9c8cb1edf2cf839799e3180065

Options
    • -1
    • +1
    ./ClosingStructuresCalculationService.cs
  2. … 14 more files in changeset.
Friday 28 Oct 2016
10:56 am

Robert Tangerman <robert.tangerman@deltares.nl>

- Introduced AssessmentSectionHelper to create assessment section stubs. - Introduced service for stability point structures. - Introduced test calculation for stability point structures. Related to Issue [WTI-568]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6259 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 341b4d67f97ea9ff66407a2f408577674c7c948d

Former-commit-id: f2f1c210714d43fbde39a88be94cd95599efd5b7

Options
    • -1
    • +1
    ./ClosingStructuresCalculationService.cs
  2. … 19 more files in changeset.
10:38 am

Dennis Tang <dennis.tang@deltares.nl>

Implement validation: - Added validation for the flooded culvert calculations Related to Issue [WTI-926]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6257 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b06381fe2f4d7951d2e79f2a9cd51192c1af9274

Former-commit-id: 2c11dfa81411bf8f924cd9872d30244715f7d6c9

Options
    • -5
    • +34
    ./ClosingStructuresCalculationService.cs
  2. … 1 more file in changeset.
9:04 am

Dennis Tang <dennis.tang@deltares.nl>

Implement validation: - Resource was removed while file out of date: fixed Related to Issue [WTI-926]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6251 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a90a035a9b302fc410f3ac7a6a476c2de0d8cbe4

Former-commit-id: f50bfecf910d01ff1a8ea6cfdd6976b4427eb33b

Options
    • -1
    • +1
    ./ClosingStructuresCalculationService.cs
9:01 am

Dennis Tang <dennis.tang@deltares.nl>

Implement validation: - Added validation for the inputs that are required for a low sill calculation - Simplified tests: introduced a method that sets all the input parameters of the calculation object to invalid values - Added documentation Related to Issue [WTI-926]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6250 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7bd5a770ac99355474ab8d75af6ffc088944770e

Former-commit-id: 69a68ed124717f26cb8c6538a40a84f57f927188

Options
    • -0
    • +45
    ./ClosingStructuresCalculationService.cs
  2. … 1 more file in changeset.
9:00 am

Elmar Kleijn

Moved some resources Related to Issue [WTI-570]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6249 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c795294f2e378a89a95f3808dfe0c98ca3f73eef

Former-commit-id: a7a95f864bbed2edfd542508171fa2abcd856704

Options
    • -1
    • +1
    ./ClosingStructuresCalculationService.cs
  2. … 11 more files in changeset.
Thursday 27 Oct 2016
3:28 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Changes after review. Related to Issue [WTI-554]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6233 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: aa525712740ea4d4c290bb2be7d7f91c8f1e8fa7

Former-commit-id: 59b6c1d9951a51610a60068228326a1f588c9aeb

Options
    • -1
    • +3
    ./ClosingStructuresCalculationService.cs
  2. … 11 more files in changeset.
3:13 pm

Dennis Tang <dennis.tang@deltares.nl>

Implement validation: - Removed obsolete function in HeightStructuresCalculationService - Added validation for the inputs that are required for a vertical wall calculation Related to Issue [WTI-926]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6230 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1753103e36b04f9785289770d1608b2a57e33381

Former-commit-id: eacc706ca5a543c3040a37c45700fe2f8f02d1e1

Options
    • -5
    • +74
    ./ClosingStructuresCalculationService.cs
  2. … 4 more files in changeset.
12:11 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated review comments 1129 - Adjusted exception when invalid enum of ClosingStructureInflowModelType is set Related to Issue [WTI-554]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6212 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3853885913d6298a9a3ec973f2b6badff2bcb7a0

Former-commit-id: d313b923eeca0fafe0af9ce8ad4c5e3d10fd791a

Options
    • -3
    • +5
    ./ClosingStructuresCalculationService.cs
  2. … 1 more file in changeset.
11:55 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated review comments 1129 - Renamed CalculationInputParser to something more generic and applicable - Adjusted XML doc of the StructuresClosureCalculator

Related to Issue [WTI-554]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6208 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2f00137a4aa30d9fe3f4ef3e42636185f40d54b3

Former-commit-id: 38f78612d2e68c2b03f3c1887cf43226076d4179

Options
    • -6
    • +6
    ./ClosingStructuresCalculationService.cs
  2. … 11 more files in changeset.
11:26 am

bos_en <bos_en@example.com>

Templated the StructuresHelper class. Related to Issue [WTI-594]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6204 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 9af2ee4c370f0472857b45b41fd796b579f50619

Former-commit-id: d9c3e22d99ef39196a54806e55d1fd577a29f574

Options
    • -3
    • +3
    ./ClosingStructuresCalculationService.cs
  2. … 38 more files in changeset.
Wednesday 26 Oct 2016
5:31 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated review comments 1129 - Extracted ParseBreakWater and ParseForeshore in a static class: implementation is now generic for StructuresCalculations and GrassCoverErosionInwardsCalculations Related to Issue [WTI-554]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6188 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7bf60fe98b88dc42b5a967de92f8775357b805f8

Former-commit-id: baca4f930a848196d1113d4987971b6a042a6a73

Options
    • -36
    • +26
    ./ClosingStructuresCalculationService.cs
  2. … 6 more files in changeset.
4:12 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated review comments 1129 - Editorial changes - Ensured that the output is cleared before a calculation starts

Related to Issue [WTI-554]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6184 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f79443262092233e3b3416e49441046c09ba3837

Former-commit-id: f2b6382e18c1ae0bbf69f206c64202da00a124b3

Options
    • -1
    • +1
    ./ClosingStructuresCalculationService.cs
  2. … 7 more files in changeset.
2:38 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated review comments 1129 - Changed method call signature of the Calculate methods in the HeightStructures and ClosingStructures services: service extracts the necessary information, not the activity Related to Issue [WTI-554]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6174 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 79566144bc44d8b7d4a1f435453d3321ee598df7

Former-commit-id: e73b7a124a7b3e44631e862bf7dcd5db00cd6425

Options
    • -25
    • +36
    ./ClosingStructuresCalculationService.cs
  2. … 5 more files in changeset.
1:36 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated review comments 1129 - Moved the responsibility of determining the directory of the HLCD filepath from the plugin to the service (fixed for all structures calculations) Related to Issue [WTI-554]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6171 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 50ef699096c94b2a5bd589bfdd8a4499d0cfb07c

Former-commit-id: 40fa4afce33f65e13e23ac0125c57d33044e7739

Options
    • -3
    • +6
    ./ClosingStructuresCalculationService.cs
  2. … 11 more files in changeset.
12:13 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated review comments 1129 - Make all Validation methods of the services static

Related to Issue [WTI-554]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6168 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c2c1dfa6ae053ad7643e226bab6babdcccdf32c8

Former-commit-id: bfac9a2e7e59a3da068ccea7378d8c8bd4cde47a

Options
    • -1
    • +1
    ./ClosingStructuresCalculationService.cs
  2. … 29 more files in changeset.
11:38 am

Elmar Kleijn

Changed name of calculation routine in GrassCoverErosionInwardsCalculationService

Paired with tangerma

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6166 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 25f58d379a9eb6a426f9f53fffdfa9b573b57b43

Former-commit-id: 1b987b3e8b06a4dd720be621dbf857054c804d92

Options
    • -1
    • +1
    ./ClosingStructuresCalculationService.cs
  2. … 5 more files in changeset.
Tuesday 25 Oct 2016
3:54 pm

bos_en <bos_en@example.com>

Generalized three structures Calculations to StructuresCalculation class. Related to Issue [WTI-594]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6151 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a8405ee298bf3c641f426352c072744f2e3685cb

Former-commit-id: 5968cf3a46e1b19065199c498dbd525ef5f26552

Options
    • -8
    • +9
    ./ClosingStructuresCalculationService.cs
  2. … 93 more files in changeset.
9:55 am

Dennis Tang <dennis.tang@deltares.nl>

Connecting ClosingStructureCalculationActivity with relevant services: - Implemented functionality in the plugin as specified by the CalculationContextTreeNodeInfoTests (Note: one function is still missing) - Added basic functionality for the validation of input parameters: validate hydraulic boundary location and DB connection - Renamed inconsistent names in the ClosingStructuresCalculationServiceTest - Adjusted TestClosingStructuresCalculation: one probability value was uninitialized

Related to Issue [WTI-554]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6118 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d67f48b0cf39e9911bf89af66c4c9d59d2180130

Former-commit-id: 0985bcd17011fc22fb933332858adc5420bc039e

Options
    • -3
    • +26
    ./ClosingStructuresCalculationService.cs
  2. … 8 more files in changeset.
Monday 24 Oct 2016
12:02 pm

Dennis Tang <dennis.tang@deltares.nl>

Connecting ClosingStructureCalculationActivity with relevant services: - Extracted string Resources for the service - Added missing license headers - Connected the calculation activity with the plugin

Related to Issue [WTI-554]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6092 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c62b7744f24ebb093e3a759c16f217bab3698c90

Former-commit-id: dce6c1b5b4b81088b1e55f7877040c5e91f42de5

Options
    • -2
    • +3
    ./ClosingStructuresCalculationService.cs
  2. … 7 more files in changeset.
11:36 am

Dennis Tang <dennis.tang@deltares.nl>

Connecting ClosingStructureCalculationActivity with relevant services: - Finalizing ClosingStructuresCalculationActivity: introduced Validation placeholder - Extended tests for Activity and renamed them to reflect the what is being tested

Related to Issue [WTI-554]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6091 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4af55b9dda2b07623f3e3cad5e05b941668a61bc

Former-commit-id: 96b85be6f5754a5f21818c67ed8c3dadeb427098

Options
    • -0
    • +9
    ./ClosingStructuresCalculationService.cs
  2. … 3 more files in changeset.
Friday 21 Oct 2016
3:32 pm

Dennis Tang <dennis.tang@deltares.nl>

Added ClosingStructuresCalculationService: - Implemented cancel and calculation functionality

Related to Issue [WTI-554]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6080 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3203c25c11e395928dffed45dde755a0c3cec1ef

Former-commit-id: 7b921c0f57de6ca4815dd64aa418fee5bbd8a928

Options
    • -3
    • +43
    ./ClosingStructuresCalculationService.cs
  2. … 2 more files in changeset.
1:06 pm

Dennis Tang <dennis.tang@deltares.nl>

Added ClosingStructuresCalculationService: - Input feedthrough created for flooded culvert

Related to Issue [WTI-554]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6067 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c35d2e1e5be3a476df18cf241b7c0d70ca583f59

Former-commit-id: 69d7819d51383bd4b2b794c8f1b4d5d7bf2eded8

Options
    • -5
    • +34
    ./ClosingStructuresCalculationService.cs
  2. … 1 more file in changeset.