Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
* Made type explicit or more concrete. * Reformatted code to improve readability and better adherence to code-conventions. Related to Issue [WTI-596]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6287 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b843544708d2da78f91008dbddb0c9bc748e51cb

Former-commit-id: a132052d0d6e775430eca5ca1ccaa8c2730ec7fb

    • -14
    • +8
    ./Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
  1. … 4 more files in changeset.
Implemented improvements of review 1143. Related to Issue [WTI-594]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6268 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 421edd42003bb6a398baba98b51e8d0127174d67

Former-commit-id: 0bd25a60e86104fef7664e113a09f8fce1995d6b

    • -1
    • +1
    ./Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanism.cs
    • -4
    • +2
    ./Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationActivity.cs
    • -19
    • +2
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresDataSynchronizationService.cs
  1. … 28 more files in changeset.
- Introduced AssessmentSectionHelper to create assessment section stubs. - Introduced service for stability point structures. - Introduced test calculation for stability point structures. Related to Issue [WTI-568]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6259 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 341b4d67f97ea9ff66407a2f408577674c7c948d

Former-commit-id: f2f1c210714d43fbde39a88be94cd95599efd5b7

    • -1
    • +1
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
  1. … 19 more files in changeset.
Implement validation: - Added validation for the flooded culvert calculations Related to Issue [WTI-926]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6257 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b06381fe2f4d7951d2e79f2a9cd51192c1af9274

Former-commit-id: 2c11dfa81411bf8f924cd9872d30244715f7d6c9

    • -5
    • +34
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
  1. … 1 more file in changeset.
Updated signature of method so that implicit knowledge about structures type is not divided over methods. Related to Issue [WTI-603]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6253 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e0f26eaa0133ad7ffdbbb3ca50e32a32bdf46585

Former-commit-id: dda2033d868ea42c9d43e0f4e886ef9a6e33985a

    • -5
    • +8
    ./Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
  1. … 2 more files in changeset.
Implement validation: - Resource was removed while file out of date: fixed Related to Issue [WTI-926]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6251 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a90a035a9b302fc410f3ac7a6a476c2de0d8cbe4

Former-commit-id: f50bfecf910d01ff1a8ea6cfdd6976b4427eb33b

    • -1
    • +1
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
Implement validation: - Added validation for the inputs that are required for a low sill calculation - Simplified tests: introduced a method that sets all the input parameters of the calculation object to invalid values - Added documentation Related to Issue [WTI-926]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6250 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7bd5a770ac99355474ab8d75af6ffc088944770e

Former-commit-id: 69a68ed124717f26cb8c6538a40a84f57f927188

    • -0
    • +45
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
  1. … 1 more file in changeset.
Moved some resources Related to Issue [WTI-570]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6249 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c795294f2e378a89a95f3808dfe0c98ca3f73eef

Former-commit-id: a7a95f864bbed2edfd542508171fa2abcd856704

    • -54
    • +0
    ./Ringtoets.ClosingStructures.Forms/Properties/Resources.Designer.cs
    • -18
    • +0
    ./Ringtoets.ClosingStructures.Forms/Properties/Resources.resx
    • -2
    • +2
    ./Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructureProperties.cs
    • -6
    • +6
    ./Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresInputContextProperties.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
  1. … 7 more files in changeset.
Changes after review. Related to Issue [WTI-554]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6233 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: aa525712740ea4d4c290bb2be7d7f91c8f1e8fa7

Former-commit-id: 59b6c1d9951a51610a60068228326a1f588c9aeb

    • -1
    • +3
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
  1. … 11 more files in changeset.
Implement validation: - Removed obsolete function in HeightStructuresCalculationService - Added validation for the inputs that are required for a vertical wall calculation Related to Issue [WTI-926]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6230 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1753103e36b04f9785289770d1608b2a57e33381

Former-commit-id: eacc706ca5a543c3040a37c45700fe2f8f02d1e1

    • -5
    • +74
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
    • -0
    • +10
    ./Ringtoets.ClosingStructures.Service/Ringtoets.ClosingStructures.Service.csproj
  1. … 3 more files in changeset.
Made sure result view of closing structures updates when there is a change in the calculations and sections. Related to Issue [WTI-596]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6221 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2f2928ad823cb072cc7e161e27f61c2dc10fa32f

Former-commit-id: 10380ff8b8922ec56f57620e3e665c14b8d2748f

    • -0
    • +49
    ./Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresScenariosView.cs
  1. … 3 more files in changeset.
Added GenerateCalculations menu option for ClosingStructures. Related to Issue [WTI-594]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6217 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ea7f4d903427c827656083a23af14fec7fc6f49c

Former-commit-id: c3fcdb600447914c78d0e9e165f450412396b321

    • -0
    • +58
    ./Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
  1. … 20 more files in changeset.
Incorporated review comments 1129 - Adjusted exception when invalid enum of ClosingStructureInflowModelType is set Related to Issue [WTI-554]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6212 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3853885913d6298a9a3ec973f2b6badff2bcb7a0

Former-commit-id: d313b923eeca0fafe0af9ce8ad4c5e3d10fd791a

    • -3
    • +5
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
  1. … 1 more file in changeset.
Incorporated review comments 1129 - Renamed CalculationInputParser to something more generic and applicable - Adjusted XML doc of the StructuresClosureCalculator

Related to Issue [WTI-554]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6208 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2f00137a4aa30d9fe3f4ef3e42636185f40d54b3

Former-commit-id: 38f78612d2e68c2b03f3c1887cf43226076d4179

    • -6
    • +6
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
  1. … 11 more files in changeset.
Templated the StructuresHelper class. Related to Issue [WTI-594]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6204 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 9af2ee4c370f0472857b45b41fd796b579f50619

Former-commit-id: d9c3e22d99ef39196a54806e55d1fd577a29f574

    • -7
    • +1
    ./Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResult.cs
    • -6
    • +6
    ./Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresInputContextProperties.cs
    • -5
    • +5
    ./Ringtoets.ClosingStructures.Forms/Ringtoets.ClosingStructures.Forms.csproj
    • -3
    • +3
    ./Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresScenariosView.cs
    • -7
    • +7
    ./Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
    • -5
    • +5
    ./Ringtoets.ClosingStructures.Plugin/Ringtoets.ClosingStructures.Plugin.csproj
    • -3
    • +3
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
    • -5
    • +5
    ./Ringtoets.ClosingStructures.Service/Ringtoets.ClosingStructures.Service.csproj
  1. … 31 more files in changeset.
Incorporated review comments 1129 - Generalised ValidateAll method calls in all plugins Related to Issue [WTI-554]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6200 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3ce79447d29e2056543b6f5b273f1f24cd25594c

Former-commit-id: c812777234b3d6fc6d9a62a5feeb7c462bdb0aa8

    • -3
    • +19
    ./Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
  1. … 7 more files in changeset.
Adapted some log messages Related to Issue [WTI-867]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6190 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4ba3ccc4c2c1a59dfc7c0d0988ffa1c9d357c298

Former-commit-id: 9c257e93cfec630cf11fccd264b9bcc01122aed6

    • -1
    • +1
    ./Ringtoets.ClosingStructures.Service/Properties/Resources.Designer.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Service/Properties/Resources.resx
  1. … 11 more files in changeset.
Incorporated review comments 1129 - Extracted ParseBreakWater and ParseForeshore in a static class: implementation is now generic for StructuresCalculations and GrassCoverErosionInwardsCalculations Related to Issue [WTI-554]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6188 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7bf60fe98b88dc42b5a967de92f8775357b805f8

Former-commit-id: baca4f930a848196d1113d4987971b6a042a6a73

    • -36
    • +26
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
  1. … 6 more files in changeset.
Implemented improvements of review 1128. Related to Issue [WTI-935]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6185 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d9e620ed2e1f85ee6374f7b4f36332000273c705

Former-commit-id: 1058f1ad36ee4eaa8f4b3eaabe0c0315b64a503a

    • -1
    • +1
    ./Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
  1. … 26 more files in changeset.
Incorporated review comments 1129 - Editorial changes - Ensured that the output is cleared before a calculation starts

Related to Issue [WTI-554]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6184 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f79443262092233e3b3416e49441046c09ba3837

Former-commit-id: f2b6382e18c1ae0bbf69f206c64202da00a124b3

    • -1
    • +1
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresDataSynchronizationService.cs
  1. … 6 more files in changeset.
Applied small resource improvement

Paired with tang_ds

Related to Issue [WTI-554]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6177 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4d3ab2e91844769cf7bfcbe409112547834319e2

Former-commit-id: bf212ff2acd353f69c4b9649103c6a954f27d506

    • -2
    • +3
    ./Ringtoets.ClosingStructures.Service/Properties/Resources.Designer.cs
    • -1
    • +2
    ./Ringtoets.ClosingStructures.Service/Properties/Resources.resx
    • -0
    • +1
    ./Ringtoets.ClosingStructures.Service/Ringtoets.ClosingStructures.Service.csproj
Incorporated review comments 1129 - Changed method call signature of the Calculate methods in the HeightStructures and ClosingStructures services: service extracts the necessary information, not the activity Related to Issue [WTI-554]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6174 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 79566144bc44d8b7d4a1f435453d3321ee598df7

Former-commit-id: e73b7a124a7b3e44631e862bf7dcd5db00cd6425

    • -9
    • +2
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationActivity.cs
    • -25
    • +36
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
  1. … 4 more files in changeset.
* Made variables explicit. * Resharper cleanup. Related to Issue [WTI-596]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6173 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f8dd875f7ba23965a19403c76918608d12072146

Former-commit-id: d728b03cc2ac6d683d9baf38b866951175ab7228

    • -2
    • +2
    ./Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresScenariosView.cs
  1. … 3 more files in changeset.
Incorporated review comments 1129 - Moved the responsibility of determining the directory of the HLCD filepath from the plugin to the service (fixed for all structures calculations) Related to Issue [WTI-554]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6171 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 50ef699096c94b2a5bd589bfdd8a4499d0cfb07c

Former-commit-id: 40fa4afce33f65e13e23ac0125c57d33044e7739

    • -3
    • +2
    ./Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
    • -7
    • +7
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationActivity.cs
    • -3
    • +6
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
  1. … 9 more files in changeset.
Incorporated review comments 1129 - Make all Validation methods of the services static

Related to Issue [WTI-554]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6168 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c2c1dfa6ae053ad7643e226bab6babdcccdf32c8

Former-commit-id: bfac9a2e7e59a3da068ccea7378d8c8bd4cde47a

    • -2
    • +2
    ./Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationActivity.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
  1. … 27 more files in changeset.
Changed name of calculation routine in GrassCoverErosionInwardsCalculationService

Paired with tangerma

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6166 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 25f58d379a9eb6a426f9f53fffdfa9b573b57b43

Former-commit-id: 1b987b3e8b06a4dd720be621dbf857054c804d92

    • -1
    • +1
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
  1. … 5 more files in changeset.
- Set FailureProbabilityOpenStructure and FailureProbabilityReparation in calculation input to default value of 0 Related to Issue [WTI-838]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6163 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0262a6911626b02a9a74f3a32c36625f6db7e247

Former-commit-id: f7ace5175fba87c6fbbe2d89e5a874823e308e93

    • -2
    • +2
    ./Ringtoets.ClosingStructures.Data/ClosingStructuresInput.cs
  1. … 1 more file in changeset.
* Create and Read extension methods for StabilityPointStructure instances. * Introduced RoundedDouble.NaN constant (removes the proliferation of casting from double.NaN to RoundedDouble) Related to Issue [WTI-911]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6162 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e0faff5c1252f482de48e7849a8d4ae3f6bf1d5c

Former-commit-id: 2f2757c0a49641b703a66ca60d5ab0e28b7e7098

    • -4
    • +4
    ./Ringtoets.ClosingStructures.Data/ClosingStructuresInput.cs
  1. … 71 more files in changeset.
Generalized three structures Calculations to StructuresCalculation class. Related to Issue [WTI-594]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6151 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a8405ee298bf3c641f426352c072744f2e3685cb

Former-commit-id: 5968cf3a46e1b19065199c498dbd525ef5f26552

    • -86
    • +0
    ./Ringtoets.ClosingStructures.Data/ClosingStructuresCalculation.cs
    • -1
    • +2
    ./Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanism.cs
    • -2
    • +3
    ./Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResult.cs
    • -1
    • +0
    ./Ringtoets.ClosingStructures.Data/Ringtoets.ClosingStructures.Data.csproj
    • -5
    • +6
    ./Ringtoets.ClosingStructures.Forms/PresentationObjects/ClosingStructuresCalculationContext.cs
    • -2
    • +3
    ./Ringtoets.ClosingStructures.Forms/PresentationObjects/ClosingStructuresInputContext.cs
    • -4
    • +5
    ./Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresInputContextProperties.cs
    • -2
    • +3
    ./Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresScenarioRow.cs
    • -1
    • +2
    ./Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresScenariosView.cs
    • -13
    • +14
    ./Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
    • -2
    • +3
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationActivity.cs
    • -8
    • +9
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
    • -14
    • +15
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresDataSynchronizationService.cs
    • -17
    • +18
    ./Ringtoets.ClosingStructures.Utils/ClosingStructuresHelper.cs
  1. … 80 more files in changeset.
Extended ClosingStructuresInputContextProperties Related to Issue [WTI-556]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6148 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c134d46a047ac927066b8f23b7b655156a06db5e

Former-commit-id: 58c5a8962250c3dd46c0aaf52a46129a553c6fc7

    • -1
    • +37
    ./Ringtoets.ClosingStructures.Forms/Properties/Resources.Designer.cs
    • -0
    • +12
    ./Ringtoets.ClosingStructures.Forms/Properties/Resources.resx
    • -23
    • +271
    ./Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresInputContextProperties.cs
  1. … 3 more files in changeset.