Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Made use of nameof operator. Removed redundancy. Made types explicit in tests. Related to Issue [WTI-973]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7613 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ae0a1774c3921e4893681196f73a6bfa1f084bc4

Former-commit-id: 0304bd841817e0d89abbbb8792162fb125eedae0

    • -1
    • +0
    ./Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresFailureMechanismProperties.cs
  1. … 20 more files in changeset.
Added confirmation inquiry to other failure mechanisms. Removed unused methods from the IFailureMechanismPropertyChangeHandler. Related to Issue [WTI-967]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7610 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8e8ef9f7a0da1e8c09547d90dfcbd2c62f1c5042

Former-commit-id: 7239e460f2d71689a1576aa654c45bcce9557ad5

    • -13
    • +14
    ./Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresFailureMechanismProperties.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
  1. … 12 more files in changeset.
Added documentation for Hydra-Ring calculation process. Related to Issue [WTI-777]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7605 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e5cf1d8d3a806018f43ab7bc2a0a7bd9390af16b

Former-commit-id: 70a9cfa92619125137e1418a1dede18d579bff46

    • -3
    • +16
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
  1. … 19 more files in changeset.
Initial commit of changes from kleijn: - Removed HandleUserCancellingImport: FileImporter should not decide on its own how to handle Canceled actions. Consequently removed the messages that are generated by these handles - Added logic to the importers: Cancelling is not possible when putting data on the data model. Action will always execute when it is in this stage - Added branching paths in the activity: Import() returns false when it has failed or is cancelled

Note: failing tests will be fixed in following commits

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/WTI-490@7598 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 409bfee1e3deebb4fe4368cb7010a8c4c37dae5e

Former-commit-id: 98175da77f6910f259097a90626bbb10450e2c8f

    • -6
    • +0
    ./Ringtoets.ClosingStructures.IO/ClosingStructuresImporter.cs
  1. … 20 more files in changeset.
Added null checks in dune erosion and closing structures calculation services. Related to Issue [WTI-777]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7588 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 63f021f5741f4dae65ad82aa12c4593af72c8727

Former-commit-id: 19a06c73d09214b5c9422976aeb691946802d415

    • -29
    • +70
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
    • -0
    • +5
    ./Ringtoets.ClosingStructures.Service/Ringtoets.ClosingStructures.Service.csproj
  1. … 3 more files in changeset.
modified logic with relation to removing foreshore/dike profiles to only return calculations which had output that is cleared due to the change. Related to Issue [WTI-973]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7576 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 17c1dad357f70f1ecfe52b5299cd9c580492a9f3

Former-commit-id: 946b5bf4041ffa141dc4854ba078b8496ea6a60b

    • -0
    • +5
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresDataSynchronizationService.cs
  1. … 5 more files in changeset.
Fixed synchronization of Calculation assignments to SectionResult when dike profiles are assigned to calculations or when dike profile or calculations are deleted. Related to Issue [WTI-968]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7560 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2c3389f3ce5ae650350fe36697da4d08761ace93

Former-commit-id: 35b379b3f056389aa0a2859a2cf0af85a9cba6cc

    • -1
    • +4
    ./Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresInputContextProperties.cs
    • -23
    • +19
    ./Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
    • -7
    • +8
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresDataSynchronizationService.cs
  1. … 22 more files in changeset.
- Renamed some methods - Improved documentation and exception handling in DuneErosionCalculationService. Related to Issue [WTI-777]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7555 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d194f66842310d591e1bbc09ab807bf3bb16aedc

Former-commit-id: 41aa2143aeaac94aaccc9fe38e202ec1c2b3d174

    • -1
    • +1
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
  1. … 19 more files in changeset.
Made the context for StructuresInputBaseProperties a constructor parameter. Related to Issue [WTI-973]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7552 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4e5398462ba1ed5e8304e674343519593bf8d8e1

Former-commit-id: bde528a2d322d326e34ebc33df3d64ab4af10b44

    • -22
    • +26
    ./Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresInputContextProperties.cs
    • -1
    • +4
    ./Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
  1. … 15 more files in changeset.
* Refactored FailureMechanismPropertyChangedHandler to be generic at class level ** Updated inheritors. ** Updated usages. Related to Issue [WTI-971]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7548 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f89b45f54e87601aa753b3750f27a982a6d3c9d6

Former-commit-id: a08ed73d7ab09657f6bb092d604f320b6567db2d

    • -1
    • +2
    ./Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
  1. … 5 more files in changeset.
Extracted TestStructuresOutput for reuse. Remove calculation results when input changes for closing structures failure mechanism. Related to Issue [WTI-973]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7545 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f929ee8cdcbc1fdf43c9051695222d306d9ca729

Former-commit-id: 7355f2162ab9ef94256533232413bf6437017576

    • -2
    • +1
    ./Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresInputContextProperties.cs
  1. … 13 more files in changeset.
Added optional handler as constructor property for VariationCoefficientDistributionProperties and derivatives. StructureInputBaseProperties clears calculation output. ClosingStructuresInputContextProperties clears calculation output. Related to Issue [WTI-973]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7542 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7d417a7b7ffacac40c8d8a2e4708f2209e6f8dca

Former-commit-id: 6b6516e6d2267784b442fdf43e2b84ca19937ada

    • -8
    • +6
    ./Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresInputContextProperties.cs
  1. … 8 more files in changeset.
Removed IGrassCoverErosionOutwardsFailureMechanismPropertyChangeHandler. Made IFailureMechanismPropertyChangeHandler generic. Implemented IFailureMechanismPropertyChangeHandler<GrassCoverErosionInwardsFailureMechanism> in GrassCoverErosionOutwardsFailureMechanismPropertyChangeHandler. Related to Issue [WTI-971]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7533 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: fa614fa1c906e229bb5c23f5d4902230ae5a05e4

Former-commit-id: 19d7524b8499d203c177fc854341c211ca08f078

    • -2
    • +3
    ./Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresFailureMechanismProperties.cs
  1. … 17 more files in changeset.
Added IFailureMechanismPropertyChangeHandler for ClosingStructuresFailureMechanismProperties. Updated tests for (invalid) values with and without confirmation for piping, grass cover erosion inwards and grass cover erosion outwards failure mechanisms.

Related to Issue [WTI-973]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7529 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 76580d08c34eaf23721670e0714d528354e34e0e

Former-commit-id: e5f4dfb51a26e7363c002052165b52a12791fd8d

    • -2
    • +40
    ./Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresFailureMechanismProperties.cs
    • -4
    • +3
    ./Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
  1. … 7 more files in changeset.
Merged IUseBreakWaterPropertyChangeHandler and IDistributionPropertyChangeHandler into a single IPropertyChangeHandler Related to Issue [WTI-968]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7524 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ebc30eecf289d704188c1ec45d4712bffd708c16

Former-commit-id: f6de7e38e4ae49a64dacfd18347b61deb3c9f2fd

    • -2
    • +2
    ./Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresInputContextProperties.cs
  1. … 16 more files in changeset.
Incorporated comments review 1344: - Replaced related if-statements with a single if-else statement Related to Issue [WTI-995]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7516 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0adeef40b1e7724d98e53fcc98a6295b44b7e054

Former-commit-id: 71cf32a15f8ac8c639c049f3c9b730e7025b7366

    • -8
    • +6
    ./Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
  1. … 7 more files in changeset.
Extracted IDistributionPropertyChangeHandler for DistributionPropertiesBase. Improved doc. Related to Issue [WTI-968]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7513 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1f48da1794e42d12944bd5149b11314e7a29b5a4

Former-commit-id: 7436cba0ba1fa3c380a5f89fbe1047b1f119f0ee

    • -9
    • +2
    ./Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresInputContextProperties.cs
  1. … 12 more files in changeset.
Removed obsolete Test from WaveConditionsInputContextPropertiesTest. Made certain variables' types explicit. Replaced .Matches(x => true) with Is.NotNull. Some general cleanups. Added missing docs. Related to Issue [WTI-968]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7511 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 95da872000b9ba2b113ad54b4c3f8ee363e25472

Former-commit-id: 782a5a1fef732e1f91e310b5a31aeb471f792751

    • -1
    • +2
    ./Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresInputContextProperties.cs
  1. … 68 more files in changeset.
* Extended IReferenceLineReplaceHandler with DoPostReplacementUpdates to allow for actions to be resolved after the replacement of the ReferenceLine took place. ** Main reason behind this architectural choice, is allowing for UI updates from non-UI threads. ** ReferenceLineImporter makes use of this new method in the DoPostImportUpdates method. * ReferenceLineReplaceHandler now keeps track of deleted objects and closes views for those objects in the DoPostReplacementUpdates method. ** Introduced ClearResults class for this purpose. ** Updated DataSynchronisationService methods related to replacing the ReferenceLine and now keep track of both changed objects as well as removed objects. * Cleanup in some commands to use IViewCommands. Related to Issue [WTI-1034]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7494 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 239f69a11ed199f938d5dd31e76f60772ad40072

Former-commit-id: 9cb0286bb78c272cc2d2cb43b703d0fc9ad386f3

    • -8
    • +17
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresDataSynchronizationService.cs
  1. … 56 more files in changeset.
Refactored way GrassCoverErosionInwardsInputContextProperties handles changes of UseBreakWaterProperties. UseBreakWaterProperties now accepts an handler which performs the action after a property has been changed. DistributionPropertiesBase accepts a similar handler. Related to Issue [WTI-968]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7473 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b2d5ebc5f93edd0607d3d39291a3542412944177

Former-commit-id: f9801610f0d5020c0485b7af2d6052cc19868fe4

    • -23
    • +36
    ./Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresInputContextProperties.cs
  1. … 17 more files in changeset.
Changed behavior of the ClosingStructuresInput: - Values (including mean, SD/Coefficient of Variation) that are set by selecting a structure are defaulted to NaN - When structure is reset to NULL, all dependent values that are set by selecting a structure are defaulted

Related to Issue [WTI-1041]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7468 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1d4c82833723d19cbfe7e7d785313d5a9dd108e7

Former-commit-id: 3d57fc1444852eb84a51ae3f66394b77ba7f3fea

    • -4
    • +4
    ./Ringtoets.ClosingStructures.Data/ClosingStructuresInput.cs
  1. … 1 more file in changeset.
Implement consistent ordering in context menus, quality check for previous corrected items: - Structures context - Dike profiles context - Foreshore profiles context

Order was adjusted according to the issue description.

Related to Issue [WTI-995]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7440 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3235c2be3daee181c61130d000b03adaacd91ac4

Former-commit-id: 6740ef30ddc37f6004975d3b7868a1d52270755f

    • -3
    • +3
    ./Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
  1. … 12 more files in changeset.
Improvements after review. Related to Issue [WTI-773]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7438 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bf03f344571164795f315d8a063a3bc2bdc2b9c4

Former-commit-id: beb549c0f7dc4e2aeaee8e8152a840fa15364b86

    • -8
    • +8
    ./Ringtoets.ClosingStructures.Forms/Properties/Resources.Designer.cs
    • -4
    • +4
    ./Ringtoets.ClosingStructures.Forms/Properties/Resources.resx
    • -4
    • +4
    ./Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresFailureMechanismProperties.cs
  1. … 37 more files in changeset.
Implement consistent ordering in context menus - (Editorial) cleaned up closing structures plugin

Related to Issue [WTI-995]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7431 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 59650f7acc2addf4239482ec7e7a670f3c99102d

Former-commit-id: 2b1a7cb152a25db90a940dde7a12fb3685cba55a

    • -2
    • +2
    ./Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
Implement consistent ordering in context menus - Made ClosingStructureContext menu consistent with the issue description - Adjusted affected tests Related to Issue [WTI-995]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7423 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ef16059e8de48346dff88e461a2450cfef44fc4a

Former-commit-id: b043463278b63a37f84a5eca8e82694c7399d65f

    • -27
    • +30
    ./Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
  1. … 3 more files in changeset.
- Upgraded Project ToolsVersion="4.0" to ToolsVersion="14.0" - Ignored ".vs" folder in trunk paired with tang_ds

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7422 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: beca2918e38aa1e3900b6bc17a0df7e8d1f9c8e3

Former-commit-id: 681a7a3764b91f67e1e97dc0d30f930c901276e0

    • -1
    • +1
    ./Ringtoets.ClosingStructures.Data/Ringtoets.ClosingStructures.Data.csproj
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Forms/Ringtoets.ClosingStructures.Forms.csproj
    • -1
    • +1
    ./Ringtoets.ClosingStructures.IO/Ringtoets.ClosingStructures.IO.csproj
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Plugin/Ringtoets.ClosingStructures.Plugin.csproj
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Service/Ringtoets.ClosingStructures.Service.csproj
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Utils/Ringtoets.ClosingStructures.Utils.csproj
  1. … 214 more files in changeset.
Renamed ClosingStructureFailureMechanismProperties. Related to Issue [WTI-773]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7410 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4249e0002cb1ea12b1ed926b824a45a1df7800e4

Former-commit-id: 993794aa745c111221cb521f0680f4db7379a314

    • -201
    • +0
    ./Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructureFailureMechanismProperties.cs
    • -0
    • +201
    ./Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresFailureMechanismProperties.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Forms/Ringtoets.ClosingStructures.Forms.csproj
    • -2
    • +2
    ./Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
  1. … 4 more files in changeset.
Synchronize schematization parameters in a consistent way: - Reset schematization properties to their default values when structure is NULL: -- Introduced a general method to prevent code duplciation for each structure -- Added test that asserts the reset and whether unrelated values were changed

Related to Issue [WTI-1041]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7402 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 69cc21f5d0989fea5f32dffc51f3beab74a0211b

Former-commit-id: ae08cf3f2893a0f155e8ae74471dbab83937e6e9

    • -26
    • +43
    ./Ringtoets.ClosingStructures.Data/ClosingStructuresInput.cs
  1. … 7 more files in changeset.
Replaced calls to GetObjectPropertiesData with calls to CreateInstance. Updated PropertyInfoExtensions to just set Data based on the sourceData when it wasn't already set in the CreateInstance function. Related to Issue [WTI-1039]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7377 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d74bdc2465940c63fe37c43aad0fff0690cac57a

Former-commit-id: e6a7f359cc4f720ee65c2943ea7c0662351ad090

    • -2
    • +4
    ./Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
  1. … 23 more files in changeset.
Improved comment

Paired with tang_ds

Related to Issue [WTI-1029]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7328 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 70ac61c71bbbae23f6cf5dfba7e169218ff4c596

Former-commit-id: cd69ce2405ce8a06aa0509326381424501082187

    • -1
    • +1
    ./Ringtoets.ClosingStructures.Data/ClosingStructure.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Data/ClosingStructuresInput.cs