Riskeer / Ringtoets / ClosingStructures

test

Clone Tools

Stats

Commits this week: 0
Total Committers: 8
Last Commit: 26 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 31 Oct 2016
9:46 am

bouvrie <bouvrie@example.com>

* Made type explicit or more concrete. * Reformatted code to improve readability and better adherence to code-conventions. Related to Issue [WTI-596]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6287 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b843544708d2da78f91008dbddb0c9bc748e51cb

Former-commit-id: a132052d0d6e775430eca5ca1ccaa8c2730ec7fb

Options
    • -14
    • +14
    ./Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
  2. … 4 more files in changeset.
8:33 am

Elmar Kleijn

Extended StabilityPointStructuresInputContextPropertiesTest Related to Issue [WTI-570]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6282 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1d9c771f4c6fc2358f2fb84873505730630ae982

Former-commit-id: a5826dbec60eab1b59aa752032cdfe0ce5835775

Options
    • -12
    • +2
    ./Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresInputContextPropertiesTest.cs
  2. … 2 more files in changeset.
Friday 28 Oct 2016
2:32 pm

Dennis Tang <dennis.tang@deltares.nl>

Overall improvement: - Simplified all integration tests fr activity: have 1 test with invalid input and at least 1 tests with valid input. All the tests with invalid cases are already tested in the corresponding lower level service tests and are not necessary in the higher level integration tests

Made grass cover erosion inwards validation procedure consistent with other calculation tracks:

- Removed obsolete hydraulic boundary database check

- If the connection with the hydraulic boundary database becomes invalid, no further validation will be performed

- If the connection remains valid, the hydraulic boundary location will be checked

Related to Issue [WTI-926]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6271 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 24a88dbec5699e1462bef4e9eadfa48d4274d87b

Former-commit-id: b4502f1c90d99960abb201ded6965455f8a8bcb3

Options
    • -49
    • +5
    ./Ringtoets.ClosingStructures.Integration.Test/ClosingStructuresCalculationActivityIntegrationTest.cs
  2. … 6 more files in changeset.
2:06 pm

bos_en <bos_en@example.com>

Implemented improvements of review 1143. Related to Issue [WTI-594]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6268 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 421edd42003bb6a398baba98b51e8d0127174d67

Former-commit-id: 0bd25a60e86104fef7664e113a09f8fce1995d6b

Options
    • -1
    • +0
    ./Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismTest.cs
    • -12
    • +1
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructureDataSynchronizationServiceTest.cs
  3. … 30 more files in changeset.
10:57 am

Robert Tangerman <robert.tangerman@deltares.nl>

Fix error. Related to Issue [WTI-568]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6260 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 41a272a198e6cbbc472177e9c7731927b8e2efda

Former-commit-id: 9f1510fd6b6fa17fd7288b6a016a174b3e40266b

Options
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
10:56 am

Robert Tangerman <robert.tangerman@deltares.nl>

- Introduced AssessmentSectionHelper to create assessment section stubs. - Introduced service for stability point structures. - Introduced test calculation for stability point structures. Related to Issue [WTI-568]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6259 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 341b4d67f97ea9ff66407a2f408577674c7c948d

Former-commit-id: f2f1c210714d43fbde39a88be94cd95599efd5b7

Options
    • -31
    • +13
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
    • -0
    • +4
    ./Ringtoets.ClosingStructures.Service.Test/Ringtoets.ClosingStructures.Service.Test.csproj
  3. … 18 more files in changeset.
10:38 am

Dennis Tang <dennis.tang@deltares.nl>

Implement validation: - Added validation for the flooded culvert calculations Related to Issue [WTI-926]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6257 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b06381fe2f4d7951d2e79f2a9cd51192c1af9274

Former-commit-id: 2c11dfa81411bf8f924cd9872d30244715f7d6c9

Options
    • -3
    • +60
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
  2. … 1 more file in changeset.
9:01 am

Dennis Tang <dennis.tang@deltares.nl>

Implement validation: - Added validation for the inputs that are required for a low sill calculation - Simplified tests: introduced a method that sets all the input parameters of the calculation object to invalid values - Added documentation Related to Issue [WTI-926]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6250 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7bd5a770ac99355474ab8d75af6ffc088944770e

Former-commit-id: 69a68ed124717f26cb8c6538a40a84f57f927188

Options
    • -52
    • +124
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
  2. … 1 more file in changeset.
8:22 am

Elmar Kleijn

Added some final tests Related to Issue [WTI-556]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6247 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2e68a7ec420938a47fa181d4fda1290ef54e1c1d

Former-commit-id: c5690edeefdfc97655173da0f532e3592bf488c6

Options
    • -0
    • +34
    ./Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresInputContextPropertiesTest.cs
  2. … 1 more file in changeset.
Thursday 27 Oct 2016
3:38 pm

Elmar Kleijn

Extended ClosingStructuresInputContextPropertiesTest Related to Issue [WTI-556]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6235 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 9e35ae9e70dabb766466de039ee2ece71509e749

Former-commit-id: f530372317a69f4e2462197bb07ae48dc132618b

Options
    • -0
    • +275
    ./Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresInputContextPropertiesTest.cs
  2. … 1 more file in changeset.
3:28 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Changes after review. Related to Issue [WTI-554]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6233 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: aa525712740ea4d4c290bb2be7d7f91c8f1e8fa7

Former-commit-id: 59b6c1d9951a51610a60068228326a1f588c9aeb

Options
    • -0
    • +1
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
  2. … 11 more files in changeset.
3:20 pm

Elmar Kleijn

Extended ClosingStructuresInputContextPropertiesTest Related to Issue [WTI-556]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6232 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 83fe7133937d32f95350d85e9a48f696204c8bfc

Former-commit-id: 53263a92ecad876eff3e96196d975695fdf55996

Options
    • -17
    • +20
    ./Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresInputContextPropertiesTest.cs
  2. … 1 more file in changeset.
3:13 pm

Dennis Tang <dennis.tang@deltares.nl>

Implement validation: - Removed obsolete function in HeightStructuresCalculationService - Added validation for the inputs that are required for a vertical wall calculation Related to Issue [WTI-926]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6230 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1753103e36b04f9785289770d1608b2a57e33381

Former-commit-id: eacc706ca5a543c3040a37c45700fe2f8f02d1e1

Options
    • -0
    • +1
    ./Ringtoets.ClosingStructures.Integration.Test/ClosingStructuresCalculationActivityIntegrationTest.cs
    • -0
    • +235
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
  3. … 3 more files in changeset.
2:44 pm

Elmar Kleijn

Extended ClosingStructuresInputContextPropertiesTest Related to Issue [WTI-556]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6225 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: dec1e1a20446edd9e01a0891ca42a332dd399b47

Former-commit-id: 5feb86737d6fb37b5187463040666676e033a3b4

Options
    • -0
    • +18
    ./Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresInputContextPropertiesTest.cs
2:34 pm

Elmar Kleijn

Extended ClosingStructuresInputContextPropertiesTest Related to Issue [WTI-556]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6224 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e97e3447a0cd52172bbbbeadb66ab2581d3a2d8b

Former-commit-id: e4e02291d45bdb27487d58a1adff18e2d15a05b0

Options
    • -19
    • +101
    ./Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresInputContextPropertiesTest.cs
  2. … 1 more file in changeset.
2:03 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Made sure result view of closing structures updates when there is a change in the calculations and sections. Related to Issue [WTI-596]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6221 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2f2928ad823cb072cc7e161e27f61c2dc10fa32f

Former-commit-id: 10380ff8b8922ec56f57620e3e665c14b8d2748f

Options
    • -21
    • +146
    ./Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
  2. … 4 more files in changeset.
1:44 pm

Elmar Kleijn

Extended ClosingStructuresInputContextPropertiesTest Related to Issue [WTI-556]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6218 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 05bfa6db27c6e70be45eb0bc48cda751c3ecd0c4

Former-commit-id: 5257ee638169235fa0d51ab0300ccb77217c0b32

Options
    • -4
    • +21
    ./Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresInputContextPropertiesTest.cs
  2. … 2 more files in changeset.
1:34 pm

bos_en <bos_en@example.com>

Added GenerateCalculations menu option for ClosingStructures. Related to Issue [WTI-594]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6217 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ea7f4d903427c827656083a23af14fec7fc6f49c

Former-commit-id: c3fcdb600447914c78d0e9e165f450412396b321

Options
    • -6
    • +236
    ./Ringtoets.ClosingStructures.Forms.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs
  2. … 20 more files in changeset.
1:29 pm

Elmar Kleijn

Added first version of ClosingStructuresInputContextPropertiesTest Related to Issue [WTI-556]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6215 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f74e7b9959cb2a7d629b424d2a24fa5816ea946b

Former-commit-id: d35046fd2e8f5e7b8195737435311143b5dfb4bb

Options
    • -0
    • +283
    ./Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresInputContextPropertiesTest.cs
    • -0
    • +5
    ./Ringtoets.ClosingStructures.Forms.Test/Ringtoets.ClosingStructures.Forms.Test.csproj
  3. … 1 more file in changeset.
12:11 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated review comments 1129 - Adjusted exception when invalid enum of ClosingStructureInflowModelType is set Related to Issue [WTI-554]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6212 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3853885913d6298a9a3ec973f2b6badff2bcb7a0

Former-commit-id: d313b923eeca0fafe0af9ce8ad4c5e3d10fd791a

Options
    • -2
    • +3
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
  2. … 1 more file in changeset.
11:26 am

bos_en <bos_en@example.com>

Templated the StructuresHelper class. Related to Issue [WTI-594]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6204 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 9af2ee4c370f0472857b45b41fd796b579f50619

Former-commit-id: d9c3e22d99ef39196a54806e55d1fd577a29f574

Options
    • -20
    • +1
    ./Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultTest.cs
    • -4
    • +0
    ./Ringtoets.ClosingStructures.Utils.Test/Ringtoets.ClosingStructures.Utils.Test.csproj
  3. … 37 more files in changeset.
Wednesday 26 Oct 2016
6:39 pm

Elmar Kleijn

Adapted some log messages Related to Issue [WTI-867]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6190 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4ba3ccc4c2c1a59dfc7c0d0988ffa1c9d357c298

Former-commit-id: 9c257e93cfec630cf11fccd264b9bcc01122aed6

Options
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Forms.Test/TreeNodeInfos/ClosingStructuresCalculationContextTreeNodeInfoTest.cs
    • -2
    • +2
    ./Ringtoets.ClosingStructures.Forms.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -2
    • +2
    ./Ringtoets.ClosingStructures.Integration.Test/ClosingStructuresCalculationActivityIntegrationTest.cs
    • -2
    • +2
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
  5. … 9 more files in changeset.
3:36 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated review comments 1129 - Cleaned up tests: introduced variable - Improved ClosingStructuresCalculationServiceTest with suggestions

Related to Issue [WTI-554]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6180 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3c6dcfe16f795d89fd080b66cd25b205bfb95152

Former-commit-id: 59c3a57b35a5ca625fc32cd08aa43e5ed080cb3c

Options
    • -2
    • +3
    ./Ringtoets.ClosingStructures.Forms.Test/TreeNodeInfos/ClosingStructuresCalculationContextTreeNodeInfoTest.cs
    • -2
    • +4
    ./Ringtoets.ClosingStructures.Forms.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -4
    • +11
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
  4. … 5 more files in changeset.
3:08 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated review comments 1129 - Cleaned up tests Related to Issue [WTI-554]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6176 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8f7d65ef8065e2757706511fdfc408c05e0b9e61

Former-commit-id: a83de80f2b2122b5174f58363c9448ae6dd15f85

Options
    • -155
    • +0
    ./Ringtoets.ClosingStructures.Forms.Test/TreeNodeInfos/ClosingStructuresCalculationContextTreeNodeInfoTest.cs
    • -197
    • +0
    ./Ringtoets.ClosingStructures.Forms.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -3
    • +2
    ./Ringtoets.ClosingStructures.Integration.Test/ClosingStructuresCalculationActivityIntegrationTest.cs
    • -4
    • +4
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationActivityTest.cs
2:38 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated review comments 1129 - Changed method call signature of the Calculate methods in the HeightStructures and ClosingStructures services: service extracts the necessary information, not the activity Related to Issue [WTI-554]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6174 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 79566144bc44d8b7d4a1f435453d3321ee598df7

Former-commit-id: e73b7a124a7b3e44631e862bf7dcd5db00cd6425

Options
    • -28
    • +12
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
  2. … 5 more files in changeset.
2:35 pm

bouvrie <bouvrie@example.com>

* Made variables explicit. * Resharper cleanup. Related to Issue [WTI-596]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6173 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f8dd875f7ba23965a19403c76918608d12072146

Former-commit-id: d728b03cc2ac6d683d9baf38b866951175ab7228

Options
    • -36
    • +81
    ./Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresScenariosViewTest.cs
  2. … 3 more files in changeset.
1:36 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated review comments 1129 - Moved the responsibility of determining the directory of the HLCD filepath from the plugin to the service (fixed for all structures calculations) Related to Issue [WTI-554]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6171 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 50ef699096c94b2a5bd589bfdd8a4499d0cfb07c

Former-commit-id: 40fa4afce33f65e13e23ac0125c57d33044e7739

Options
    • -3
    • +1
    ./Ringtoets.ClosingStructures.Integration.Test/ClosingStructuresCalculationActivityIntegrationTest.cs
    • -2
    • +2
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationActivityTest.cs
    • -7
    • +7
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
  4. … 9 more files in changeset.
12:13 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated review comments 1129 - Make all Validation methods of the services static

Related to Issue [WTI-554]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6168 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c2c1dfa6ae053ad7643e226bab6babdcccdf32c8

Former-commit-id: bfac9a2e7e59a3da068ccea7378d8c8bd4cde47a

Options
    • -2
    • +2
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
  2. … 29 more files in changeset.
12:06 pm

bouvrie <bouvrie@example.com>

* Extracted ParameterNameExtractor to Ringtoets.Common.Services. * Fixed Resources names to be consistent with naming convention. * Improved message text. Related to Issue [WTI-925]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6167 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8e4eba96b51adda20434194e2e84663e9dbaa836

Former-commit-id: 9c8134b11d9b377f751047bcacda1f21bf497a7e

Options
    • -1
    • +3
    ./Ringtoets.ClosingStructures.Data.Test/ClosingStructuresInputTest.cs
  2. … 14 more files in changeset.
10:34 am

Marten Janssen <marten.janssen@deltares.nl>

- Set FailureProbabilityOpenStructure and FailureProbabilityReparation in calculation input to default value of 0 Related to Issue [WTI-838]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6163 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0262a6911626b02a9a74f3a32c36625f6db7e247

Former-commit-id: f7ace5175fba87c6fbbe2d89e5a874823e308e93

Options
    • -2
    • +2
    ./Ringtoets.ClosingStructures.Data.Test/ClosingStructuresInputTest.cs
  2. … 1 more file in changeset.