Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Cleanup Structures: WTI-1923

- Editorial changes

    • -1
    • +0
    ./Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationContextTreeNodeInfoTest.cs
Cleanup: WTI-1923

- Removed explicit invocation checks, use the HydraRingCalculationSettingsTestHelper to assert input arguments to the calculators

-- Removed unnecessary stub definitions for the mocks and stubs

    • -8
    • +2
    ./Ringtoets.ClosingStructures.Integration.Test/ClosingStructuresCalculationActivityIntegrationTest.cs
  1. … 6 more files in changeset.
Introduced HydraulicBoundaryCalculationSettings for ClosingStructure calculations: WTI-1923

- Fixed failing tests in the ClosingStructures namespace

    • -61
    • +43
    ./Ringtoets.ClosingStructures.Integration.Test/ClosingStructuresCalculationActivityIntegrationTest.cs
    • -12
    • +12
    ./Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationContextTreeNodeInfoTest.cs
    • -8
    • +8
    ./Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -8
    • +8
    ./Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresFailureMechanismContextTreeNodeInfoTest.cs
Introduced HydraulicBoundaryCalculationSettings for ClosingStructure calculations: WTI-1923

- Adjusted service and activities

- Fixed failing tests in the corresponding Service.Test namespace

    • -9
    • +13
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationActivityFactoryTest.cs
    • -111
    • +49
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
  1. … 1 more file in changeset.
Updated StructureCalculator calls: WTI-1923

- Fixed failing tests

    • -1
    • +1
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
  1. … 2 more files in changeset.
Updated StructureCalculator calls: WTI-1923

- Performed for the closing structures related elements

-- Integration elements (e.g. AssessmentSection) tests were not taken into account

    • -7
    • +57
    ./Ringtoets.ClosingStructures.Integration.Test/ClosingStructuresCalculationActivityIntegrationTest.cs
    • -1
    • +9
    ./Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationContextTreeNodeInfoTest.cs
    • -1
    • +9
    ./Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -1
    • +9
    ./Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresFailureMechanismContextTreeNodeInfoTest.cs
    • -1
    • +9
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationActivityFactoryTest.cs
    • -11
    • +89
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
Improvements after review. WTI-977

    • -3
    • +3
    ./Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismViewTest.cs
  1. … 14 more files in changeset.
Updated observers in closing structures view. WTI-977

    • -5
    • +47
    ./Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismViewTest.cs
  1. … 1 more file in changeset.
Adapted ClosingStructures Import info. WTI-977

    • -3
    • +4
    ./Ringtoets.ClosingStructures.Plugin.Test/ImportInfos/ClosingStructuresContextImportInfoTest.cs
  1. … 1 more file in changeset.
Fixed compilation errors. WTI-977

    • -3
    • +2
    ./Ringtoets.ClosingStructures.Plugin.Test/ImportInfos/ClosingStructuresContextImportInfoTest.cs
    • -3
    • +2
    ./Ringtoets.ClosingStructures.Plugin.Test/UpdateInfos/ClosingStructuresContextUpdateInfoTest.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Plugin.Test/UpdateInfos/ClosingStructuresFailureMechanismSectionsContextUpdateInfoTest.cs
Add assembly layers to closing structures view WTI-1872

    • -52
    • +314
    ./Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismViewTest.cs
  1. … 1 more file in changeset.
Introduce map features factory for closing structures WTI-1872

    • -0
    • +240
    ./Ringtoets.ClosingStructures.Forms.Test/Factories/ClosingStructuresAssemblyMapDataFeaturesFactoryTest.cs
    • -0
    • +1
    ./Ringtoets.ClosingStructures.Forms.Test/Ringtoets.ClosingStructures.Forms.Test.csproj
  1. … 2 more files in changeset.
Fixed compilation errors. WTI-1888

    • -1
    • +1
    ./Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructureTreeNodeInfoTest.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationContextTreeNodeInfoTest.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresContextTreeNodeInfoTest.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresFailureMechanismContextTreeNodeInfoTest.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresInputContextTreeNodeInfoTest.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresProbabilityFailureMechanismSectionResultContextTreeNodeInfoTest.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresScenariosContextTreeNodeInfoTest.cs
Add vakindelingen group to structures views WTI-1879

    • -68
    • +77
    ./Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismViewTest.cs
  1. … 5 more files in changeset.
Fix typo WTI-1553

    • -3
    • +3
    ./Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismViewTest.cs
  1. … 9 more files in changeset.
Incorporated comments reviews 3225 and 3227:

- Updated test names

- Formatting / layout tests

Paired with ~carloslubbers

WTI-1658

    • -1
    • +1
    ./Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
  1. … 7 more files in changeset.
Update columns in closing structures view WTI-1658

    • -2
    • +39
    ./Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
  1. … 1 more file in changeset.
Fixed DisplayName. WTI-1848

    • -1
    • +1
    ./Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresFailureMechanismPropertiesTest.cs
  1. … 3 more files in changeset.
Changed copyright year. Paired with lubbers. WTI-1828

    • -1
    • +1
    ./Ringtoets.ClosingStructures.Data.Test/ClosingStructureInflowModelTypeTest.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Data.Test/ClosingStructureTest.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismAssemblyFactoryTest.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultDetailedAssessmentExtensionsTest.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultTest.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismTest.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Data.Test/ClosingStructuresInputTest.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Data.Test/ClosingStructuresProbabilityAssessmentOutputFactoryTest.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Data.Test/GeneralClosingStructuresInputTest.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Data.Test/Properties/AssemblyInfo.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Data.Test/packages.config
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Data.TestUtil.Test/ClosingStructurePermutationHelperTest.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Data.TestUtil.Test/Properties/AssemblyInfo.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Data.TestUtil.Test/TestClosingStructureCalculationTest.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Data.TestUtil.Test/TestClosingStructureTest.cs
  1. … 6081 more files in changeset.
Fixed license headers. WTI-1767

    • -1
    • +0
    ./Ringtoets.ClosingStructures.Util.Test/packages.config
  1. … 28 more files in changeset.
Removed unused references. WTI-1767

Paired with ~carloslubbers

    • -4
    • +0
    ./Ringtoets.ClosingStructures.Forms.Test/Ringtoets.ClosingStructures.Forms.Test.csproj
  1. … 1 more file in changeset.
Ran Deltares Cleanup:

- Performed for Ringtoets.ClosingStructures

WTI-1767

    • -3
    • +3
    ./Ringtoets.ClosingStructures.Data.Test/GeneralClosingStructuresInputTest.cs
    • -4
    • +3
    ./Ringtoets.ClosingStructures.Data.TestUtil.Test/ClosingStructurePermutationHelperTest.cs
    • -2
    • +2
    ./Ringtoets.ClosingStructures.Forms.Test/PresentationObjects/ClosingStructuresFailureMechanismSectionsContextTest.cs
    • -1
    • +2
    ./Ringtoets.ClosingStructures.IO.Test/ClosingStructuresImporterTest.cs
    • -0
    • +2
    ./Ringtoets.ClosingStructures.Plugin.Test/ExportInfos/ClosingStructuresCalculationContextExportInfoTest.cs
    • -0
    • +3
    ./Ringtoets.ClosingStructures.Plugin.Test/ExportInfos/ClosingStructuresCalculationGroupContextExportInfoTest.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructuresFailureMechanismSectionResultUpdateStrategyTest.cs
    • -0
    • +1
    ./Ringtoets.ClosingStructures.Plugin.Test/ImportInfos/ClosingStructuresCalculationGroupContextImportInfoTest.cs
    • -0
    • +3
    ./Ringtoets.ClosingStructures.Plugin.Test/ImportInfos/ClosingStructuresContextImportInfoTest.cs
    • -0
    • +1
    ./Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresContextTreeNodeInfoTest.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresFailureMechanismContextTreeNodeInfoTest.cs
    • -0
    • +1
    ./Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresInputContextTreeNodeInfoTest.cs
    • -0
    • +1
    ./Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresScenariosContextTreeNodeInfoTest.cs
  1. … 11 more files in changeset.
Remove unused refs WTI-1767

    • -4
    • +0
    ./Ringtoets.ClosingStructures.Util.Test/Ringtoets.ClosingStructures.Util.Test.csproj
Cleanup WTI-1842

    • -12
    • +0
    ./Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
  1. … 5 more files in changeset.
Improve assembly factory tests for group 1 and 2 WTI-1842

    • -64
    • +27
    ./Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismAssemblyFactoryTest.cs
  1. … 5 more files in changeset.
Adjusted the failure mechanism section calculator stub:

- Split the assembly categories input in a version for the detailed and for the tailor made assessment to prevent confusion.

WTI-1842

    • -2
    • +2
    ./Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismAssemblyFactoryTest.cs
  1. … 8 more files in changeset.
Refactor result views, remove has manual assembly results method WTI-1839

    • -47
    • +0
    ./Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
  1. … 35 more files in changeset.
Incorporated comments review 3274:

- Fixed typo CalculatorThrowsExceptions --> CalculatorThrowsException

WTI-1842

    • -2
    • +2
    ./Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismAssemblyFactoryTest.cs
  1. … 17 more files in changeset.
Remove failure mechanism specific helpers WTI-1839

    • -93
    • +0
    ./Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismHelperTest.cs
    • -2
    • +1
    ./Ringtoets.ClosingStructures.Data.Test/Ringtoets.ClosingStructures.Data.Test.csproj
  1. … 55 more files in changeset.
Rename use manual property WTI-1839

    • -7
    • +7
    ./Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismAssemblyFactoryTest.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismHelperTest.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultTest.cs
    • -9
    • +9
    ./Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
    • -16
    • +16
    ./Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
    • -2
    • +2
    ./Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructuresFailureMechanismSectionResultUpdateStrategyTest.cs
  1. … 10 more files in changeset.