Riskeer / Ringtoets

ClosingStructures

Clone Tools

Stats

Commits this week: 0
Total Committers: 8
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 01 Aug 2018
1:40 pm

Carlos Lubbers

Update test name WTI-1751

Options
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismTest.cs
  2. … 17 more files in changeset.
Tuesday 31 Jul 2018
3:10 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed HBL file path as constructor argument from the CalculationActivity

- Performed for ClosingStructures

- Removed because of:

-- Constructor argument assessment section contains all information that's required

-- there's currently no check on the assessment section level which causes an argument null exception when an activity is created while there's no HB database is selected.

WTI-1720

Options
    • -10
    • +1
    ./src/Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationActivity.cs
    • -1
    • +0
    ./src/Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationActivityFactory.cs
    • -23
    • +3
    ./test/Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationActivityTest.cs
Wednesday 25 Jul 2018
2:37 pm

Carlos Lubbers

Refactor section (result) clearing, now uses a template method. WTI-1751

Options
    • -2
    • +1
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanism.cs
    • -3
    • +1
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismTest.cs
  3. … 39 more files in changeset.
1:29 pm

Carlos Lubbers

Fix failing tests and cleanup WTI-1751

Options
    • -8
    • +8
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresScenariosViewTest.cs
  2. … 13 more files in changeset.
11:33 am

Carlos Lubbers

Use new test helper in tests WTI-1751

Options
    • -1
    • +2
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresScenariosViewTest.cs
  2. … 13 more files in changeset.
11:24 am

Carlos Lubbers

Use new test helper in tests WTI-1751

Options
    • -3
    • +3
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismAssemblyFactoryTest.cs
    • -2
    • +2
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresInputContextPropertiesTest.cs
    • -2
    • +2
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismViewTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresScenariosViewTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.IO.Test/Configurations/ClosingStructuresCalculationConfigurationImporterTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructureReplaceDataStrategyTest.cs
    • -2
    • +2
    ./test/Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructureUpdateDataStrategyTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationContextTreeNodeInfoTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -3
    • +3
    ./test/Ringtoets.ClosingStructures.Service.Test/ClosingStructureDataSynchronizationServiceTest.cs
    • -2
    • +2
    ./test/Ringtoets.ClosingStructures.Util.Test/ClosingStructuresHelperTest.cs
  13. … 116 more files in changeset.
10:37 am

Carlos Lubbers

Rename AddSections to SetSections WTI-1751

Options
    • -3
    • +3
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismAssemblyFactoryTest.cs
    • -2
    • +2
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresInputContextPropertiesTest.cs
    • -2
    • +2
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismViewTest.cs
    • -2
    • +2
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresScenariosViewTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.IO.Test/Configurations/ClosingStructuresCalculationConfigurationImporterTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructureReplaceDataStrategyTest.cs
    • -2
    • +2
    ./test/Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructureUpdateDataStrategyTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationContextTreeNodeInfoTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -3
    • +3
    ./test/Ringtoets.ClosingStructures.Service.Test/ClosingStructureDataSynchronizationServiceTest.cs
    • -2
    • +2
    ./test/Ringtoets.ClosingStructures.Util.Test/ClosingStructuresHelperTest.cs
  13. … 128 more files in changeset.
Tuesday 24 Jul 2018
3:43 pm

Carlos Lubbers

Fix compilation errors in tests WTI-1751

Options
    • -17
    • +23
    ./test/Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructureUpdateDataStrategyTest.cs
    • -18
    • +26
    ./test/Ringtoets.ClosingStructures.Service.Test/ClosingStructureDataSynchronizationServiceTest.cs
  3. … 12 more files in changeset.
2:07 pm

Carlos Lubbers

Fix compilation errors in tests WTI-1751

Options
    • -6
    • +12
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresScenariosViewTest.cs
    • -2
    • +4
    ./test/Ringtoets.ClosingStructures.IO.Test/Configurations/ClosingStructuresCalculationConfigurationImporterTest.cs
    • -4
    • +7
    ./test/Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructureReplaceDataStrategyTest.cs
  4. … 16 more files in changeset.
1:57 pm

Carlos Lubbers

Fix compilation errors in tests WTI-1751

Options
    • -4
    • +7
    ./test/Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresInputContextPropertiesTest.cs
    • -7
    • +13
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismViewTest.cs
    • -2
    • +5
    ./test/Ringtoets.ClosingStructures.Service.Test/ClosingStructureDataSynchronizationServiceTest.cs
    • -2
    • +8
    ./test/Ringtoets.ClosingStructures.Util.Test/ClosingStructuresHelperTest.cs
  5. … 24 more files in changeset.
1:29 pm

Carlos Lubbers

Fix compilation errors in failure mechanism tests WTI-1751

Options
    • -8
    • +14
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismTest.cs
  2. … 16 more files in changeset.
1:06 pm

Carlos Lubbers

Fix compilation errors in tests WTI-1751

Options
    • -3
    • +12
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismAssemblyFactoryTest.cs
    • -1
    • +4
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationContextTreeNodeInfoTest.cs
    • -2
    • +5
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs
  4. … 25 more files in changeset.
Monday 23 Jul 2018
5:06 pm

Carlos Lubbers

Merge branch 'master' into 1722

# Conflicts:

# Ringtoets/Storage/src/Ringtoets.Storage.Core/Read/FailureMechanismEntityReadExtensions.cs

# Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/ClosingStructures/ClosingStructuresFailureMechanismCreateExtensionsTest.cs

# Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/DuneErosion/DuneErosionFailureMechanismCreateExtensionsTest.cs

# Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/FailureMechanismCreateExtensionsTest.cs

# Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/GrassCoverErosionInwards/GrassCoverErosionInwardsFailureMechanismCreateExtensionsTest.cs

# Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/GrassCoverErosionOutwards/GrassCoverErosionOutwardsFailureMechanismCreateExtensionsTest.cs

# Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/GrassCoverSlipOffInwards/GrassCoverSlipOffInwardsFailureMechanismCreateExtensionsTest.cs

# Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/GrassCoverSlipOffOutwards/GrassCoverSlipOffOutwardsFailureMechanismCreateExtensionsTest.cs

# Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/HeightStructures/HeightStructuresFailureMechanismCreateExtensionsTest.cs

# Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/MacroStabilityInwards/MacroStabilityInwardsFailureMechanismCreateExtensionsTest.cs

# Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/MacrostabilityOutwards/MacroStabilityOutwardsFailureMechanismCreateExtensionsTest.cs

# Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/Microstability/MicrostabilityFailureMechanismCreateExtensionsTest.cs

# Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/Piping/PipingFailureMechanismCreateExtensionsTest.cs

# Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/PipingStructure/PipingStructureFailureMechanismCreateExtensionsTest.cs

# Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/StabilityPointStructures/StabilityPointStructuresFailureMechanismCreateExtensionsTest.cs

# Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/StabilityStoneCover/StabilityStoneCoverFailureMechanismCreateExtensionsTest.cs

# Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/StrengthStabilityLengthwise/StrengthStabilityLengthwiseConstructionFailureMechanismCreateExtensionsTest.cs

# Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/TechnicalInnovation/TechnicalInnovationFailureMechanismCreateExtensionsTest.cs

# Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/WaterPressureAsphaltCover/WaterPressureAsphaltCoverFailureMechanismCreateExtensionsTest.cs

# Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/WaveImpactAsphaltCover/WaveImpactAsphaltCoverFailureMechanismCreateExtensionsTest.cs

Options
    • -47
    • +5
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationContextTreeNodeInfoTest.cs
    • -73
    • +17
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs
  3. … 30 more files in changeset.
Thursday 19 Jul 2018
1:19 pm

Elmar Kleijn

Review related changes. WTI-1732

Options
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationContextTreeNodeInfoTest.cs
  2. … 6 more files in changeset.
1:19 pm

Elmar Kleijn

Review related changes. WTI-1732

Options
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationContextTreeNodeInfoTest.cs
  2. … 6 more files in changeset.
Tuesday 03 Jul 2018
3:14 pm

Carlos Lubbers

Implement review comments, improve tests and move methods in plugins WTI-1740

Options
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
    • -10
    • +9
    ./test/Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationActivityFactoryTest.cs
  3. … 5 more files in changeset.
Monday 02 Jul 2018
2:44 pm

Carlos Lubbers

Improve/fix tests WTI-1743

Options
    • -1
    • +2
    ./test/Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationActivityFactoryTest.cs
  2. … 2 more files in changeset.
1:55 pm

Carlos Lubbers

Make closing structures calculation activity internal and use it where needed WTI-1742

Options
    • -18
    • +10
    ./src/Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationActivity.cs
    • -1
    • +3
    ./src/Ringtoets.ClosingStructures.Service/Properties/AssemblyInfo.cs
    • -8
    • +29
    ./test/Ringtoets.ClosingStructures.Integration.Test/ClosingStructuresCalculationActivityIntegrationTest.cs
1:29 pm

Carlos Lubbers

Introduce factory for closing structure calculation activities WTI-1742

Options
    • -0
    • +133
    ./src/Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationActivityFactory.cs
    • -0
    • +1
    ./src/Ringtoets.ClosingStructures.Service/Ringtoets.ClosingStructures.Service.csproj
    • -0
    • +312
    ./test/Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationActivityFactoryTest.cs
    • -0
    • +1
    ./test/Ringtoets.ClosingStructures.Service.Test/Ringtoets.ClosingStructures.Service.Test.csproj
Tuesday 26 Jun 2018
9:53 am

Carlos Lubbers

Remove contribution check from closing structures WTI-1755

Options
    • -9
    • +4
    ./src/Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
    • -46
    • +4
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationContextTreeNodeInfoTest.cs
    • -66
    • +9
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -46
    • +0
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresFailureMechanismContextTreeNodeInfoTest.cs
Monday 25 Jun 2018
12:03 pm

Dennis Tang <dennis.tang@deltares.nl>

Committed rename changes Note: compiling erros in the tests and testutils are still present

Options
    • -3
    • +3
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismAssemblyFactoryTest.cs
    • -3
    • +3
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresInputContextPropertiesTest.cs
    • -4
    • +4
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismViewTest.cs
    • -3
    • +3
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresScenariosViewTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.IO.Test/Configurations/ClosingStructuresCalculationConfigurationImporterTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructureReplaceDataStrategyTest.cs
    • -3
    • +3
    ./test/Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructureUpdateDataStrategyTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationContextTreeNodeInfoTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -6
    • +6
    ./test/Ringtoets.ClosingStructures.Service.Test/ClosingStructureDataSynchronizationServiceTest.cs
    • -2
    • +2
    ./test/Ringtoets.ClosingStructures.Util.Test/ClosingStructuresHelperTest.cs
  13. … 127 more files in changeset.
Friday 22 Jun 2018
3:29 pm

Carlos Lubbers

Fix failing tests for calculation treenode infos and gui services WTI-1754

Options
    • -7
    • +8
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -7
    • +8
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresFailureMechanismContextTreeNodeInfoTest.cs
  3. … 15 more files in changeset.
Thursday 21 Jun 2018
2:15 pm

Dennis Tang <dennis.tang@deltares.nl>

Changed accessor for the AddSectionResult function

Options
    • -2
    • +2
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanism.cs
  2. … 16 more files in changeset.
Wednesday 20 Jun 2018
2:55 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2977: - Remove exception messages for NotSupportedExceptions that only occur in the 'default' switch state.

WTI-1694

Options
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Service/ClosingStructuresValidationRulesRegistry.cs
  3. … 22 more files in changeset.
Tuesday 19 Jun 2018
4:45 pm

Elmar Kleijn

Fixed failing tests. WTI-1719

Options
    • -4
    • +2
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationContextTreeNodeInfoTest.cs
  2. … 3 more files in changeset.
3:43 pm

Elmar Kleijn

Fixed failing tests. WTI-1719

Options
    • -5
    • +0
    ./src/Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationActivity.cs
    • -19
    • +0
    ./test/Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationActivityTest.cs
  3. … 18 more files in changeset.
2:33 pm

Elmar Kleijn

Introduced parametered constructor for CalculatableActivity. WTI-1719

Options
    • -2
    • +5
    ./src/Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationActivity.cs
  2. … 9 more files in changeset.
1:53 pm

Elmar Kleijn

Moved CalculatableActivity to Ringtoets.Common.Service. WTI-1719

Options
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationActivity.cs
    • -0
    • +4
    ./test/Ringtoets.ClosingStructures.Integration.Test/Ringtoets.ClosingStructures.Integration.Test.csproj
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationActivityTest.cs
  4. … 32 more files in changeset.
1:28 pm

Elmar Kleijn

Renamed HydraRingActivityBase into CalculatableActivity. WTI-1719

Options
    • -3
    • +2
    ./src/Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationActivity.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationActivityTest.cs
  3. … 24 more files in changeset.
Wednesday 13 Jun 2018
1:23 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2946: - Adjusted testnames for failuremechanism section results making use of SimpleAssessmentResultType

WTI-1723

Options
    • -2
    • +2
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismAssemblyFactoryTest.cs
  2. … 3 more files in changeset.