Riskeer / Ringtoets

ClosingStructures

Clone Tools

Stats

Commits this week: 0
Total Committers: 8
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 13 Mar 2018
8:44 am

Robert Tangerman <robert.tangerman@deltares.nl>

Fix inconsistent naming. WTI-1634

Options
    • -9
    • +11
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResultAssemblyFactory.cs
    • -3
    • +3
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
    • -41
    • +41
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultAssemblyFactoryTest.cs
Monday 12 Mar 2018
11:38 am

Carlos Lubbers

Add SQLite targets to csproj files that need it WTI-1614

Options
    • -0
    • +7
    ./test/Ringtoets.ClosingStructures.Integration.Test/Ringtoets.ClosingStructures.Integration.Test.csproj
    • -0
    • +7
    ./test/Ringtoets.ClosingStructures.Plugin.Test/Ringtoets.ClosingStructures.Plugin.Test.csproj
    • -0
    • +7
    ./test/Ringtoets.ClosingStructures.Service.Test/Ringtoets.ClosingStructures.Service.Test.csproj
  4. … 31 more files in changeset.
Friday 09 Mar 2018
10:52 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2555: - Cleaned up tests - Reordened files - Corrected test calls

WTI-1632

Options
    • -13
    • +0
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
  2. … 7 more files in changeset.
Thursday 08 Mar 2018
3:21 pm

Carlos Lubbers

Review related changes WTI-1631

Paired with roberttangerman

Options
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResult.cs
    • -1253
    • +0
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs.orig
  3. … 6 more files in changeset.
1:09 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Renamed method. WTI-1634

Options
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
  2. … 7 more files in changeset.
11:39 am

Carlos Lubbers

Implement new rows in result view for piping WTI-1632

Options
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
  2. … 7 more files in changeset.
11:18 am

Robert Tangerman <robert.tangerman@deltares.nl>

Renamed DetailedAssessmentResultType to DetailedAssessmentProbabilityOnlyResultType. WTI-1634

Options
    • -2
    • +2
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResult.cs
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
    • -2
    • +2
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultAssemblyFactoryTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
    • -5
    • +5
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
  7. … 48 more files in changeset.
Wednesday 07 Mar 2018
4:21 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Updated xml docs. WTI-1631

Options
    • -2
    • +0
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
  2. … 3 more files in changeset.
2:33 pm

Carlos Lubbers

Move and unify detailed assessment errors WTI-1629

Options
    • -198
    • +198
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
  2. … 2 more files in changeset.
2:04 pm

Robert Tangerman <robert.tangerman@deltares.nl>

reshuffle properties. WTI-1631

Options
    • -40
    • +40
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
2:03 pm

Robert Tangerman <robert.tangerman@deltares.nl>

reshuffle some tests. WTI-1631

Options
    • -0
    • +1253
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs.orig
2:02 pm

Carlos Lubbers

Review related changes WTI-1629

Options
    • -2
    • +26
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
  2. … 7 more files in changeset.
12:55 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Improved assembly factory method docs. WTI-1631

Options
    • -6
    • +6
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResultAssemblyFactory.cs
  2. … 6 more files in changeset.
12:11 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup assembly factory. WTI-1631

Options
    • -3
    • +6
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultAssemblyFactoryTest.cs
  2. … 2 more files in changeset.
12:01 pm

Carlos Lubbers

Dont recreate failure mechanisms in tests WTI-1628

Options
    • -5
    • +5
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
  2. … 2 more files in changeset.
11:16 am

Carlos Lubbers

Update tests and test cases related to review comments WTI-1630 Paired with siuhintang

Options
    • -6
    • +30
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
  2. … 2 more files in changeset.
9:13 am

Dennis Tang <dennis.tang@deltares.nl>

Expanded the ClosingStructuresFailureMechanismSectionResultRow: - Cleaned up, GetSectionResultCalculation is not necessary anymore, as the error text is set in the row itself, rather than by the view.

WTI-1630

Options
    • -12
    • +0
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
    • -56
    • +2
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
9:11 am

Dennis Tang <dennis.tang@deltares.nl>

Adjusted Factory: - Pass tailor made probability in the AssembleTailorMadeAssembly result

WTI-1630

Options
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResultAssemblyFactory.cs
Tuesday 06 Mar 2018
4:53 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted view: - Implemented view to make use of all the properties as defined by the section result row

WTI-1630

Options
    • -67
    • +46
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
    • -0
    • +1
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
    • -464
    • +83
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
    • -0
    • +2
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
4:41 pm

Dennis Tang <dennis.tang@deltares.nl>

Expanded the ClosingStructuresFailureMechanismSectionResultRow: - Renamed AssessmentLayerThree to TailorMadeAssessmentProbability

WTI-1630

Options
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
    • -5
    • +5
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
4:36 pm

Dennis Tang <dennis.tang@deltares.nl>

Expanded the ClosingStructuresFailureMechanismSectionResultRow: - Added colour styling for the derived properties

WTI-1630

Options
    • -0
    • +12
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
    • -0
    • +51
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
4:13 pm

Dennis Tang <dennis.tang@deltares.nl>

Expanded the ClosingStructuresFailureMechanismSectionResultRow: - Moved error text generation for detailed assessment from view to row logic

WTI-1630

Options
    • -0
    • +17
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
    • -0
    • +242
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
3:52 pm

Dennis Tang <dennis.tang@deltares.nl>

Expanded the ClosingStructuresFailureMechanismSectionResultRow: - Added converter between the retrieval of the assembly results and the string representation of the retrieved enum values

WTI-1630

Options
    • -12
    • +40
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
    • -12
    • +22
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
3:49 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed/Adjusted failing tests in the view as effect of styling in the SectionResultRows

WTI-1630

Options
    • -125
    • +2
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
3:28 pm

Dennis Tang <dennis.tang@deltares.nl>

Expanded the ClosingStructuresFailureMechanismSectionResultRow: - Added cell styling for the when use manual assessment input is set to TRUE

WTI-1630

Options
    • -15
    • +27
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
    • -6
    • +67
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
3:17 pm

Dennis Tang <dennis.tang@deltares.nl>

Expanded the ClosingStructuresFailureMechanismSectionResultRow: - Added cell styling for the tailor made assessment input

WTI-1630

Options
    • -1
    • +2
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
    • -1
    • +37
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
3:14 pm

Dennis Tang <dennis.tang@deltares.nl>

Expanded the ClosingStructuresFailureMechanismSectionResultRow: - Added cell styling for the detailed assessment input

WTI-1630

Options
    • -1
    • +2
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
    • -0
    • +35
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
3:08 pm

Dennis Tang <dennis.tang@deltares.nl>

Expanded the ClosingStructuresFailureMechanismSectionResultRow: - Added cell styling for the simple assessment input

WTI-1630

Options
    • -0
    • +22
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
    • -20
    • +80
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
2:55 pm

Dennis Tang <dennis.tang@deltares.nl>

Expanded the ClosingStructuresFailureMechanismSectionResultRow: - Added error handling for the row when the assembly factory throws exception(s)

WTI-1630

Options
    • -48
    • +97
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
    • -0
    • +116
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
2:28 pm

Dennis Tang <dennis.tang@deltares.nl>

Expanded the ClosingStructuresFailureMechanismSectionResultRow: - Added ConstructionProperties -- Used to indicate at which columns, columnstatedefinitions are defined for - Adjusted the View to incorporate the constructionproperties

WTI-1630

Options
    • -1
    • +3
    ./src/Ringtoets.ClosingStructures.Forms/Properties/AssemblyInfo.cs
    • -3
    • +31
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
    • -2
    • +134
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
    • -17
    • +89
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs