Riskeer / Ringtoets

ClosingStructures

Clone Tools

Stats

Commits this week: 0
Total Committers: 8
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 25 Sep 2018
10:22 am

Carlos Lubbers

Cleanup WTI-1842

Options
    • -12
    • +0
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
  2. … 5 more files in changeset.
9:59 am

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup: Removed mutable properties from GetHashCode. WTI-1767

Options
    • -5
    • +0
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructure.cs
  2. … 10 more files in changeset.
Monday 24 Sep 2018
1:44 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup: Fixed some typos. WTI-1767

Options
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.IO/Configurations/ClosingStructuresCalculationConfigurationExporter.cs
  2. … 7 more files in changeset.
11:27 am

Carlos Lubbers

Improve assembly factory tests for group 1 and 2 WTI-1842

Options
    • -64
    • +27
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismAssemblyFactoryTest.cs
  2. … 5 more files in changeset.
11:19 am

Dennis Tang <dennis.tang@deltares.nl>

Adjusted the failure mechanism section calculator stub:

- Split the assembly categories input in a version for the detailed and for the tailor made assessment to prevent confusion.

WTI-1842

Options
    • -2
    • +2
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismAssemblyFactoryTest.cs
  2. … 8 more files in changeset.
Friday 21 Sep 2018
4:32 pm

Carlos Lubbers

Refactor result views, remove has manual assembly results method WTI-1839

Options
    • -6
    • +0
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
    • -47
    • +0
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
  3. … 34 more files in changeset.
4:04 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3274:

- Fixed typo CalculatorThrowsExceptions --> CalculatorThrowsException

WTI-1842

Options
    • -2
    • +2
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismAssemblyFactoryTest.cs
  2. … 17 more files in changeset.
10:05 am

Carlos Lubbers

Use new helper in views WTI-1839

Options
    • -1
    • +2
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
  2. … 17 more files in changeset.
10:02 am

Carlos Lubbers

Remove failure mechanism specific helpers WTI-1839

Options
    • -49
    • +0
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismHelper.cs
    • -1
    • +0
    ./src/Ringtoets.ClosingStructures.Data/Ringtoets.ClosingStructures.Data.csproj
    • -93
    • +0
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismHelperTest.cs
    • -2
    • +1
    ./test/Ringtoets.ClosingStructures.Data.Test/Ringtoets.ClosingStructures.Data.Test.csproj
  5. … 53 more files in changeset.
9:37 am

Carlos Lubbers

Move UseManualAssembly to base section result WTI-1839

Options
    • -5
    • +0
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResult.cs
  2. … 18 more files in changeset.
8:56 am

Carlos Lubbers

Rename use manual property WTI-1839

Options
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismAssemblyFactory.cs
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismHelper.cs
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResult.cs
    • -2
    • +2
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
    • -11
    • +11
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Plugin/FileImporters/ClosingStructuresFailureMechanismSectionResultUpdateStrategy.cs
    • -7
    • +7
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismAssemblyFactoryTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismHelperTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultTest.cs
    • -9
    • +9
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
    • -16
    • +16
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
    • -2
    • +2
    ./test/Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructuresFailureMechanismSectionResultUpdateStrategyTest.cs
  13. … 4 more files in changeset.
Thursday 20 Sep 2018
5:11 pm

Robert Tangerman <robert.tangerman@deltares.nl>

"<geen>" => "<selecteer>". WTI-1691

Options
    • -11
    • +11
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresScenariosViewTest.cs
  2. … 14 more files in changeset.
5:11 pm

Robert Tangerman <robert.tangerman@deltares.nl>

"<geen>" => "<selecteer>". WTI-1691

Options
    • -11
    • +11
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresScenariosViewTest.cs
  2. … 14 more files in changeset.
1:04 pm

Carlos Lubbers

Rename in result view tests WTI-1839

Options
    • -7
    • +7
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
  2. … 17 more files in changeset.
Wednesday 19 Sep 2018
1:31 pm

Carlos Lubbers

Rename AssessmentSectionHelper -> AssessmentSectionTestHelper WTI-1839

Options
    • -24
    • +24
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismAssemblyFactoryTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultDetailedAssessmentExtensionsTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresProbabilityAssessmentOutputFactoryTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresOutputPropertiesTest.cs
    • -27
    • +27
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/ImportInfos/ClosingStructuresCalculationGroupContextImportInfoTest.cs
    • -13
    • +13
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationContextTreeNodeInfoTest.cs
    • -14
    • +14
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -2
    • +2
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresFailureMechanismContextTreeNodeInfoTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/ViewInfos/ClosingStructuresFailureMechanismResultViewInfoTest.cs
    • -9
    • +9
    ./test/Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationActivityFactoryTest.cs
    • -41
    • +56
    ./test/Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
  13. … 129 more files in changeset.
9:01 am

Carlos Lubbers

Improve test coverage WTI-1842

Options
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismAssemblyFactoryTest.cs
  2. … 5 more files in changeset.
Tuesday 18 Sep 2018
3:40 pm

Carlos Lubbers

Rename calculatorfactory -> calculatorFactory WTI-1842

Options
    • -8
    • +8
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
  2. … 19 more files in changeset.
3:38 pm

Carlos Lubbers

Cleanup WTI-1842

Options
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
  2. … 5 more files in changeset.
10:57 am

Robert Tangerman <robert.tangerman@deltares.nl>

Removed ModelFactorSuperCriticalFlow from low sill HydraRing input. WTI-1835

Options
    • -1
    • +0
    ./src/Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
    • -2
    • +0
    ./test/Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
  3. … 3 more files in changeset.
10:24 am

Robert Tangerman <robert.tangerman@deltares.nl>

Don't show ModelFactorSuperCriticalFlow when InflowModelType is LowSill. WTI-1835

Options
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresInputContextProperties.cs
    • -13
    • +4
    ./test/Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresInputContextPropertiesTest.cs
Monday 17 Sep 2018
3:27 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Assemblageresultaat => Toetsoordeel. WTI-1838

Options
    • -7
    • +7
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
  2. … 21 more files in changeset.
2:40 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup:

- Fixed inline comment in test

WTI-1839

Options
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
  2. … 5 more files in changeset.
2:27 pm

Carlos Lubbers

Add tests to result views WTI-1842

Options
    • -18
    • +36
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
  2. … 18 more files in changeset.
1:48 pm

Dennis Tang <dennis.tang@deltares.nl>

Fixed compilation errors for groups 1 and 2:

- Added logic which determines when to set a warning

WTI-1839

Options
    • -0
    • +5
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
    • -0
    • +4
    ./test/Ringtoets.ClosingStructures.Forms.Test/Ringtoets.ClosingStructures.Forms.Test.csproj
    • -0
    • +71
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
  4. … 12 more files in changeset.
9:10 am

Carlos Lubbers

Cleanup WTI-1842

Options
    • -6
    • +3
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismAssemblyFactory.cs
  2. … 8 more files in changeset.
Friday 14 Sep 2018
3:11 pm

Carlos Lubbers

Add useManual parameter to Closing structures assembly factory methods WTI-1842

Options
    • -6
    • +15
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismAssemblyFactory.cs
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
    • -47
    • +176
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismAssemblyFactoryTest.cs
3:11 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduced failure mechanism helpers to determine if any section has manual overwritten results:

- Introduced for group 1 and 2

WTI-1839

Options
    • -0
    • +49
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismHelper.cs
    • -0
    • +1
    ./src/Ringtoets.ClosingStructures.Data/Ringtoets.ClosingStructures.Data.csproj
    • -0
    • +93
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismHelperTest.cs
    • -1
    • +2
    ./test/Ringtoets.ClosingStructures.Data.Test/Ringtoets.ClosingStructures.Data.Test.csproj
  5. … 20 more files in changeset.
Monday 10 Sep 2018
4:50 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3237:

- Changed layout of properties to maintain file order equal to the visual order in the property panel.

Paired with ~kleijn

WTI-1800

Options
    • -12
    • +12
    ./test/Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresInputContextPropertiesTest.cs
3:12 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Reorder properties. WTI-1836

Options
    • -6
    • +6
    ./src/Ringtoets.ClosingStructures.Data/GeneralClosingStructuresInput.cs
3:05 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Passed model factor long threshold to HydraRing input. WTI-1836

Options
    • -1
    • +2
    ./src/Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
    • -2
    • +4
    ./test/Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
  3. … 3 more files in changeset.