Riskeer / Ringtoets

ClosingStructures

Clone Tools

Stats

Commits this week: 0
Total Committers: 8
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 15 Feb 2018
2:34 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed mirror property SectionResults2 for ClosingStructures: - Replaced the old generic SectionResults property with the mirror property - Cleaned up XMLDocs

WTI-1621

Options
    • -1
    • +0
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanism.cs
  2. … 1 more file in changeset.
1:59 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed mirror property SectionResults2: - Replaced the old generic SectionResults property with the mirror property - Cleaned up test

WTI-1621

Options
    • -4
    • +0
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismTest.cs
1:55 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed mirror property SectionResults2: - Replaced the old generic SectionResults property with the mirror property

WTI-1621

Options
    • -17
    • +6
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanism.cs
    • -2
    • +2
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresScenariosView.cs
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
    • -2
    • +2
    ./src/Ringtoets.ClosingStructures.Util/ClosingStructuresHelper.cs
    • -7
    • +6
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresInputContextPropertiesTest.cs
    • -4
    • +4
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.IO.Test/Configurations/ClosingStructuresCalculationConfigurationImporterTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructureReplaceDataStrategyTest.cs
    • -4
    • +4
    ./test/Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructureUpdateDataStrategyTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationContextTreeNodeInfoTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresFailureMechanismContextTreeNodeInfoTest.cs
    • -11
    • +11
    ./test/Ringtoets.ClosingStructures.Plugin.Test/ViewInfos/ClosingStructuresFailureMechanismResultViewInfoTest.cs
    • -9
    • +8
    ./test/Ringtoets.ClosingStructures.Service.Test/ClosingStructureDataSynchronizationServiceTest.cs
  16. … 6 more files in changeset.
1:43 pm

Dennis Tang <dennis.tang@deltares.nl>

Simplified ClosingStructuresHelper: - Accepts a ClosingStructuresFailureMechanism now it is a dedicated implementation - Removed obsolete function arguments

WTI-1621

Options
    • -2
    • +1
    ./src/Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresInputContextProperties.cs
    • -3
    • +1
    ./src/Ringtoets.ClosingStructures.IO/Configurations/ClosingStructuresCalculationConfigurationImporter.cs
    • -9
    • +3
    ./src/Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
    • -3
    • +1
    ./src/Ringtoets.ClosingStructures.Plugin/FileImporters/ClosingStructureUpdateDataStrategy.cs
    • -12
    • +7
    ./src/Ringtoets.ClosingStructures.Service/ClosingStructuresDataSynchronizationService.cs
    • -58
    • +21
    ./src/Ringtoets.ClosingStructures.Util/ClosingStructuresHelper.cs
    • -2
    • +2
    ./test/Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructureUpdateDataStrategyTest.cs
    • -93
    • +23
    ./test/Ringtoets.ClosingStructures.Util.Test/ClosingStructuresHelperTest.cs
12:56 pm

Dennis Tang <dennis.tang@deltares.nl>

Separated the generic RingtoetsCommonDataSynchronization service implementation into specific (ClosingStructure) implementation: - Corrected calls in the corresponding Replace- and UpdateDataStrategies - Adjusted tests

WTI-1621

Options
    • -4
    • +2
    ./src/Ringtoets.ClosingStructures.Plugin/FileImporters/ClosingStructureReplaceDataStrategy.cs
    • -7
    • +5
    ./src/Ringtoets.ClosingStructures.Plugin/FileImporters/ClosingStructureUpdateDataStrategy.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructureReplaceDataStrategyTest.cs
    • -10
    • +7
    ./test/Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructureUpdateDataStrategyTest.cs
10:56 am

Dennis Tang <dennis.tang@deltares.nl>

Separated the generic RingtoetsCommonDataSynchronization service implementation into specific (ClosingStructure) implementation: - Performed for the RemoveAllStructures method

WTI-1621

Options
    • -0
    • +33
    ./src/Ringtoets.ClosingStructures.Service/ClosingStructuresDataSynchronizationService.cs
    • -0
    • +111
    ./test/Ringtoets.ClosingStructures.Service.Test/ClosingStructureDataSynchronizationServiceTest.cs
10:43 am

Dennis Tang <dennis.tang@deltares.nl>

Separated the generic RingtoetsCommonDataSynchronization service implementation into specific (ClosingStructure) implementation: - Performed for the RemoveStructure method

WTI-1621

Options
    • -0
    • +64
    ./src/Ringtoets.ClosingStructures.Service/ClosingStructuresDataSynchronizationService.cs
    • -0
    • +5
    ./src/Ringtoets.ClosingStructures.Service/Ringtoets.ClosingStructures.Service.csproj
    • -0
    • +125
    ./test/Ringtoets.ClosingStructures.Service.Test/ClosingStructureDataSynchronizationServiceTest.cs
9:48 am

Carlos Lubbers

Rename SimpleAssessmentInput->SimpleAssessmentResult WTI-1617

Options
    • -2
    • +2
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResult.cs
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResultAssemblyFactory.cs
    • -2
    • +2
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultAssemblyFactoryTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultTest.cs
Wednesday 14 Feb 2018
5:22 pm

Dennis Tang <dennis.tang@deltares.nl>

Merge branch 'master' of https://github.com/Deltares/Riskeer

# Conflicts:

# Application/Ringtoets/src/Application.Ringtoets.Setup/Licentie.rtf

# Ringtoets.sln

# Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs

Options
    • -0
    • +5
    ./src/Ringtoets.ClosingStructures.Forms/Ringtoets.ClosingStructures.Forms.csproj
    • -4
    • +11
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
    • -0
    • +17
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
    • -0
    • +31
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
  5. … 2 more files in changeset.
4:55 pm

Dennis Tang <dennis.tang@deltares.nl>

Separated the generic StructuresHelper implementation into specific (ClosingStructure) implementation: - Replaced StructuresHelperCall with the specific ClosingStructure helper implementation -- Except for the UpdateDataStrategy

WTI-1621

Options
    • -2
    • +3
    ./src/Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresInputContextProperties.cs
    • -0
    • +5
    ./src/Ringtoets.ClosingStructures.Forms/Ringtoets.ClosingStructures.Forms.csproj
    • -2
    • +3
    ./src/Ringtoets.ClosingStructures.IO/Configurations/ClosingStructuresCalculationConfigurationImporter.cs
    • -0
    • +5
    ./src/Ringtoets.ClosingStructures.IO/Ringtoets.ClosingStructures.IO.csproj
    • -6
    • +7
    ./src/Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
    • -0
    • +5
    ./src/Ringtoets.ClosingStructures.Plugin/Ringtoets.ClosingStructures.Plugin.csproj
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresInputContextPropertiesTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.IO.Test/Configurations/ClosingStructuresCalculationConfigurationImporterTest.cs
    • -0
    • +4
    ./test/Ringtoets.ClosingStructures.Plugin.Test/Ringtoets.ClosingStructures.Plugin.Test.csproj
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationContextTreeNodeInfoTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs
4:19 pm

Dennis Tang <dennis.tang@deltares.nl>

Separated the generic StructuresHelper implementation into specific (ClosingStructure) implementation

WTI-1621

Options
    • -0
    • +124
    ./src/Ringtoets.ClosingStructures.Util/ClosingStructuresHelper.cs
    • -0
    • +23
    ./src/Ringtoets.ClosingStructures.Util/Ringtoets.ClosingStructures.Util.csproj
    • -0
    • +187
    ./test/Ringtoets.ClosingStructures.Util.Test/ClosingStructuresHelperTest.cs
    • -0
    • +31
    ./test/Ringtoets.ClosingStructures.Util.Test/Ringtoets.ClosingStructures.Util.Test.csproj
    • -0
    • +26
    ./test/Ringtoets.ClosingStructures.Util.Test/packages.config
2:19 pm

Elmar Kleijn

Review related changes

WTI-1531

Options
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Data/GeneralClosingStructuresInput.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/PropertyInfos/ClosingStructuresFailureMechanismContextPropertyInfoTest.cs
  3. … 12 more files in changeset.
2:19 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduced Util project for closing structures: - Required to separate the generic StructuresHelper implementation into specific (ClosingStructure) implementation

WTI-1621

Options
    • -0
    • +25
    ./src/Ringtoets.ClosingStructures.Util/Properties/AssemblyInfo.cs
    • -0
    • +21
    ./src/Ringtoets.ClosingStructures.Util/Ringtoets.ClosingStructures.Util.csproj
    • -0
    • +25
    ./test/Ringtoets.ClosingStructures.Util.Test/Properties/AssemblyInfo.cs
    • -0
    • +21
    ./test/Ringtoets.ClosingStructures.Util.Test/Ringtoets.ClosingStructures.Util.Test.csproj
  5. … 2 more files in changeset.
2:07 pm

Carlos Lubbers

Rename some resources WTI-1617

Options
    • -2
    • +2
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
  2. … 21 more files in changeset.
1:29 pm

Elmar Kleijn

Review related changes

WTI-1531

Options
    • -2
    • +1
    ./test/Ringtoets.ClosingStructures.Data.Test/GeneralClosingStructuresInputTest.cs
  2. … 6 more files in changeset.
1:23 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Moved SimpleAssessmentResult types to Ringtoets.Common.Primitives. WTI-1616

Options
    • -0
    • +1
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResult.cs
    • -0
    • +5
    ./src/Ringtoets.ClosingStructures.Data/Ringtoets.ClosingStructures.Data.csproj
    • -0
    • +5
    ./src/Ringtoets.ClosingStructures.Forms/Ringtoets.ClosingStructures.Forms.csproj
    • -0
    • +1
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
    • -0
    • +1
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultAssemblyFactoryTest.cs
    • -0
    • +1
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultTest.cs
    • -0
    • +4
    ./test/Ringtoets.ClosingStructures.Data.Test/Ringtoets.ClosingStructures.Data.Test.csproj
  8. … 186 more files in changeset.
1:11 pm

Carlos Lubbers

Remove AssessmentLayerOne from the base section result row class WTI-1617

Options
    • -0
    • +17
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
    • -0
    • +31
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
  3. … 7 more files in changeset.
12:00 pm

Dennis Tang <dennis.tang@deltares.nl>

Rewired SectionResult to the mirror property SectionResult2 for ClosingStructures in Forms: - Adjusted ScenarioRow and the view

WTI-1621

Options
    • -3
    • +3
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresScenarioRow.cs
    • -2
    • +2
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresScenariosView.cs
    • -3
    • +3
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresScenarioRowTest.cs
11:59 am

Carlos Lubbers

Rename AssessmentLayerOneColumnIndex -> SimpleAssessmentColumnIndex WTI-1617

Options
    • -2
    • +2
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
  2. … 18 more files in changeset.
11:59 am

Robert Tangerman <robert.tangerman@deltares.nl>

Moved all data objects from Ringtoets.Common.Data.AssemblyTool to Ringtoets.AssemblyTool.Data. WTI-1616

Options
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResultAssemblyFactory.cs
    • -0
    • +5
    ./src/Ringtoets.ClosingStructures.Data/Ringtoets.ClosingStructures.Data.csproj
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultAssemblyFactoryTest.cs
    • -0
    • +4
    ./test/Ringtoets.ClosingStructures.Data.Test/Ringtoets.ClosingStructures.Data.Test.csproj
  5. … 99 more files in changeset.
11:49 am

Dennis Tang <dennis.tang@deltares.nl>

Rewired SectionResult to the mirror property SectionResult2 for ClosingStructures in Data: - Adjusted the 2aAssessementResultExtensions - Adjusted Forms classes that depend on the extension method: -- Fixed compilation errors and tests for the failure mechanism result view

WTI-1621

Options
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSection2aAssessmentResultExtensions.cs
    • -4
    • +4
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
    • -5
    • +5
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
    • -2
    • +2
    ./src/Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
    • -6
    • +5
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSection2aAssessmentResultExtensionsTest.cs
    • -30
    • +31
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
    • -10
    • +10
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
    • -2
    • +2
    ./test/Ringtoets.ClosingStructures.Plugin.Test/ClosingStructuresPluginTest.cs
    • -16
    • +17
    ./test/Ringtoets.ClosingStructures.Plugin.Test/ViewInfos/ClosingStructuresFailureMechanismResultViewInfoTest.cs
11:32 am

Carlos Lubbers

Rename resource and remove method from base result view. WTI-1617

Options
    • -1
    • +7
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
  2. … 22 more files in changeset.
10:43 am

Dennis Tang <dennis.tang@deltares.nl>

Introduced mirror property for ClosingStructures failure mechanism: - Used to remove the generic failure mechanism section result step by step

WTI-1621

Options
    • -0
    • +12
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanism.cs
    • -0
    • +6
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismTest.cs
Tuesday 13 Feb 2018
1:46 pm

Dennis Tang <dennis.tang@deltares.nl>

Implemented Factory to create assembly tool results for ClosingStructures

WTI-1620

Options
    • -0
    • +67
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResultAssemblyFactory.cs
    • -0
    • +6
    ./src/Ringtoets.ClosingStructures.Data/Ringtoets.ClosingStructures.Data.csproj
    • -0
    • +120
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultAssemblyFactoryTest.cs
    • -0
    • +9
    ./test/Ringtoets.ClosingStructures.Data.Test/Ringtoets.ClosingStructures.Data.Test.csproj
12:55 pm

Carlos Lubbers

Reverse parameters in closing structures result view WTI-1617

Options
    • -3
    • +3
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
    • -3
    • +2
    ./src/Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
    • -7
    • +4
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
    • -7
    • +7
    ./test/Ringtoets.ClosingStructures.Plugin.Test/ViewInfos/ClosingStructuresFailureMechanismResultViewInfoTest.cs
11:48 am

Carlos Lubbers

Reverse order of (type) parameters for FailureMechanismResultView WTI-1617

Options
    • -2
    • +2
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
    • -1
    • +2
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
  3. … 38 more files in changeset.
Monday 12 Feb 2018
4:33 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed autoproperty tests

WTI-1617

Options
    • -18
    • +0
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultTest.cs
  2. … 1 more file in changeset.
4:23 pm

Dennis Tang <dennis.tang@deltares.nl>

- Added SimpleAssemblyInput property on the ClosingStructures failure mechanism section result to hold the input of a simple assembly for the assembly tool. -- Made explicit implementations for the structures

WTI-1617

Options
    • -0
    • +77
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResult.cs
    • -0
    • +1
    ./src/Ringtoets.ClosingStructures.Data/Ringtoets.ClosingStructures.Data.csproj
    • -0
    • +106
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultTest.cs
    • -0
    • +1
    ./test/Ringtoets.ClosingStructures.Data.Test/Ringtoets.ClosingStructures.Data.Test.csproj
4:17 pm

Carlos Lubbers

Re-add assessment layer one column to all views to maintain old functionality WTI-1617

Options
    • -0
    • +15
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
  2. … 17 more files in changeset.
1:36 pm

Carlos Lubbers

Start adding new simple assessment column to result view tables WTI-1617

Options
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
  2. … 28 more files in changeset.