IllustrationPoints

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Implement review comments, update XMLDocs, improve tests, move some values of resources and improve their names. Related to Issue [WTI-1391]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12037 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 21483bef12f061dd693853d6e33a8aefedfda574

Former-commit-id: 6a3f33b230f7364d277d7045a995e94a9540b0d6

  1. … 19 more files in changeset.
Rename AnyNonDistinct to HasDuplicates, also adapt test(helper) names. Related to Issue [WTI-1391]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11956 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1abe5ec281a7f33d85e8c49d85aef49802f2dc0e

Former-commit-id: 85b88e9b1beadf3b34e0bced7087d480709b0fb9

  1. … 19 more files in changeset.
Change error log to warning and change text. Remove groupby call from AnyNonDistinct. Related to Issue [WTI-1391]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11950 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 662e9d82dfe0817a67d821e7784be330adc47eff

Former-commit-id: d2d886b12d819750c93a66f77a090466fbf69658

  1. … 17 more files in changeset.
Implement validation in structures, waveheight and designwaterlevel calculation with corresponding tests. Improve GeneralResult validation with stochast check for toplevel submechanism points. Adapt old tests so they will pass. Related to Issue [WTI-1391]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11940 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7c5475baca39b2e50fd92cffcd066cb90035b84d

Former-commit-id: 7371f7aa9c2fe4da40051f708686731a7b20ad61

  1. … 12 more files in changeset.
Create GeneralResultTestFactory, add more tests for all calculations in GrassCoverErosionInwardsCalculationServiceTest. Update XMLDocs Related to Issue [WTI-1391]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11935 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3952c6f76f0de1ee05e376b80a2b8817fabd4ce2

Former-commit-id: 0082f5ae471b9ca5f19ddab584c447271cc4e406

  1. … 6 more files in changeset.
Implement validation in the data model, add tests to data model and started adding tests to calculator services. Old tests have been adapted to create valid generalresult/faulttrees so they won't throw exceptions when creating them. Related to Issue [WTI-1391]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11925 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 50fbd65dee53f455a510032c25787207ef0332d9

Former-commit-id: 89df2cfd12e7ddc527716a82d3325da29e8bfaef

  1. … 36 more files in changeset.
Add duplication check to GeneralResult for Stochasts and TopLevelIllustrationPoints Related to Issue [WTI-1391]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11881 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e89c79ccda401aa8e57d3ce4710f78f07c978b9d

Former-commit-id: 2da9469e287d7de825dd3f47783a20aae505a5a2

  1. … 11 more files in changeset.
Ensured enumerations are directly evaluated during clone Related to Issue [WTI-1365]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11365 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 87d4754b4f8d59c83c433c9fdc721ec296e225e9

Former-commit-id: 3620c9e1332623da8fb6804dfd934afa24872335

  1. … 1 more file in changeset.
Made GeneralResult ICloneable Related to Issue [WTI-1370]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11139 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 58b1e5c0d5127bb53683f65be588623b4f053197

Former-commit-id: a39dfdc60bce66cd6a22f1c9c939065d6f49f910

  1. … 2 more files in changeset.
Made TopLevelFaultTreeIllustrationPoint ICloneable Related to Issue [WTI-1370]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11138 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b8495e0078e8d5a3ff5bdca670976dd3d6861803

Former-commit-id: 4fbdb41f853ac31e49e3ea7d2d3f84d237d5a797

    • -2
    • +11
    ./TopLevelFaultTreeIllustrationPoint.cs
  1. … 2 more files in changeset.
Made IllustrationPointNode ICloneable Related to Issue [WTI-1370]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11137 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 90284e34f8ab813499d52fe50f275ad3a687e73b

Former-commit-id: a62639dad657fa2f6872a8ff83baacbaf15599b0

  1. … 2 more files in changeset.
Made TopLevelSubMechanismIllustrationPoint ICloneable Related to Issue [WTI-1370]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11136 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: cd7330926a35e0e3b2892dc7cbfb63378c90992c

Former-commit-id: 6456c035f61c2f2b239b8b63ebf5370ea1ac24ac

    • -1
    • +10
    ./TopLevelSubMechanismIllustrationPoint.cs
  1. … 2 more files in changeset.
Made FaultTreeIllustrationPoint ICloneable Related to Issue [WTI-1370]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11135 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b48a9043e776a073f7e4e4d272fbf078bebbeefb

Former-commit-id: b64d75b559c26f0ca678339b240e779bac912ddd

  1. … 2 more files in changeset.
Made SubMechanismIllustrationPoint ICloneable Related to Issue [WTI-1370]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11132 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c062dd5ff34ee3c930d385d29d16613758d5300c

Former-commit-id: e18064836f921881a77abeb065ae7daa701aad01

  1. … 2 more files in changeset.
Made IllustrationPointBase ICloneable Related to Issue [WTI-1370]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11131 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4ef94ebc1f903b55bf08ed23f4e85d0ecaf6464f

Former-commit-id: 3102f64e875bd0ba94e1fff2f41ad427def00f33

  1. … 2 more files in changeset.
Made IllustrationPointResult ICloneable

Related to Issue [WTI-1370]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11130 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ff5dbb2ee1ea181747bd673c2ea67294aa416ead

Former-commit-id: f88d38d5850250e6391094820969720a7b1ab0e0

  1. … 2 more files in changeset.
Made TopLevelIllustrationPointBase ICloneable Related to Issue [WTI-1370]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11129 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 50a119918ebd3183a48952e8c2697b6faedd5d71

Former-commit-id: 6c4461e744d9a52b582122a884d42ddab6726a0a

  1. … 3 more files in changeset.
Made Stochast ICloneable Related to Issue [WTI-1370]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11127 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1fbdf83283e68fbfe022bd978cb21ca608d75038

Former-commit-id: 2e99ef6513fdac42bfd63e142e99403968ca9d71

  1. … 2 more files in changeset.
Made WindDirection ICloneable Related to Issue [WTI-1370]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11126 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3d044136ac1a955ac25cb8940f2facfc2cbe9df6

Former-commit-id: 6eaf700a9d1f6557db83ced2b3b8463741f16e79

  1. … 2 more files in changeset.
Incorporated comments review 1959: Relevant comments for illustration point fault tree data model and forms projects - Updated XMLDocs - Converted new Tuple --> Tuple.Create - Inverted if statement in data model for the fault treenode related class - Adjusted IllustrationPointControlItems: -- wraps a TopLevelIllustrationPointBase instead of an object to prevent information loss and casts -- Adjusted helper, use distinct instead of array retrievals to have the same logic as its property class -- Removed NULL item verification in the collection from the helper class - Simplified and added missing tests Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10819 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f6dd317f5156d8dccc68fee462606c00c3fb72cb

Former-commit-id: 3ef18114114da459468058dd2e136728a4c2d0f9

  1. … 23 more files in changeset.
Incorporated comments review 1959: - Relevant comments for illustration point fault tree data model and some XMLDocs -- Updated XMLDocs and string values -- Removed redundant code: --- Data model is not responsible for checking the validity of enum values --- Removed redundant null checks -- Simplified tests

Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10816 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2a0c2e2180367365375f19171402c4b9aa886b82

Former-commit-id: 72f7a5d8fc62e3a2bd8432d47d4e5c2e3db62ac4

    • -10
    • +2
    ./TopLevelFaultTreeIllustrationPoint.cs
    • -8
    • +0
    ./TopLevelSubMechanismIllustrationPoint.cs
  1. … 15 more files in changeset.
Changed CombinationType values to start at 1 Related to Issue [WTI-1309]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10723 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: edc77dcb320d9071ce39ccedbd6c356001bf5165

Former-commit-id: 1e8545f6451bf6548e0f3e571f564f4d2fc7d35a

  1. … 4 more files in changeset.
Added validation that child count of HydraRingIllustrationPointTreeNode must be 0 or 2. Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10701 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1d10d09048cace62e57818f6744c2c3e20c6bba1

Former-commit-id: 945e83f3e6f257b7502121a40cfa2787434ed93a

  1. … 9 more files in changeset.
Refactored GeneralResultSubMechanismIllustrationPoint: - Removed class in favor of the GeneralResult<T> - Renamed files when appropriate - Removed obsolete extensions, these are replaced by internal logic based on strings of the wrapper IllustrationPointControlItem on the calling side Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10687 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 65bcd4295ccbcbfc85ffe45740c5877d9c0a8352

Former-commit-id: c9de3cb8e9980d93fb413ad1e598c7795816ffdd

    • -78
    • +0
    ./GeneralResultSubMechanismIllustrationPoint.cs
    • -51
    • +0
    ./GeneralResultSubMechanismIllustrationPointExtensions.cs
  1. … 50 more files in changeset.
Renamed FaultTreeIllustrationPointNode to IllustrationPointNode. Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10685 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 675f66ab164f678566acc665917f38aafc0e641d

Former-commit-id: ac2a381ce94b7f77008ff10e9f6c33e3a1cc7880

    • -88
    • +0
    ./FaultTreeIllustrationPointNode.cs
    • -0
    • +88
    ./IllustrationPointNode.cs
    • -2
    • +2
    ./TopLevelFaultTreeIllustrationPoint.cs
  1. … 5 more files in changeset.
Separated GeneralResult from the IllustrationPointControl classes: - Introduced an intermediate data object IllustrationPointControlItem - Introduced IComparer for the aforementioned dataobject to compare collections of items (relevant for view tests) Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10682 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1466bf574f0b6e9ab46ff0fe9017dad55a9ce4f8

Former-commit-id: b24c182da59308acbc293ea43b935678116bb099

  1. … 32 more files in changeset.
Incorporated comments review 1942: Improvements on RT codebase: - Updated XMLDocs: made submechanism --> sub mechanism - Simplified converter test by inlining

Related to Issue [WTI-1305]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10647 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bdd6384633ed0471eecafeaf81d95055e54ee1d0

Former-commit-id: 3ddeddeab3bb6e3839c2e78cb070161951b086a5

    • -1
    • +1
    ./GeneralResultSubMechanismIllustrationPoint.cs
    • -2
    • +2
    ./TopLevelSubMechanismIllustrationPoint.cs
  1. … 10 more files in changeset.
Improvements after review. Related to Issue [WTI-1306]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10617 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6bf9363dec6e0f77c3b78aebb4f474a45adec3eb

Former-commit-id: a1ff9279f1d052510ab4c61e9153afe04bf2ee06

    • -2
    • +2
    ./GeneralResultSubMechanismIllustrationPointExtensions.cs
  1. … 28 more files in changeset.
- Introduced GeneralResult as a root element for the illustration point results - Cleaned up tests, used the WindDirection factory instead of constructing arbitrary wind directions every time Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10611 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7aded1343b69ffa66a055c92c8d8cedeefe6d044

Former-commit-id: 667168681911f4f5ef4d4a5a2b4cb4c399958ff4

  1. … 4 more files in changeset.
Introduced TopLevelIllustrationPointBase as a common base class between the TopLevelFaultTreeIllustrationPoint and TopLevelSubMechanismIllustrationPoint for storing the combination of every wind direction, closing situation and the corresponding illustration points

Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10607 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 508092aff701dac6d1d1bac24df48172dd44080b

Former-commit-id: 39c65d1551c8597dfc6bab6c2c20720865cbd091

    • -13
    • +2
    ./TopLevelFaultTreeIllustrationPoint.cs
    • -0
    • +64
    ./TopLevelIllustrationPointBase.cs
    • -14
    • +3
    ./TopLevelSubMechanismIllustrationPoint.cs
  1. … 5 more files in changeset.