Riskeer / Ringtoets / Common / src / Ringtoets.Common.IO

ReferenceLines

Clone Tools

Stats

Commits this week: 0
Total Committers: 7
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 06 Jan 2017
4:15 pm

Dennis Tang <dennis.tang@deltares.nl>

- Added NotifyProgress calls when adding data to the data model - Synchronised message values across all the importers

Note:

No tests are available to verify the cancel behaviour for the FeatureBasedMapData because it has no NotifyProgress (and consequently no SetProgress handle to set the Action it should execute during the import)

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7655 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ee82e9d839a1acfffb0ccb4ff219a30856c744e7

Former-commit-id: a79f8f2e64e63d1e9bac5672052dc8bc143bf91f

Options
    • -1
    • +1
    ./ReferenceLineImporter.cs
  2. … 18 more files in changeset.
1:17 pm

Dennis Tang <dennis.tang@deltares.nl>

Merged revision(s) 7595-7638 from branches/WTI-490:

Merged revision(s) 7537-7594 from trunk

........

Initial commit of changes from kleijn:

- Removed HandleUserCancellingImport: FileImporter should not decide on its own how to handle Canceled actions. Consequently removed the messages that are generated by these handles

- Added logic to the importers: Cancelling is not possible when putting data on the data model. Action will always execute when it is in this stage

- Added branching paths in the activity: Import() returns false when it has failed or is cancelled

Note: failing tests will be fixed in following commits

........

Fixed tests of the FileImporterBase and Activity:

- Checks on the states are made for the 4 different paths of the Import:

-- Import successful, canceled or not

-- Import not successful, canceled or not

- Moved logging from the activity to the importer

- Added tests to assert mentioned behaviour

........

Fixed tests of the PipingSurfaceLinesCsvImporter:

- Added test to verify behaviour when canceling at the two stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Added resource value for the ImportActivity (missing file commit)

........

Fixed tests of the PipingSoilProfilesImporter:

- Added test to verify behaviour when canceling at the three stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Cleaned redundant brackets

........

Fixed tests of the StructuresImporter:

- Added test to verify behaviour when canceling at the two stages during the import. Test regarding cancelling while Creating structures is missing

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

Adjusted test in PipingSoilProfilesImporterTest

- Changed initial value of the result to make clear that the value is set correctly

........

Fixed tests of the ProfilesImporters:

- Added test to verify behaviour when canceling at the two stages during the import. Test regarding cancelling while Creating structures is missing

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Removed obsolete Cancel call in the PipingSoilProfilesImporterTest

........

FileImporters should call Observers in case the import was successfull AND was cancelled at an uncancellable stage.

Note: test is missing to verify this behaviour

........

Fixed tests of the ProfilesImporters:

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Temporarily removed the Cancel tests, because the FeatureBasedMapDataImporter does not have a handle for NotifyProgress. Hence, Cancel method cannot be invoked when Import is running.

........

Fixed tests of the FailureMechanismSectionsImporter:

- Added test to verify behaviour when canceling at the three stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Cleaned up tests in the StructuresImporterTest

........

Fixed tests of the ReferenceLineImporter:

- Added test to verify behaviour when canceling at the two stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

........

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7646 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1c355702dfbd410c7c4733529d8db9e243496eba

Former-commit-id: 75c614862d018947936ef85e3775a125c425c032

Options
    • -17
    • +8
    ./ReferenceLineImporter.cs
  2. … 26 more files in changeset.
8:21 am

Dennis Tang <dennis.tang@deltares.nl>

Fixed tests of the ReferenceLineImporter: - Added test to verify behaviour when canceling at the two stages during the import - Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/WTI-490@7638 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 19a87c098521b229e4db615cca959bf60833a879

Former-commit-id: 5d08cb600da99361dde2bcf491347ed73ef603fc

Options
    • -3
    • +7
    ./ReferenceLineImporter.cs
  2. … 1 more file in changeset.
Wednesday 04 Jan 2017
2:01 pm

Dennis Tang <dennis.tang@deltares.nl>

Initial commit of changes from kleijn: - Removed HandleUserCancellingImport: FileImporter should not decide on its own how to handle Canceled actions. Consequently removed the messages that are generated by these handles - Added logic to the importers: Cancelling is not possible when putting data on the data model. Action will always execute when it is in this stage - Added branching paths in the activity: Import() returns false when it has failed or is cancelled

Note: failing tests will be fixed in following commits

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/WTI-490@7598 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 409bfee1e3deebb4fe4368cb7010a8c4c37dae5e

Former-commit-id: 98175da77f6910f259097a90626bbb10450e2c8f

Options
    • -14
    • +1
    ./ReferenceLineImporter.cs
  2. … 20 more files in changeset.
Thursday 29 Dec 2016
3:18 pm

bouvrie <bouvrie@example.com>

* Extended IReferenceLineReplaceHandler with DoPostReplacementUpdates to allow for actions to be resolved after the replacement of the ReferenceLine took place. ** Main reason behind this architectural choice, is allowing for UI updates from non-UI threads. ** ReferenceLineImporter makes use of this new method in the DoPostImportUpdates method. * ReferenceLineReplaceHandler now keeps track of deleted objects and closes views for those objects in the DoPostReplacementUpdates method. ** Introduced ClearResults class for this purpose. ** Updated DataSynchronisationService methods related to replacing the ReferenceLine and now keep track of both changed objects as well as removed objects. * Cleanup in some commands to use IViewCommands. Related to Issue [WTI-1034]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7494 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 239f69a11ed199f938d5dd31e76f60772ad40072

Former-commit-id: 9cb0286bb78c272cc2d2cb43b703d0fc9ad386f3

Options
    • -0
    • +5
    ./IReferenceLineReplaceHandler.cs
    • -0
    • +6
    ./ReferenceLineImporter.cs
  3. … 55 more files in changeset.
Friday 23 Dec 2016
11:14 am

Robert Tangerman <robert.tangerman@deltares.nl>

Changes after review. Related to Issue [WTI-1016]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7421 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7eea8f3346f21c5f0ae2283c6d7eeb94f731f07c

Former-commit-id: 3cd3e2fe4ed82c29d50bcd0f2aeae9999e698f04

Options
    • -2
    • +1
    ./ReferenceLineImporter.cs
  2. … 7 more files in changeset.
Friday 16 Dec 2016
8:57 am

Robert Tangerman <robert.tangerman@deltares.nl>

Introduced new importer to import FeatureBasedMapData Related to Issue [WTI-1016]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7349 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 735f1f01d2537f932f7ca415a07e07f09e88a3a8

Former-commit-id: b8cdbbd1835ebf87c9b5a09429838be6783e92b2

Options
    • -1
    • +1
    ./ReferenceLineImporter.cs
  2. … 5 more files in changeset.
Monday 28 Nov 2016
3:28 pm

bouvrie <bouvrie@example.com>

* Fixed typos. * Refactored common code to new methods. * Fixed correct responsibility of filtering out duplicate observable notification. * Improved XML docs. * Improved returning all affected objects by some 'clear' methods of DataSynchronisationService classes. * Readded license header. * Simplified RhinoMock argument restraints. * Fixed test filename. * Fixed test structure of Integration tests conform coding conventions. Related to Issue [WTI-440]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6902 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 575f790757a486d0efa5b560c8170dc02cefb1f5

Former-commit-id: 8f94dd18882a6eaa65a1a9ca5592839b0d8b8084

Options
    • -1
    • +1
    ./ReferenceLineImporter.cs
  2. … 33 more files in changeset.
Friday 18 Nov 2016
10:15 am

Robert Tangerman <robert.tangerman@deltares.nl>

Made FeatureBasedMapData typed. Related to Issue [WTI-957]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/WTI-957.2@6748 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 47c7c54df07ed78dab74487b501f611ca3c22474

Former-commit-id: 137edc6a74b7acc8cbcc25c71a4cc1e87877c0b2

Options
    • -3
    • +3
    ./ReferenceLineWriter.cs
  2. … 16 more files in changeset.
Thursday 17 Nov 2016
9:13 am

bouvrie <bouvrie@example.com>

* Introduced IReferenceLineReplaceHandler and its implementation. ** Applied Dependency Injection on ReferenceLineImporter to abstract ReferenceLine replacement specifics (also removing dependencies such as View logic!) * Moved integration test data production methods to generally available location (new test project created for it) ** Created DataImportHelper class (Replaced several IntegrationTestHelper classes with identical implementation) Related to Issue [WTI-440]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6706 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 327965238ad610377b99e3b293193784bb2ef163

Former-commit-id: efce33cd742bfd09ba26d9337f1508223c8a2559

Options
    • -0
    • +50
    ./IReferenceLineReplaceHandler.cs
    • -64
    • +26
    ./ReferenceLineImporter.cs
  3. … 89 more files in changeset.
Wednesday 09 Nov 2016
3:18 pm

Dennis Tang <dennis.tang@deltares.nl>

(Editorial) Applied comments review 1178 - Removed redundant references in XML docs (e.g. System.X when System was already referenced) - Standardized XML docs regarding exceptions: Thrown is prefixed for the cause of the exception (e.g. <exception cref="X">Thrown when Lorus Ipsum</exception>)

Related to Issue [WTI-931]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6553 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c9a908b16e966485b3c2f38d472d9628b6f581ff

Former-commit-id: 71660f2e2159bfbb2e958ce8211bb236f66286e4

Options
    • -1
    • +1
    ./ReferenceLinesMetaReader.cs
  2. … 31 more files in changeset.
2:26 pm

Joël van den Berg

fixed failing test due to the now returned null value instead of an unparsable string. Related to Issue [WTI-948]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6551 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3569ae58e252e728628c2d7f3dd4d1f63995e918

Former-commit-id: ec6826c1c00c7dc58fc124b591975170bea334ae

Options
    • -1
    • +1
    ./ReferenceLinesMetaReader.cs
Friday 04 Nov 2016
1:58 pm

Marten Janssen <marten.janssen@deltares.nl>

- Ensure the technical reference guide can be build via Doxygen - Ran Deltares cleanup on every project that was touched Related to Issue [WTI-931]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6491 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8f75344419774da76c09075d5ac8308830a35a8b

Former-commit-id: e26553796c0f3ada7c458ada2db8e053610b8161

Options
    • -1
    • +1
    ./ReferenceLineImporter.cs
    • -2
    • +2
    ./ReferenceLineReader.cs
  3. … 114 more files in changeset.
Friday 23 Sep 2016
2:30 pm

Marten Janssen <marten.janssen@deltares.nl>

changes in review. paired by bos_en Related to Issue [WTI-576]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5529 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bdbc3b3233130eb0bfa1893a4d03a8770063d893

Former-commit-id: 6f3ce69fda788e55d8e40e0ff81d68fd3d5cb729

Options
    • -0
    • +76
    ./ReferenceLineExporter.cs
    • -0
    • +202
    ./ReferenceLineImporter.cs
    • -0
    • +150
    ./ReferenceLineMetaImporter.cs
    • -0
    • +127
    ./ReferenceLineReader.cs
    • -0
    • +119
    ./ReferenceLineWriter.cs
    • -0
    • +237
    ./ReferenceLinesMetaReader.cs
  7. … 34 more files in changeset.