Riskeer / Ringtoets / Common / src / Ringtoets.Common.Service

DesignWaterLevelCalculationService.cs

Clone Tools

Stats

Commits this week: 0
Total Committers: 7
Last Commit: 12 Sep 24
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 02 Nov 2017
1:29 pm

Elmar Kleijn

Fixed compilation failures

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/1444@12563 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a64dd3fa6b52e48204ab4bed16d5d4d0aaac0903

Former-commit-id: d377dc837539347f9d73463b7b3225c7057a479b

Options
    • -1
    • +1
    ./DesignWaterLevelCalculationService.cs
  2. … 54 more files in changeset.
Friday 06 Oct 2017
11:26 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Implement review comments, simplify calculation service tests and improve logging messages Related to Issue [WTI-1391]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12039 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 103dc1fa4f8c5ee91ba04ceac3b851a2b31ce24c

Former-commit-id: bac9d51986c9579366a4bb55172ac1a7576a345d

Options
    • -3
    • +3
    ./DesignWaterLevelCalculationService.cs
  2. … 8 more files in changeset.
10:04 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Implement review comments, update XMLDocs, improve tests, move some values of resources and improve their names. Related to Issue [WTI-1391]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12037 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 21483bef12f061dd693853d6e33a8aefedfda574

Former-commit-id: 6a3f33b230f7364d277d7045a995e94a9540b0d6

Options
    • -1
    • +3
    ./DesignWaterLevelCalculationService.cs
  2. … 22 more files in changeset.
Friday 29 Sep 2017
11:29 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Change error log to warning and change text. Remove groupby call from AnyNonDistinct. Related to Issue [WTI-1391]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11950 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 662e9d82dfe0817a67d821e7784be330adc47eff

Former-commit-id: d2d886b12d819750c93a66f77a090466fbf69658

Options
    • -1
    • +1
    ./DesignWaterLevelCalculationService.cs
  2. … 18 more files in changeset.
Thursday 28 Sep 2017
2:09 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Implement validation in structures, waveheight and designwaterlevel calculation with corresponding tests. Improve GeneralResult validation with stochast check for toplevel submechanism points. Adapt old tests so they will pass. Related to Issue [WTI-1391]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11940 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7c5475baca39b2e50fd92cffcd066cb90035b84d

Former-commit-id: 7371f7aa9c2fe4da40051f708686731a7b20ad61

Options
    • -3
    • +11
    ./DesignWaterLevelCalculationService.cs
  2. … 12 more files in changeset.
Tuesday 01 Aug 2017
4:05 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated refactoring comments regarding the SetGeneralResult function and constructor arguments for HBL: - Removed SetGeneralResult function - Preparation for removing the constructor without GeneralResult - Added HBL testoutput without the necessity to set the result Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10968 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e2d4b83e0f419027400c12339b6a76ce6dd6035e

Former-commit-id: 42e3857807291e0d52a5c547af300ae6923e8c25

Options
    • -18
    • +17
    ./DesignWaterLevelCalculationService.cs
  2. … 20 more files in changeset.
Thursday 27 Jul 2017
11:09 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Implement comments from review 1981: - Rename tests and references from IllustrationPoints to GeneralResult - Removed some excessive calls in tests - Added/improved some asserts Related to Issue [WTI-1318]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10894 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4d96ac129eec8de3d7aa5bdd68051a3a50c24693

Former-commit-id: 495106ec1ae86e970f28d4fa9348c1d3885979d6

Options
    • -3
    • +3
    ./DesignWaterLevelCalculationService.cs
  2. … 16 more files in changeset.
Tuesday 25 Jul 2017
4:37 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Implement review comments 1970: - Refactor HasIllustrationPoints and SetIllustrationPoints to HasGeneralResult and SetGeneralResult - ProbabilityAssessmentOutput in GrassCoverErosionInwardsOvertoppingOutput cannot be null - Improve tests for services and output objects - Move Resources to Common - Correct implementation of IllustrationPointsParserErrorMessage - Made ConvertIllustrationPointsResult private Related to Issue [WTI-1318]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10867 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 26b18ecde3707516f72159c322b00f31c74271a9

Former-commit-id: 693f5a23203efef71b2a492062c80e2d8e3202e3

Options
    • -1
    • +1
    ./DesignWaterLevelCalculationService.cs
  2. … 56 more files in changeset.
Monday 24 Jul 2017
1:12 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1959: Relevant comments for Converters - Renamed Create methods to Convert

Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10841 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5e0b94a85615f02a7c19028830441a8616e1a88a

Former-commit-id: f46ac23151fc772d5a60dc227ed4f6d222a60ce5

Options
    • -1
    • +1
    ./DesignWaterLevelCalculationService.cs
  2. … 23 more files in changeset.
Thursday 20 Jul 2017
10:29 am

Dennis Tang <dennis.tang@deltares.nl>

Improved illustration points parsing logic - In case an exception occurs in the parser, set the message instead of logging. Logging will always occur regardless of whether the user selected "ShouldIllustrationPointsBeCalculated" - Cleaned up tests - Adjusted the HBL calculation services with the following logic: -- In case illustrationPoints are calculated and there is an error --> log the error as a warning -- In case illustrationPoints are not calculated and there is an error --> do not log the error Related to Issue [WTI-1354]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10780 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 659e7f077bae7147201d04d102671920ad438c87

Former-commit-id: 86419684bf7231a4bc491f04c4913e01cbcf581a

Options
    • -13
    • +16
    ./DesignWaterLevelCalculationService.cs
  2. … 11 more files in changeset.
Tuesday 18 Jul 2017
1:06 pm

Dennis Tang <dennis.tang@deltares.nl>

Reverted error handling logic to the old situation for HBL: - Do not log exception - Make difference between the situation with and without a last error file content - Cleaned up tests

Related to Issue [WTI-1354]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10749 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b8ab026259cab7153a1264a8278bf5108fb811eb

Former-commit-id: 5a8beab837d82b84b8d751f1df5f7f2007904567

Options
    • -5
    • +6
    ./DesignWaterLevelCalculationService.cs
  2. … 18 more files in changeset.
Monday 17 Jul 2017
3:32 pm

Dennis Tang <dennis.tang@deltares.nl>

Connected the Illustration point outputs with structures: - Introduced test factory for the general result to produce one with SubMechanismIllustrationPoints only - Cleaned up implementations and tests of existing (HBL) services - Moved GeneralResult from the ProbabilityAssessmentOutput to the StructuresOutput, because it should not be part of the ProbabilityAssessmentOutput Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10730 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c7c49b07b1a7f21052e5005afe1854158fd812c6

Former-commit-id: 2df669351e05f07b0265ee10f2f38567e88b76f9

Options
    • -4
    • +4
    ./DesignWaterLevelCalculationService.cs
  2. … 13 more files in changeset.
11:57 am

Dennis Tang <dennis.tang@deltares.nl>

Improved existing implementations of existing services that read illustration points: - Introduced a TestGeneralResult containing only FaultTreeIllustrationPoints to Assert behaviour on the classes that make use of the GeneralResult converters - Added TestHelper method which allows assertions on the generated Exceptions in the log - Added missing tests which assert the logging behaviour when a calculation does not converge

Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10722 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c92d4f326db7c4987492c09192b089ad36d106ca

Former-commit-id: b417dc94e8227e4ef0963f43297b60641bd2cb8c

Options
    • -3
    • +11
    ./DesignWaterLevelCalculationService.cs
  2. … 9 more files in changeset.
Thursday 13 Jul 2017
3:37 pm

Dennis Tang <dennis.tang@deltares.nl>

Refactored GeneralResultSubMechanismIllustrationPoint: - Removed class in favor of the GeneralResult<T> - Renamed files when appropriate - Removed obsolete extensions, these are replaced by internal logic based on strings of the wrapper IllustrationPointControlItem on the calling side Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10687 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 65bcd4295ccbcbfc85ffe45740c5877d9c0a8352

Former-commit-id: c9de3cb8e9980d93fb413ad1e598c7795816ffdd

Options
    • -5
    • +5
    ./DesignWaterLevelCalculationService.cs
  2. … 51 more files in changeset.
11:21 am

Robert Tangerman <robert.tangerman@deltares.nl>

Renamed converter methods. Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10680 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 39813d75d3bde285faf0333d57ec1730d7772dcb

Former-commit-id: 79d8d67b1718c854004dc41d739d41192d706e0e

Options
    • -1
    • +1
    ./DesignWaterLevelCalculationService.cs
  2. … 11 more files in changeset.
Tuesday 11 Jul 2017
9:12 am

Robert Tangerman <robert.tangerman@deltares.nl>

Improved handling of faulty illustration points parsing. Related to Issue [WTI-1354]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10613 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6adef418960795d27b6e2090ae1986a4a466a67e

Former-commit-id: b306ef8f133eb61477ad5eb0294f18cae47b1ad0

Options
    • -8
    • +5
    ./DesignWaterLevelCalculationService.cs
  2. … 8 more files in changeset.
Monday 10 Jul 2017
11:50 am

Dennis Tang <dennis.tang@deltares.nl>

Moved IllustrationPoint up one level from the Hydraulics: - Elements are a common element which is not only tied to Hydraulics Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10591 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 91d4f7623869b05460e914b82ef6daef39531376

Former-commit-id: 578a6fb8e14ce4094139337ff19c3f126bae3aa3

Options
    • -1
    • +1
    ./DesignWaterLevelCalculationService.cs
  2. … 118 more files in changeset.
10:10 am

Robert Tangerman <robert.tangerman@deltares.nl>

Refactored HydraRingCalculatorBase so that illustration points are always parsed. Related to Issue [WTI-1354]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10586 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bf7f32809537aeefc5bde64ba1e7c01d2fe4f75a

Former-commit-id: 6ed0002e196d7eda5f1a129b802cc9c520d4feb8

Options
    • -10
    • +2
    ./DesignWaterLevelCalculationService.cs
  2. … 9 more files in changeset.
Thursday 06 Jul 2017
1:15 pm

Marten Janssen <marten.janssen@deltares.nl>

Merged IDesignWaterLevelCalculation.cs and IWaveHeightCalculation.cs Removed ICalculationMessageProvider.GetCalculationName Updated XMLdoc Related to Issue [WTI-1303]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10572 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: cfe13e25136b4cac64d2638227613ee0063192fa

Former-commit-id: 8194fc2bf4bad8fc11267eb6ae322d76dfcc2e62

Options
    • -4
    • +4
    ./DesignWaterLevelCalculationService.cs
  2. … 23 more files in changeset.
Wednesday 05 Jul 2017
2:51 pm

Marten Janssen <marten.janssen@deltares.nl>

Review suggestions: - Added exception for the theoretical case when a calculator did not set a GeneralResult object when it should have. - Fixed WaveHeight test that was set up for design water level Related to Issue [WTI-1303]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10567 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f8c9582278603fbbd107b2a832fbaeb95341aac1

Former-commit-id: a1a398e02fdf505bdda86daedde3c9ee05fe234b

Options
    • -6
    • +17
    ./DesignWaterLevelCalculationService.cs
  2. … 7 more files in changeset.
Tuesday 04 Jul 2017
1:04 pm

Marten Janssen <marten.janssen@deltares.nl>

Review suggestions: - updated XMLdoc - changed method to property Related to Issue [WTI-1303]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10556 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 052cf78f56d9ff4a5029bc9251ec6c23cd4665ba

Former-commit-id: 08c5cd00334a61865388666d7668feec052530b4

Options
    • -27
    • +53
    ./DesignWaterLevelCalculationService.cs
  2. … 6 more files in changeset.
10:16 am

Dennis Tang <dennis.tang@deltares.nl>

Renamed GeneralResult to GeneralResultSubMechanismIllustrationPoint for data(base) consistency reasons Related to Issue [WTI-1305]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10550 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3a34bb24e35a4846eb6629406914d042bb442134

Former-commit-id: 5e87896bbb0b3267a545b4df88602a9c86fed0fa

Options
    • -3
    • +6
    ./DesignWaterLevelCalculationService.cs
  2. … 50 more files in changeset.
8:27 am

Marten Janssen <marten.janssen@deltares.nl>

Review suggestions: - updated XMLdoc - changed method to property Related to Issue [WTI-1303]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10547 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 495ab60de8ec166a1449fba5eda632dfeaa62219

Former-commit-id: fefa25382e94307c30f65fb72d9024b2219dcb3a

Options
    • -7
    • +7
    ./DesignWaterLevelCalculationService.cs
  2. … 19 more files in changeset.
Friday 30 Jun 2017
9:12 am

Elmar Kleijn

Improved log messaging (removed duplication on calculation names and others) Related to Issue [WTI-1097]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10512 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7f80d5d4b3fe2cb329fc7a00666f09e0858a333c

Former-commit-id: 6a5fe69c43427946827b8a6ee1455e1649475356

Options
    • -10
    • +5
    ./DesignWaterLevelCalculationService.cs
  2. … 100 more files in changeset.
Tuesday 27 Jun 2017
10:07 am

Marten Janssen <marten.janssen@deltares.nl>

Added exception message to log removed "No detailed report available" Wrapped HydraRingFileParserException in a HydraRingCalculationException Related to Issue [WTI-1303]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10465 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d309f5f6bb054006e9ad709aef3aedb60891d39c

Former-commit-id: 0ec970eb19ae125d80ab86bbc8074a80f0bb1776

Options
    • -4
    • +5
    ./DesignWaterLevelCalculationService.cs
  2. … 19 more files in changeset.
Friday 23 Jun 2017
11:43 am

Marten Janssen <marten.janssen@deltares.nl>

Moved hydraring illustration point data model to Data/Output/IllustrationPoints Related to Issue [WTI-1303]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10420 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 82586716e967302c3debd0beb6123aa331e57043

Former-commit-id: 1cbe04f7cffe9510e996704b793ac145002700b1

Options
    • -1
    • +1
    ./DesignWaterLevelCalculationService.cs
  2. … 66 more files in changeset.
10:46 am

Marten Janssen <marten.janssen@deltares.nl>

Created TestGeneralResult (HydraRing side) Set GeneralResult to the HydraulicBoundaryLocationOutput in DesignWaterLevelCalculationService Related to Issue [WTI-1303]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10416 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bcf69029a22e09b8c0cac269b5f9360e692e7836

Former-commit-id: 3f2410988ad949f6e6ce0991b92e4cc44b1d1fc1

Options
    • -5
    • +25
    ./DesignWaterLevelCalculationService.cs
  2. … 6 more files in changeset.
Wednesday 21 Jun 2017
10:54 am

Marten Janssen <marten.janssen@deltares.nl>

Updated DesignWaterLevelCalculator to be able to read illustrationPoints Related to Issue [WTI-1303]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10386 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 73469d058ba4d58e19e55881daaa5161c98fc0ce

Former-commit-id: 069a66be09117340e9f74dc0d3c9d5b3d31733bf

Options
    • -1
    • +9
    ./DesignWaterLevelCalculationService.cs
  2. … 4 more files in changeset.
Tuesday 20 Jun 2017
2:07 pm

Marten Janssen <marten.janssen@deltares.nl>

Introduced WaveHeightCalculation to be an adapter for a wave height calculation in an HydraulicBoundaryLocation Related to Issue [WTI-1303]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10375 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 68a24f3a4748bdfdc5a9d302570508a6f4f4d5ca

Former-commit-id: edb74304b0d7149a738273425ced8e50de574fcc

Options
    • -3
    • +4
    ./DesignWaterLevelCalculationService.cs
  2. … 11 more files in changeset.
1:31 pm

Marten Janssen <marten.janssen@deltares.nl>

Introduced DesignWaterLevelCalculation to be an adapter for a design water level calculation in an HydraulicBoundaryLocation Related to Issue [WTI-1303]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10374 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 300845ec0436fe70fc06c19f4d764748f544630f

Former-commit-id: a29b5ea7fcc49e501d58c1d83048caee99200ace

Options
    • -17
    • +17
    ./DesignWaterLevelCalculationService.cs
  2. … 9 more files in changeset.