Riskeer / Ringtoets / Common / src / Ringtoets.Common.Service

Structures

Clone Tools

Stats

Commits this week: 0
Total Committers: 4
Last Commit: 12 Sep 24
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 02 Aug 2017
10:09 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated refactoring comments regarding the SetGeneralResult function and constructor arguments for Structures: - Removed SetGeneralResult function - Preparation for removing the constructor without GeneralResult

Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10973 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4ff595cc45ef3da259be523660cb018058c8e23b

Former-commit-id: 478f3d8d407b0da1a72aca9e87fb958f50166390

Options
    • -16
    • +14
    ./StructuresCalculationServiceBase.cs
  2. … 8 more files in changeset.
Thursday 27 Jul 2017
11:09 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Implement comments from review 1981: - Rename tests and references from IllustrationPoints to GeneralResult - Removed some excessive calls in tests - Added/improved some asserts Related to Issue [WTI-1318]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10894 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4d96ac129eec8de3d7aa5bdd68051a3a50c24693

Former-commit-id: 495106ec1ae86e970f28d4fa9348c1d3885979d6

Options
    • -3
    • +3
    ./StructuresCalculationServiceBase.cs
  2. … 16 more files in changeset.
Tuesday 25 Jul 2017
4:37 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Implement review comments 1970: - Refactor HasIllustrationPoints and SetIllustrationPoints to HasGeneralResult and SetGeneralResult - ProbabilityAssessmentOutput in GrassCoverErosionInwardsOvertoppingOutput cannot be null - Improve tests for services and output objects - Move Resources to Common - Correct implementation of IllustrationPointsParserErrorMessage - Made ConvertIllustrationPointsResult private Related to Issue [WTI-1318]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10867 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 26b18ecde3707516f72159c322b00f31c74271a9

Former-commit-id: 693f5a23203efef71b2a492062c80e2d8e3202e3

Options
    • -1
    • +1
    ./StructuresCalculationServiceBase.cs
  2. … 56 more files in changeset.
Monday 24 Jul 2017
1:12 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1959: Relevant comments for Converters - Renamed Create methods to Convert

Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10841 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5e0b94a85615f02a7c19028830441a8616e1a88a

Former-commit-id: f46ac23151fc772d5a60dc227ed4f6d222a60ce5

Options
    • -1
    • +1
    ./StructuresCalculationServiceBase.cs
  2. … 23 more files in changeset.
10:37 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1959: Relevant comments for services - Extracted functions - Simplified tests by inlining variables

Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10834 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a75ec12cf186a5719eaee92aec98e379e9a12609

Former-commit-id: 7bada798fc2e240edb3ff611fe6057f18a08aade

Options
    • -45
    • +77
    ./StructuresCalculationServiceBase.cs
  2. … 3 more files in changeset.
Thursday 20 Jul 2017
11:15 am

Dennis Tang <dennis.tang@deltares.nl>

Improved illustration points parsing logic - In case an exception occurs in the parser, set the message instead of logging. Logging will always occur regardless of whether the user selected "ShouldIllustrationPointsBeCalculated" - Cleaned up tests - Adjusted the Structures calculation services with the following logic: -- In case illustrationPoints are calculated and there is an error --> log the error as a warning -- In case illustrationPoints are not calculated and there is an error --> do not log the error

Related to Issue [WTI-1354]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10782 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4e6c6ebda34a8e1580c4b81302c7e43ccc9c4d30

Former-commit-id: 6cbf649ac3ac402b2a4719c29a4760751646b747

Options
    • -12
    • +15
    ./StructuresCalculationServiceBase.cs
  2. … 6 more files in changeset.
Tuesday 18 Jul 2017
10:25 am

Dennis Tang <dennis.tang@deltares.nl>

Reverted error handling logic to the old situation: - Do not log exception - Make difference between the situation with and without a last error file content Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10743 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 79a579b6ded4e87561b98beb73daf7f1633c5e4b

Former-commit-id: 185cd61d1f28e40436fe2ac0472f0af5d85d4f44

Options
    • -2
    • +2
    ./StructuresCalculationServiceBase.cs
  2. … 1 more file in changeset.
Monday 17 Jul 2017
3:32 pm

Dennis Tang <dennis.tang@deltares.nl>

Connected the Illustration point outputs with structures: - Introduced test factory for the general result to produce one with SubMechanismIllustrationPoints only - Cleaned up implementations and tests of existing (HBL) services - Moved GeneralResult from the ProbabilityAssessmentOutput to the StructuresOutput, because it should not be part of the ProbabilityAssessmentOutput Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10730 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c7c49b07b1a7f21052e5005afe1854158fd812c6

Former-commit-id: 2df669351e05f07b0265ee10f2f38567e88b76f9

Options
    • -2
    • +38
    ./StructuresCalculationServiceBase.cs
  2. … 13 more files in changeset.
Thursday 13 Jul 2017
2:41 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. Related to Issue [WTI-1353]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10683 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f3e2da5e486e49fd7c41a8b4862f9b25ab06212e

Former-commit-id: 9e32d8def96918c22209c7213f3bcf82f3441b2a

Options
    • -7
    • +18
    ./StructuresCalculationServiceBase.cs
  2. … 12 more files in changeset.
Wednesday 12 Jul 2017
3:29 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup Related to Issue [WTI-1353]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10664 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1b0aec6a006f082315c3fe347d76687aef6e3d95

Former-commit-id: c74b245e6d8d07774d3f8fb1a6a4482726fbd46c

Options
    • -3
    • +2
    ./StructuresCalculationServiceBase.cs
3:28 pm

Robert Tangerman <robert.tangerman@deltares.nl>

- Moved performing the calculation to the base. - Changed type parameters of base. Related to Issue [WTI-1353]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10663 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4a75417bd348972b9f9f1acbf6e6859ed47a1fbd

Former-commit-id: 220809cd3396870cbb1272378802252605f3fa1b

Options
    • -45
    • +78
    ./StructuresCalculationServiceBase.cs
  2. … 17 more files in changeset.
1:51 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added message provider to calculation service constructors. Related to Issue [WTI-1353]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10656 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: cd2665b7fda8fcf42f62c623a403f0c26bb3892e

Former-commit-id: 1b619281f65cc1bbb53ad9cd17006ee884d8dd94

Options
    • -0
    • +15
    ./StructuresCalculationServiceBase.cs
  2. … 4 more files in changeset.
12:00 pm

Robert Tangerman <robert.tangerman@deltares.nl>

- Moved cancel method to base. - Refactored perform calculation method. Related to Issue [WTI-1353]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10648 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 319e32471cff41243febb3a7de2305040ffcf9f7

Former-commit-id: f4523a3c6b43ef344678bd39d1f2d5664751db8e

Options
    • -9
    • +46
    ./StructuresCalculationServiceBase.cs
  2. … 7 more files in changeset.
9:12 am

Robert Tangerman <robert.tangerman@deltares.nl>

Refactored getting the calculation input. Related to Issue [WTI-1353]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10640 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 49287039b12c4b602c7989e2bcc564b9d646a3a1

Former-commit-id: 0614817094806a73d321be4b1f4bd0c82c2e0882

Options
    • -36
    • +73
    ./StructuresCalculationServiceBase.cs
  2. … 7 more files in changeset.
8:38 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added calculate method with null checks to the StructuresCalculationServiceBase Related to Issue [WTI-1353]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10636 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5dcc87c7f4ac386f10b4c18b41f99f06b4bf11fe

Former-commit-id: 93fd51170d798af95d9709f9d7943391e621f30f

Options
    • -1
    • +46
    ./StructuresCalculationServiceBase.cs
  2. … 7 more files in changeset.
Tuesday 11 Jul 2017
2:53 pm

Robert Tangerman <robert.tangerman@deltares.nl>

- Implemented validate method in StructuresCalculationServiceBase. - Refactored all depending calculation services. Related to Issue [WTI-1353]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10629 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: eacc84c9546683908cc316390f0f9fbcc83f4b84

Former-commit-id: ce6af66ecff89a16568da6283a30bdc97de7a3db

Options
    • -2
    • +79
    ./StructuresCalculationServiceBase.cs
  2. … 13 more files in changeset.
Friday 07 Jul 2017
9:56 am

Elmar Kleijn

Introduced StructuresCalculationServiceBase Related to Issue [WTI-1353]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10580 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1f6d248b8179af6a9078b63bafc15d2818d32465

Former-commit-id: bbf53a7ff4361c1b8c388201a7639ee725fde530

Options
    • -0
    • +30
    ./StructuresCalculationServiceBase.cs
  2. … 7 more files in changeset.